Commit Graph

3 Commits

Author SHA1 Message Date
James Hopkin
5364db3824 XML parser: fixed out-of-bounds memory access and made saving cross-platform by using UTF-8
Local function SplitLines was using BufferSize as if it were the character count (the bug had already been worked around for in-memory XML, but file reading was broken). This happened to work correctly unless it crashed due to the out-of-bounds memory access causing a page fault.

The switch to UTF-8 addresses TTP 336433 (CrashReportClient was silently failing to write the user's id to the crash report XML file).

#CodeReview Bob.Tellez,Thomas.Sarkanen

[CL 2089570 by James Hopkin in Main branch]
2014-05-30 07:58:39 -04:00
Thomas Sarkanen
6d1102c60e #fix Fixed buffer size being incorrectly specifed in the XML parser.
#detail 	Fix for crash reported in AnswerHub thread: https://answers.unrealengine.com/questions/16540/bug-conecting-to-source-control-causes-project-to.html

[CL 2046624 by Thomas Sarkanen in Main branch]
2014-04-23 18:51:46 -04:00
Tim Sweeney
324683ce78 Engine source (Main branch up to CL 2026164) 2014-03-14 14:13:41 -04:00