Commit Graph

6 Commits

Author SHA1 Message Date
Andrew Brown
ad0c2f67ff Prevent crash when accessing the localization settings more than once.
#ttp 334601 - Crash: Live: Setting and Unsetting Use Localized Field Name

#branch UE4

#change Model wasn't disassociating itself with the OnSettingsChanged delegate when it was destroyed... which meant next time the settings were changed the delegate was being called with a stale pointer.

reviewed by Thomas.Sarkanen

[CL 2089501 by Andrew Brown in Main branch]
2014-05-30 07:57:09 -04:00
Jamie Dale
b9d6c68dfc Fixes for how the editor handles localization when the OS is set to a language we don't have a translation for
TTP# 333731 - EDITOR: The editor region doesn't always seem to get set correctly on non-English systems

If you'd previously not set a language in the editor, the "Region & Language" settings would always show you the option for "en_US_POSIX" (and claim that you needed to restart the editor) because the saved culture name ("") didn't match the FInternationalization culture name (eg, "en_GB"), causing it to call GetCulture with an empty string (which seems to cause ICU to return "en_US_POSIX"). It now just uses the current FInternationalization culture name if the saved culture is empty.

Additionally, the editor/game now verifies that it has an available translation for the culture that FInternationalization is using (the one set during startup). If it doesn't (eg, your PC is using "fr_BR") then it will fallback to using generic English ("en") to ensure that the editor/game always has a valid translation to use.

ReviewedBy Saul.Abreu

[CL 2068467 by Jamie Dale in Main branch]
2014-05-09 14:42:45 -04:00
Max Preussner
4664956156 Delegates: Cleaned up abusive/legacy usages of the Delegate API
Please use AddRaw, AddSP, AddUObject, , BindRaw, BindSP, RemoveAll, Unbind etc.

[CL 2068405 by Max Preussner in Main branch]
2014-05-09 14:02:33 -04:00
Saul Abreu
bcb92e4dbf #summary Internationalization now operates as a singleton with non-static initialization. Should no longer have issues with initializing before file server when applicable. Resolved related previous double initialization issue. API-breaking change for calls to most FInternationalization methods.
#ttp 331776 - L10N: ICU: Executable size for engine and programs has regressed dramatically (ICU)

[CL 2044493 by Saul Abreu in Main branch]
2014-04-23 18:30:01 -04:00
Saul Abreu
b16c5668f5 #summary Updated metadata gathering commandlet to be configuration driven. Fixed a bug with local edits to metadata overriding localization. Updated property editors using comboboxes for enums to use localized data. Added Region & Language Settings for toggling use of localized field names.
#ttp 331251 - L10N: Editor: Tooltips and Property Names need to be localized

[CL 2040155 by Saul Abreu in Main branch]
2014-04-23 17:36:48 -04:00
UnrealBot
db494a6e69 Engine source (Main branch up to CL 2037954) 2014-04-02 18:09:23 -04:00