Commit Graph

1234 Commits

Author SHA1 Message Date
sebastian nordgren b2dd11e5ae Fixed issues while searching details panels (most notably Project Settings) introduced by change 19171653.
Fixed crash when accessing and invalid PropertyEditor in FDetailPropertyRow.

Fixed performance issue caused by calling GetWidgetRow() on FDetailPropertyRow for every row, which caused the row's widgets to be constructed again when filtering.

Added GetCustomResetToDefault() to IDetailLayoutRow, which allows us to bypass the performance penalty of creating the WidgetRow by directly accessing the FResetToDefaultOverride of the row.

#jira UE-144131
#rb paul.chipchase
#preflight 621de59f037be0078cecb0e4
#preflight 621df0563e14f0c7e5276836

[CL 19196340 by sebastian nordgren in ue5-main branch]
2022-03-01 05:20:41 -05:00
sebastian nordgren ccfaf382cd Fixed mismerged indentation.
#rb none
#preflight 621cfa2d4972367857a2f603

[CL 19175345 by sebastian nordgren in ue5-main branch]
2022-02-28 11:48:47 -05:00
sebastian nordgren 03c8e7c243 Details view's IsPropertyReadOnly delegate is now evaluated every frame instead of only when refreshing the tree, similar to how IsPropertyVisible now works.
IsPropertyReadOnly and IsPropertyVisible removed from update args, because they were only evaluated in conjunction with a full refresh.

#review @michael.noland
#preflight 621cf1bf6e5ae46efd48a323

[CL 19174367 by sebastian nordgren in ue5-main branch]
2022-02-28 11:11:53 -05:00
sebastian nordgren 85b68fa164 Show Only Modified will now also take into account the visibility of a custom reset to default provided to FDetailWidgetRow::OverrideResetToDefault().
#jira UE-142439
#review-19050410 @daren.cheng
#preflight 621ca1396e5ae46efd3c7ae6

[CL 19171653 by sebastian nordgren in ue5-main branch]
2022-02-28 05:32:19 -05:00
jeanfrancois dube 9aabdf23c3 World Partition UE5 default experience:
- Added option 'DisableStreaming' in the World Partition convert commandlet to allow disabling streaming for converted maps.
- Added flag 'bEnableStreaming' for partitioned worlds that can be used to disable streaming but keep key features such as OFPA and Data Layers.
- In this mode, the streaming generation acts as standard level streaming and can be enabled at any time by the user.
- This mode is enabled by default for new partitioned maps created from the empty template or the open world template.
- The World Partition convert commandlet will now duplicate the default HLOD layers setup.
- Show a hint in the World Partition window that streaming is disabled.
- When disabling streaming from the UI, show a dialog to warn the user about the implications of the change.
- When enabling streaming for the first time, show a dialog to warn the user that the world is about to be set up for streaming.
- When saving a map, don't duplicate its HLOD setup unless it's a template map.
- Includes changes from MattK: `Allow external object details customizations to hide the root object node`.
- TODO: Convert all template maps from the Games project to use World Partiton with streaming disabled using the new 'DisableStreaming' commandlet option.

#rb patrick.enfedaque, richard.malo
#jira UE-143719
#preflight

#ROBOMERGE-AUTHOR: jeanfrancois.dube
#ROBOMERGE-SOURCE: CL 19149766 in //UE5/Release-5.0/... via CL 19150115
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19160979 by jeanfrancois dube in ue5-main branch]
2022-02-25 19:31:01 -05:00
robert manuszewski 9514070355 Temp fix for crashes when editing array properties
#rb trivial
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19110591 via CL 19110613 via CL 19110617 via CL 19110763
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19152719 by robert manuszewski in ue5-main branch]
2022-02-25 14:09:32 -05:00
marc audy cff01aa9fa Added support for native FProperty setters and getters.
Setters and getters are native functions called by FProperties when setting property values with *_InContainer functions.
Setters and getter function names can be manually specified with Setter = Func and Getter = Func keywords inside of UPROEPRTY macro but they will also be automatically parsed if the name is not explicitly specified if the setter or getter function name matches SetPropertyName and GetPropertyName pattern.
The latter behavior can be disabled in UHT's DefaultEngine.ini by setting AutomaticSettersAndGetters=False.
ImportText and ExportTextItem functions have been deprecated and should be replaced with *_InContainer or *_Direct variants.

#rb Steve.Robb
#preflight 6210a377a83e0bcefd03d9e1

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19070318 via CL 19098059 via CL 19104650 via CL 19104661 via CL 19110012
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147839 by marc audy in ue5-main branch]
2022-02-25 10:39:39 -05:00
sebastian nordgren f49bb7e38f Uses of IPropertyHandle::GetMetadataProperty() have been switched to directly call GetMetadata(), which does it internally anyway. It's probably a mistake for GetMetadataProperty() to be exposed anyway, and it should be deprecated.
#review-19111929 @editor-ux
#preflight 6218f2f51d1c501799437761

[CL 19147685 by sebastian nordgren in ue5-main branch]
2022-02-25 10:32:40 -05:00
sebastian nordgren 4959608709 SPropertyEditorNumeric now uses ForceUnits even when placed in an array.
#review-19072571 @engine-ux
#preflight 6218ec05783beeaf8a02bae7

[CL 19147260 by sebastian nordgren in ue5-main branch]
2022-02-25 10:11:22 -05:00
daren cheng 26b6f4f613 Fix config hierarchy crashes due to being enabled on array entries
#jira UE-118423
#rb Vincent.Gauthier
#preflight 620ffe48ff52bfecfc012659
#lockdown JeanMichel.Dignard

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 19081092 in //UE5/Release-5.0/... via CL 19095743
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19140390 by daren cheng in ue5-main branch]
2022-02-24 23:12:03 -05:00
simon therriault 1fb1c57e92 - Fix potential crash when AddObjectPropertyData is called during a customization
#rb matt.kuhlenschmidt
#preflight 62153804840463c99a6caab6
#lockdown alejandro.arango
#jira UE-142047

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 19078686 in //UE5/Release-5.0/... via CL 19094691
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19136999 by simon therriault in ue5-main branch]
2022-02-24 20:46:57 -05:00
flo schar e056c45185 Clip contents of SDetailSingleItemRow on the outermost border only, so widgets can overlay the whole row
#jira UE-143475
#rb Matt.Kuhlenschmidt
#preflight 621533a09e113332ba1ce3d7
#lockdown Alejandro.Arango

#ROBOMERGE-AUTHOR: flo.schar
#ROBOMERGE-SOURCE: CL 19078635 in //UE5/Release-5.0/... via CL 19094685
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19136957 by flo schar in ue5-main branch]
2022-02-24 20:46:12 -05:00
jason stasik 882beee667 Log "Add to Allowlist" events in PropertyEditor
#rb none
#preflight 620eb194731ab58d824fedfc

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 19043699 via CL 19046089 via CL 19046103 via CL 19046126 via CL 19049397
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19065747 by jason stasik in ue5-main branch]
2022-02-21 00:31:46 -05:00
sebastian nordgren 7cd051a230 Removed unnecessary TWeakPtr::IsValid() check.
#rb paul.chipchase
#preflight 620fc793ff52bfecfcf87872

[CL 19051063 by sebastian nordgren in ue5-main branch]
2022-02-18 11:37:50 -05:00
vlad golovan 485406734e Engine change to allow only building the property nodes that user is going to see.
When property view widgets get reused, we are running (generate nodes) repeatedly while scrolling. Through some trial and error, I've identified that since I am only showing a fraction of the nodes I don't need to have all the nodes built; I can get away with generating the ones I will see, which improves performance from around 130 ms to 10-20ms per widget. I am adding a way to specify the properties you want to build and ignore the rest, which ultimately dramatically speeds up the PropertyView widget for the case where you are only showing a few properties from the object.


[REVIEW] [at]jay.Nakai, [at]sebastian.nordgren, [at]david.hamm

#rb sebastian.nordgren


#ROBOMERGE-OWNER: vlad.golovan
#ROBOMERGE-AUTHOR: vlad.golovan
#ROBOMERGE-SOURCE: CL 19036849 via CL 19036854 via CL 19038143 via CL 19038155 via CL 19039279
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19039995 by vlad golovan in ue5-main branch]
2022-02-17 14:54:44 -05:00
sebastian nordgren 2bb8c0f18a Scrolling a row outside of the Details view now commits any changes that were being made to that row.
#jira UE-134865
#rb matt.kuhlenschmidt
#preflight 620cb57701253d2e19fe9efa

[CL 19011614 by sebastian nordgren in ue5-main branch]
2022-02-16 03:42:24 -05:00
Robb Surridge 65a3c1236d Move IntroTutorials to a plugin. Part 1: move code module and clean up references.
#jira 141830
#preflight 6202f3e4bd4f846436f1dfc6
#rb lauren.barnes

[CL 18920903 by Robb Surridge in ue5-main branch]
2022-02-09 13:00:06 -05:00
George Rolfe 92509989f3 Property NoClear specifier propagates to item object pickers
#jira none
#preflight 62019c30384d6a94e8e656a7
#rb Sebastian.Nordgren

[CL 18895119 by George Rolfe in ue5-main branch]
2022-02-07 17:40:15 -05:00
George Rolfe 24061d010d InvalidEnumValues metadata support in PropertyHandle
(should have been part of 18805091)

#jira none
#preflight 61fae3a2e759a1a1a5ebe83b
#rb none

[CL 18832267 by George Rolfe in ue5-main branch]
2022-02-02 15:20:24 -05:00
jamie dale d45257c2ba Allow AddChildStructure to be used by sparse data properties
The child struct properties can't inherit the sparse data flag, as FStructurePropertyNode is already directly editing a block of struct memory.

#jira UE-140961
#preflight 61fa9368ad2ae6c3b75c1d66
#rb Mikko.Mononen

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 18826037 in //UE5/Release-5.0/... via CL 18826067 via CL 18826480
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18826515 by jamie dale in ue5-main branch]
2022-02-02 10:02:39 -05:00
sebastian nordgren fe30f189fd The Reset to Default button is no longer hidden when a details row is disabled, but is rather shown greyed out.
#jira UE-139917
#review-18772191 @lauren.barnes
#preflight 61f415e06b5aea38e5bb1726

[CL 18824161 by sebastian nordgren in ue5-main branch]
2022-02-02 07:11:10 -05:00
George Rolfe 62e2ce4d8d InvalidEnumValues metadata support (inverse of ValidEnumValues)
#jira none

#preflight 61f89c86f657e25a5908ebe7

#rb matt.kuhlenschmidt

[CL 18805064 by George Rolfe in ue5-main branch]
2022-01-31 22:36:04 -05:00
sebastian nordgren fbe733e5f5 Subcategory nodes now hide themselves if no children are visible. This was most evident with eg. EditInstanceOnly metadata set for a property while editing the CDO - the property would be hidden, but the subcategory would still be visible.
#jira UE-112640
[REVIEW] [at]lauren.barnes
#preflight 61f2b191304c93e2cba43cda

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 18753805 in //UE5/Release-5.0/... via CL 18753814 via CL 18756962
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18757283 by sebastian nordgren in ue5-main branch]
2022-01-27 14:10:26 -05:00
simon therriault e3bac11d06 - Fixing crash at shutdown with remote control
#rb jeremie.roy
#jira UE-140261
#preflight 61f195d62f38223e17bc1910

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18740277 in //UE5/Release-5.0/... via CL 18740804 via CL 18741555
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18742261 by simon therriault in ue5-main branch]
2022-01-26 15:04:41 -05:00
sebastian nordgren 74959d7da3 FPropertyHandleObject::SetValue when called with an FAssetData no longer always marks an asset as dirty if the new value is identical to the previous value.
This makes an assumption the FObjectPropertyBase::GetExportPath() will continue to return the value in 'ClassName'ObjectPath format, but that seems very unlikely to change and is depended on elsewhere so this can be considered an acceptable risk.

Suggested by UDN: https://epicgames.lightning.force.com/lightning/r/Case/5004z00001ay3pbAAA/view

#rb paul.chipchase
#preflight 61efd42b8c16f8372245a8f2

[CL 18721203 by sebastian nordgren in ue5-main branch]
2022-01-25 06:05:21 -05:00