Commit Graph

293 Commits

Author SHA1 Message Date
alain lafleur
ff0a5a3185 Replace check calls with ensure calls since the connections are supposed to be created in Shipping as well.
Therefore, compilation of the assets were failing on production backend.

Some other undetected? cases have been corrected at the same time.

swarm review has been upvoted in another branch : https://p4-swarm.epicgames.net/reviews/36646875

#rb JeanMichel.Dignard
#rnx
#tests Tested with and without fix on shipping build. Saw the bug happening while debugging

[CL 36765502 by alain lafleur in 5.5 branch]
2024-10-01 20:54:30 -04:00
alain lafleur
1b905ebe01 Merging
//Fortnite/Main/...
to //Fortnite/Dev-FN-32/...

Data driven condition bindings

Authoring and compilation of the new type is hidden behind a project setting.
Fix crash when changing hooked event and trying to edit conversion function parameters.
Fix issue with events valid source check node being purged from the graph upon regenerating connections in the wrapper graph.

Fixes FORT-768257

#tests Tested in editor and in game. Tried with widget property bindings, tried with vm bindings. Verified with multiple bindings to ensure we only execute when it's the condition property that is modified. Ran with cooked version. Tested in standalone and pie.
#rnx
#rb Vincent.Gauthier

[CL 36754418 by alain lafleur in 5.5 branch]
2024-10-01 18:59:25 -04:00
zahra nikbakht
92d7526266 MVVM UX: add tooltips for the editor side of viewmodel extensions.
[CL 36339142 by zahra nikbakht in 5.5 branch]
2024-09-17 12:23:20 -04:00
christian savoie
291cb8f68a [MVVM] Fix VM default resolvers to be created in the correct package so they save properly
[REVIEW] [at]editor-ui-systems
#tests Add a new VM that defaults to resolver, restart editor to see data being saved correctly

[CL 36172869 by christian savoie in 5.5 branch]
2024-09-10 21:32:44 -04:00
daren cheng
40714e7a08 Add LoadAsset & derived classes to allowlist for MVVM
Make Node Bindings show display name rather than node class name

#rb daren.cheng
#tests editor
[FYI] editor-ui-systems

[CL 35937414 by daren cheng in ue5-main branch]
2024-08-30 16:58:33 -04:00
daren cheng
cdabada69b Remove uncessary commented code in async MVVM nodes
#rb daren.cheng

[CL 35874448 by daren cheng in ue5-main branch]
2024-08-28 13:57:58 -04:00
rex hill
c0b7071419 Fix crash on exit MVVMConversionFunctionLibrary
#rnx

[CL 35863150 by rex hill in ue5-main branch]
2024-08-28 08:38:35 -04:00
daren cheng
77ef4d3ffa Add Async MakeBrush & LoadTexture / LoadMaterial Nodes for MVVM
[REVIEW] [at]editor-ui-systems
#rb daren.cheng
[FYI] editor-ui-systems
#tests PIE, cooked, validation

[CL 35836548 by daren cheng in ue5-main branch]
2024-08-27 16:28:59 -04:00
zahra nikbakht
e34e1d0bc4 MVVM/UMG: use the link icon as the Bind drop down for UMG details panel.
Add a checkmark next to the bound viewmodel property when vewing from the Bind menu.
fix pin color not reflecting the property color
fix conversion functions not showing as a binding in the Bind button
#jira UE-204913
#rb daren.cheng, Vincent.Gauthier

[CL 35798945 by zahra nikbakht in ue5-main branch]
2024-08-26 10:51:19 -04:00
christian savoie
8a3b1c35fc [MVVM] Add ability to set default resolver to select by default in project settings.
* Fixed a mixed up condition
* Cleanup resolver reference when not using it as a creation type.

[REVIEW] [at]editor-ui-systems, [at]jc.authier
#tests Changed creation types. Added a VM that's defaulted to use resolver type.
#rb daren.cheng, jc.authier

[CL 35642642 by christian savoie in ue5-main branch]
2024-08-19 18:26:43 -04:00
daren cheng
95dbd34e5b Fix Manual Arg refresh required when node added to MVVM Allowlist
#rb zahra.nikbakht
#tests Editor

[CL 35576488 by daren cheng in ue5-main branch]
2024-08-15 16:19:51 -04:00
zahra nikbakht
174101da50 MVVM: fix context sensitive filtering non-field notify values when they're being written to by a field notify value.
This case should be accepted, and the correct case to filter out is when a non-field notify field is writing to another field (in a binding that's not one-time).
#rb daren.cheng

[CL 35532929 by zahra nikbakht in ue5-main branch]
2024-08-14 10:09:14 -04:00
daren cheng
9121acc4c1 Add Async Node support to MVVM
Add generated ubergraph / multicast support to MVVM.
Some MVVM conversion function compilation refactoring, param / result structs, duplicate method extraction.

#tests PIE, Standalone, Cooked
#rb dan.oconnor, Patrick.Boutot

[CL 35532573 by daren cheng in ue5-main branch]
2024-08-14 09:59:16 -04:00
george rolfe
6f984f4cc9 [UMG MVVM] Uses new UMG Preview plugin
#rb Patrick.Boutot, Vincent.Gauthier
#jira UE-166282

[CL 35387060 by george rolfe in ue5-main branch]
2024-08-07 20:09:56 -04:00
zahra nikbakht
201483a4a4 MVVM: fix context sensitive option not working
#jira UE-216495
#rb Patrick.Boutot

[CL 35120264 by zahra nikbakht in ue5-main branch]
2024-07-26 17:17:29 -04:00
patrick boutot
2e269042c7 MVVM: Add Callback on the WidgetBlueprintGeneratedClass to collect save override. The generated function are transient in editor but save during the cooking process.
#rb Jamie.Dale, Zahra.Nikbakht, Vincent.Gauthier

[CL 35115660 by patrick boutot in ue5-main branch]
2024-07-26 14:43:34 -04:00
george rolfe
3ad27abefb [Backout] - CL34976623
[FYI] George.Rolfe
Original CL Desc
-----------------------------------------------------------------
[ToolWidgets] Dependencies reference correct base widget

#rnx

[CL 35075563 by george rolfe in ue5-main branch]
2024-07-25 00:59:31 -04:00
george rolfe
0ce09516bd [ToolWidgets] Dependencies reference correct base widget
[CL 34976625 by george rolfe in ue5-main branch]
2024-07-22 03:08:14 -04:00
alain lafleur
cbf994d73a UE-219574 missing icons on the BindingRow and EventRow
#jira UE-219574

The image path was going toward a file that didn't exist. The code was identical to what can be found in widgetreflector. We noticed the discrepency between the CoreContentRoot between the 2 projects.

To get access to the right directory with the resource, we had to bring the root back up, which forced changes on RootCoreContentDir() accesses for the button style.

#tests Tested the presence of the icon for properties and events. Also verified the normal/hovered/pressed effect on the 2 buttons with NoStyleComboButton. I didn't see any other accesses to the MVVMEditorStyle.
#rnx
#rb yohann.dossantos

[CL 34933672 by alain lafleur in ue5-main branch]
2024-07-19 11:44:12 -04:00
zousar shaker
dffd381e7d TObjectPtr upgrades for engine plugins.
[CL 34894832 by zousar shaker in ue5-main branch]
2024-07-18 01:17:14 -04:00
daren cheng
8b8f86805c Fix MVVM Show Graph not working in view binding due to missing graph editor mode set
#rb daren.cheng
[FYI] editor-ui-systems
#tests editor

[CL 34678842 by daren cheng in ue5-main branch]
2024-06-26 12:04:45 -04:00
patrick boutot
56488c7325 MVVM: Add an event when a conversion function setting changes. The event is used to rebuild the library.
#rb zahra.nikbakht

[CL 34638925 by patrick boutot in ue5-main branch]
2024-06-25 08:55:46 -04:00
zahra nikbakht
1cba503479 UMG: Check the drag-drop extensions to see if a widget accepts drop when moving widgets in the designer.
#jira UE-215900
#rb daren.cheng

[CL 34324947 by zahra nikbakht in ue5-main branch]
2024-06-12 17:53:53 -04:00
steve robb
e521f5d700 Replaced EAutomationTestFlags::ApplicationContextMask with EAutomationTestFlags_ApplicationContextMask.
[CL 34321160 by steve robb in ue5-main branch]
2024-06-12 16:14:25 -04:00
bunnylacey
880a0521bb PR #11968: Request update to FViewModelClassFilter in SMVVMSelectViewModel.h
#jira UE-216536
#rb patrick.boutot

[CL 34205656 by bunnylacey in ue5-main branch]
2024-06-07 12:04:04 -04:00