Commit Graph

340 Commits

Author SHA1 Message Date
Marc Audy
51605fb095 Protect against crashes when querying information from a graph pin that has been reconstructed (and thus is in the transient package)
[CL 2550661 by Marc Audy in Main branch]
2015-05-14 09:52:54 -04:00
Michael Schoell
c6f93e2b5c Selecting all nodes in a graph using keybindings will no longer assert due to null nodes being present in the graph list.
Added in some protection against nullptr to SGraphEditorImpl::SelectAllNodes

#jira UE-15379 - Crash copying all nodes in level blueprint of Audio.umap in ContentExamples

[CL 2549397 by Michael Schoell in Main branch]
2015-05-13 15:31:46 -04:00
Andrew Rodham
2d77514016 Fixed not being able to rename some graph node types on initial creation
This addresses UE-14873.

[CL 2547706 by Andrew Rodham in Main branch]
2015-05-12 15:39:48 -04:00
Ben Cosh
333979f59b This modfiies the InlineEditableTextBlocks to have a multiline option and enables this on comment nodes
#UE-9118 - Graph comments (Blueprints, Materials, Sound cues, etc...) should support multiline text editing
#UE-12964 - Comment box hits (Title bar) are offset
#Branch UE4
#Proj GraphEditor, Kismet, Slate

[CL 2546952 by Ben Cosh in Main branch]
2015-05-12 06:09:01 -04:00
Michael Noland
1105b5645c Graph Editor: Allowed double-clicking to interact with splines when they overlap the body of a comment node (double-clicking on the header still activates comment editing) [UE-15209]
[CL 2543793 by Michael Noland in Main branch]
2015-05-08 17:44:46 -04:00
Michael Schoell
db9c8e2240 UProperty and UFunction metadata for Category can now be localized and have improved FText usage throughout the editor (Blueprints, Behavior Trees, Materials, etc).
Big conversion of FStrings and FNames to FText.

Version bump to move some MaterialFunction UProperty from a TArray<FString> to TArray<FText> (some Engine assets are older than being allowed to auto-convert the UProperty)

Auto conversion of FName to FText (and back) now supported (as well as TArrays of those types).

Searching categories by both the localized string and the source string is now supported in Blueprints.

#jira UE-14481 - We are missing ability to translate node categories

#codereview Justin.Sargent

[CL 2542875 by Michael Schoell in Main branch]
2015-05-08 10:46:42 -04:00
Michael Schoell
d798e477c8 Blueprints and Behavior Trees will no longer have their graphs display as disabled/read-only when debugging (in PIE).
Fallout from CL# 2535806

#jira UE-15170 - When in PIE, Blueprints display as disabled making them difficult to debug.

[CL 2541246 by Michael Schoell in Main branch]
2015-05-07 12:39:59 -04:00
Ben Cosh
ac5d03c83b This adds a missed safety check in the comment bubbles before trying to set the text widget content.
#UE-15081 - Editor crashes without crash report or warning when entering a node comment on a blueprint node
#Branch UE4
#Proj GraphEditor

[CL 2540744 by Ben Cosh in Main branch]
2015-05-07 05:04:50 -04:00
Maciej Mroz
94197986df GetBaseStructure was replaced with TBaseStructure<>::Get()
Related to: https://udn.unrealengine.com/questions/244398/blueprint-struct-with-vector-member-crashes-editor.html

#codereview Robert.Manuszewski, Jaroslaw.Palczynski, Nick.Whiting

[CL 2538645 by Maciej Mroz in Main branch]
2015-05-05 23:07:23 -04:00
Michael Schoell
2043b596a8 Various graphs that looked disabled, will now correctly display as Read Only but can be panned and nodes are selectable.
Reworked how graphs were disabled to stop all out disabling of the SGraphPanel while still maintaining the visual display of being read-only.

Removed concept of TitleBarEnabledOnly from the graph editor and merged it with the IsEditable functionality.

#jira UE-10289  - Changing Blueprint Interface layout can shift nodes out of view

[CL 2535806 by Michael Schoell in Main branch]
2015-05-04 11:08:14 -04:00
Dan Oconnor
7877e203fb [UE-14700] Improving check message, CNR
[CL 2534617 by Dan Oconnor in Main branch]
2015-05-01 19:31:19 -04:00
Jamie Dale
0ca520a77e Improved diffing of behavior tree graphs
UETOOL-292 - Diffing of Behavior Trees doesn't work correctly

- Added support for diffing decorators and services.
- Ensured that you could see the properties of services and decorators in the diff tool.
    - This is now using common code shared with the behavior tree editor (to avoid this getting out of sync again).
- Fixed an issue where nodes containing changes could still be drawn faded out.
    - The "DiffR_" functions in GraphDiffControl weren't marking the node as changed since the diff results couldn't hold the information.
- Fixed SNodePanel::DeferredMovementTargetObject always moving the selection into view (rather than itself).
- Added a way to move to a node without also selecting it (SNodePanel::CenterObject).
    - This is needed as decorators and services don't exist as top-level nodes in the SNodePanel, so can't be centered on. We instead have to center on their container node.
- Added a way to control what items you want to diff.
    - This helps when checking for nodes that have been removed, as you can now avoid having to re-check all the other properties on the node, and just check for their existence (or lack thereof).

[CL 2533378 by Jamie Dale in Main branch]
2015-05-01 06:38:56 -04:00
Ben Cosh
7e0c9d9e28 Changing the comment bubble newline modifier key to shift in order match other examples in the editor.
#Branch UE4
#Proj GraphEditor

[CL 2530000 by Ben Cosh in Main branch]
2015-04-29 06:59:37 -04:00
Andrew Rodham
234e1259a4 Fixed not being able to rename graph nodes on mac
This addresses UE-9950.

[CL 2529992 by Andrew Rodham in Main branch]
2015-04-29 06:52:02 -04:00
Simon Tovey
0453945bb0 UE-14522 - Unlit materials no longer make use of the normal input thus making it impossible to use modified normals to modify refraction on unlit materials
The material side of this was actually working. When the refraction input is connected, the normal pin is active. The issue was just visual.
Material result node pin widgets were caching their colour on construction. Changed to recalculate each frame.

[CL 2529948 by Simon Tovey in Main branch]
2015-04-29 05:45:13 -04:00
Michael Noland
11db89485f Graph Editor: Removed dead method ComputeSensibleGraphBounds from SNodePanel
[CL 2529477 by Michael Noland in Main branch]
2015-04-28 19:45:43 -04:00
Jamie Dale
9968a0a15c Some workflow and performance improvements for behavior trees and environmental queries
UETOOL-293 - Behavior Tree Editor is sluggish

- Made the behavior tree and environmental query pins larger so they're easier to grab.
- Adjusted the node padding so that we don't add the padding for the pins when there aren't any pins.
- Added lodding so that node elements are culled out as you zoom out (to improve performance).
- Fixed connections being culled when they were still visible.

[CL 2528547 by Jamie Dale in Main branch]
2015-04-28 11:13:20 -04:00
Ben Cosh
c8bdd05cdc This changes the dark background on the documentation nodes to something lighter so the text can be read more easily.
#UE-14516 - Documentation Node Text Not Legible
#Branch UE4
#Proj GraphEditor

[CL 2528382 by Ben Cosh in Main branch]
2015-04-28 09:00:44 -04:00
Ben Cosh
ac6b1e60da This modifies the comment balloons behavior on reroute nodes to be more inline other node comment balloons by enabling a toggle button and displaying by default when a comment is entered in the context menu.
#UE-12866 - Have node comments and reroute node comments act the same
#Branch UE4
#Proj Engine, GraphEditor

#includes some more general comment node / comment bubble fixes

[CL 2528202 by Ben Cosh in Main branch]
2015-04-28 04:58:34 -04:00
Michael Schoell
ef74111bf9 Editor should not stall when pasting large amounts of text into the Blueprint node context menu filter.
#jira UE-11436 - Hang after you paste node data into Blueprint right click menu

[CL 2527289 by Michael Schoell in Main branch]
2015-04-27 15:09:27 -04:00
Ben Cosh
0dc3ecf817 Fix for broken comment node colors
#UE-14212 - Fortnite Branch: Colors no longer work on Blueprint comments
#Branch UE4
#Proj GraphEditor

[CL 2526760 by Ben Cosh in Main branch]
2015-04-27 06:45:26 -04:00
Michael Noland
56943257fe Graph Editor: Allowed interacting with splines when they overlap with a comment node [UE-13021]
[CL 2521705 by Michael Noland in Main branch]
2015-04-22 16:40:05 -04:00
Jamie Dale
a7ba1dcd00 Back out changelist 2519615
[CL 2519619 by Jamie Dale in Main branch]
2015-04-21 14:13:02 -04:00
Jamie Dale
735bca0f8f WIP - Fixing behaviour tree culling and line drawing
[CL 2519615 by Jamie Dale in Main branch]
2015-04-21 14:12:32 -04:00
Andrew Rodham
efcc3d35b7 Fixed graph nodes sometimes not opening a rename when created
Changed the way that renames are initiated to depend on the event structure passed in, rather than keyboard focus
This addresses UE-9950.

[CL 2519070 by Andrew Rodham in Main branch]
2015-04-21 08:43:00 -04:00