Commit Graph

902 Commits

Author SHA1 Message Date
ben marsh
566e59e1e6 Live Coding: Fixes issue linking patch DLLs with Visual Studio Express, due to PATH environment variable not including path to mspdb140.dll.
Now stores the linker environment block in the live coding manifest, and adds it to the cache before executing the linker.

#rb none
#jira UE-72324

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5740602 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5740765 by ben marsh in Main branch]
2019-04-04 12:02:05 -04:00
peter engstrom
6da65b072e Use forward slashes in include paths.
#rb ben.marsh
#rnx


#ROBOMERGE-SOURCE: CL 5667718 via CL 5667743 via CL 5667748 via CL 5667751 via CL 5668993

[CL 5668997 by peter engstrom in Main branch]
2019-04-01 10:37:55 -04:00
graeme thornton
ba498ac644 Reinstate the warning about short keys but wrap it in the condition that was lost in the merge from Release-4.22
#rb none


#ROBOMERGE-SOURCE: CL 5629597 via CL 5629603 via CL 5629607 via CL 5629609 via CL 5631976

[CL 5632515 by graeme thornton in Main branch]
2019-03-28 13:49:05 -04:00
ben marsh
cd0577dc24 Fix problems with HotReload on Mac.
* Linker arguments for each hot-reloaded module where only being patched with that module's new name (and not *all* the new module names). Windows was unaffected by this, since it uses response files (which were being handled correctly).
* Loop to rename modules in the manifest was terminating after the first modified module was found. This prevented other modules from being renamed.

#rb none
[FYI] Steve.Robb, Michael.Trepka
#jira UE-62612

#ROBOMERGE-SOURCE: CL 5503573 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5503574 by ben marsh in Main branch]
2019-03-22 14:05:08 -04:00
bob tellez
923d988545 #UE4 Disable warning while we wait for a key cycle
#ROBOMERGE-SOURCE: CL 5493785 via CL 5495889

[CL 5496062 by bob tellez in Main branch]
2019-03-21 16:32:52 -04:00
graeme thornton
eae38e7ac5 Add new config values to go alongside "PlatformRequiresDataCrypto" which can specifically disable signing or encryption. Allows selective disabling of signing OR encryption on some platforms, rather than the old config value which would disable both.
Disable signing on platforms that we wanted encryption enabled for by default (mobile mainly)
Add a warning if pak signing or encryption is enabled but there is no key, then disable the offending functionality for that build

#rb none
#jira UE-71811, UE-71806
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 5487098 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5487102 by graeme thornton in Main branch]
2019-03-20 18:40:20 -04:00
graeme thornton
c491de975a Edigrated rollup of all engine RSA changes that were done for 4.22. Pak signature checking is now much more competent.
#rb none
[FYI] joe.barrett
#rnx


#ROBOMERGE-SOURCE: CL 5469067 via CL 5469119 via CL 5470585

[CL 5470597 by graeme thornton in Main branch]
2019-03-20 12:03:26 -04:00
ben marsh
4b0b806b71 Fix issues related to hot-reload and LiveCoding co-existing.
* Removed code to invalidate makefiles when adding new source files. UBT should be reliable enough to make this determination itself nowadays, and ignored -invalidatemakefilesonly argument was causing modules to be recompiled.
* Fixed incorrect config section name when determining whether to allow hot reload from IDE. Now prevents hot reload from IDE when live coding is enabled.
* Added error message when trying to add a new class with Live Coding enabled.
* Added error messages when trying to start Live Coding after a hot reload has taken place.
* Added error messages when trying to hot reload with Live Coding enabled.

#jira UE-71253
#rb none

#ROBOMERGE-SOURCE: CL 5403464 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5403485 by ben marsh in Main branch]
2019-03-14 17:52:18 -04:00
ben marsh
02e4eddc0f UBT: Fix generated config files not being read by UBT, or being considered when determining if makefiles are out of date.
#rb none
#jira UE-71501

#ROBOMERGE-SOURCE: CL 5392870 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5392891 by ben marsh in Main branch]
2019-03-13 17:39:17 -04:00
ben marsh
4ac90e38c2 UBT: Use compact FileItem objects in source file metadata cache. Improves serialization performance by another 50-60ms.
#rb none
#jira UE-71116

#ROBOMERGE-SOURCE: CL 5337196 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5337949 by ben marsh in Main branch]
2019-03-07 11:45:19 -05:00
ben marsh
33fcfd2977 UBT: Serialize compact FileItem objects. Improves serialization performance and significantly reduces size of cpp dependency cache.
#rb none
#jira UE-71116

#ROBOMERGE-SOURCE: CL 5337193 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5337948 by ben marsh in Main branch]
2019-03-07 11:45:17 -05:00
ben marsh
4d9d6bc91f UBT: Store hashes in the action history rather than full command lines. Improves serialization performance by ~50ms.
#rb none
#jira UE-71116

#ROBOMERGE-SOURCE: CL 5337191 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5337944 by ben marsh in Main branch]
2019-03-07 11:45:15 -05:00
ben marsh
219cb4c2c5 Improve accuracy of timer for running UBT. Now includes startup time as well as time spent in the build mode.
#rb none
#jira UE-71116

#ROBOMERGE-SOURCE: CL 5319676 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5337053 by ben marsh in Main branch]
2019-03-07 09:14:13 -05:00
ben marsh
08aa889a34 UBT: Use the cached filesystem attributes to figure out which files are part of the adaptive non-unity working set. Much faster than querying directly because (a) they're cached, and (b) they're enumerated via a directory scan, which fetches the metadata up front.
#rb none
#jira UE-71116
#rnx

#ROBOMERGE-SOURCE: CL 5318685 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5336842 by ben marsh in Main branch]
2019-03-07 08:14:02 -05:00
ben marsh
78e31eb6e1 UBT: Figure out outdated actions in parallel. Saves 0.5s on iterative compile.
#rb none
#jira
#rnx

#ROBOMERGE-SOURCE: CL 5315074 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5317566 by ben marsh in Main branch]
2019-03-06 14:52:27 -05:00
ben marsh
eeb6345cd1 UBT: Add additional timing info into logs.
#rb none
#rnx
#jira

#ROBOMERGE-SOURCE: CL 5312405 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5316167 by ben marsh in Main branch]
2019-03-06 13:30:40 -05:00
ben marsh
cf183af67c Integrating live coding feature (aka Live++) into UE4.
Allows fast iteration of C++ changes without restarting the application. To use, select the "Live Coding (Experimental)" mode from the drop down menu next to the editor's compile button, or type "LiveCoding" into the console for a monolithic build. Press Ctrl+Alt+F11 to find changes and compile.

Changes vs standalone Live++ version:

* UBT is used to execute builds. This allows standard UE4 adaptive unity mode, allows us to reuse object files when we do regular builds, supports using any build executor allowed by UBT (XGE, SNDBS, etc..).
* Adding new source files is supported.
* Custom visualizer for FNames is supported via a weakly linked symbol in a static library (Engine/Extras/NatvisHelpers).
* Settings are exposed in the editor's project settings dialog.
* Standalone application has been rewritten as a Slate app ("LiveCodingConsole"). There is an additional option to start the program as hidden, where it will not be visible until Ctrl+Alt+F11 is hit. Similarly, closing the window will hide it instead of closing the application.
* Does not require a standalone licensed version of Live++.

Known issues:

* Does not currently support class layout changes / object reinstancing

#rb none
[FYI] Marc.Audy, Stefan.Boberg, Nick.Penwarden
#jira

#ROBOMERGE-SOURCE: CL 5304722 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5309051 by ben marsh in Main branch]
2019-03-05 18:49:25 -05:00
ben marsh
c1806516a1 Fix settings for enabling shadow variable and undefined identifier warnings not being treated as requiring a unique PCH. Also fix shared PCHs not enabling each by default. The compiler (at least on Windows) does not produce a warning/error on this mismatch, but does not respect the different settings passed via the command line.
#rb none
#jira

#ROBOMERGE-SOURCE: CL 5295902 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5308945 by ben marsh in Main branch]
2019-03-05 18:48:32 -05:00
ben marsh
7dea12512a Fix exception when trying to get path for main module for hot reload.
#rb none
#rnx
#jira

#ROBOMERGE-SOURCE: CL 5290983 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5308917 by ben marsh in Main branch]
2019-03-05 18:48:00 -05:00
graeme thornton
a668621c8a Minor unrealpak refactor
- Added a "-sign" parameter to enable signing for the given pak. The cached settings in the crypto.json file aren't used to enable signing any more.
 - Encapsulated all signing and encryption keys in a single keychain object which is passed around, rather than individual keys
 - Added some validation to UBT/UAT encryption config parsing so that if you enable any signing or encryption stuff but haven't generated a key, it'll warn and disable everything.

#jira


#ROBOMERGE-OWNER: graeme.thornton
#ROBOMERGE-AUTHOR: graeme.thornton
#ROBOMERGE-SOURCE: CL 5237725 via CL 5237726 via CL 5240337

[CL 5240343 by graeme thornton in Main branch]
2019-02-28 12:55:02 -05:00
Josh Adams
d0bf843c9c - Merging Dev-Kairos/Engine/... to Main/Engine/...
- Brings over the necessary engine changes for embedding UE4 mobile as a dylib/so in native mobile app
- Various changes for facial animation, screen recording, others
- ARKit and ARCore plugins were removed, as deemed "not ready"
#rb many people


#ROBOMERGE-OWNER: josh.adams
#ROBOMERGE-AUTHOR: josh.adams
#ROBOMERGE-SOURCE: CL 5201138 via CL 5203024

[CL 5226277 by Josh Adams in Main branch]
2019-02-27 11:57:17 -05:00
ben marsh
62b17cd8f0 Fix "launch on" always rebuilding the executable, due to order of enumerated plugins being non-deterministic.
#jira UE-70371
#rb none

#ROBOMERGE-SOURCE: CL 5103941 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 5103942 by ben marsh in Main branch]
2019-02-20 22:49:16 -05:00
ben marsh
fca86be496 Fix target not being rebuilt when an plugin not required for this platform is disabled. Also add log output showing why a temp target was required.
#rb none
#jira UE-69674

#ROBOMERGE-SOURCE: CL 4974444 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4974445 by ben marsh in Main branch]
2019-02-12 14:09:23 -05:00
ben marsh
8547f02ddc UBT: Fix module manifest not being updated correctly when -ModuleWithSuffix is passed on the command line.
#rb none
#rnx
#jira UE-69366

#ROBOMERGE-SOURCE: CL 4957024 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4968440 by ben marsh in Main branch]
2019-02-12 09:39:51 -05:00
ben marsh
4b2c7d21ec Missing file.
#rb none
#jira
#rnx

#ROBOMERGE-SOURCE: CL 4957017 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4968439 by ben marsh in Main branch]
2019-02-12 09:39:50 -05:00