[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina [at]jon.cook
#rb jon.cook, michael.atchison
#tests Passed WebTests test case
[CL 32409091 by lorry li in ue5-main branch]
Reason: Currently when shutdown and flush in http manager, it gives up and cancels remaining requests after waiting a short period. When cancel, it holds the RequestLock, and in FHttpRequestCommon::CancelRequest, it tries to access HttpTaskTimerHandleCriticalSection to stop activity timer. In the mean time, the request itself could be in activity or total timeout callback, which is holding the HttpTaskTimerHandleCriticalSection, and trying to AbortRequest which will try to access RequstLock in HttpManager.IsValidRequest.
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
#rb michael.atchison, Michael.Kirzinger, Rafa.Lecina
#tests Reproduced with test case in WebTests and fixed it. Tried launch and quit game on Win64.
[CL 32281657 by lorry li in ue5-main branch]
Use FTSTicker in http manager instead to manage game thread tasks.
#jira UE-163631
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
#rb Rafa.Lecina
#tests Passed all tests in WebTests project
[CL 32052075 by lorry li in ue5-main branch]
Only output log if request had completed when activity timeout, it can continue to run even if that happened.
[REVIEW] [at]michael.atchison [at]michael.kirzinger [at]rafa.lecina
#rb Rafa.Lecina
[CL 31948912 by lorry li in ue5-main branch]
Make the test case "Test platform request requests limits" covers the cancelling using CompleteOnHttpThread as delegate thread policy.
[REVIEW] [at]michael.atchison [at]michael.kirzinger [at]rafa.lecina [at]stephen.ma
#rb Rafa.Lecina
#tests Passed the WebTests.
[CL 31879765 by lorry li in ue5-main branch]
Deperecate the FGenericPlatformHttp::UsesThreadedHttp interface and remove corresponding impls, now all platforms are using threaded http requests;
Re-enable retry system off-game thread support.
Reason:
When accessing requests lock and trigger complete callback in http manager Tick from main thread, the complete callback could have been bound to retry manager which will try to access retry manager lock, while retry manager lock can be holding by FHttpRetrySystem::FManager::RetryHttpRequestWithDelay, which triggered by timer callback from http thread and is trying to access http manager's requests lock in order to add the retry request to http manager.
[REVIEW] [at]michael.atchison [at]michael.kirzinger [at]rafa.lecina
#rb michael.atchison
[CL 31821069 by lorry li in ue5-main branch]
Add test cases to test that after canceling/shut down request, the response body receive delegate won't ever been called.
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina [at]jens.petersam
#jira UE-207423, FORT-706402
#rb michael.atchison, Rafa.Lecina
[CL 31820574 by lorry li in ue5-main branch]
Get rid of platform specific code in WebTests, define macros in Http.Build.cs instead.
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
#jira UE-207067, UE-207061
#rb Rafa.Lecina
[CL 31777105 by lorry li in ue5-main branch]
- Retry period changed from linear to exponential;
- Adds random jitter multiplication to computed backoff.
Final default retry lockout period formula looks like this:
RandRange(JitterMin, JitterMax) * Pow(Base, RetryNumber + 1 + Bias) where RetryNumber is 0, 1, 2, 3...
Defaults:
JitterMin = 0.5
JitterMax = 1.0
Base = 2.0
Bias = 1.0
[REVIEW] [at]david.parton [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
#rb Rafa.Lecina
[CL 31776593 by lorry li in ue5-main branch]
Use cvar for the new flow just in case the headers needs to be read when complete for some urls.
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
#rb Chris.Adams, michael.atchison
#tests Tried through WebTests and the game
[CL 31601881 by lorry li in ue5-main branch]
Added the MaxTimeToWaitInQueue stat in HttpStats.
#jira UE-204405
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina [at]alejandro.aguilar
#rb alejandro.aguilar, michael.atchison, Rafa.Lecina
[CL 31441575 by lorry li in ue5-main branch]
Move the default max concurrent http requests limit to compile time decided by different platforms.
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]alejandro.aguilar [at]stephen.ma [at]rafa.lecina
#rb michael.atchison, Rafa.Lecina, stephen.ma
#tests Passed WebTests project
[CL 31350710 by lorry li in ue5-main branch]
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina [at]daniel.lamb
#jira UE-206119
#rb Daniel.Lamb, michael.atchison, Rafa.Lecina
#tests Passed new test case in WebTests
[CL 31350103 by lorry li in ue5-main branch]
Also adds tests for canceling 1,20,50,100,500,1000 requests.
[FYI] Benjamin.Dohrmann, Ryan.Hairyes, Chris.Varnsverry
#rb alejandro.aguilar, Chris.Varnsverry, lorry.li
[CL 31313811 by stephen ma in ue5-main branch]
Make sure when timed out in retry system, during back off or during retrying, it will return the last response instead of empty response.
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
[FYI] daniel.lamb
#rb Rafa.Lecina
#tests Tried in WebTests
[CL 31310240 by lorry li in ue5-main branch]
Stop total timeout timer after request completed in retry manager;
Move the virtual impls of FHttpRequestAdapter to cpp file.
[REVIEW] [at]michael.kirzinger [at]rafa.lecina [at]michael.atchison
#jira UE-197485
[FYI] [at]jens.petersam
#rb Jens.Petersam, Rafa.Lecina
#tests Repro and fixed in WebTests
[CL 31304925 by lorry li in ue5-main branch]
Added more checks in test case "Can do blocking call" of WebTests;
Added duplicated call CancelRequest in test case "Cancel http request connect before timeout" of WebTests;
Some other code clean in WebTests.
[REVIEW] [at]stephen.ma [at]michael.kirzinger [at]rafa.lecina
#rb stephen.ma
[CL 31289833 by lorry li in ue5-main branch]
#jira UE-204044
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina [at]jens.petersam
#rb Rafa.Lecina
#tests Passed WebTests test case, launched the game to main menu.
[CL 31180593 by lorry li in ue5-main branch]
Deprecate HttpTimeout config, use HttpActivityTimeout or HttpTotalTimeout instead;
Deprecate HttpSendTimeout config, only use HttpActivityTimeout;
Make HttpActivityTimeout work on all platforms, not only CurlHttp;
Added corresponding http tests;
Now because timeout migrated, enable new flow by default in retry system to have non-game thread support.
#jira UE-197485, UE-202201
[REVIEW] [at]michael.atchison [at]michael.kirzinger [at]rafa.lecina
#rb michael.atchison, Michael.Kirzinger
#tests Tested through WebTests project on all platforms, also tried the game on PC.
[CL 30817277 by lorry li in ue5-main branch]
#jira UE-203992
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina [at]jans.petersam
#rb michael.atchison, Rafa.Lecina
#tests Tested through new test cases in WebTests project
[CL 30726774 by lorry li in ue5-main branch]
