Commit Graph

451 Commits

Author SHA1 Message Date
hilda cruz
bc54fcf54c [Backout] - CL31610257
[FYI] Patrick.Boutot
#rnx
Original CL Desc
-----------------------------------------------------------------
MVVM: Add the UserWidget to the message log. The UserWidget is a link that the user can click on.
#jira UE-164353
#rb editor-ui-systems

[CL 31637723 by hilda cruz in ue5-main branch]
2024-02-19 22:33:06 -05:00
patrick boutot
82c961e519 MVVM: Add the UserWidget to the message log. The UserWidget is a link that the user can click on.
#jira UE-164353
#rb editor-ui-systems

[CL 31613893 by patrick boutot in ue5-main branch]
2024-02-19 11:53:46 -05:00
patrick boutot
16e9296b30 MVVM: Always assign the viewmodel value to the property value. It's a bug to not assign it when it's null.
#rb daren.cheng

[CL 31587293 by patrick boutot in ue5-main branch]
2024-02-16 18:52:47 -05:00
patrick boutot
aaa9e3684a MVVM: Enable compilation warning when there are 2 bindings trying to change the same value. Since the order is not configurable that can lead to binding executing in different orders and do run in an unexpected behavior.
#rb editor-ui-systems

[CL 31571515 by patrick boutot in ue5-main branch]
2024-02-16 13:12:00 -05:00
vincent gauthier
e5c2f534a8 Localization Warning fixes.
#rnx
#jira UE-207165
#rb vincent.gauthier
[FYI] patrick.boutot

[CL 31566357 by vincent gauthier in ue5-main branch]
2024-02-16 10:59:31 -05:00
patrick boutot
bb3bdc747f MVVM: Change the source sort algo to support destination.
At initalization, one at the time, the source initialize and then execute the bindings. Binding can use a source a soon to be initialize source and a binding can set the value of a source. Both cases need to be taken into account when sorting the sources.
When initializing, the binding can trigger a FieldNotify of another initialized source that can trigger that same source that try to initialize. Add a message if that occurs.
#rb christian.savoie

[CL 31538433 by patrick boutot in ue5-main branch]
2024-02-15 17:11:33 -05:00
dave jones2
a2073bc6c5 UE-206013 - StrongObjectPtr Crash running with -asyncloadingthread
Early runs of async loading in the editor were tripping the TStrongObjectPtr's check that it can only be created on the game thread. The was caused by the FMVVMViewBlueprintCompiler::BlueprintView field. Since we're dealing with a non-UObject here, we typically introduce the object reference either by reflecting the struct, or forcing it to inherit from FGCObject.

However, we can also take advantage of the ownership structure. Both the FMVVMViewBlueprintCompiler and UMVVMBlueprintView are owned by UMVVMWidgetBlueprintExtension_View. Technically, FMVVMViewBlueprintCompiler doesn't need a reference to UMVVMBlueprintView if it's already owned by the extension.

#jira UE-206013
#rb Patrick.Boutot, Francis.Hurteau
#rnx

[CL 31496292 by dave jones2 in ue5-main branch]
2024-02-14 17:27:16 -05:00
zahra nikbakht
58ee7f4dd0 MVVM: add customization for property paths and conversion functions of bindings in the details panel
#jira UE-205044
#rb patrick.boutot

[CL 31485951 by zahra nikbakht in ue5-main branch]
2024-02-14 14:03:50 -05:00
mikko mononen
f543d8078b PropertyAccessEditor: Added BindingChain to OnCanBindProperty.
[CL 31465565 by mikko mononen in ue5-main branch]
2024-02-14 07:07:33 -05:00
patrick boutot
4f6580c630 MVVM: Fix ensure that warn when there is no delayed bindings to execute. Fix ExecuteAtInit flag when one of the field is not a FieldNotify. The ensure was a false positif and the flag was not removed correctly on the second to last source. Update the ToString method to better identify compiler problems in the future.
#rb editor-ui-systems

[CL 31446359 by patrick boutot in ue5-main branch]
2024-02-13 16:20:41 -05:00
patrick boutot
b426a78a9d Generated widget properties are private unless specified "as variable" in the DetailView. This is to prevent mistakes and to not break encapsulation.
#jira UE-194167
#rb editor-ui-systems
#tests full cook

[CL 31381720 by patrick boutot in ue5-main branch]
2024-02-12 10:10:08 -05:00
patrick boutot
2e9a983dfa MVVM: Function in another widget was not correctly tested for availability. Prevent crash when the availability test fails.
#jira UE-204712
#rb editor-ui-systems

[CL 31303323 by patrick boutot in ue5-main branch]
2024-02-08 15:56:09 -05:00
ben zeigler
67acabd26a Fix engine FTickableGameObjects to never tick if they are part of a class default object.
Checking IsTemplate in GetTickableTickType only happens on the first tick, while IsAllowedToTick is called every frame.
#rb Simon.orr

[CL 31271994 by ben zeigler in ue5-main branch]
2024-02-07 16:38:13 -05:00
zahra nikbakht
f5757057d6 MVVM: Add a message to the empty binding panel to act as a starting tip
#jira UE-202317
#rb patrick.boutot

[CL 31218405 by zahra nikbakht in ue5-main branch]
2024-02-06 12:10:03 -05:00
zahra nikbakht
651e0be15b MVVM: add tooltips for different fields of a binding in the binding panel.
#jira UE-204914
#rb patrick.boutot

[CL 31217934 by zahra nikbakht in ue5-main branch]
2024-02-06 11:57:28 -05:00
patrick boutot
98f68d2bf9 MVVM: Fix loading pin values. The TrySetDefault reset the other option so the order was important. Introduced with CL30592781.
#jira UE-205197
#rb editor-ui-systems

[CL 31002167 by patrick boutot in ue5-main branch]
2024-01-30 07:41:13 -05:00
zahra nikbakht
d9a7d6d2d3 MVVM: fix field selector permission setting not working.
Add to the list of disallowed fields.
#rb Patrick.Boutot

[CL 30887449 by zahra nikbakht in ue5-main branch]
2024-01-25 10:53:19 -05:00
patrick boutot
d6010b615c MVVM: Fix editor that show the field list when the source is not yet valid. Introduced with CL28965726
#rb yohann.dossantos, zahra.nikbakht

[CL 30861632 by patrick boutot in ue5-main branch]
2024-01-24 16:16:19 -05:00
patrick boutot
d27d4891cf MVVM: Fix structure permissions when iterating/displaying.
#rb yohann.dossantos

[CL 30841805 by patrick boutot in ue5-main branch]
2024-01-24 09:29:05 -05:00
zahra nikbakht
80badbd5ce MVVM: allow events to bind to functions with any number of parameters.
#jira UE-199291
#rb Patrick.Boutot

[CL 30825631 by zahra nikbakht in ue5-main branch]
2024-01-23 19:17:27 -05:00
aris theophanidis
7192b9d0a2 Remove text.h from script.h (script.h is included by object.h)
#rb Yoan.StAmant

[CL 30776575 by aris theophanidis in ue5-main branch]
2024-01-22 11:52:48 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
zahra nikbakht
1692e62b5c MVVM: allow viewmodel values to be edited on nested userwidgets.
Expose viewmodels whose creation type is "Create Instance" in the details panel of nested userwidgets and allow editing them independently.
#jira UE-185718
#rb christian.savoie, jared.joyal, Patrick.Boutot

[CL 30717868 by zahra nikbakht in ue5-main branch]
2024-01-19 11:53:42 -05:00
steve robb
7da84c1d1b Replaced UE_NODISCARD with [[nodiscard]].
[CL 30593744 by steve robb in ue5-main branch]
2024-01-12 10:47:04 -05:00
patrick boutot
146c084883 MVVM: Enable K2Node as conversion functions.
#jira UE-190393
#rb editor-ui-systems

[CL 30592808 by patrick boutot in ue5-main branch]
2024-01-12 10:07:58 -05:00