#change Allow ArrangeChildren() calls inside FWidgetPath::GeneratePathToWidget() to include 3D widgets.
#codereview Nick.Atamas
[CL 2517575 by Chris Wood in Main branch]
I have reviewed each change carefully, but it is a large change and I could have missed something! Here is a summary of the types of changes in this CL:
* Made nullptr checks consistent (the plurality of the changes are of this type)
* Completed switch statements (IE, switch did not explicitly handle default case, but had unhandled enum entries - this is the second most popular type of fix)
* Removed unused variables
* Removed redundant initializations
* WidgetNavigationCustomization.cpp was fixed by the owner
* integers converted to floats where result was stored in a float
* Removed redundent null checks (e.g. before delete statements)
* Renamed variables to prevent non-obvious shadowing
* Fixed use of bitwise & when checking for equality to an enum entry (which is often 0)
* Fixes for some copy paste errors (e.g. FoliageEdMode.cpp)
[CL 2498053 by Dan Oconnor in Main branch]
Resulted in an non zero grid offset which wasn't handled properly in navigations clip rect intersection code.
Fixes Jira UE-8052
[CL 2488678 by Chris Gagnon in Main branch]
https://github.com/EpicGames/UnrealEngine/pull/946
I have gone through these changes and verified that whatever behavior change they cause could only be an improvement (generally they just prevent possible access to nullptrs, but there are also some style corrections). A separate changelist is being prepared that includes changes that could unintentionally caues behavior change for the worse.
[CL 2486801 by Dan Oconnor in Main branch]
Inspired by pull request #886, however we deemed it better to use the previously existing EConsumeMouseWheel enumeration to keep the feature inline with the ListView functionality. UE-11386
[CL 2484807 by Chris Gagnon in Main branch]
- Added basic drag-drop outline indicators to the SCS tree
- Removed redundant definition of SlateEditorStyle::NormalTableRowStyle & added the basic drag-drop indicators to the normal style
#codereview Nick.Darnell
[CL 2484512 by Dan Hertzka in Main branch]
These are mostly fixes to redundant comparisons and initialization code, but there's also a fix for serious looking scope issue in FontCache.cpp
[CL 2483865 by Dan Oconnor in Main branch]
This also stops offline (bitmap) cached fonts from reporting that they're able to provide a composite font (they can't).
This makes it clearer when Slate will be forced to use the fallback font path, which may not always be as fast as the standard font path.
[CL 2482035 by Jamie Dale in Main branch]
Slate Widget was failing, because of missing Slate dependencies. Testing introduced a couple of problems which all was fixed by this CL:
1. I introduced AdditionalDependencies in .uproject file and change "Add Code To Project..." procedure to fill this array if needed. UBT reads this field and builds the project with required modules. Needed for Slate classes.
2. Changed UHT to #include missing headers in generated.h files if it was missing an include for it's super class. It was causing problems if we were trying to add a subclass of BrushShape -- BrushShape.h didn't have #include "Brush.h" and UBrushShape was inheriting from UBrush.
3. Above problems also occured for Slate classes, but not all of them was UCLASSes, so I had to fixed that manually.
4. "Add Code To Project..." functionality was not invalidating UBT makefiles, which lead to omitting new source files during hot-reloading (even thought it was reporting a success). This change also should improve a bit performance, cause right now there is no "gathering" step -- there is only invalidate step which is a lot quicker.
5. Fixed "Selected Class Source" link to source class in Slate Widget and Slate Widget Style class.
#codereview Robert.Manuszewski
[CL 2481488 by Jaroslaw Palczynski in Main branch]
