- Constructs like if (foo=1) will still break the build, but if ((foo == 1)) will not (won't be suppressed completely, but will produce a visible warning).
#codereview Josh.Adams
[CL 2500399 by Dmitry Rekman in Main branch]
- After discussion with Core/Platform teams, it was determined that these warnings [would] affect build failure rate too much.
- We do not want to suppress them altogether though and they are going to be fixed as time and resources permit.
#codereview Josh.Adams, Michael.Trepka, Chris.Babcock, Marcus.Wassmer, Ankit.Khare
[CL 2488268 by Dmitry Rekman in Main branch]
- cache border sizes until the next time the window is shown.
- cache cursor position until the next mouse move or position change.
As of this commit, xtrace shows only OpenGL context changes when we aren't moving the mouse.
[CL 2482505 by Dmitry Rekman in Main branch]
- Previous code was broken as it was caching the result regardless of the actual rectangle being passed.
- Now we cache the display info itself, not the result.
- Maybe we should use maximum overlap instead of top, left (doesn't seem to be important though).
[CL 2481662 by Dmitry Rekman in Main branch]
Rob asked me to back out GENERATED_*_BODY -> GENERATED_BODY change for now until the "_Validate and _Implementation auto-generation" discussion is over.
#codereview Robert.Manuszewski
[CL 2481343 by Jaroslaw Palczynski in Main branch]
- Currently essential on Windows only; other platforms may make use of this when managing file handles.
#codereview Eric.Newman, Robert.Manuszewski, Josh.Adams, Michael.Trepka, Chris.Babcock, Marcus.Wassmer, Peter.Sauerbrei
[CL 2480709 by Dmitry Rekman in Main branch]
- We run out of TLS slot limit on Ubuntu 14.04 and earlier.
- Theoretically -ftls-model=local-dynamic (the proper fix) should have fixed this, but for some reason we don't see this happening.
- Issue will need to be investigated, but for now just don't cache thread id for glibc <= 2.19 (this assumes ubuntu-patched glibc by the way).
[CL 2478884 by Dmitry Rekman in Main branch]
- Contributed by x414e54 (https://github.com/EpicGames/UnrealEngine/pull/911).
- We are flip-flopping on this, but currently it doesn't seem to cause issues.
[CL 2478761 by Dmitry Rekman in Main branch]
- Deprecated FProcHandle::Close() in favor of existing FPlatformProcess::CloseProc() (symmetric to FPlatformProcess::CreateProc()).
- Linux: made FProcHandle instances safe to pass by value.
- Linux: added support for "fire and forget" children, which will not leave zombies (at the expense of extra threads and a leaked thread handle).
- Extended TestPAL with tests for most of the above functionality.
#codereview Michael.Trepka, Josh.Adams, Robert.Manuszewski, Jaroslaw.Surowiec
[CL 2476050 by Dmitry Rekman in Main branch]
