*because of tons of changes, I will supply the changelists in the email because it was too large for this checkin*
[CL 2483008 by Todd Eckert in Main branch]
- Changed Core module to use Core.h (removed CorePrivate.h)
- CorePrivate.h only included Core.h, so their PCHs were identical other than name
- Does not affect modular builds, as we need different defines for DLLExport/DLLImport for private and public PCH headers
[CL 2221011 by Mike Fricker in Main branch]
This was a regression caused by the re-introduction of the escaping characters in CL#2056465.
This addresses TTP#338005 - Editor: If you copy/paste a comment that has an apostrophe in it, it'll show the escape character in the new comment (\\')
Reviewed by Tom Sarkanen, Matt Kuhlenschmidt
[CL 2107969 by Andrew Rodham in Main branch]
Please note that file comments had no purpose in nearly all cases and just added visual clutter. The two files that had meaningful file comments had their comments moved into the corresponding classes. There are still hundreds of file comments left in other files that will be removed over time.
Also cleaned up some random stuff along the way:
- relative paths to public headers within the same module are no longer necessary (automatically discovered by UBT now)
- header guards are deprecated, use #pragma once instead (all compilers support it now)
- space between multiple template brackets is no longer required (all compilers support >> now)
- NULL to nullptr, OVERRIDE to override
- spelling errors, whitespace, line breaks
[CL 2104067 by Max Preussner in Main branch]
#ttp 337751: [GitHub] 208 : FString Replace() Crash Fix
#add Added an assert for when the crash, but will assert instead.
#codereview robert.manuszewski
[CL 2097239 by Steve Robb in Main branch]
TTP# 333749 - CRITICAL: Regression: Editor: Keyboard shortcuts reset on editor relaunch
CharToEscapeSeqMap had recently had a conversion from \\ -> \\\\ added to it, but ReplaceCharWithEscapedChar and ReplaceEscapedCharWithChar both span the array in the same order, so the unescape sequence wouldn't catch all the places where \\ had been escaped when processing carriage returns. ReplaceEscapedCharWithChar now spins the array backwards to ensure it's doing the inverse operation.
I also had the gestures written out using the compact JSON format, since the new-lines aren't used in the ini file.
ReviewedBy Thomas.Sarkanen, Max.Preussner
[CL 2060886 by Jamie Dale in Main branch]
