Commit Graph

133 Commits

Author SHA1 Message Date
Marc Audy
6b9642b23a Fix UHT shadow variables
#codereview Steve.Robb, Dmitry.Rekman, Terence.Burns

[CL 2521443 by Marc Audy in Main branch]
2015-04-22 14:47:12 -04:00
Steve Robb
83203b555a Shadowed variables fixed.
#codereview robert.manuszewski,terence.burns,marc.audy

[CL 2521372 by Steve Robb in Main branch]
2015-04-22 14:15:56 -04:00
Marc Audy
734e40c910 Temporarily disable warning since UHT turns it in to an error
[CL 2519961 by Marc Audy in Main branch]
2015-04-21 16:40:14 -04:00
Marc Audy
ccf62f558f Warn that virtual BlueprintImplementableEvents are not allowed, will remove support in a future release.
[CL 2519475 by Marc Audy in Main branch]
2015-04-21 12:46:26 -04:00
Steve Robb
7147a13be2 TMap properties.
#codereview robert.manuszewski

[CL 2519223 by Steve Robb in Main branch]
2015-04-21 10:25:59 -04:00
Robert Manuszewski
d80262a45e Fixing UHT not propagating class flags/properties properly
- Small refactor of how and where class flags are parsed
- 'Placeable' is no longer deprecated (it never really was)
- Restoring 'Placeable' keyword on ALandscape

UE-14035

[CL 2518912 by Robert Manuszewski in Main branch]
2015-04-21 05:03:44 -04:00
Mikolaj Sieluzycki
a342337136 UHT enforces user defined _Validate and _Implementation functions to be "virtual".
[CL 2517391 by Mikolaj Sieluzycki in Main branch]
2015-04-20 06:19:21 -04:00
Mikolaj Sieluzycki
d77f990644 Back out changelist 2515530
[CL 2515554 by Mikolaj Sieluzycki in Main branch]
2015-04-17 04:37:38 -04:00
Mikolaj Sieluzycki
cf4bc20014 UHT enforces user defined _Validate and _Implementation functions to be "virtual".
#codereview Robert.Manuszewski

[CL 2515530 by Mikolaj Sieluzycki in Main branch]
2015-04-17 04:04:20 -04:00
Michael Noland
36e8025b9c UnrealHeaderTool: Added support for FColor default values in reflected methods
[CL 2515150 by Michael Noland in Main branch]
2015-04-16 18:43:00 -04:00
Steve Robb
86b49f977d New CPF_UObjectWrapper flag to indicate that a UObjectProperty is a wrapper or a raw pointer.
UClassProperty::GetCPPType made to use the flag to generate a UClass* rather than a TSubobjectOf<UObject>.
Test code for UHT.

#codereview robert.manuszewski,marc.audy

[CL 2508644 by Steve Robb in Main branch]
2015-04-10 14:19:15 -04:00
Mikolaj Sieluzycki
3483da7d5a Stop UHT from emiting warnings on missing *_Validate and *_Implementation functions
Introduce versioning system to GENERATED_*BODY macros
Search for existing functions using case sensitive and whole word match.
Move checks for existing of *_Validate and *_Implementation functions to *generated.cpp to allow changing that code in hotfixes.
#codereview Robert.Manuszewski

[CL 2508131 by Mikolaj Sieluzycki in Main branch]
2015-04-10 06:02:22 -04:00
John Pollard
48eb523b3e UE-4679 - Remove CPF_RepRetry
[CL 2507484 by John Pollard in Main branch]
2015-04-09 18:10:40 -04:00
Dan Oconnor
76e1440d85 Further changes from PVS-Studio, submitted without modification, reviewed with owners where I was unsure of the change
[CL 2500334 by Dan Oconnor in Main branch]
2015-04-02 16:31:18 -04:00
Maciej Mroz
3ed5ae4cf6 UE-12214 Calling a function that returns TWeakObjectPtr in blueprints causes crash
Only a simple pointer to UObjects can be a parameter of BlueprintCallable (or BlueprintImplementableEvent.. etc) function. No WeakObjPtr or AssetSubclassOf is accepted. Strict check in UHT.

#codereview Steve.Robb, Richard.Hinckley

[CL 2499396 by Maciej Mroz in Main branch]
2015-04-01 20:59:46 -04:00
Steve Robb
983796dc35 ValidateMetaDataFormat overloads and AddMetaDataToClassData moved out of FHeaderParser.
#codereview robert.manuszewski

[CL 2497048 by Steve Robb in Main branch]
2015-03-31 07:20:11 -04:00
Steve Robb
0ad5c735f2 Property creation moved to its own function.
DoesAnythingInHierarchyHaveDefaultToInstanced moved out of FHeaderParser.

#codereview robert.manuszewski

[CL 2497043 by Steve Robb in Main branch]
2015-03-31 07:03:34 -04:00
Steve Robb
36a973206c UHT can skip inline function declarations.
#codereview robert.manuszewski

[CL 2495922 by Steve Robb in Main branch]
2015-03-30 14:13:41 -04:00
Michael Noland
6ef30e720a Optimized UnrealHeaderTool
- Optimized Tabify and Macroize
- Replaced various %s Spc(constant) calls with direct string literals
- Replaced injected indentation spaces with tabs (avoiding some of the work in Tabify; they were ultimately being replaced anyways)
- Replaced various %s of LINE_TERMINATOR with compile-time string literal concatenation
- Avoided case-insensitive work in various places
- Replaced direct references to FStringOutputDevice with a typedef to facilitate future optimizations
- Used Reset() instead of Empty() on various string builders and strings to reduce reallocations
[INTEGRATE] Change 2494450 by Michael.Noland@mnoland-T2784-HDepot on 2015/03/27 16:48:25

[CL 2494606 by Michael Noland in Main branch]
2015-03-27 18:10:52 -04:00
Michael Noland
9e64d67053 UnrealHeaderTool: Added time logging for various phases and clarified code/comments surrounding the phases
[INTEGRATE] Change 2493166 by Michael.Noland@mnoland-T2784-HDepot on 2015/03/26 23:49:36

[CL 2494507 by Michael Noland in Main branch]
2015-03-27 17:16:51 -04:00
Dan Oconnor
195086b1a5 Changes from PVS-Studio, these could introduce small behavior change.
Consistent null checks, fixes for copy/pasted conditions, copy pasted LOCTEXT identifiers, comparisons against literals of the wrong type, missing return statements, dead code, and some system calls that were ignoring their return value

[CL 2494390 by Dan Oconnor in Main branch]
2015-03-27 16:11:50 -04:00
Maciej Mroz
1a22ee9081 UHT error when an property/parameter exposed to BP is not supported by blueprint.
#codereview Robert.Manuszewski, Steve.Robb

[CL 2494269 by Maciej Mroz in Main branch]
2015-03-27 15:02:56 -04:00
Steve Robb
90ea7283f0 Nested switch broken up.
#codereview robert.manuszewski

[CL 2486563 by Steve Robb in Main branch]
2015-03-20 15:14:52 -04:00
Steve Robb
0fd156ad2a NoArrays parameter removed from GetVarNameAndDim.
#codereview robert.manuszewski

[CL 2486377 by Steve Robb in Main branch]
2015-03-20 13:26:37 -04:00
Steve Robb
89d426db24 IsFunction parameter removed from GetVarNameAndDim.
#codereview robert.manuszewski

[CL 2486354 by Steve Robb in Main branch]
2015-03-20 13:11:34 -04:00