Commit Graph

102 Commits

Author SHA1 Message Date
Ben Marsh
8be8504edc Remove some of the tedious layers of indirection from the plugin manager.
[CL 2521707 by Ben Marsh in Main branch]
2015-04-22 16:41:13 -04:00
Steve Robb
83203b555a Shadowed variables fixed.
#codereview robert.manuszewski,terence.burns,marc.audy

[CL 2521372 by Steve Robb in Main branch]
2015-04-22 14:15:56 -04:00
Steve Robb
7147a13be2 TMap properties.
#codereview robert.manuszewski

[CL 2519223 by Steve Robb in Main branch]
2015-04-21 10:25:59 -04:00
Jaroslaw Palczynski
d9e4f8f862 UE-8954: Update commonly-subclassed actor and component classes to take a default FObjectInitializer constructor argument.
[CL 2518882 by Jaroslaw Palczynski in Main branch]
2015-04-21 04:37:32 -04:00
Mikolaj Sieluzycki
a342337136 UHT enforces user defined _Validate and _Implementation functions to be "virtual".
[CL 2517391 by Mikolaj Sieluzycki in Main branch]
2015-04-20 06:19:21 -04:00
Mikolaj Sieluzycki
d77f990644 Back out changelist 2515530
[CL 2515554 by Mikolaj Sieluzycki in Main branch]
2015-04-17 04:37:38 -04:00
Mikolaj Sieluzycki
9574020014 Add missing file.
[CL 2515551 by Mikolaj Sieluzycki in Main branch]
2015-04-17 04:32:11 -04:00
Mikolaj Sieluzycki
cf4bc20014 UHT enforces user defined _Validate and _Implementation functions to be "virtual".
#codereview Robert.Manuszewski

[CL 2515530 by Mikolaj Sieluzycki in Main branch]
2015-04-17 04:04:20 -04:00
Jaroslaw Surowiec
1e12abcfd8 UHT Fix
#codereview steve.robb

[CL 2511512 by Jaroslaw Surowiec in Main branch]
2015-04-14 08:03:34 -04:00
Marc Audy
ee362038bb Avoid shadow variable warnings when a class has a UFUNCTION with a parameter with the same name as a member
Avoid shadow variable warnings when a class has a member named Result

[CL 2510514 by Marc Audy in Main branch]
2015-04-13 13:43:58 -04:00
Mikolaj Sieluzycki
3483da7d5a Stop UHT from emiting warnings on missing *_Validate and *_Implementation functions
Introduce versioning system to GENERATED_*BODY macros
Search for existing functions using case sensitive and whole word match.
Move checks for existing of *_Validate and *_Implementation functions to *generated.cpp to allow changing that code in hotfixes.
#codereview Robert.Manuszewski

[CL 2508131 by Mikolaj Sieluzycki in Main branch]
2015-04-10 06:02:22 -04:00
Dan Oconnor
76e1440d85 Further changes from PVS-Studio, submitted without modification, reviewed with owners where I was unsure of the change
[CL 2500334 by Dan Oconnor in Main branch]
2015-04-02 16:31:18 -04:00
Mike Fricker
114458bf0f Clang warning fixes: Fixed missing 'override' specifiers
- Also removed some unreferenced functions that adding 'override' revealed

PR #1002 -- Thank you, Omar007!

[CL 2498415 by Mike Fricker in Main branch]
2015-04-01 07:20:55 -04:00
Steve Robb
31548a8951 Delete old generated .cpp files when generating less code.
Provided by Robert Milllar at Black Tusk.

#codereview robert.manuszewski

[CL 2497133 by Steve Robb in Main branch]
2015-03-31 09:33:11 -04:00
Michael Noland
6ef30e720a Optimized UnrealHeaderTool
- Optimized Tabify and Macroize
- Replaced various %s Spc(constant) calls with direct string literals
- Replaced injected indentation spaces with tabs (avoiding some of the work in Tabify; they were ultimately being replaced anyways)
- Replaced various %s of LINE_TERMINATOR with compile-time string literal concatenation
- Avoided case-insensitive work in various places
- Replaced direct references to FStringOutputDevice with a typedef to facilitate future optimizations
- Used Reset() instead of Empty() on various string builders and strings to reduce reallocations
[INTEGRATE] Change 2494450 by Michael.Noland@mnoland-T2784-HDepot on 2015/03/27 16:48:25

[CL 2494606 by Michael Noland in Main branch]
2015-03-27 18:10:52 -04:00
Michael Noland
9e64d67053 UnrealHeaderTool: Added time logging for various phases and clarified code/comments surrounding the phases
[INTEGRATE] Change 2493166 by Michael.Noland@mnoland-T2784-HDepot on 2015/03/26 23:49:36

[CL 2494507 by Michael Noland in Main branch]
2015-03-27 17:16:51 -04:00
Robert Manuszewski
30c9c30f7a ScriptGeneratorPlugin will now be disabled by default. Projects can opt-in by enabling it in their uproject file.
[CL 2493289 by Robert Manuszewski in Main branch]
2015-03-27 03:51:19 -04:00
Max Preussner
97d1b77e1e UHT: Fixed a large number of missing 'override' warnings on Linux
This will not fix warnings for UObject classes that implement legacy C++ interfaces for which we generate code (GENERATED_IINTERFACE_BODY), because, as far as I can tell, the code generator is currently not able to detect those cases. For example: class UFont : public UObject, public IFontProviderInterface --- IFontProviderInterface gets a _getUObject() injected, but we cannot detect this in the code generation for UFont. Some more work is needed here. It might be better to simply always generate _getUObject() for all classes, so that there are no weird special cases.

#CodeReview: steve.robb, dmitry.rekman

[CL 2492772 by Max Preussner in Main branch]
2015-03-26 18:31:15 -04:00
Steve Robb
175b44a665 .generated.inl headers removed.
#codereview robert.manuszewski

[CL 2481705 by Steve Robb in Main branch]
2015-03-17 12:02:56 -04:00
Jaroslaw Palczynski
6c305898e0 UE-8578: Slate Widget fails to compile once added to a new project
Slate Widget was failing, because of missing Slate dependencies. Testing introduced a couple of problems which all was fixed by this CL:
1. I introduced AdditionalDependencies in .uproject file and change "Add Code To Project..." procedure to fill this array if needed. UBT reads this field and builds the project with required modules. Needed for Slate classes.
2. Changed UHT to #include missing headers in generated.h files if it was missing an include for it's super class. It was causing problems if we were trying to add a subclass of BrushShape -- BrushShape.h didn't have #include "Brush.h" and UBrushShape was inheriting from UBrush.
3. Above problems also occured for Slate classes, but not all of them was UCLASSes, so I had to fixed that manually.
4. "Add Code To Project..." functionality was not invalidating UBT makefiles, which lead to omitting new source files during hot-reloading (even thought it was reporting a success). This change also should improve a bit performance, cause right now there is no "gathering" step -- there is only invalidate step which is a lot quicker.
5. Fixed "Selected Class Source" link to source class in Slate Widget and Slate Widget Style class.

#codereview Robert.Manuszewski

[CL 2481488 by Jaroslaw Palczynski in Main branch]
2015-03-17 09:34:18 -04:00
Jaroslaw Palczynski
fa31560e2d Enabled UHT to digest GENERATED_BODY instead of GENERATED_UCLASS_BODY, GENERATED_USTRUCT_BODY, GENERATED_UINTERFACE_BODY or GENERATED_IINTERFACE_BODY, changed every occurence to the new syntax and fixed every warning that have fallen out of this change.
#codereview Robert.Manuszewski

[CL 2481333 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:19:11 -04:00
Maciej Mroz
56e1ade4b0 Inner DELEGATEs as children. [By JaroslawP]
UE-11693 Compiler error when using Bind Event to OnTextChanged in UMG
UE-11674 BindEvent node gives "Wrong Event Dispatcher" error for BlueprintAssignable MC delegate

#codereview Jaroslaw.Palczynski

[CL 2477120 by Maciej Mroz in Main branch]
2015-03-12 14:06:13 -04:00
Jaroslaw Palczynski
f12f8a83bc UHT was reporting circular dependency if UClassA inherited UClassB defined in the same header. Fixed.
[CL 2473892 by Jaroslaw Palczynski in Main branch]
2015-03-10 12:06:49 -04:00
Mikolaj Sieluzycki
d7a081e634 Disable deprecation warnings in code generated by UHT.
[CL 2473643 by Mikolaj Sieluzycki in Main branch]
2015-03-10 08:24:59 -04:00
Robert Manuszewski
7f252d9994 Fixing UnrealHeaderTool not respecting class flags on unparsed classes used as property types in other classes.
- Fixed some properties requiring 'instanced' keyword even though their type was marked as 'defaulttoinstanced"
- Removed 'Placeable' keyword from ALandscape (it has long been deprecated)

[CL 2473550 by Robert Manuszewski in Main branch]
2015-03-10 06:14:19 -04:00