We already had FPlatformProcess::CreateProc/CloseProc pair (which is part of larger set with WaitForProc(), TerminateProc(), GetProcReturnCode(), etc). FProcHandle::Close() made the API more confusing (and actually introduced bugs, because it did not call CloseProc() until recently).
#codereview Josh.Adams, Robert.Manuszewski, Jaroslaw.Surowiec
[CL 2476322 by Dmitry Rekman in Main branch]
Fixes
- Incorrect NULL usage.
- Incorrect proc handle initialization (default constructor should create an invalid handle).
- Filename case not matching actual file on disk.
- Non-const string literals.
- Superfluous expression without side effect.
This is a subset of changes (compiler warning fixes needed for Linux editor) from pull request 185 by sbc100, 3dluvr, wshearn, abarbu et al (#ue4linux community): https://github.com/EpicGames/UnrealEngine/pull/185
[CL 2085630 by Dmitry Rekman in Main branch]
