Commit Graph

27 Commits

Author SHA1 Message Date
Ben Cosh
ac6b1e60da This modifies the comment balloons behavior on reroute nodes to be more inline other node comment balloons by enabling a toggle button and displaying by default when a comment is entered in the context menu.
#UE-12866 - Have node comments and reroute node comments act the same
#Branch UE4
#Proj Engine, GraphEditor

#includes some more general comment node / comment bubble fixes

[CL 2528202 by Ben Cosh in Main branch]
2015-04-28 04:58:34 -04:00
Ben Cosh
f48004b3d8 Fix to remove the ability to toggle comment balloons in read only graphs.
#UE-13295 - Comment balloons can be toggled in read only graphs
#Branch UE4
#Proj GraphEditor

[CL 2508078 by Ben Cosh in Main branch]
2015-04-10 04:43:31 -04:00
Ben Cosh
a04ac2129c Fix for the comment nodes displaying comment balloons at fulldetail
#UE-13107 - Blueprint Editor: Newly-created Comments draw a redundant comment balloon on top by default
#UE-13301 - Comment depth is editable in the details panel for comment nodes
#Branch UE4
#Proj UnrealEd, GraphEditor

[CL 2505583 by Ben Cosh in Main branch]
2015-04-08 14:54:52 -04:00
Ben Cosh
bc1ef30d69 This changes the comment balloons and context comment text boxes to require ctrl + enter for newlines to match editor standards.
#UE-6148 - Pressing "enter" in a node comment bubble moves cursor to a new line instead of submitting text
#Branch UE4
#Proj Engine, GraphEditor

[CL 2505575 by Ben Cosh in Main branch]
2015-04-08 14:52:36 -04:00
Ben Cosh
3dc289b4d7 This change prevents comment balloons modifying text in read-only graphs.
#UE-13297 - Comment balloons are editable in readonly graphs
#Branch UE4
#Proj GraphEditor

[CL 2502574 by Ben Cosh in Main branch]
2015-04-06 08:39:28 -04:00
Ben Cosh
3e32ad6d9c Updated the comment balloon text hint to make use of the recently implemented interface in SMultiLineEditableTextBox.
#UE-13108 - Blueprint Editor: Problems with editing comment balloons inline
#Branch UE4
#Proj GraphEditor

[CL 2502546 by Ben Cosh in Main branch]
2015-04-06 08:03:53 -04:00
Ben Cosh
964f7959eb This change prevents comment balloon toggle button from displaying inside read only graphs.
#UE-13295 - Comment balloons can be toggled in read only graphs
#Branch UE4
#Proj GraphEditor

[CL 2502537 by Ben Cosh in Main branch]
2015-04-06 07:48:17 -04:00
Ben Cosh
3d8d167250 Added the ability to pin re-route node comment bubbles to resolve conflicting user requests.
#UE-7910 - Pin-able Reroute Node Comments
#Branch UE4
#Proj GraphEditor, EditorStyle

[CL 2481434 by Ben Cosh in Main branch]
2015-03-17 08:44:54 -04:00
Gil Gribb
35cf42566a UE4 - merge GDC branch, code @2465640 to main
[CL 2468685 by Gil Gribb in Main branch]
2015-03-04 08:31:40 -05:00
Michael Schoell
89841b0345 Comment bubble colors now obey property set on the comment node.
#jira UE-10666 - Color bubble has no effect in an Event Graph

[CL 2462706 by Michael Schoell in Main branch]
2015-02-26 15:16:46 -05:00
Ben Cosh
3dc594916a Fix for the call out arrow on ghost nodes displaying with the wrong color.
#Branch UE4
#proj GraphEditor

[CL 2461994 by Ben Cosh in Main branch]
2015-02-26 06:35:20 -05:00
Matthew Griffin
46027b3101 [INTEGRATE] Change 2445658 by Ben.Cosh@BCosh_Home2 on 2015/02/13 18:28:24
Fix for missing comment text in reference viewer.
	#UE-9833 - Reference viewer doesn't display text in the bubbles
	#Branch UE4-Releases
	#Proj GraphEditor

	#lockdown Nick.Whiting

[CL 2449911 by Matthew Griffin in Main branch]
2015-02-18 06:22:34 -05:00
Michael Schoell
9c0cbd9c6b Hidden comment bubbles should no longer reappear when doing unrelated actions.
#jira UE-9416 - Unpinned comment bubbles on comment blocks come back after deleting an unrelated node

[CL 2448867 by Michael Schoell in Main branch]
2015-02-17 12:27:10 -05:00
Matthew Griffin
8ccae5aec7 [INTEGRATE] Change 2442643 by Michael.Schoell@Phosphor_M_Schoell on 2015/02/11 19:07:13
Blueprints now start with basic nodes, in a disabled state that will not be compiled. These nodes will auto-enable if you connect another node to them.

	#jira UE-7189 - Make sure that newly created Blueprints always have a nice starting point

[CL 2448803 by Matthew Griffin in Main branch]
2015-02-17 11:23:23 -05:00
Matthew Griffin
7a5b092fe9 [INTEGRATE] Change 2441355 by Ben.Cosh@BCosh_Home2 on 2015/02/11 05:57:54
This change re-implements info bubble vertical stacking functionality on GraphNodes.
	#UE-9280 - Node comment bubbles draw on top of diagnostic info bubbles (pin watches, anim states / timeline / latent action time displays / etc...)
	#Branch UE4-Releases
	#Proj GraphEditor

	#info Also added a fix for compact nodes not displaying any comments

	codereview Michael.Noland

[CL 2448656 by Matthew Griffin in Main branch]
2015-02-17 09:57:29 -05:00
Matthew Griffin
b2088e32bb [INTEGRATE] Change 2434763 by Michael.Noland@mnoland-T2784-Reference on 2015/02/05 22:57:02
Graph editor: Fixed regression where node comment bubbles (watch values, anim states, timeline/latent delay display, etc...) would be hugely inflated
	#codereview ben.cosh

[CL 2446717 by Matthew Griffin in Main branch]
2015-02-16 04:16:06 -05:00
Ben Cosh
577274af7a This changes the behaviour of context menu comment editing in the graphs so that they automatically display comment bubbles when text is entered and hide when text is completely removed ( empty comment )
#UE-8480 - Unable to create comments on nodes
#Branch UE4
#Proj GraphEditor

[CL 2425487 by Ben Cosh in Main branch]
2015-01-30 06:11:03 -05:00
Ben Cosh
c5166c2502 Reworked the comment commit code to restore functionality and handle material expression synchronisation correctly.
#UE-7369 - Giving a custom event node a comment will rename that node instead
#UE-7639 - Node comments are cleared when compiling or closing the blueprint
#UE-5661 - New [redundant] CommentBubble in material editor has bugs
#Branch UE4
#Proj Engine, UnrealEd, GraphEditor

#Info This change adds UEdGraphNode::OnUpdateCommentText to allow derived GraphNodes to hook into comment changes where neccesary. I've implemented this on the Material Expressions to address the initial change that resulted in the bugs.

#codereview Richard.TalbotWatkin

[CL 2410122 by Ben Cosh in Main branch]
2015-01-17 15:04:08 -05:00
Richard TalbotWatkin
c5b0ef59a3 Made certain material node properties multiline in the details panel. Fixed a small bug where comment bubbles weren't updating their node comment text.
#jira UE-1659 - material editor ui: re-enabling the multilined text editor on certain fields

[CL 2390840 by Richard TalbotWatkin in Main branch]
2014-12-17 02:16:07 -05:00
Nick Darnell
90e793745c Slate - ESlateCheckBoxState has been renamed to ECheckBoxState.
[CL 2384008 by Nick Darnell in Main branch]
2014-12-10 14:24:09 -05:00
Ben Marsh
149375b14b Update copyright notices to 2015.
[CL 2379638 by Ben Marsh in Main branch]
2014-12-07 19:09:38 -05:00
Ben Cosh
d7b7ebef34 Addressing some feedback and fixing a few issues to do with the recent node comment bubble changes.
#Branch UE4
#Proj Engine, GraphEditor

[CL 2357051 by Ben Cosh in Main branch]
2014-11-12 09:59:31 -05:00
Ben Cosh
d772dae6af Modified the comment bubbles to support multiline editing.
#UE-2051 - ROCKET: TASK: The ability to write multi-line comments.
#Branch UE4
#Proj GraphEditor

#codereview Nick.Atamas

[CL 2354875 by Ben Cosh in Main branch]
2014-11-10 14:25:31 -05:00
Ben Cosh
33d058a99a Fix for dark comment colors obscuring text. The text should now select a light or dark foreground color based on the bubble luminance.
#Branche UE4
#Proj GraphEditor

[CL 2353131 by Ben Cosh in Main branch]
2014-11-07 10:49:44 -05:00
Ben Cosh
8f104b0dfd Modified the comment bubbles on SGraphNodeKnot to display on node hover.
#UE-2353 - Feature Request: BP: Allow users to hide comments on nodes
#Branch UE4
#Proj GraphEditor

[CL 2350119 by Ben Cosh in Main branch]
2014-11-05 13:10:16 -05:00