I have reviewed each change carefully, but it is a large change and I could have missed something! Here is a summary of the types of changes in this CL:
* Made nullptr checks consistent (the plurality of the changes are of this type)
* Completed switch statements (IE, switch did not explicitly handle default case, but had unhandled enum entries - this is the second most popular type of fix)
* Removed unused variables
* Removed redundant initializations
* WidgetNavigationCustomization.cpp was fixed by the owner
* integers converted to floats where result was stored in a float
* Removed redundent null checks (e.g. before delete statements)
* Renamed variables to prevent non-obvious shadowing
* Fixed use of bitwise & when checking for equality to an enum entry (which is often 0)
* Fixes for some copy paste errors (e.g. FoliageEdMode.cpp)
[CL 2498053 by Dan Oconnor in Main branch]
UETOOL-213 - Minimize Slate FString -> FText conversion (remove SLATE_TEXT_ATTRIBUTE)
This fixes any editor/engine specific code that was passing text to Slate as FString rather than FText.
[CL 2399803 by Jamie Dale in Main branch]
The "Get" pin was named in such a way that compiling would result in being unable to find the pin to expand and remove it from the node.
#jira UE-5945 - Unable to compile a Blueprint with renamed variable set node
[CL 2372546 by Michael Schoell in Main branch]
Added an output pin to UK2Node_VariableSet
Changed UK2Node_Variable::CreatePinForVariable to accept an optional pin name.
Changed UK2Node_Variable::RecreatePinForVariable to accept an optional pin name.
UK2NOde_Variable::DoPinsMatchForReconstruction will now confirm the pins are going in the same direction as well of compatible types before it determines that the pins match.
[CL 2366314 by Michael Schoell in Main branch]
#add Added UEdGraphNode::GetNodeNativeTitle to return a native title for a node.
#add Added UEdGraphNode::GetNodeSearchTitle to return the native and localized title for a node, together, for searching.
#add Can hold "alt" over a node (in the graph panel, or the palette) to see the native name of the node.
#ttp 331252 - Blueprints: Editor: L10N: Blueprints need to consistently show localized node names and when searching need to search both the localized name and the native name
#codereview justin.sargent
[CL 2044506 by Michael Schoell in Main branch]
