Commit Graph

50 Commits

Author SHA1 Message Date
Maciej Mroz
8ee2a47122 UE-14582 Many warnings about bSelfContext == true, but no scope supplied opening QA-Blueprints
#codereview Mike.Beach, Marc.Audy

[CL 2529278 by Maciej Mroz in Main branch]
2015-04-28 17:43:29 -04:00
Maciej Mroz
6ef830d587 UE-12558 'Directions are not Compatible' error on ForEachLoopWithBreak if split struct pin is disconnected from Enum type
The problem is related to pins default value for an enum. But it seems, it should be fixed in the Marco node.

#codereview Mike.Beach, Michael.Schoell

[CL 2521782 by Maciej Mroz in Main branch]
2015-04-22 17:04:42 -04:00
Phillip Kavan
11982590d6 [UE-11380] Reroute nodes now function correctly in an animation graph after compiling an animation blueprint.
change summary:
- added new UEdGraphNode::IsCompilerRelevant() and UEdGraphNode::GetPassThroughPin() APIs
- added a UK2Node::GetPassThroughPin() override to return the opposing exec pin on any given exec pin, else NULL, as base node logic
- added a UK2Node_Knot::IsCompilerRelevant() override to always return false for reroute nodes (since they are always precompiled out)
- added a UK2Node_Knot::GetPassThroughPin() override to always return the opposing pin given either the input or output pin, else NULL
- added new FBlueprintEditorUtils::GetCompilerRelevantNodes() and FBlueprintEditorUtils::FindFirstCompilerRelevantNodes() utility methods
- modified UAnimGraphNode_Base::GetLinkIDLocation() to look for the first linked "compiler-relevant" node rather than the literal first linked node

#codereview Michael.Noland

[CL 2508464 by Phillip Kavan in Main branch]
2015-04-10 12:36:02 -04:00
Maciej Mroz
1f114d4193 SplitPin crashes when the structure doesn't exist anymore.
A part of: UE-11813 User crashes in UObject::SetLinker() during Ctrl+Z and other operations

#codereview Marc.Audy

[CL 2505678 by Maciej Mroz in Main branch]
2015-04-08 15:25:57 -04:00
Maciej Mroz
57f43e8073 Better fix for UE-12990 Contains node connected to Enum Array value selection cleared on editor restart
[CL 2496601 by Maciej Mroz in Main branch]
2015-03-30 20:08:11 -04:00
Maciej Mroz
ce1e298b63 UE-12990 Contains node connected to Enum Array value selection cleared on editor restart
#codereview Mike.Beach

[CL 2496302 by Maciej Mroz in Main branch]
2015-03-30 17:56:55 -04:00
Michael Noland
6367c98d9f Prevented a few more uses of Pop() from shrinking
[CL 2494798 by Michael Noland in Main branch]
2015-03-27 20:23:08 -04:00
Marc Audy
d67a694c69 Move member reference out of K2Node and make it usable elsewhere
[CL 2477135 by Marc Audy in Main branch]
2015-03-12 14:17:48 -04:00
Marc Audy
f2bda7c975 Fix shadowed variables
[CL 2468158 by Marc Audy in Main branch]
2015-03-03 17:20:43 -05:00
Saul Abreu
79a26091bf Fixed behavior on FString::ParseIntoArray (muliple delimiters overload) functionality to support optionally culling empty strings. Greatly simplified implementation logic. Output parameter now properly named and taken by reference.
#codereview Steve.Robb, Robert.Manuszewski

[CL 2466824 by Saul Abreu in Main branch]
2015-03-02 15:51:37 -05:00
Jaroslaw Palczynski
33d90304eb Original fix by Michael Schoell:
"Fixes for multicast delegates (and K2Node_Events in general) to now use FMemberReference for finding their UFunction.

#jira UE-8391 - Crash occurs adding an Overlap Event for a component
#jira UE-7976 - Adding an on event for an actor in the level blueprint results in a crash"

I've change it a bit, so it don't require ObjectVersion.h edition as it's locked. My changes are located in:
* UK2Node_Event::Serialize
* UK2Node_ComponentBoundEvent::Serialize
* UK2Node_ActorBoundEvent::Serialize
* header K2Node_Event.h lines from 16 to 39.

This change works for now as a workaround. We will change that into proper deprecation fix after ObjectVersion.h lock lift.

[CL 2435347 by Jaroslaw Palczynski in Main branch]
2015-02-06 09:41:28 -05:00
Dan Oconnor
72c84d3c64 Fix for UE-8450, could not select 'wildcard' for input pins on macros
[CL 2427693 by Dan Oconnor in Main branch]
2015-02-01 21:44:29 -05:00
Michael Schoell
57e719de5e Pasting local variable nodes in graphs outside of scope will no longer show them as being valid.
Pasting local or variable nodes into graphs with local variables of the same name will have them reference the local variable automatically.

#jira UE-6658 - BLUEPRINTS: Can copy/paste local var nodes outside the function

[CL 2391108 by Michael Schoell in Main branch]
2014-12-17 10:00:41 -05:00
Michael Schoell
09444cfef5 Improvements to "Spawn Actor From Class" node to prevent the input pins created for the class from disconnecting when changing classes (if the pins remain).
#jira UE-2179 - BP: Add in base class for Spawn Actor From Class node

[CL 2388792 by Michael Schoell in Main branch]
2014-12-15 13:14:58 -05:00
Ben Marsh
149375b14b Update copyright notices to 2015.
[CL 2379638 by Ben Marsh in Main branch]
2014-12-07 19:09:38 -05:00
Mikolaj Sieluzycki
f0a67f1e2b Prepare cpp files for header cleanup.
#codereview Robert.Manuszewski

[CL 2356845 by Mikolaj Sieluzycki in Main branch]
2014-11-12 04:18:54 -05:00
Maciej Mroz
22281886d7 BP: ExpandNode() functions don't check "if (CompilerContext.bIsFullCompile)". The function should be called only when necessary.
[CL 2332863 by Maciej Mroz in Main branch]
2014-10-17 06:37:11 -04:00
Phillip Kavan
8a2b98e590 [347201] Added error tolerance input to "Equal" function for vector/rotator types.
- Updated tooltip text.
- Remapped recently introduced "NearlyEqual" function for vector/rotator back to "Equal"
- Added a K2Node::PostLoad() override to clear the default error tolerance input value on already-placed "Equal" nodes to preserve existing behavior in current Blueprint assets.

#codereview Zak.Middleton,Mike.Beach,Nick.Whiting

[CL 2329126 by Phillip Kavan in Main branch]
2014-10-14 15:58:08 -04:00
Jaroslaw Palczynski
7c41927cf4 Rename FPostConstructInitializeProperties to something simpler
Changed it with FObjectInitializer.

UECORE-7

[CL 2328384 by Jaroslaw Palczynski in Main branch]
2014-10-14 10:29:11 -04:00
Michael Schoell
348ad15aee Pasting invalid self variables into Macro Blueprints is no longer allowed and promoting or replacing variables with missing properties is no longer an option.
Pasting any nodes into interface BPs is not possible.

When right clicking on a variable node with a missing property, you can replace the node with any valid local variables (in functions).

#ttp 340631 - bp: macros: one can create variables within macros by pasting them into a macro from a blueprint (not sure if this is intentional because the create variable ui has been removed)

[CL 2321738 by Michael Schoell in Main branch]
2014-10-07 16:04:29 -04:00
Michael Noland
928559eaa0 Editor: Coding-standards fixes (TypeName [*|&] VariableName -> TypeName[*|&] VariableName)
[CL 2316341 by Michael Noland in Main branch]
2014-10-01 14:45:23 -04:00
Mike Beach
3beb0cd5f6 FMemberReferences now default to the authoritative class (unless set through the SetDirect() function).
This is to support references being set for the skeleton class (in the new BP menu system).

#codereview Nick.Whiting

[CL 2308582 by Mike Beach in Main branch]
2014-09-24 14:15:01 -04:00
Marc Audy
cb0766b302 Make Event nodes strip @param from tooltip
Apply @param from function comment to Event node pins

[CL 2304895 by Marc Audy in Main branch]
2014-09-21 20:34:20 -04:00
Marc Audy
ddd0441430 Missed file from CL# 2286449
Remove the frequently incorrect and not very informative (NO DEBUGGING INFORMATION GENERATED, NEED TO RECOMPILE THE BLUEPRINT) from graph pin tooltips

[CL 2286494 by Marc Audy in Main branch]
2014-09-05 13:36:22 -04:00
Marc Audy
c70012aff6 Enable Split Pin functionality by default and remove from experimental settings
[CL 2282989 by Marc Audy in Main branch]
2014-09-03 10:32:06 -04:00