Commit Graph

173 Commits

Author SHA1 Message Date
Jamie Dale
9968a0a15c Some workflow and performance improvements for behavior trees and environmental queries
UETOOL-293 - Behavior Tree Editor is sluggish

- Made the behavior tree and environmental query pins larger so they're easier to grab.
- Adjusted the node padding so that we don't add the padding for the pins when there aren't any pins.
- Added lodding so that node elements are culled out as you zoom out (to improve performance).
- Fixed connections being culled when they were still visible.

[CL 2528547 by Jamie Dale in Main branch]
2015-04-28 11:13:20 -04:00
Ben Cosh
ac6b1e60da This modifies the comment balloons behavior on reroute nodes to be more inline other node comment balloons by enabling a toggle button and displaying by default when a comment is entered in the context menu.
#UE-12866 - Have node comments and reroute node comments act the same
#Branch UE4
#Proj Engine, GraphEditor

#includes some more general comment node / comment bubble fixes

[CL 2528202 by Ben Cosh in Main branch]
2015-04-28 04:58:34 -04:00
Lukasz Furman
7189f23ffe fixed duplicated subnodes in behavior tree editor
#ue4 UE-14368

[CL 2524029 by Lukasz Furman in Main branch]
2015-04-24 04:41:17 -04:00
Jamie Dale
9d912e51dc FText::AsNumber usability and performance improvements
FNumberFormattingOptions now provides a convenient way to create a default number formatter that doesn't use grouping (FNumberFormattingOptions::DefaultNoGrouping()), as well as one that does (FNumberFormattingOptions::DefaultWithGrouping()).

This also improves the performance when using the default formatting options, by caching the formatters used by those options. This helps greatly when using Blueprint formatting (see KismetTextLibrary.cpp) as these were always creating custom formatters for every operations, which is a *very* expensive thing to do.

To improve the cases where you are frequently re-using a custom set of formatting options, we also have a LRU cache of the most recently used formatting options which we check before creating a new custom formatter.

[CL 2519071 by Jamie Dale in Main branch]
2015-04-21 08:43:22 -04:00
Mieszko Zielinski
158d72e521 Made blackboard key name editable in details tab #UE4
UE-7112

[CL 2515716 by Mieszko Zielinski in Main branch]
2015-04-17 08:29:20 -04:00
Michael Schoell
3f52b7d131 In "Region and Language" you can toggle localization of node and pins in all graph editors.
SNodeTitle no longer compares cached node titles to the title the node wants to be to determine a reconstruction, it checks if the schema wants to purge all cached node titles.

#jira UE-8371 - Change Editor language while leaving Blueprint Editor node & pin names in English

[CL 2508681 by Michael Schoell in Main branch]
2015-04-10 14:37:56 -04:00
Mikolaj Sieluzycki
a96989f147 Add includes to files to remove the need of including Engine.h.
[CL 2508000 by Mikolaj Sieluzycki in Main branch]
2015-04-10 03:30:54 -04:00
Nick Darnell
6818029208 Editor - Giving the DetailsView more capability to allow it to be set to automatically handle the EditDefaultsOnly flag for showing/hiding nodes when selecting a CDO instead of needing to monitor it, and show/hide them manually.
[CL 2505946 by Nick Darnell in Main branch]
2015-04-08 17:27:30 -04:00
Ben Cosh
7ce2a96c63 This change enables comment balloon coloring set in the preferences and restores the comment node option to enable coloring.
#UE-13299 - Comments and comment balloons don't obey colors set in editor preferences
#Branch UE4
#Proj BehaviourTreeEditor, EnvironmentQueryEditor, GraphEditor

#codereview Dan.Oconnor

[CL 2505562 by Ben Cosh in Main branch]
2015-04-08 14:48:01 -04:00
Mike Fricker
114458bf0f Clang warning fixes: Fixed missing 'override' specifiers
- Also removed some unreferenced functions that adding 'override' revealed

PR #1002 -- Thank you, Omar007!

[CL 2498415 by Mike Fricker in Main branch]
2015-04-01 07:20:55 -04:00
PaulEremeeff
3d878d5a79 PR #996: Fixing PVS-Studio warnings (Contributed by PaulEremeeff)
I have reviewed each change carefully, but it is a large change and I could have missed something! Here is a summary of the types of changes in this CL:
 * Made nullptr checks consistent (the plurality of the changes are of this type)
 * Completed switch statements (IE, switch did not explicitly handle default case, but had unhandled enum entries - this is the second most popular type of fix)
 * Removed unused variables
 * Removed redundant initializations
 * WidgetNavigationCustomization.cpp was fixed by the owner
 * integers converted to floats where result was stored in a float
 * Removed redundent null checks (e.g. before delete statements)
 * Renamed variables to prevent non-obvious shadowing
 * Fixed use of bitwise & when checking for equality to an enum entry (which is often 0)
 * Fixes for some copy paste errors (e.g. FoliageEdMode.cpp)

[CL 2498053 by Dan Oconnor in Main branch]
2015-03-31 20:12:31 -04:00
Dan Oconnor
195086b1a5 Changes from PVS-Studio, these could introduce small behavior change.
Consistent null checks, fixes for copy/pasted conditions, copy pasted LOCTEXT identifiers, comparisons against literals of the wrong type, missing return statements, dead code, and some system calls that were ignoring their return value

[CL 2494390 by Dan Oconnor in Main branch]
2015-03-27 16:11:50 -04:00
Michael Schoell
11bbd9aa06 Using the up and down arrow keys for selection in the MyBlueprint window will correctly select them.
Refactored logic for what selection type is allowed in a SGraphActionMenu to the widgets that react to the selection.

#jira UE-11644 - Selected BP Variables do not refresh details properly

[CL 2493909 by Michael Schoell in Main branch]
2015-03-27 11:43:37 -04:00
Dan Oconnor
06806b2237 PR #946: Fixing PVS-Studio warning (Contributed by PaulEremeeff)
https://github.com/EpicGames/UnrealEngine/pull/946

I have gone through these changes and verified that whatever behavior change they cause could only be an improvement (generally they just prevent possible access to nullptrs, but there are also some style corrections). A separate changelist is being prepared that includes changes that could unintentionally caues behavior change for the worse.

[CL 2486801 by Dan Oconnor in Main branch]
2015-03-20 17:18:31 -04:00
Lukasz Furman
f447f709bc fixed drag & drop operation for composite decorators
#ue4, merged from dev branch

[CL 2484510 by Lukasz Furman in Main branch]
2015-03-19 10:48:19 -04:00
Michael Noland
3c77014348 Graph Editor: Add experimental support for hovering and interacting with splines
- Currently gated by a setting in Editor Preferences..Graph Editors
- Alt+LMB Click on the spline to break the connection
- Ctrl+LMB Click on the spline to move the connection to a different pin
- Hover over the spline to highlight it

[CL 2483923 by Michael Noland in Main branch]
2015-03-18 21:37:27 -04:00
Marc Audy
a425eba9ed Unify Slate's FInputGesture and Engine's FInputChord as FInputChord defined in Slate
[CL 2481648 by Marc Audy in Main branch]
2015-03-17 11:36:28 -04:00
Lukasz Furman
8db86ff08b fixed crash on pasting composite decorator node in behavior tree editor
#ue4

[CL 2481392 by Lukasz Furman in Main branch]
2015-03-17 07:30:01 -04:00
Jaroslaw Palczynski
28fc7695a0 Missing chages for 2481343.
Some P4V problem with backing out large changelist missed some files.

#codereview Robert.Manuszewski

[CL 2481366 by Jaroslaw Palczynski in Main branch]
2015-03-17 06:17:32 -04:00
Jaroslaw Palczynski
f23f29257b Back out changelist 2481333
Rob asked me to back out GENERATED_*_BODY -> GENERATED_BODY change for now until the "_Validate and _Implementation auto-generation" discussion is over.

#codereview Robert.Manuszewski

[CL 2481343 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:38:32 -04:00
Jaroslaw Palczynski
fa31560e2d Enabled UHT to digest GENERATED_BODY instead of GENERATED_UCLASS_BODY, GENERATED_USTRUCT_BODY, GENERATED_UINTERFACE_BODY or GENERATED_IINTERFACE_BODY, changed every occurence to the new syntax and fixed every warning that have fallen out of this change.
#codereview Robert.Manuszewski

[CL 2481333 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:19:11 -04:00
Thomas Sarkanen
5ae7bbc244 Renaming blackboard keys now automaticaly updates Behavior Trees that reference them
Note that to do this we need to load all behavior trees in the asset registry to check for blackboard/key usage

UE-8415 - Renaming a Blackboard Key removes it's references in the Behavior Tree

[CL 2475144 by Thomas Sarkanen in Main branch]
2015-03-11 10:52:20 -04:00
Lukasz Furman
44fe9fb9b1 added spawning new wait task when parallel's background branch is empty on behavior tree save
#ue4 UE-11053

[CL 2474980 by Lukasz Furman in Main branch]
2015-03-11 06:17:18 -04:00
Lukasz Furman
54f413caee fixed creating connections from task to composite node in behavior tree editor
#ue4 UE-6594

[CL 2473793 by Lukasz Furman in Main branch]
2015-03-10 10:58:49 -04:00
Lukasz Furman
23aaaaf7da EQS graph restoring code will now be able to deal with missing option nodes
#ue4

[CL 2473690 by Lukasz Furman in Main branch]
2015-03-10 09:38:12 -04:00