Commit Graph

74 Commits

Author SHA1 Message Date
Rolando Caloca
dc2ade0796 UE4 - hlslcc - Metal - Fix texture sampled with different samplers
[CL 2514987 by Rolando Caloca in Main branch]
2015-04-16 17:03:26 -04:00
Marc Audy
6fbd586187 Disable shadow variable warnings around third party includes that throw warnings
[CL 2510513 by Marc Audy in Main branch]
2015-04-13 13:43:25 -04:00
Marc Audy
4562acb429 Fix shadow variables
[CL 2507160 by Marc Audy in Main branch]
2015-04-09 15:23:52 -04:00
PaulEremeeff
3d878d5a79 PR #996: Fixing PVS-Studio warnings (Contributed by PaulEremeeff)
I have reviewed each change carefully, but it is a large change and I could have missed something! Here is a summary of the types of changes in this CL:
 * Made nullptr checks consistent (the plurality of the changes are of this type)
 * Completed switch statements (IE, switch did not explicitly handle default case, but had unhandled enum entries - this is the second most popular type of fix)
 * Removed unused variables
 * Removed redundant initializations
 * WidgetNavigationCustomization.cpp was fixed by the owner
 * integers converted to floats where result was stored in a float
 * Removed redundent null checks (e.g. before delete statements)
 * Renamed variables to prevent non-obvious shadowing
 * Fixed use of bitwise & when checking for equality to an enum entry (which is often 0)
 * Fixes for some copy paste errors (e.g. FoliageEdMode.cpp)

[CL 2498053 by Dan Oconnor in Main branch]
2015-03-31 20:12:31 -04:00
Rolando Caloca
1033b06e67 UE4 - Metal - Fix texture arrays
[CL 2488158 by Rolando Caloca in Main branch]
2015-03-23 14:50:36 -04:00
Rolando Caloca
8827cb7a4a UE4 - Metal - fixed bug with previous check-in (depth samplers)
- Initial support for texture arrays

[CL 2488058 by Rolando Caloca in Main branch]
2015-03-23 14:05:22 -04:00
Rolando Caloca
02b118b057 UE4 - Metal - Fix for depth textures
- Fix case of float3 Out : SV_Target1 instead of float4

[CL 2488021 by Rolando Caloca in Main branch]
2015-03-23 13:39:16 -04:00
Rolando Caloca
a1f4fdf0be UE4 - Metal - Fix bad uav dereference
Glsl - Better variable names

[CL 2486692 by Rolando Caloca in Main branch]
2015-03-20 16:18:49 -04:00
Rolando Caloca
1362eb3a75 UE4 - Metal - Change fmax/fmin to max/min when using int/uint types
- Change local var name to match type for easier debugging

[CL 2486219 by Rolando Caloca in Main branch]
2015-03-20 11:31:48 -04:00
Allan Bentham
64090df1f4 Ensure correct assignment of emulated (ES2) uniform buffer indices for UB's generated within BuildResourceTableMapping(). Typically arises when only sampler related parameters are encountered.
Fixes UE-9804 and probably more.

#codereview nick.penwarden, Rolando.Caloca

[CL 2482912 by Allan Bentham in Main branch]
2015-03-18 08:03:21 -04:00
Rolando Caloca
be71ff1af5 UE4 - hlslcc - Reduce memory leaks (missing Linux libs)
#codereview Dmitry.Rekman

[CL 2473774 by Rolando Caloca in Main branch]
2015-03-10 10:40:42 -04:00
Rolando Caloca
6868525794 UE4 - hlslcc - Cleanup parser state & change hlslcc entry point to be a class in prep for moving to the Engine (missing Linux libraries)
odereview Dmitry.Rekman

[CL 2471354 by Rolando Caloca in Main branch]
2015-03-06 13:09:36 -05:00
Saul Abreu
79a26091bf Fixed behavior on FString::ParseIntoArray (muliple delimiters overload) functionality to support optionally culling empty strings. Greatly simplified implementation logic. Output parameter now properly named and taken by reference.
#codereview Steve.Robb, Robert.Manuszewski

[CL 2466824 by Saul Abreu in Main branch]
2015-03-02 15:51:37 -05:00
Rolando Caloca
ff538da9bf UE4 - Fixes UE-10562
hlslcc - Fix empty if() generation
Converts from
if(!EXPR) {}
to
EXPR
#codereview Mark.Satterthwaite, Chris.Babcock, Dmitry.Rekman, Michael.Trepka

[CL 2457355 by Rolando Caloca in Main branch]
2015-02-23 18:55:44 -05:00
Josh Adams
f143c10f80 - Some compute shader fixes, one left with buffer indices (handing back to Rolando)
[CL 2408122 by Josh Adams in Main branch]
2015-01-15 19:28:55 -05:00
Rolando Caloca
a71dea4f0d UE4 - Metal - Fix: texture2D into texture2d
#codereview Josh.Adams

[CL 2407332 by Rolando Caloca in Main branch]
2015-01-15 11:20:29 -05:00
Rolando Caloca
b4bf3df59e UE4 - Metal - Fix RWTexture2D writes (still need to check if we can bind textures as buffer[[n]] )
#codereview Josh.Adams

[CL 2406714 by Rolando Caloca in Main branch]
2015-01-14 20:54:20 -05:00
Rolando Caloca
31e52138a9 UE4 - Metal - Fix for SVPosition.w
[CL 2398968 by Rolando Caloca in Main branch]
2015-01-06 14:44:32 -05:00
Josh Adams
946168cd4f Quick fix for packing 2 halves into a uint (better fix will be handling all packing modes)
#codereview rolando.caloca

[CL 2391116 by Josh Adams in Main branch]
2014-12-17 10:05:37 -05:00
Rolando Caloca
c0db1bfb0e UE4 - hlslcc & Metal
- Metal - Fix for RWBuffer<uint> generating swizzle .x
- hlslcc - Support for RWStructuredBuffer

[CL 2388726 by Rolando Caloca in Main branch]
2014-12-15 12:21:10 -05:00
Rolando Caloca
b2146e396d UE4 - Metal - Fix UAV indices
[CL 2387457 by Rolando Caloca in Main branch]
2014-12-12 16:43:26 -05:00
Ben Marsh
149375b14b Update copyright notices to 2015.
[CL 2379638 by Ben Marsh in Main branch]
2014-12-07 19:09:38 -05:00
Josh Adams
efab15adfb - Added a Metal shader CC workaround for use of packHalf2x16 in compute shader (likely can be done cleaner - rco!)
#codereview rolando.caloca

[CL 2375131 by Josh Adams in Main branch]
2014-12-03 14:46:51 -05:00
Rolando Caloca
83b098f70c #UE4 - Metal - Fix for UAVs
[CL 2373118 by Rolando Caloca in Main branch]
2014-12-01 19:09:11 -05:00
Rolando Caloca
41144eec34 #UE4 - Metal - Proper sync primitives, add missing #include
#codereview Josh.Adams

[CL 2372584 by Rolando Caloca in Main branch]
2014-12-01 11:18:51 -05:00