Commit Graph

34 Commits

Author SHA1 Message Date
Max Preussner
ed7b70caed Messaging: Removed the WithMessaging type trait and message type pre-cache
#UpgradeNotes:
The TStructOpsTypeTraits<>::WithMessaging type trait is no longer necessary for UStructs intended to be used as messages, because UObject creation and destruction is now thread-safe, and message types no longer need to be pre-cached. You can now use any existing and custom UStruct class in the Engine as messages. I ran the Editor for a couple hours with the profiler enabled and did not have any stability issues. If you experience any Messaging related crashes, please let me know asap, thanks!

#CodeReview: robert.manuszewski, peter.sauerbrei, chris.gagnon, jason.bestimt, michael.trepka, nicholas.davies

[CL 2499164 by Max Preussner in Main branch]
2015-04-01 17:35:20 -04:00
Jaroslaw Palczynski
f23f29257b Back out changelist 2481333
Rob asked me to back out GENERATED_*_BODY -> GENERATED_BODY change for now until the "_Validate and _Implementation auto-generation" discussion is over.

#codereview Robert.Manuszewski

[CL 2481343 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:38:32 -04:00
Jaroslaw Palczynski
fa31560e2d Enabled UHT to digest GENERATED_BODY instead of GENERATED_UCLASS_BODY, GENERATED_USTRUCT_BODY, GENERATED_UINTERFACE_BODY or GENERATED_IINTERFACE_BODY, changed every occurence to the new syntax and fixed every warning that have fallen out of this change.
#codereview Robert.Manuszewski

[CL 2481333 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:19:11 -04:00
Marcus Wassmer
230a4e61d0 Double target adds are safe, but we must protect against two adds at the same time in every circumstance.
#codereview chris.gagnon, lee.clark

[CL 2411503 by Marcus Wassmer in Main branch]
2015-01-19 17:54:43 -05:00
Marcus Wassmer
d2617368ce Lock isn't necessary here since double-add is safe now. Fixes a potential deadlock for platforms that have an internal critical section on device discovery.
[CL 2411453 by Marcus Wassmer in Main branch]
2015-01-19 17:18:54 -05:00
Marcus Wassmer
db2345528c Protect against race condition when adding targets
#codereview chris.gagnon

[CL 2405142 by Marcus Wassmer in Main branch]
2015-01-13 15:53:08 -05:00
Chris Gagnon
94d063fa1c Fix for intermitent add issue with async discovered devices.
#codereview marcus.wassmer

[CL 2405085 by Chris Gagnon in Main branch]
2015-01-13 15:11:55 -05:00
Steve Robb
0756ef15b9 Delegate comparisons deprecated, lots of other associated code deprecated, and lots of warning fixups:
* Multicast delegate Add* calls now return FDelegateHandles, and Remove* calls are now all deprecated, except for a new Remove function which takes a FDelegateHandle.
* New FConsoleManager::RegisterConsoleVariableSink_Handle and UnregisterConsoleVariableSink_Handle functions which work in terms of FConsoleVariableSinkHandle.
* Timer calls which don't take FTimerHandles are deprecated.
* FTicker::AddTicker now returns an FDelegateHandle and is removed by an overloaded Remove function.
* DEFINE_ONLINE_DELEGATE* macros now define _Handle variants of the Add/Remove functions which return/take handles.
* Various other handle-based registration changes.
* Some unity build fixes.
* Some simplification of delegate code.
* Fixes for lots of existing code to use handle-based registration and unregistration.

#codereview robert.manuszewski

[CL 2400883 by Steve Robb in Main branch]
2015-01-08 09:29:27 -05:00
Ben Marsh
149375b14b Update copyright notices to 2015.
[CL 2379638 by Ben Marsh in Main branch]
2014-12-07 19:09:38 -05:00
Max Preussner
fdfdf274ee Messaging: First pass on making headers compilable individually
[CL 2333827 by Max Preussner in Main branch]
2014-10-17 19:15:09 -04:00
Max Preussner
d206670ffe TargetPlatform: Replaced namespaced enums with enum classes
[CL 2326174 by Max Preussner in Main branch]
2014-10-10 20:14:21 -04:00
Max Preussner
762f10fc6b TargetDeviceServices: Code and documentation cleanup pass
[CL 2323221 by Max Preussner in Main branch]
2014-10-08 16:57:50 -04:00
Max Preussner
04874fa782 DeviceManager: Fixed regression: Target devices cannot be released
#CodeReview: chris.gagnon, marcus.wassmer

[CL 2322991 by Max Preussner in Main branch]
2014-10-08 13:54:50 -04:00
Chris Gagnon
c36ad97587 UI is now robust enough to handle variant list corruption.
Fix for UFE Crash caused by Serialization issues (Corruption no longer occurs).

[CL 2320180 by Chris Gagnon in Main branch]
2014-10-06 14:07:37 -04:00
Michael Noland
928559eaa0 Editor: Coding-standards fixes (TypeName [*|&] VariableName -> TypeName[*|&] VariableName)
[CL 2316341 by Michael Noland in Main branch]
2014-10-01 14:45:23 -04:00
Max Preussner
e524e270f1 Core: Re-adding UClass dummy removals from CL# 2305058; this should now work properly
#CodeReview: dmitriy.dyomin, robert.manuszewski

[CL 2307110 by Max Preussner in Main branch]
2014-09-23 13:29:47 -04:00
Dmitriy Dyomin
2f10e3b20c Restored dummy UClasses, looks like they are still needed (crashes on engine startup)
#codereview Max.Preussner

[CL 2305176 by Dmitriy Dyomin in Main branch]
2014-09-22 01:01:36 -04:00
Max Preussner
121fccd2ab Code and documentation cleanup pass
- removed dummy UClasses (no longer needed)
- removed file header comments (not used)
- removed duplicated function documentation in cpp files
- documentation cleanup, punctuation, spelling etc.
- pragma once include guards (now work on all platforms)
- relative public includes (are auto-discovered by UBT)
- fixed too many/too few line breaks
- deleted empty files
- missing override
- NULL to nullptr

[CL 2305058 by Max Preussner in Main branch]
2014-09-21 20:35:48 -04:00
Chris Gagnon
7c7c1cc543 Fixed a crash caused by a profile refering to an unsupported variant.
#codereview max.preussner

[CL 2302666 by Chris Gagnon in Main branch]
2014-09-18 13:32:06 -04:00
Chris Gagnon
1322601e10 Missed a Username convert which cause devices to not show up.
[CL 2299020 by Chris Gagnon in Main branch]
2014-09-15 22:03:49 -04:00
Chris Gagnon
e9fc0ada9d Removed Whitespace from usernames.
Added new buttons on the lauch profile results screen ( rerun, and cancel without closing).
Fixed possible crash when trying to populate a non existant profiler window.
#codereview matt.kuhlenschmidt

[CL 2295572 by Chris Gagnon in Main branch]
2014-09-12 16:57:10 -04:00
Chris Gagnon
0b7619a711 Added missing build configuration UI in the advanced settings.
Fixed possible crash when removing a device.
Some cleanup of unused API.
#codereview matt.kuhlenschmidt

[CL 2292529 by Chris Gagnon in Main branch]
2014-09-10 12:32:10 -04:00
Chris Gagnon
18c1b726cf Removed spurious #pragma once
[CL 2291458 by Chris Gagnon in Main branch]
2014-09-09 17:20:40 -04:00
Chris Gagnon
9ccd8c9ec4 Target Platform API added to provide more information about variants and variant support.
Device Services Refactoring to create the concept of a physical device.
Game launcher and device viewer UI changes to show these new concepts.
#codereview Max.Preussner, Matt.Kuhlenschmidt

[CL 2290918 by Chris Gagnon in Main branch]
2014-09-09 12:20:43 -04:00
Ben Marsh
e9f8b8d3a1 Fixup multiline comments that are meant to be documentation. Need to start with /** for doxygen to parse them.
[CL 2265840 by Ben Marsh in Main branch]
2014-08-21 08:33:39 -04:00