Commit Graph

36 Commits

Author SHA1 Message Date
Saul Abreu
79a26091bf Fixed behavior on FString::ParseIntoArray (muliple delimiters overload) functionality to support optionally culling empty strings. Greatly simplified implementation logic. Output parameter now properly named and taken by reference.
#codereview Steve.Robb, Robert.Manuszewski

[CL 2466824 by Saul Abreu in Main branch]
2015-03-02 15:51:37 -05:00
Ben Marsh
0c9614b56a Fixes for UnrealVersionSelector:
* Only try to build UBT if it's not present in the *target* engine directory (as opposed to the running engine directory). Fixes problems with running from launcher installation.
* Fix building UBT from paths that contain spaces.
* Better logging of what's going on when trying to build UBT (and possible failure points)
* Remove duplicate entries in installation list, and make sure that every path is stored in the same way. Was allowing a number of paths to contain relative portions.

#codereview Carlos.Cuello

[CL 2424385 by Ben Marsh in Main branch]
2015-01-29 16:15:16 -05:00
Dmitry Rekman
7f0fd4c401 Added generic UserTempDir() to platform abstraction.
- Moved Windows code from DesktopPlatform module to Core.
- All other platforms aren't implemented yet, but should compile (fixes CIS).

#codereview Dan.Hertzka, Matt.Kuhlenschmidt, Michael.Trepka, Josh.Adams

[CL 2409470 by Dmitry Rekman in Main branch]
2015-01-16 16:20:36 -05:00
Dan Hertzka
8c7348dc9b Replaced the "Get Visual Studio" hyperlink in the SNewProjectWizard and SNewClassDialog with an "Install Visual Studio" button on Windows
- Added IDesktopPlatform::GetUserTempPath() and implemented it for windows
- Created SGetSuggestedIDEWidget class that handles whether to show a "Download X" hyperlink vs. an "Install X" button (depending on whether the platform supports on-demand installation)
- Analytics event added ("Editor.Usage.InstalledIDE") that fires whenever the "Install X" button is clicked
- Changed SourceCodeIDEURL_Windows in BaseEditor.ini from the VSC 2013 web page link to the installer download link (need to replace with perma-link once we have it)

[CL 2409158 by Dan Hertzka in Main branch]
2015-01-16 13:29:54 -05:00
Ben Marsh
149375b14b Update copyright notices to 2015.
[CL 2379638 by Ben Marsh in Main branch]
2014-12-07 19:09:38 -05:00
Andrew Rodham
4ad1b987fc Improved progress reporting in the editor
FScopedSlowTask has been refactored to better allow for nesting of slow operations. This allows us to cascade nested scopes and provide accurate feedback on slow tasks. FScopedSlowTasks now work together when nested inside sub functions. Break up long functions that contain calls to multiple nested FScopedSlowTasks with FScopedSlowTask::EnterProgressFrame().

Example Usage:
void DoSlowWork()
{
    FScopedSlowTask Progress(2.f, LOCTEXT("DoingSlowWork", "Doing Slow Work..."));
    // Optionally make this show a dialog if not already shown
    Progress.MakeDialog();

    // Indicate that we are entering a frame representing 1 unit of work
    Progress.EnterProgressFrame(1.f);

    // DoFirstThing() can follow a similar pattern of creating a scope divided into frames. These contribute to their parent's progress frame proportionately.
    DoFirstThing();

    Progress.EnterProgressFrame(1.f);
    DoSecondThing();
}

This addresses TTP#338602 - NEEDS REVIEW: Editor progress bars nearly always just show 100%, don't offer useful indication of progress

[CL 2322391 by Andrew Rodham in Main branch]
2014-10-08 04:42:34 -04:00
Jaroslaw Palczynski
65ba5d456f TArray documentation and a coupld of methods deprecation.
Changes mostly in Array.h. The changes in other files are only renames for deprecated functions.

[CL 2312616 by Jaroslaw Palczynski in Main branch]
2014-09-29 04:23:44 -04:00
Max Preussner
121fccd2ab Code and documentation cleanup pass
- removed dummy UClasses (no longer needed)
- removed file header comments (not used)
- removed duplicated function documentation in cpp files
- documentation cleanup, punctuation, spelling etc.
- pragma once include guards (now work on all platforms)
- relative public includes (are auto-discovered by UBT)
- fixed too many/too few line breaks
- deleted empty files
- missing override
- NULL to nullptr

[CL 2305058 by Max Preussner in Main branch]
2014-09-21 20:35:48 -04:00
Robert Manuszewski
694e7ca807 Hot-Reload: Make sure hot-reload is waiting for new modules only when UBT from the current branch is running
#change Added (desktop) platform abstraction for checking if UBT is running. Fully functional for Windows, WIP for Mac and Linux (should work, but can give false positives)

[CL 2302894 by Robert Manuszewski in Main branch]
2014-09-18 15:12:13 -04:00
Ben Marsh
ae5e700449 Use WinXP compatible functions for DesktopPlatform functionality. TTP 345688 seems to indicate failure to compile CrashReportClient due to using RegGetValue.
[CL 2301206 by Ben Marsh in Main branch]
2014-09-17 13:01:52 -04:00
Ben Marsh
a711f14ebc Fixed stale file association settings that were never cleaned up from the old UE/Rocket shell extensions.
[CL 2262706 by Ben Marsh in Main branch]
2014-08-19 13:06:50 -04:00
Ben Marsh
f059fa0542 Always show the marketplace button if the launcher is installed (or can be installed from the installers in Engine\\Extras\\UnrealEngineLauncher).
#codereview Mike.Fricker, Michael.Trepka

[CL 2262476 by Ben Marsh in Main branch]
2014-08-19 09:54:22 -04:00
Mike Fricker
1f5c22cff5 SlateViewer now compiles and runs using Clang for Windows
- Fixed bad casting in "slow task" window creation code
- Also added comment about treating warnings as errors with Clang

[CL 2260828 by Mike Fricker in Main branch]
2014-08-18 10:23:54 -04:00
Steve Robb
57dd5d7493 New ENUM_CLASS_FLAGS macro for declaring all of the bitwise operators needed for a bitflags enum.
Fixed CONSTEXPR definitions.
Converted EFontImportFlags to an enum class in order to test this feature.

#codereview robert.manuszewski,john.barrett

[CL 2254804 by Steve Robb in Main branch]
2014-08-13 12:53:47 -04:00
Terence Burns
440672e372 Fix for Windows XP compile issues.
Cannot use ::RegGetValue or ::RegDeleteTree with xp supported builds, compatible alternatives added.

[CL 2251408 by Terence Burns in Main branch]
2014-08-11 10:30:29 -04:00
Ben Marsh
2273dd82b7 Normalize path for Win32 call to opening a project using the shell.
[CL 2110346 by Ben Marsh in Main branch]
2014-06-19 08:06:46 -04:00
Ben Marsh
dbe3af585d Add a function to open a project file using the shell. Always opens as an Unreal.ProjectFile, preventing the user's default program selection from overriding it.
#codereview Nicholas.Davies

[CL 2109482 by Ben Marsh in Main branch]
2014-06-18 13:42:01 -04:00
Matt Kuhlenschmidt
cb140c07dc Merged GitHub pull request #202 to main.
refactored tga code to allows use outside of EditorFactories.cpp
added support for grayscale jpeg
fix memory leak in jpeg code
changes in AssetTools to allow to specify precise factory when multiple factories support the same filetype
changes in Plugin.cs to allow binary only plugins
exposed parts of engine API to other modules

[CL 2108453 by Matt Kuhlenschmidt in Main branch]
2014-06-17 16:16:40 -04:00
Jaroslaw Palczynski
ebce413232 UE4 Refactoring. Changed OVERRIDE and FINAL macros to keywords override and final.
[CL 2104397 by Jaroslaw Palczynski in Main branch]
2014-06-13 06:14:46 -04:00
Ben Marsh
7aa5f3825c Move the feedback context window to the front when it's first displayed.
[CL 2077835 by Ben Marsh in Main branch]
2014-05-19 13:08:20 -04:00
Ben Marsh
bf6db427fe Fix generating project files for non-foreign projects.
[CL 2077834 by Ben Marsh in Main branch]
2014-05-19 13:08:08 -04:00
Ben Marsh
25264358fd Fix updates not writing out to the log in FWindowsNativeFeedbackContext.
[CL 2073609 by Ben Marsh in Main branch]
2014-05-14 19:56:42 -04:00
Ben Marsh
9154520358 CIS fix for Win32.
[CL 2073374 by Ben Marsh in Main branch]
2014-05-14 16:20:51 -04:00
Ben Marsh
661056258e Don't re-read launcher installation list if the timestamp hasn't changed.
[CL 2073301 by Ben Marsh in Main branch]
2014-05-14 15:20:39 -04:00
Ben Marsh
45ebc11eb9 Add native feedback context for Windows, and use it to display project file generation progress in UnrealVersionSelector. Also generate project files when switching versions.
[CL 2073201 by Ben Marsh in Main branch]
2014-05-14 14:53:19 -04:00