Commit Graph

468 Commits

Author SHA1 Message Date
helen yang
0650063b74 Add hidden friend GetHashType hash functions for MetaSound types for Array Random Get node refactor
#jira UE-211778

#rb phil.popp

[CL 33492636 by helen yang in ue5-main branch]
2024-05-07 15:58:09 -04:00
jack porter
3ee785bcce Emit warning for code using the old #include "PerPlatformProperties.h" instead of #include "UObject/PerPlatformProperties.h"
Update all existing references
#jira UE-212076
#rb David.Harvey

[CL 33424549 by jack porter in ue5-main branch]
2024-05-03 09:13:43 -04:00
matthew booth
2133e33fe0 [MetasoundEngine] TAudioBusReaderOperator crash fix - BusProxy.Object was nullptr
[REVIEW] [at]maxwell.hayes
[FYI] phil.popp
#rb phil.popp

[CL 33341104 by matthew booth in ue5-main branch]
2024-04-30 12:12:19 -04:00
maxwell hayes
266cdaa324 [MetaSounds] Fix for AudioBusReaderNode resizing an array to a large value (unsigned overflow)
#rb jimmy.smith
#rnx

[CL 33311643 by maxwell hayes in ue5-main branch]
2024-04-29 15:51:34 -04:00
rob gay
39d0de55b1 Fix for AudioUnitTest build break caused by added Engine & AudioMixer dependencies in MetaSound Frontend
#rb rob.gay
#rnx
[FYI] pete.bliss, phil.popp
#jira UE-213147

[CL 33282525 by rob gay in ue5-main branch]
2024-04-26 18:28:12 -04:00
aaron mcleran
25e7e03cdf Adding StartTime interface as an optional MetaSound Source interface.
StartTime used in BP API and Sequencer will now be forwarded to the MetaSound through this interface. The MetaSound can decide what to do with that information -- i.e. sound design what 'Start Time' means.

#rb Phil.Popp, Rob.Gay, Brian.Chrisman
#jira UE-211683

[CL 33272664 by aaron mcleran in ue5-main branch]
2024-04-26 14:51:16 -04:00
rob gay
e8e0c199a2 Remove dependency on MetaSound engine subsystems of any kind being required to register MetaSounds with frontend
#rb rob.gay
#rnx
[FYI] sondra.moyls, phil.popp, helen.yang

[CL 33199328 by rob gay in ue5-main branch]
2024-04-24 10:36:28 -04:00
steve robb
20e93ad90b Fixed potentially uninitialized variables.
#jira UE-87511

[CL 33146357 by steve robb in ue5-main branch]
2024-04-22 14:54:14 -04:00
pete bliss
bc4a3bdfc5 Fix for pin audio inspector oscilloscope data dropouts.
#jira UE-196333
#rb Rob.Gay

[CL 33136245 by pete bliss in ue5-main branch]
2024-04-22 08:43:37 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
steve robb
2981e439fb Fixed unused and potentially uninitialized FQuats and FVector2Ds.
#jira UE-87511

[CL 33099248 by steve robb in ue5-main branch]
2024-04-19 07:10:09 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
50a661b140 Reverting early return speculative fix for warnings and removing warning for now when attempting to cache MetaSound runtime data to fix sequencer warnings.
#rb rob.gay
[FYI] phil.popp, helen.yang
#jira UE-194159
#rnx

[CL 33089038 by rob gay in ue5-main branch]
2024-04-18 18:24:11 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00
miro salminen
72d7104167 [MetaSound Feature Request] Add Get Name to Wave Asset
#rb phil.popp
#jira UE-177360
#rnx

[CL 33030277 by miro salminen in ue5-main branch]
2024-04-17 02:41:05 -04:00
chris ritter
c92ef085b9 Expose VertexInterface changes in OnGeneratorIOUpdated
#rb phil.popp
#tests PIE, MetasoundDynamicGenerator test suite
[FYI] charlie.huguenard

[CL 32873045 by chris ritter in ue5-main branch]
2024-04-11 02:17:22 -04:00
phil popp
f0941560d0 Fix ensure on retrieving quality settings from none-asset metasound.
#jira UE-210369, FORT-724365
#rb rob.gay

[CL 32448309 by phil popp in ue5-main branch]
2024-03-22 16:20:00 -04:00
jimmy smith
048f5a5a11 Fix for perf regression in Metasounds
#rb Maxwell.Hayes, phil.popp
#tests Local verification

[CL 32409889 by jimmy smith in ue5-main branch]
2024-03-21 15:21:31 -04:00
jimmy smith
0637da8f9e Fix non-cooked quality settings by adding a cook stage the MetasoundSource to correctly save them out per platform.
Previously the PerPlatformSettings was added to the MetasoundSettings, however as this is not a true asset they weren't being correctly cooked.
The code previously pulled the global settings, then allowed overrides upon this. This decision is now made during cook.
#rb jake.burga, Josh.Adams
#tests Shelve tested back and forth with Sondra Moyles
#jira UE-204075

[CL 32370815 by jimmy smith in ue5-main branch]
2024-03-20 12:42:32 -04:00
jimmy smith
2bf8dd4f1f Fix for Client Crash - ADPCM::DecodeBlock() - Code by Aaron.
#rb aaron.mcleran
[FYI] aaron.mcleran

[CL 32198462 by jimmy smith in ue5-main branch]
2024-03-12 19:34:04 -04:00
rob gay
524d0f85fe Refactor reroute templating in preparation of new templates coming in subsequent changes (i.e. inputs, maybe more node config templates, etc.)
#rb phil.popp
#jira UE-194159
#tests AudioUnitTests, engine tests, tested adding, removing, and auditioning reroutes

[CL 32104370 by rob gay in ue5-main branch]
2024-03-07 17:53:25 -05:00
maxwell hayes
ca3c6d9f4c [MetaSound Operator Cache] Added defense and warning against calling Remove without a MetaSound source
#jira UE-201800
#swarm 32060562
#rb alfaroh.corneyiii

[CL 32068233 by maxwell hayes in ue5-main branch]
2024-03-06 16:52:28 -05:00
rob gay
446e58f9fd Move operator cache to use async build pipe instead of task graph (follow-up to listed bug fix per initial review feedback)
#rb Maxwell.Hayes
#jira UE-201787
#rnx

[CL 31918581 by rob gay in ue5-main branch]
2024-02-29 14:30:15 -05:00
jimmy andrews
5e5d976da3 fix unreachable implicit "++iterator" in cases where a for-loop was used to just grab the first element of a set or map
#rb lonnie.li
#lockdown michael.balzer

[CL 31880424 by jimmy andrews in ue5-main branch]
2024-02-28 14:51:06 -05:00
matthew booth
5ee63ad5f0 [MetasoundEngine] Provide UnwatchOutput API as inverse of WatchOutput operation.
#rb charlie.huguenard

[CL 31859188 by matthew booth in ue5-main branch]
2024-02-27 19:26:07 -05:00