Commit Graph

367 Commits

Author SHA1 Message Date
Tim Smith
808f81dd6c Performance improvements and clean up in preperation for a Live Coding fix.
1) Refactored preparsing to scan for @UCLASS, @USTRUCT, and @ENUM and define then.  This means that no new entries into the type definition info system will be added after pre-parsing and thus remove the need for any type of locking during code generation.
2) Parsing and code generation is now being done in a strict order based on dependencies and no longer by project.  This removes the need of explicitly parsing depedencies first or waiting on hashes to be computed.  (Provided a 50%-80% improvement in code generation time)
3) Changed HeaderParser to be specific to one source file.  Removed the need to pass the source file around since it is always known at construction time.  Simplified some error handling logic.
4) Changed parallel for loops to using event graph to provide more concurrency.
5) Refactored the main program flow into concise steps.

Testing:

Verified that the headers generated exactly the same for:

1) First person C++ Project
2) UnrealEditor
3) QAGame
4) ShooterGame
5) FortniteGame

FYI: Marc had reviewed this as part of a larger change but some parts were extract.  These are the remaining changes.

#rb marc.audy
#rnx
#preflight 6078666a02850d00010e22c5

[CL 16023636 by Tim Smith in ue5-main branch]
2021-04-15 13:44:34 -04:00
Tim Smith
5c94acdaa1 Provide a more general exception class.
New mechanism for maintaining the overall result.
Helper methods for making try blocks.

Work in progress

#rb steve.robb
#rnx
#preflight 607706d22674e100018f74af

[CL 16006480 by Tim Smith in ue5-main branch]
2021-04-14 11:55:52 -04:00
Marc Audy
01b7c9f4f5 Merge UE5/RES @ 15958325 to UE5/Main
This represents UE4/Main @ 15913390 and Dev-PerfTest @ 15913304

[CL 15958515 by Marc Audy in ue5-main branch]
2021-04-08 14:32:07 -04:00
Tim Smith
d9a3b5af20 Minor changes to stablize UHT code generation in preperation for more extensive performance changes.
#rb devin.doucette
#rnx

[CL 15915280 by Tim Smith in ue5-main branch]
2021-04-05 09:17:25 -04:00
Tim Smith
11119486ae Fix issue where if in a single include file, we define UMyInterface, implement IMyInterface, and implement the interface in a UObject, UHT would generate a circular dependency error.
The fix is to ignore identifier references that resolve to the same source file.

#rb none

[CL 15873286 by Tim Smith in ue5-main branch]
2021-03-31 07:49:15 -04:00
Tim Smith
a9dd8d0077 Client fails to build due to an assert in UHT.
#rb trivial
#jira UE-111972

#ushell-cherrypick of 15850207 by Tim.Smith

[CL 15850311 by Tim Smith in ue5-main branch]
2021-03-29 09:30:09 -04:00
Jamie Dale
4ca8447908 Fixed bad merge
#fyi Ben.Marsh, Tim.Smith
#rb none
#rnx

[CL 15815140 by Jamie Dale in ue5-main branch]
2021-03-24 22:16:13 -04:00
ben marsh
7427752f6c Various UE4->UE5 renames.
#rb none
#jira UE-111511, UE-111448, UE-111128, UE-111287, UE-111198, UE-111657
#preflight 605b8cec0c31c10001599547

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 15807072 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v783-15756269)
#ROBOMERGE-CONFLICT from-shelf

[CL 15813821 by ben marsh in ue5-main branch]
2021-03-24 20:52:19 -04:00
Tim Smith
7571d8ea73 Reduce preprocessing time by 60%. Utilizing JobGraph to allow reading and initial parsing of files to be 100% concurrent.
#rb devin.doucette

[CL 15738003 by Tim Smith in ue5-main branch]
2021-03-18 11:03:01 -04:00
Tim Smith
a2237e050d LiveCoding Re-instancing
LIMITATIONS:

1) Re-instancing will only update UClass instance data.
2) Adding and removing properties should only be done towards the end of a class or structure and can not be followed by complex data types.
3) Adding and removing properties from a base class should not be done if a derived class contains complex data types.

KNOWN ISSUES:

1) Changes to enumerations and structures will not be reflected in existing blueprints.  However, adding new nodes to the blueprint will show the updated enumeration or structure.
2) If a class contains an enumeration or structure as a member, the class will not be re-instanced if enumeration or structure is changed.

CHANGES:

1) LiveCodingServer
1a) Modified to always execute certain static instances during load.
1b) Modified to exclude the _Statics static structures to avoid patching to old copies.

2) Added support for LiveCoding reinstancing
2a) Refactored deferred registration system for UClass, UEnum, and UScriptStruct to use a common system that works for normal game, hot reload and live coding.
2b) Type specific version check data is possible (i.e. enum doesn't have a size)
2c) Single registration static for UClass
2d) Single registration class for all types that is just a blind forward to API.
2e) Static and dynamic registrations use different API entry points to avoid having overloaded argument lists that just apply to one or the other.
2f) Shims for older API

3) New common "Reload" system to avoid using HotReload code.
3a) Support common delegates regardless of who is reloading/reinstancing.
3b) Re-instancing code moved from HotReload to Kismet2 (where the bulk of the re-instance code already existed).
3c) Modified PyWrapper to use new helper class instead of depending on HotRelaod
3d) Added WITH_RELOAD which is defined if HotReload or LiveCoding is enabled.
3e) Modifed existing code to use new #define and delegates.

Robert did the review on the changes covered by Part 2.  Remaining changes are all straightforward.

#rb robert.manuszewski
#jira UE-74493

[CL 15736777 by Tim Smith in ue5-main branch]
2021-03-18 08:13:59 -04:00
Tim Smith
35cc3755d2 Fixing a race condition with -WRITEREF and -VERIFYREF that would cause files to be missing.
Removed some unused functionality in FScriptLocation that wasn't being used and depended on a global variable.

#rb devin.doucette

[CL 15726794 by Tim Smith in ue5-main branch]
2021-03-17 13:16:36 -04:00
Marc Audy
1d16cff267 No longer generate PPO offsets since nativization is no longer a thing
#rb Phillip.Kavan

[CL 15480852 by Marc Audy in ue5-main branch]
2021-02-19 20:14:52 -04:00
Marc Audy
9753392e2b Merge UE5/RES CL# 15462083 to UE5/Main
This represents UE4/Main @ 15414221

[CL 15463811 by Marc Audy in ue5-main branch]
2021-02-18 18:13:28 -04:00
Zousar Shaker
bdfe4fff0f Split the representation in the reflection system of TObjectPtr fields into FObjectPtrProperty (derived from FObjectProperty and already existed since the introduction of wrapped object pointers) and a new FClassPtrProperty (derived from FClassProperty, and newly introduced in this change). As with raw pointers, UHT will generate code for one vs the other depending on whether the inner type is derived from UClass or not. The new reflection type is meant to be functionally equivalent to the existing one, except it changes how the PROPERTY (not the instance of the field on a containing object) is serialized to ensure it includes the MetaClass member as inherited from FClassProperty.
#rb robert.manuszewski

[CL 15317249 by Zousar Shaker in ue5-main branch]
2021-02-04 12:19:38 -04:00
Marc Audy
cac1fe0019 Merge UE5/Release-Engine-Staging @ CL# 15299266 to UE5/Main
This represents UE4/Main @ CL# 15277572

[CL 15299962 by Marc Audy in ue5-main branch]
2021-02-03 14:57:28 -04:00
Marc Audy
bc88b73a29 Merge Release-Engine-Staging to Main @ CL# 15151250
Represents UE4/Main @ 15133763

[CL 15158774 by Marc Audy in ue5-main branch]
2021-01-21 16:22:06 -04:00
Marc Audy
4c1bb11c29 Merge UE5/Release-Engine-Staging to UE5/Main @ 14548662
This represents UE4/Main @ 14525125 + cherrypicked fixes
#skipundocheck

[CL 14551026 by Marc Audy in ue5-main branch]
2020-10-22 19:19:16 -04:00
jack cai
cc44047bec RigVM: Backing out UHT changes @ CL14544263, causing UHT failure in Frosty
#jira UE-101652
#rb none

[CL 14546229 by jack cai in ue5-main branch]
2020-10-22 12:33:50 -04:00
jack cai
cbe2dcee05 RigVM: Add header file path registration for RigVM Functions, required for Control Rig Nativization Research Project
#jira UEA-679

#rb helge.mathee sara.schvartzman

[CL 14544263 by jack cai in ue5-main branch]
2020-10-22 09:42:42 -04:00
Zousar Shaker
77d13185b7 Copying //UE5/Dev-Cooker@14539516 to Main (//UE5/Main)
[CL 14539954 by Zousar Shaker in ue5-main branch]
2020-10-21 17:56:05 -04:00
Marc Audy
50a3d7d368 Merge Release-Engine-Staging to Main @ CL# 14467590
This represents UE4/Main @ 14432125 + some cherrypick fixes

[CL 14468207 by Marc Audy in ue5-main branch]
2020-10-09 22:42:26 -04:00
Marcus Wassmer
3b81cf8201 Merging using //UE5/Main_to_//UE5/Release-Engine-Staging @14384769
autoresolved files
#rb none

[CL 14384911 by Marcus Wassmer in ue5-main branch]
2020-09-24 00:43:27 -04:00
Marc Audy
7379fa99c5 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14229157
[CL 14233282 by Marc Audy in ue5-main branch]
2020-09-01 14:07:48 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00