Commit Graph

146 Commits

Author SHA1 Message Date
Robert Manuszewski
52d331d41c Temp fix for a crash when reverting a struct property value to default in the editor
#rb trivial
#jira none
#preflight none

[CL 19266180 by Robert Manuszewski in ue5-main branch]
2022-03-04 10:11:02 -05:00
Robert Manuszewski
6da981b1c6 Fixing reset to defaults arrow not working
#rb Sebastian.Nordgren
#jira none
#preflight trivial

[CL 19198464 by Robert Manuszewski in ue5-main branch]
2022-03-01 10:32:26 -05:00
marc audy
cff01aa9fa Added support for native FProperty setters and getters.
Setters and getters are native functions called by FProperties when setting property values with *_InContainer functions.
Setters and getter function names can be manually specified with Setter = Func and Getter = Func keywords inside of UPROEPRTY macro but they will also be automatically parsed if the name is not explicitly specified if the setter or getter function name matches SetPropertyName and GetPropertyName pattern.
The latter behavior can be disabled in UHT's DefaultEngine.ini by setting AutomaticSettersAndGetters=False.
ImportText and ExportTextItem functions have been deprecated and should be replaced with *_InContainer or *_Direct variants.

#rb Steve.Robb
#preflight 6210a377a83e0bcefd03d9e1

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19070318 via CL 19098059 via CL 19104650 via CL 19104661 via CL 19110012
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147839 by marc audy in ue5-main branch]
2022-02-25 10:39:39 -05:00
jamie dale
d45257c2ba Allow AddChildStructure to be used by sparse data properties
The child struct properties can't inherit the sparse data flag, as FStructurePropertyNode is already directly editing a block of struct memory.

#jira UE-140961
#preflight 61fa9368ad2ae6c3b75c1d66
#rb Mikko.Mononen

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 18826037 in //UE5/Release-5.0/... via CL 18826067 via CL 18826480
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18826515 by jamie dale in ue5-main branch]
2022-02-02 10:02:39 -05:00
sebastian nordgren
fe30f189fd The Reset to Default button is no longer hidden when a details row is disabled, but is rather shown greyed out.
#jira UE-139917
#review-18772191 @lauren.barnes
#preflight 61f415e06b5aea38e5bb1726

[CL 18824161 by sebastian nordgren in ue5-main branch]
2022-02-02 07:11:10 -05:00
daren cheng
bb88259ae8 Fix TMap key EditInlineNew if value is EditInlineNew.
#jira UE-137280
#rb sebastian.nordgren
#robomerge 5.0
#preflight 61b90f3f8f57c5c0c2289713

[CL 18461100 by daren cheng in ue5-main branch]
2021-12-14 17:43:57 -05:00
jamie dale
e3da028dc7 Fixed InvalidateCachedState not being called when editing structs
It was specifically looking for an object parent rather than a complex parent, which meant it skipped invalidating the cache when editing a struct (including a nested external struct) rather than an object.

#jira
#preflight skip
#rb Sebastian.Nordgren
#rnx

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 18340184 via CL 18342197 via CL 18342218 via CL 18342239 via CL 18342503 via CL 18342517
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18342528 by jamie dale in ue5-release-engine-test branch]
2021-12-01 14:05:13 -05:00
jamie dale
bb2eb686ca Fixed a crash when pasting into an array on class sparse data
This would try and get the value of the outer array property (for the inner array value) using FObjectBaseAddress::ObjectOrStruct as the start address, however for class sparse data FObjectBaseAddress::ObjectOrStruct was set to the CDO of the class that owns the sparse data, rather than the start of the sparse data itself. This resulted in a crash as it would try and read garbage from the CDO.

This change removes FObjectBaseAddress::ObjectOrStruct and FObjectBaseAddress::bIsStruct, in favor of storing FObjectBaseAddress::Object (if not editing a struct) and FObjectBaseAddress::StructAddress. FObjectBaseAddress::StructAddress always points to the thing that actually contains FObjectBaseAddress::BaseAddress, which allows the ImportText code to get the correct offset for the array property within the sparse data instance.

#jira
#rb Sebastian.Nordgren
#preflight 61a59b104f5d65edc3a8564b
#rnx

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 18326295 via CL 18328452 via CL 18328534 via CL 18328607 via CL 18330452 via CL 18330516
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18330630 by jamie dale in ue5-release-engine-test branch]
2021-11-30 15:35:13 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
sebastian nordgren
926e5fe8bb Added support for parentheses in EditConditions. Added as a result of a UDN feature request.
[at]lauren.barnes

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 18017850 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v885-17909292)

[CL 18017926 by sebastian nordgren in ue5-release-engine-test branch]
2021-11-02 09:24:19 -04:00
sebastian nordgren
899e16bc3e Changed FPropertyNode::GetChildNode(FName) to breadth-first search instead of depth-first, which lead to these types of situations:
class UFoo
{
   struct Bar { int X; } Bar;
   int X;
}

Returning Bar.X instead of just X when searching for "X", because we were iterating into the struct's children before our own.

This entire behaviour is a bit questionable since it doesn't use property paths, and is presumably in place to deal with groups and not structs, but I'm not comfortable making that change without further testing.

#jira UE-126704
[at]matt.kuhlenschmidt, [at]mikko.mononen

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 17721178 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v879-17706426)

[CL 17721189 by sebastian nordgren in ue5-release-engine-test branch]
2021-10-05 10:17:20 -04:00
sebastian nordgren
e99ee26673 Added ensure in GetDefaultValueAsString() to check that default value does not differ per-object (it really shouldn't) in FPropertyNode. If all values are the same, we return only the single default value, but if they differ we'll fallback to the previous behaviour.
This ensure is intended to check if we can simplify the logic here to just return the first object's default value in the near future.

#jira UE-81958
[at]matt.kuhlenschmidt

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 17721129 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v879-17706426)

[CL 17721138 by sebastian nordgren in ue5-release-engine-test branch]
2021-10-05 10:14:42 -04:00
aurel cordonnier
69fe095547 Merge from Release-Engine-Staging @ 17636544 to Release-Engine-Test
This represents UE4/Main @17638339 and Dev-PerfTest @17636504

[CL 17638842 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-27 19:54:25 -04:00
aurel cordonnier
7f517562d5 Merge from Release-Engine-Staging @ 17438845 to Release-Engine-Test
This represents UE4/Main @17430120 and Dev-PerfTest @17437669

[CL 17439044 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-06 12:23:53 -04:00
sebastian nordgren
5a66bb1326 FPropertyNode::HasNodeFlags now returns a bool instead of an int32.
#review-16483510 @lauren.barnes
#preflight 60afa1c60bdb27000127825e

[CL 16484743 by sebastian nordgren in ue5-main branch]
2021-05-27 10:52:20 -04:00
aurel cordonnier
50944fd712 Merge UE5/RES @ 16162155 to UE5/Main
This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156

[CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
geoff evans
2ef2da232c Remove outdated/incorrect comment about when EnsureDataIsValid should be called.
#jira none
#rb trivial

[CL 16150354 by geoff evans in ue5-main branch]
2021-04-28 18:45:58 -04:00
Marc Audy
01b7c9f4f5 Merge UE5/RES @ 15958325 to UE5/Main
This represents UE4/Main @ 15913390 and Dev-PerfTest @ 15913304

[CL 15958515 by Marc Audy in ue5-main branch]
2021-04-08 14:32:07 -04:00
sebastian nordgren
7f2094a931 FPropertyNode::GetQualifiedName() with bIgnoreCategories = true now doesn't add ".." to the path.
#jira UE-109724
#review-15874782 @lauren.barnes

[CL 15887560 by sebastian nordgren in ue5-main branch]
2021-04-01 07:18:23 -04:00
sebastian nordgren
48a7048043 Speculative fix for crash bug when fetching a potentially invalid CachedReadAddress when the parent node is invalid.
#jira UE-94688
#rb patrick.boutot

#ROBOMERGE-SOURCE: CL 15823080 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v785-15821902)

[CL 15829789 by sebastian nordgren in ue5-main branch]
2021-03-25 15:40:41 -04:00
Marc Audy
0cbbc781ca Merge UE5/Release-Engine-Staging @ 15740152 to UE5/Main
This represents UE4/Main @ 15709114

[CL 15740605 by Marc Audy in ue5-main branch]
2021-03-18 15:20:03 -04:00
Marc Audy
9753392e2b Merge UE5/RES CL# 15462083 to UE5/Main
This represents UE4/Main @ 15414221

[CL 15463811 by Marc Audy in ue5-main branch]
2021-02-18 18:13:28 -04:00
sebastian nordgren
d3d0c83679 Fixed bug with instanced objects not updating the reset to default state in the parent object when changed.
#review-15357205 @lauren.barnes

[CL 15388256 by sebastian nordgren in ue5-main branch]
2021-02-11 11:59:46 -04:00
Marc Audy
cac1fe0019 Merge UE5/Release-Engine-Staging @ CL# 15299266 to UE5/Main
This represents UE4/Main @ CL# 15277572

[CL 15299962 by Marc Audy in ue5-main branch]
2021-02-03 14:57:28 -04:00
Lauren Barnes
94aa16c5ac Adding command handling for FToolUIActions. There is now an in-viewport property menu that can be enabled by Editor.EnableInViewportMenu in the console, and then pressing Tab when a supported actor (currently any light actor) is selected.
#rb Rex.Hill
#jira UETOOL-2698

[CL 15036864 by Lauren Barnes in ue5-main branch]
2021-01-11 09:19:43 -04:00