Commit Graph

236 Commits

Author SHA1 Message Date
rob gay
1f287a42ac Parameter Update Perf Regression Fix-ups
- Use cached transmissable inputs when initializing/sanitizing parameters
- Update internal API to promote batching & keeping AudioParameters sorted/using faster merge logic where possible
- Swap CitySample vehicle controller to use batched parameter update call
- Clarify When RuntimeData is cached for safety (in InitResources or InitParameters, whichever comes first)
- Alleviate extreme confusion around AudioParameter setters requiring type by adding static conversion functions
#rb helen.yang
#rnx
#jira UE-145211
#preflight 6229424e6e026fc824b24861

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19328764 in //UE5/Release-5.0/... via CL 19329587
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19348372 by rob gay in ue5-main branch]
2022-03-10 22:07:08 -05:00
rob gay
350e70d3e3 AssetClassID generation fix-up (collab fixes w/Helen)
0 Guid MetaSound AssetRegistry entry fix-up
#rb helen.yang
#rb rob.gay
#rnx
#jira UE-144864
#preflight 6226ab981938e4deaa7f4276

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19307367 in //UE5/Release-5.0/... via CL 19308413
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19347405 by rob gay in ue5-main branch]
2022-03-10 21:19:13 -05:00
leon huang
0193ffe8d3 Fix for CIS warnings for localization duplicate keys. Fixes simply involve changing one of the colliding localization keys.
#rnx
	#rb: Vincent.Gauthier
	#jira: UE-143620
	#preflight: 6222489d2f7d78332e121416
	#lockdown Mitchell.Wilson

#ROBOMERGE-AUTHOR: leon.huang
#ROBOMERGE-SOURCE: CL 19272838 in //UE5/Release-5.0/... via CL 19273134
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19275063 by leon huang in ue5-main branch]
2022-03-04 16:10:23 -05:00
phil popp
baf70eb1c0 Fix for ensure on corrupt MetaSound asset in Lyra
#rnx
#jira UE-144618
#rb Rob.Gay
#lockdown Nick.Whiting
#preflight 622167b9aa27915dd675a04a

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 19259554 in //UE5/Release-5.0/... via CL 19260273
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19264034 by phil popp in ue5-main branch]
2022-03-04 04:25:00 -05:00
helen yang
1f363574ed Add logging for failures when matching MetaSound parameters, prevent ensure on enum-string mismatch
#jira UE-144150
#jira UE-144708

#rb jimmy.smith
#preflight 622140c4a00412627d14862e
#rnx

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 19257812 in //UE5/Release-5.0/... via CL 19258561
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263816 by helen yang in ue5-main branch]
2022-03-04 04:08:58 -05:00
rob gay
e8fb5fcd0b - Fix sort order not propagating to presets
- Fix for interfaces not updating/some manipulators being incorrectly editable on MetaSound Presets
- Clarify Set vs Synchronize location on MSEdGraphNodes
- Split up RefreshDetails to RefreshDetails/Interfaces & move RefreshInterface to RefreshGraphMemberMenu
#rb helen.yang
#rnx
#jira UE-144184, UE-144358
#preflight 621ff6b9901d830f366e5369

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19235508 in //UE5/Release-5.0/... via CL 19236719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19237376 by rob gay in ue5-main branch]
2022-03-02 22:11:18 -05:00
helen yang
b351362644 Fix missing MetaSound interface warning and interfaces not updating referencing graphs properly
#jira UE-144323
#jira UE-144366

#rb phil.popp, rob.gay
#preflight 621faa4b31454c90cc013cff
#rnx


#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 19223899 via CL 19226239 via CL 19226369 via CL 19226572 via CL 19226733
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19230244 by helen yang in ue5-main branch]
2022-03-02 16:52:01 -05:00
phil popp
cbdaf267bb Log warning when node connection is dropped during auto-update due to removed vertex.
#rnx
#jira UE-120726
#rb Rob.Gay
#lockdown Nick.Whiting
#preflight 621e6805257fd6e0992bb2ed

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 19204066 in //UE5/Release-5.0/... via CL 19209221
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19215316 by phil popp in ue5-main branch]
2022-03-01 21:25:04 -05:00
jimmy smith
0b389b3662 Fix for metasound Random node failure to reinit shared state.
#rb aaron.mcleran rob.gay phil.popp
#jira UE-112882
#preflight 621d7fbad815cc2f950666d0

#ROBOMERGE-AUTHOR: jimmy.smith
#ROBOMERGE-SOURCE: CL 19203972 in //UE5/Release-5.0/... via CL 19209209
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19215314 by jimmy smith in ue5-main branch]
2022-03-01 21:24:51 -05:00
rob gay
41a2a172dc Fix missing ability to order graph members
- Remove base template for node customizations now that it isn't required to be a template to enable intra-engine versioning (allows moving implementation of category customization to .cpp)
- Move redundant "Literal" property to parent UMetasoundEditorGraphMember
#rb helen.yang
#jira UE-121749
#rnx
#preflight 621d2e869a5676d19a3d50e9

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19181623 in //UE5/Release-5.0/... via CL 19183646
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19206681 by rob gay in ue5-main branch]
2022-03-01 16:31:55 -05:00
yali he
39046d7643 Fix some loc duplicate keys batch 3 (hopefully the last batch)
#jira UELOC-143620
#rb Mitchell.Wilson
#preflight

#ROBOMERGE-AUTHOR: yali.he
#ROBOMERGE-SOURCE: CL 19179273 in //UE5/Release-5.0/... via CL 19180516
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19204171 by yali he in ue5-main branch]
2022-03-01 14:57:03 -05:00
phil popp
ab86d0108e Fix for MetaSound node literal inputs working inconsistently.
#rnx
#jira UE-143657
#rb Aaron.McLeran
#preflight 62192e7f291e1274f8aaeab7
#lockdown nick.whiting

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 19156606 in //UE5/Release-5.0/... via CL 19159812
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19161473 by phil popp in ue5-main branch]
2022-02-25 19:46:58 -05:00
marc audy
cff01aa9fa Added support for native FProperty setters and getters.
Setters and getters are native functions called by FProperties when setting property values with *_InContainer functions.
Setters and getter function names can be manually specified with Setter = Func and Getter = Func keywords inside of UPROEPRTY macro but they will also be automatically parsed if the name is not explicitly specified if the setter or getter function name matches SetPropertyName and GetPropertyName pattern.
The latter behavior can be disabled in UHT's DefaultEngine.ini by setting AutomaticSettersAndGetters=False.
ImportText and ExportTextItem functions have been deprecated and should be replaced with *_InContainer or *_Direct variants.

#rb Steve.Robb
#preflight 6210a377a83e0bcefd03d9e1

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19070318 via CL 19098059 via CL 19104650 via CL 19104661 via CL 19110012
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147839 by marc audy in ue5-main branch]
2022-02-25 10:39:39 -05:00
aaron mcleran
e79529af7a Fixing one-shot interface issues
#rb Rob.Gay
#jira UE-139680
#preflight 620d3d228a1ea1600981931f


#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 19093707 via CL 19095893 via CL 19096208 via CL 19097039 via CL 19105391
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19146717 by aaron mcleran in ue5-main branch]
2022-02-25 09:45:49 -05:00
rob gay
bfbaa43f17 Fix for generating dynamic LiteralNodes that provide default values for vertices that are already connected with explicitly defined edges to the same destination vertex.
#rb ghost of phil.popp
#rnx
#preflight 620edd93731ab58d8254a473


#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19093018 via CL 19093699 via CL 19094508 via CL 19096021 via CL 19105306
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19146581 by rob gay in ue5-main branch]
2022-02-25 09:40:33 -05:00
vincent gauthier
1bd18c6704 Fix to Localization macros usage.
#jira UE-136397
#rb Patrick.Boutot
#preflight 62153604141b500e17ec4ad5
#lockdown jeanmichel.dignard

#ROBOMERGE-OWNER: vincent.gauthier
#ROBOMERGE-AUTHOR: vincent.gauthier
#ROBOMERGE-SOURCE: CL 19081591 in //UE5/Release-5.0/... via CL 19096389
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19140512 by vincent gauthier in ue5-main branch]
2022-02-24 23:16:52 -05:00
maxwell hayes
f9c5000301 Naming gain inputs to clarify linear vs dB. (misinterpretation would appear broken)
#rb Rob.Gay
#jira UE-142956

#lockdown Nick.Whiting
#preflight 620d4027f427898d6b59d216

#ROBOMERGE-AUTHOR: maxwell.hayes
#ROBOMERGE-SOURCE: CL 19060751 in //UE5/Release-5.0/... via CL 19078565
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19121725 by maxwell hayes in ue5-main branch]
2022-02-24 14:42:58 -05:00
aaron mcleran
d379ac8985 Fixing random get "shared state" to use GUIDs vs metasound IDs to preserve state correctly.
#jira ue-139327
#rb maxwell.hayes
#preflight 61fda991cc13ffbd10f2fb8e
#lockdown cristina.riveron

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 19059118 in //UE5/Release-5.0/... via CL 19074716
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19076615 by aaron mcleran in ue5-main branch]
2022-02-22 13:53:17 -05:00
jimmy smith
6e1ba512ee Fix for log spam on Sequencer audio track when using procedural SoundWaves.
#jira UE-136107
#rb rob.gay phil.popp aaron.mcleran
#preflight 620ae1796e5d06a542b421d3

#ROBOMERGE-AUTHOR: jimmy.smith
#ROBOMERGE-SOURCE: CL 18989958 in //UE5/Release-5.0/... via CL 18992584 via CL 18992956
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18997211 by jimmy smith in ue5-main branch]
2022-02-15 11:30:22 -05:00
helen yang
bb284960b2 Compile out FText from MetaSound Nodes in non editor builds
#rb rob.gay
#preflight 62057365a155a4cddac5bf1d
#jira UE-142194

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18945030 in //UE5/Release-5.0/... via CL 18945230 via CL 18946167
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18946312 by helen yang in ue5-main branch]
2022-02-10 18:36:47 -05:00
rob gay
4fddf8ef1c Fix MetaSound Tests Part 1
[REVIEW] helen.yang
#jira UE-142159
#preflight 620594bf6d374b98b0975fed

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18944968 in //UE5/Release-5.0/... via CL 18945212 via CL 18946142
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18946288 by rob gay in ue5-main branch]
2022-02-10 18:36:26 -05:00
rob gay
45e4645008 Compile out editor-only data from MetaSoundFrontend
- Move Author field to FString to avoid generated text collisions (Authors should always be culture invariant anyway) & add option to override default in MetaSound user settings
#rb helen.yang
#jira UE-142159
#preflight 62055c89057375a802938669

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18941073 in //UE5/Release-5.0/... via CL 18941268 via CL 18941634
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18941665 by rob gay in ue5-main branch]
2022-02-10 15:07:39 -05:00
rob gay
6c69365c1f - Fix & re-enable manual update of node class if auto-update is disabled or node class is updated and original class is missing
- Fix updating default value for a graph input not compositionally propagating to references
- Fix 'Reset to Class Default' sometimes showing when it isn't applicable (ex. on triggers or when the class default is out-of-date)
#rb phil.popp
#rnx
#jira UE-135832, UE-138819
#preflight 6204113ad619b08d92f542f4

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18922577 in //UE5/Release-5.0/... via CL 18927066 via CL 18928800
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18929238 by rob gay in ue5-main branch]
2022-02-09 19:27:40 -05:00
rob gay
8279d931a3 Fix for multiple composition nodes referencing same class failing to auto-update properly due to additional class definition added and then immediately removed when it should be updating the pre-existing entry.
- Fix node display title being 'none' when you initially add an externally-defined class
#rnx
#rb phil.popp
#jira UE-140929
#jira UE-136242
#preflight 6202f7fbc451a5d0dc0d9675

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18912572 in //UE5/Release-5.0/... via CL 18919479 via CL 18920616
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18921427 by rob gay in ue5-main branch]
2022-02-09 13:22:21 -05:00
rob gay
6d4096c2af - Reduce MetaSounds loaded on Editor startup by moving additional MetaSound loads/registration to occur when MetaSoundEditor is loaded
- Add UX to communicate on first asset editor load that MetaSounds are still loading and class picker results may be incomplete
#rb phil.popp
#jira UE-134364
#rnx
#preflight 6202b588bf28c072cbf2faeb

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18911432 in //UE5/Release-5.0/... via CL 18919339 via CL 18920527
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18920775 by rob gay in ue5-main branch]
2022-02-09 12:52:44 -05:00