Commit Graph

160 Commits

Author SHA1 Message Date
rob gay
9ed959dac8 Downgrade seek ensure to log
- Add more logging around failures in ADPCM decode
- Remove superfluous logs
#rb jimmy.smith
#rnx
#jira UE-145250
#preflight 6230cac1cf609c54b1e5ae8e
#p4v-cherrypick 19390151

[CL 19394411 by rob gay in ue5-main branch]
2022-03-15 16:40:51 -04:00
rob gay
1f287a42ac Parameter Update Perf Regression Fix-ups
- Use cached transmissable inputs when initializing/sanitizing parameters
- Update internal API to promote batching & keeping AudioParameters sorted/using faster merge logic where possible
- Swap CitySample vehicle controller to use batched parameter update call
- Clarify When RuntimeData is cached for safety (in InitResources or InitParameters, whichever comes first)
- Alleviate extreme confusion around AudioParameter setters requiring type by adding static conversion functions
#rb helen.yang
#rnx
#jira UE-145211
#preflight 6229424e6e026fc824b24861

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19328764 in //UE5/Release-5.0/... via CL 19329587
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19348372 by rob gay in ue5-main branch]
2022-03-10 22:07:08 -05:00
rob gay
350e70d3e3 AssetClassID generation fix-up (collab fixes w/Helen)
0 Guid MetaSound AssetRegistry entry fix-up
#rb helen.yang
#rb rob.gay
#rnx
#jira UE-144864
#preflight 6226ab981938e4deaa7f4276

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19307367 in //UE5/Release-5.0/... via CL 19308413
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19347405 by rob gay in ue5-main branch]
2022-03-10 21:19:13 -05:00
phil popp
baf70eb1c0 Fix for ensure on corrupt MetaSound asset in Lyra
#rnx
#jira UE-144618
#rb Rob.Gay
#lockdown Nick.Whiting
#preflight 622167b9aa27915dd675a04a

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 19259554 in //UE5/Release-5.0/... via CL 19260273
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19264034 by phil popp in ue5-main branch]
2022-03-04 04:25:00 -05:00
helen yang
1f363574ed Add logging for failures when matching MetaSound parameters, prevent ensure on enum-string mismatch
#jira UE-144150
#jira UE-144708

#rb jimmy.smith
#preflight 622140c4a00412627d14862e
#rnx

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 19257812 in //UE5/Release-5.0/... via CL 19258561
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263816 by helen yang in ue5-main branch]
2022-03-04 04:08:58 -05:00
helen yang
5a2d9e55da Use loc text for MetaSound node vertex names (Part 1)
- New macro for defining node parameters to generate localized metadata struct
- Simple find and replace to use new macro

#jira UE-143472
#rb rob.gay
#preflight 621ed5c231454c90cce4b154

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 19225883 in //UE5/Release-5.0/... via CL 19228005
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19231251 by helen yang in ue5-main branch]
2022-03-02 17:22:27 -05:00
helen yang
b351362644 Fix missing MetaSound interface warning and interfaces not updating referencing graphs properly
#jira UE-144323
#jira UE-144366

#rb phil.popp, rob.gay
#preflight 621faa4b31454c90cc013cff
#rnx


#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 19223899 via CL 19226239 via CL 19226369 via CL 19226572 via CL 19226733
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19230244 by helen yang in ue5-main branch]
2022-03-02 16:52:01 -05:00
rob gay
d6e86d6f1d Fix for ObjectArrayParams not being parsed properly by MetaSound plugin
#rb phil.popp
#jira UE-144095
#rnx
#preflight 621d76c79a5676d19a522a12

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19205910 in //UE5/Release-5.0/... via CL 19210113
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19215627 by rob gay in ue5-main branch]
2022-03-01 21:34:04 -05:00
phil popp
cbdaf267bb Log warning when node connection is dropped during auto-update due to removed vertex.
#rnx
#jira UE-120726
#rb Rob.Gay
#lockdown Nick.Whiting
#preflight 621e6805257fd6e0992bb2ed

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 19204066 in //UE5/Release-5.0/... via CL 19209221
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19215316 by phil popp in ue5-main branch]
2022-03-01 21:25:04 -05:00
rob gay
41a2a172dc Fix missing ability to order graph members
- Remove base template for node customizations now that it isn't required to be a template to enable intra-engine versioning (allows moving implementation of category customization to .cpp)
- Move redundant "Literal" property to parent UMetasoundEditorGraphMember
#rb helen.yang
#jira UE-121749
#rnx
#preflight 621d2e869a5676d19a3d50e9

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19181623 in //UE5/Release-5.0/... via CL 19183646
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19206681 by rob gay in ue5-main branch]
2022-03-01 16:31:55 -05:00
maxwell hayes
beb9bc478c Fix for one-shot metasound sources still presenting as looping. (moving init of Duration/bIsLooping to PostLoad() override).
#jira UE-143752
#rb Aaron.McLeran
#preflight 621821e78849a7424f697af1

#ROBOMERGE-AUTHOR: maxwell.hayes
#ROBOMERGE-SOURCE: CL 19138618 in //UE5/Release-5.0/... via CL 19138733
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19155704 by maxwell hayes in ue5-main branch]
2022-02-25 15:48:47 -05:00
jimmy smith
929ebcd8d7 Fix spamming of Triggers by adding new Track type
#jira UE-138615
#rb rob.gay Ludovic.Chabant
#preflight 6216753437178b0175b2317f


#ROBOMERGE-AUTHOR: jimmy.smith
#ROBOMERGE-SOURCE: CL 19095469 via CL 19096552 via CL 19097708 via CL 19098551 via CL 19105431
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147043 by jimmy smith in ue5-main branch]
2022-02-25 09:59:46 -05:00
aaron mcleran
e79529af7a Fixing one-shot interface issues
#rb Rob.Gay
#jira UE-139680
#preflight 620d3d228a1ea1600981931f


#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 19093707 via CL 19095893 via CL 19096208 via CL 19097039 via CL 19105391
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19146717 by aaron mcleran in ue5-main branch]
2022-02-25 09:45:49 -05:00
rob gay
69fb1d5b9c Fix for regression with undo/redo when adding/removing MetaSound Graph Members causing the interface list or details panel to go stale
#rb helen.yang
#rnx
#jira UE-142724
#preflight 620c2d84483ff0ae5ecbd5ac

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19082285 in //UE5/Release-5.0/... via CL 19097068
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19140752 by rob gay in ue5-main branch]
2022-02-24 23:28:20 -05:00
jimmy smith
6e1ba512ee Fix for log spam on Sequencer audio track when using procedural SoundWaves.
#jira UE-136107
#rb rob.gay phil.popp aaron.mcleran
#preflight 620ae1796e5d06a542b421d3

#ROBOMERGE-AUTHOR: jimmy.smith
#ROBOMERGE-SOURCE: CL 18989958 in //UE5/Release-5.0/... via CL 18992584 via CL 18992956
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18997211 by jimmy smith in ue5-main branch]
2022-02-15 11:30:22 -05:00
rob gay
f4d6d39ff5 Fix for Undoing/Redoing change to a MetaSound not propagating to other referencing MetaSounds.
#rb phil.popp
#rnx
#jira UE-137481
#preflight 6205f4cc69224cb0d8912fd7

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18983245 in //UE5/Release-5.0/... via CL 18983457 via CL 18983733
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18983749 by rob gay in ue5-main branch]
2022-02-14 14:25:01 -05:00
helen yang
bb284960b2 Compile out FText from MetaSound Nodes in non editor builds
#rb rob.gay
#preflight 62057365a155a4cddac5bf1d
#jira UE-142194

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18945030 in //UE5/Release-5.0/... via CL 18945230 via CL 18946167
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18946312 by helen yang in ue5-main branch]
2022-02-10 18:36:47 -05:00
rob gay
45e4645008 Compile out editor-only data from MetaSoundFrontend
- Move Author field to FString to avoid generated text collisions (Authors should always be culture invariant anyway) & add option to override default in MetaSound user settings
#rb helen.yang
#jira UE-142159
#preflight 62055c89057375a802938669

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18941073 in //UE5/Release-5.0/... via CL 18941268 via CL 18941634
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18941665 by rob gay in ue5-main branch]
2022-02-10 15:07:39 -05:00
phil popp
e11afa41f0 Fix for metasound waveplayer pop on PCM audio
#jira UE-141570
#rb helen.yang
#preflight 62044d022f56bd0ebfa2184c

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18928111 in //UE5/Release-5.0/... via CL 18931097 via CL 18931389
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18932016 by phil popp in ue5-main branch]
2022-02-10 00:30:57 -05:00
rob gay
6d4096c2af - Reduce MetaSounds loaded on Editor startup by moving additional MetaSound loads/registration to occur when MetaSoundEditor is loaded
- Add UX to communicate on first asset editor load that MetaSounds are still loading and class picker results may be incomplete
#rb phil.popp
#jira UE-134364
#rnx
#preflight 6202b588bf28c072cbf2faeb

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18911432 in //UE5/Release-5.0/... via CL 18919339 via CL 18920527
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18920775 by rob gay in ue5-main branch]
2022-02-09 12:52:44 -05:00
phil popp
d7bcb9e7a4 Fix for altered volume when using a mono wave file in a metasound wave player node.
#jira UE-141262
#rb Max.Hayes
#preflight 6201c188e85c7a08bbcbefa5

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18906409 in //UE5/Release-5.0/... via CL 18906649 via CL 18907001
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v915-18905420)

[CL 18907023 by phil popp in ue5-main branch]
2022-02-08 14:13:09 -05:00
phil popp
7742829e5d Fix AudioModulations Metasound Node audio device in PIE
#jira UE-138516
#preflight 61fdbae4cc13ffbd10f6bbe5
#lockdown nick.whiting
#rb rob.gay

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18894988 in //UE5/Release-5.0/... via CL 18895269 via CL 18895513
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18895534 by phil popp in ue5-main branch]
2022-02-07 18:00:45 -05:00
aaron mcleran
8db0b74958 Cleaning up codec definitions on soundwaves.
- Adding new enumeration to select PCM, ADPCM, Bink, and "platform specific"
- Updated platform codecs and various APIs to select correctly which codec to use
- Changed "is seekable streaming" semantics to "Is Seekable" since that is more correct in a post-stream-caching world
- Tried to clean up platform backends. Unable to move Bink decoder to multiplatform code because of module dependencies, will require a future refactor of our decoder module setup.

#rb Phil.Popp, Jimmy.Smith
#jira UE-140860
#preflight 61f97ad7f02e20f45add6d45

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18813332 in //UE5/Release-5.0/... via CL 18813341 via CL 18822758
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824290 by aaron mcleran in ue5-main branch]
2022-02-02 07:35:13 -05:00
rob gay
6887608d07 - Version MetaSound asset graph name FText being generated from file name & copied to MetaSound asset.
- Add missing user-defined fields to MetaSound graph options (ex. IsDeprecated, Keywords, etc.) and force update on transient style changeID (TODO: Probably would make more sense for Metadata FText to live on style struct and share that transient ChangeID, so that non-runtime changes to FText metadata wouldn't bump the change ID)
[CODEREVIEW] helen.yang
#jira UE-137696
#rnx
#preflight 61f870c0a6632a34f35e5e3c

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18805501 in //UE5/Release-5.0/... via CL 18807964 via CL 18821755
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822116 by rob gay in ue5-main branch]
2022-02-02 02:19:16 -05:00
rob gay
90a3fc277e Move asset loading logs to verbose to avoid spamming editor on load
#rb trivial
#jira none
#rnx
[FYI] sondra.moyls
#preflight skip

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18793996 in //UE5/Release-5.0/... via CL 18794666 via CL 18795168
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18795943 by rob gay in ue5-main branch]
2022-01-31 15:27:41 -05:00