Commit Graph

206 Commits

Author SHA1 Message Date
rob gay
350e70d3e3 AssetClassID generation fix-up (collab fixes w/Helen)
0 Guid MetaSound AssetRegistry entry fix-up
#rb helen.yang
#rb rob.gay
#rnx
#jira UE-144864
#preflight 6226ab981938e4deaa7f4276

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19307367 in //UE5/Release-5.0/... via CL 19308413
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19347405 by rob gay in ue5-main branch]
2022-03-10 21:19:13 -05:00
rob gay
2cd9dfde95 Fix MetaSound assets always redirtying after save
- Unaccounted for integer conversion causing the dirty flag to always get set on synchronization even when data hadn't changed
#rb helen.yang
#rnx
#jira UE-144881
#preflight 622259a6335298c3146393ab

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19274524 in //UE5/Release-5.0/... via CL 19274690
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19276439 by rob gay in ue5-main branch]
2022-03-04 17:11:23 -05:00
rob gay
9b977d30c6 - Fix upcast copy causing parameters to not be cached properly on proxy by removing unnecessary virtual function
- Fix return value improperly assigning value in MixModulatorNode, causing it always to be 0 or 1 based on if the modulator was registered (as return is if the value was found and assigned, and its a boolean cast when the modulator is found)
- Remove unused parameter proxy ModHandle member
- Don't re-register if parameter already registered
- Remove duplicate validation call
#rb helen.yang
#rnx
#jira UE-144721
#preflight 6221645ca00412627d1bfde2

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19259386 in //UE5/Release-5.0/... via CL 19260159
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263839 by rob gay in ue5-main branch]
2022-03-04 04:11:49 -05:00
rob gay
db2f61d3ec Hide default value if MetaSound member is hooked up.
- Clean-up some MetaSoundMember edgraphnode members
- Minor fix for hover when drag/dropping members not onto graph showing no error state
#rb helen.yang
#rnx
#jira UE-144433
#jira UE-144358
#preflight 62203018f134125ae0bc7078

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19253632 in //UE5/Release-5.0/... via CL 19257927
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263531 by rob gay in ue5-main branch]
2022-03-04 03:48:32 -05:00
rob gay
e8fb5fcd0b - Fix sort order not propagating to presets
- Fix for interfaces not updating/some manipulators being incorrectly editable on MetaSound Presets
- Clarify Set vs Synchronize location on MSEdGraphNodes
- Split up RefreshDetails to RefreshDetails/Interfaces & move RefreshInterface to RefreshGraphMemberMenu
#rb helen.yang
#rnx
#jira UE-144184, UE-144358
#preflight 621ff6b9901d830f366e5369

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19235508 in //UE5/Release-5.0/... via CL 19236719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19237376 by rob gay in ue5-main branch]
2022-03-02 22:11:18 -05:00
helen yang
b351362644 Fix missing MetaSound interface warning and interfaces not updating referencing graphs properly
#jira UE-144323
#jira UE-144366

#rb phil.popp, rob.gay
#preflight 621faa4b31454c90cc013cff
#rnx


#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 19223899 via CL 19226239 via CL 19226369 via CL 19226572 via CL 19226733
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19230244 by helen yang in ue5-main branch]
2022-03-02 16:52:01 -05:00
rob gay
655ba20880 Fix missing drag/drop on MetaSound node object picker
#rb helen.yang
#rnx
#jira UE-144313
#preflight 621eb391147b1b1965dd6be6


#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19223181 via CL 19223357 via CL 19223368 via CL 19223379 via CL 19225930
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19229652 by rob gay in ue5-main branch]
2022-03-02 16:26:17 -05:00
phil popp
cbdaf267bb Log warning when node connection is dropped during auto-update due to removed vertex.
#rnx
#jira UE-120726
#rb Rob.Gay
#lockdown Nick.Whiting
#preflight 621e6805257fd6e0992bb2ed

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 19204066 in //UE5/Release-5.0/... via CL 19209221
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19215316 by phil popp in ue5-main branch]
2022-03-01 21:25:04 -05:00
rob gay
4d3fdda44a - Fix corrupted transaction stack when deleting a MetaSound member & then calling undo
- Guard against accessing null member entries when synchronizing MetaSound edgraph
#rb Helen.Yang
#rnx
#jira UE-143938
#jira UE-143624
#preflight 621d5480d815cc2f95fe1e9f

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19189535 in //UE5/Release-5.0/... via CL 19190324
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19208544 by rob gay in ue5-main branch]
2022-03-01 17:37:06 -05:00
rob gay
41a2a172dc Fix missing ability to order graph members
- Remove base template for node customizations now that it isn't required to be a template to enable intra-engine versioning (allows moving implementation of category customization to .cpp)
- Move redundant "Literal" property to parent UMetasoundEditorGraphMember
#rb helen.yang
#jira UE-121749
#rnx
#preflight 621d2e869a5676d19a3d50e9

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19181623 in //UE5/Release-5.0/... via CL 19183646
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19206681 by rob gay in ue5-main branch]
2022-03-01 16:31:55 -05:00
rob gay
cc1b673ce9 Fix for slate "Construct" virtual being called in drag-drop constructor
#rb Helen.Yang
#jira UE-144017
#rnx
#preflight 621d21339a5676d19a3c3953

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19180176 in //UE5/Release-5.0/... via CL 19182452
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19204449 by rob gay in ue5-main branch]
2022-03-01 15:07:46 -05:00
yali he
39046d7643 Fix some loc duplicate keys batch 3 (hopefully the last batch)
#jira UELOC-143620
#rb Mitchell.Wilson
#preflight

#ROBOMERGE-AUTHOR: yali.he
#ROBOMERGE-SOURCE: CL 19179273 in //UE5/Release-5.0/... via CL 19180516
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19204171 by yali he in ue5-main branch]
2022-03-01 14:57:03 -05:00
rob gay
8317adc66d Fix MetaSound Variable display naming namespace syntax to follow that of other members (inputs & outputs)
#rb helen.yang
#jira UE-143753
#rnx
#preflight 621d1680037be0078cab4702

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19178122 in //UE5/Release-5.0/... via CL 19180179
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19203739 by rob gay in ue5-main branch]
2022-03-01 14:37:01 -05:00
helen yang
9b0ed29b45 MetaSound interfaces menu changes
- Add right click menu and actions for graph members
- Move add/remove interfaces menu to a new details tab

#jira UE-143470
#jira UE-143471

#rb rob.gay
#preflight 6218507a8849a7424f6d4ff9

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 19177650 in //UE5/Release-5.0/... via CL 19180025
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19203596 by helen yang in ue5-main branch]
2022-03-01 14:29:17 -05:00
phil popp
9d0387d032 Fix for circular include in metasound editor
#rnx
#rb helen.yang
#jira UE-143700
#preflight 62181dd47520d8f6ab9ff691

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 19135097 in //UE5/Release-5.0/... via CL 19135453
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19155593 by phil popp in ue5-main branch]
2022-02-25 15:45:57 -05:00
aaron mcleran
e79529af7a Fixing one-shot interface issues
#rb Rob.Gay
#jira UE-139680
#preflight 620d3d228a1ea1600981931f


#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 19093707 via CL 19095893 via CL 19096208 via CL 19097039 via CL 19105391
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19146717 by aaron mcleran in ue5-main branch]
2022-02-25 09:45:49 -05:00
rob gay
fd33c39c6e - Drag/Drop/Double-Click Add/JumpTo Member Support
- Fix another spot for when member is removed from the editor views on next tick, don't show garbage member in details panel
- Variable node body fix-ups
#rb helen.yang
#rnx
#jira UE-143288
#preflight 62102b6a406b34de07e846ae

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19082391 in //UE5/Release-5.0/... via CL 19097086
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19140792 by rob gay in ue5-main branch]
2022-02-24 23:29:50 -05:00
rob gay
69fb1d5b9c Fix for regression with undo/redo when adding/removing MetaSound Graph Members causing the interface list or details panel to go stale
#rb helen.yang
#rnx
#jira UE-142724
#preflight 620c2d84483ff0ae5ecbd5ac

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19082285 in //UE5/Release-5.0/... via CL 19097068
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19140752 by rob gay in ue5-main branch]
2022-02-24 23:28:20 -05:00
rob gay
0490a40d91 Fix for deleting a pasted variable node deleting all instances of that node on the graph
- Also fixes pasting a variable member from another graph or pasting a variable accessor/delayed accessor from ensuring if no other accessor exists
#rb helen.yang
#rnx
#jira UE-142410
#preflight 620adc00803d9066e6902811
#lockdown nick.whiting

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19058501 in //UE5/Release-5.0/... via CL 19074246
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19076464 by rob gay in ue5-main branch]
2022-02-22 13:47:20 -05:00
rob gay
5ba27517d3 Add missing 'BreakSinglePinLink' implementation for MetaSounds
#rb helen.yang
#jira UE-142560
#preflight 620ab0df4d320dbf4c2311e8
#lockdown nick.whiting

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19058418 in //UE5/Release-5.0/... via CL 19074107
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19076400 by rob gay in ue5-main branch]
2022-02-22 13:45:05 -05:00
rob gay
4ffce9e549 MetaSound Member localization options menu support for DisplayName & Tooltip
[REVIEW] helen.yang
#jira UE-142556
#preflight 620acc9d4d320dbf4c29ac0e
#lockdown nick.whiting

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19058366 in //UE5/Release-5.0/... via CL 19066031
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19067166 by rob gay in ue5-main branch]
2022-02-21 03:09:54 -05:00
rob gay
066f2f8c47 (Re)Fix for renaming a MetaSound not propagating the rename to referencing graphs
#rnx
#rb helen.yang
#jira UE-137696
#preflight 620b3a96483ff0ae5ea63369
#lockdown nich.whiting

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19058267 in //UE5/Release-5.0/... via CL 19066028
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19067158 by rob gay in ue5-main branch]
2022-02-21 03:09:25 -05:00
helen yang
0c14af3503 Various fixes for MetaSound meter functionality
- Add nullptr check when setting bus sends
- Initialize audio analyzer number of frames
- Remove analyzers when tearing down MetaSound audio meter

#jira UE-140872
#rb rob.gay
#preflight 620a9d8f4a08181f72a47f28

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18986455 in //UE5/Release-5.0/... via CL 18986877 via CL 18987819
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18988135 by helen yang in ue5-main branch]
2022-02-14 18:35:49 -05:00
rob gay
f4d6d39ff5 Fix for Undoing/Redoing change to a MetaSound not propagating to other referencing MetaSounds.
#rb phil.popp
#rnx
#jira UE-137481
#preflight 6205f4cc69224cb0d8912fd7

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18983245 in //UE5/Release-5.0/... via CL 18983457 via CL 18983733
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18983749 by rob gay in ue5-main branch]
2022-02-14 14:25:01 -05:00
phil popp
5c65d66c75 Fix crash when creating preset with incompatible literal
#jira UE-142367
#rnx
#rb rob.gay
#preflight 6206ddb3054c2e38c473d1e7

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18983235 in //UE5/Release-5.0/... via CL 18983409 via CL 18983631
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18983673 by phil popp in ue5-main branch]
2022-02-14 14:21:13 -05:00