Commit Graph

34 Commits

Author SHA1 Message Date
devin doucette
3897ae4e92 DDC: Added ICacheStoreStats to the memory cache and cleaned up graph node lifetime
#jira UE-133395
#rb Zousar.Shaker
#rnx

[CL 25870464 by devin doucette in ue5-main branch]
2023-06-08 10:07:21 -04:00
devin doucette
5229f46947 DDC: Added ICacheStoreStats and related functionality for cache stores to report stats
#jira UE-133395
#rb Zousar.Shaker
#rnx

[CL 25843613 by devin doucette in ue5-main branch]
2023-06-07 09:47:55 -04:00
devin doucette
0190309348 DDC: Removed an erroneous check from the file system cache store
#rb none
#rnx

[CL 25529485 by devin doucette in ue5-main branch]
2023-05-18 13:52:53 -04:00
devin doucette
defbfeb737 DDC: Moved file system cache store configuration into the file system cache store
#rb Zousar.Shaker
#rnx

[CL 25495944 by devin doucette in ue5-main branch]
2023-05-16 16:00:11 -04:00
zousar shaker
56c35e9b4b [Backout] - CL25480019
[FYI] Devin.Doucette
Original CL Desc
-----------------------------------------------------------------
DDC: Moved file system cache store configuration into the file system cache store

#rb Zousar.Shaker
#rnx

[CL 25482846 by zousar shaker in ue5-main branch]
2023-05-15 19:35:44 -04:00
devin doucette
5da0a6ca50 DDC: Moved file system cache store configuration into the file system cache store
#rb Zousar.Shaker
#rnx

[CL 25482693 by devin doucette in ue5-main branch]
2023-05-15 19:29:13 -04:00
zousar shaker
3d140963d1 When a deactivation latency limit is defined, make the initial speed test executed by filesystem DDC time limited so we don't spend an inordinate amount of time speed testing if we're just going to deactivate it due to high latency.
#rb devin.doucette

[CL 24831864 by zousar shaker in ue5-main branch]
2023-03-29 02:28:27 -04:00
devin doucette
72f0249b95 Replaced uses of FLazyEvent with FManualResetEvent
#rb none
#rnx

[CL 24810985 by devin doucette in ue5-main branch]
2023-03-27 18:26:53 -04:00
devin doucette
f52cece901 Reverted the conversion of FLazyEvent to FManualResetEvent while investigating an issue
#rb none
#rnx

[CL 24763649 by devin doucette in ue5-main branch]
2023-03-23 12:35:09 -04:00
devin doucette
18dfce3eca Added FManualResetEvent
This is a one-byte manual-reset event that can replace that use case for the experimental FLazyEvent.

#rb Zousar.Shaker

[CL 24756514 by devin doucette in ue5-main branch]
2023-03-22 19:47:06 -04:00
devin doucette
672818b928 StringBuilder: Converted WriteToString from a type to a function
This was not possible on C++14 and is possible now due to guaranteed copy elision in C++17.
This will break backward compatibility when WriteToString was used as a type or in a context where it would be copied.

#preflight 640a0460af3fc3529234c216
#rb Matt.Peters

[CL 24583299 by devin doucette in ue5-main branch]
2023-03-09 17:06:55 -05:00
danny couture
74782129ec Fix race in FCounters used in FileSystemCacheStore and AsyncLoading
#rnx
#rb Devin.Doucette
#preflight 63d1d57e6a14d8406d8fc7d4

[CL 23863764 by danny couture in ue5-main branch]
2023-01-25 21:07:51 -05:00
zousar shaker
d1afea0f1f Allow ReadOnly mode for a DDC FileSystemCacheStore to have maintenance performed if Clean=true or DeleteUnused=true. When ReadOnly, they are now both false by default, but usable if explicitly set to true. When not ReadOnly, DeleteUnused remains true by default.
#rb devin.doucette

[CL 23592522 by zousar shaker in ue5-main branch]
2023-01-05 16:11:30 -05:00
Devin Doucette
7962247e4e DDC: Added a DeleteOnly mode to FileSystemCacheStore
This allows a cache to be kept in the hierarchy solely to ensure that it is cleaned up as its contents expire. Maintenance has been improved to delete more empty folders and to count every scanned folder.

#preflight 6363370154471d10be395619
#rb Zousar.Shaker

[CL 22953493 by Devin Doucette in ue5-main branch]
2022-11-03 11:01:04 -04:00
zousar shaker
11736e9e50 If multiple active FileSystemCacheStores in DDC are configured to have the same path, ignore all but the first one to become active.
#rb devin.doucette

[CL 22660595 by zousar shaker in ue5-main branch]
2022-10-20 12:54:34 -04:00
devin doucette
6c0954fb0d DDC: Added to the summary when file system cache store maintenance completes
#rb Zousar.Shaker
#rnx

[CL 22105271 by devin doucette in ue5-main branch]
2022-09-20 19:32:44 -04:00
henrik karlsson
6739fe3d60 [Engine]
* Added UE_SCOPED_ENGINE_ACTIVITY in a couple places that takes noticable amount of time when starting monolith editor

#preflight skip
#rb self

[CL 22030271 by henrik karlsson in ue5-main branch]
2022-09-15 11:47:18 -04:00
Devin Doucette
9aee9a4bd8 DDC: Fixed unsafe type cast warnings
#preflight 6317fc04a20b67673b1de7c3
#rb Zousar.Shaker
#rnx

[CL 21850770 by Devin Doucette in ue5-main branch]
2022-09-07 10:37:16 -04:00
Devin Doucette
62f66e3e49 DDC: Fixed verbose logging in the file system cache
#preflight 62da257cbc175ec68cb7b9db
#rb Zousar.Shaker
#rnx
#robomerge FNMain

[CL 21220401 by Devin Doucette in ue5-main branch]
2022-07-22 10:20:41 -04:00
zousar shaker
75d0e7277b Add status icon to indicate DDC cache store status with tooltip text for details. Currently used to show when a cache store has been deactivated for performance.
#rb devin.doucette

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 21152573 via CL 21155094 via CL 21156160
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21181761 by zousar shaker in ue5-main branch]
2022-07-20 11:55:16 -04:00
zousar shaker
01a55c47a3 Add an optional "DeactivateAt" attribute for DDC filesystem cache stores to allow the store to be deactivated for the session if a speedtest is run and the speedtest indicates that the latency is higher than the configured threshold. Default state is that there is no deactivation threshold.
#rb devin.doucette

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 20994964 via CL 20994988 via CL 20995000
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21002571 by zousar shaker in ue5-main branch]
2022-07-08 02:53:40 -04:00
steve robb
fd2a0b1e20 Removal of TEXT literal concatenations, which doesn't work in UTF-8 mode.
#rb devin.doucette
#jira UE-132142
#preflight 62a8748fa76c84377748036b

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20647443 via CL 20648283 via CL 20648315
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v955-20579017)

[CL 20651786 by steve robb in ue5-main branch]
2022-06-14 12:46:34 -04:00
devin doucette
3e2538a313 DDC: Removed the legacy cache store implementations and limit cache bucket names to 63 characters
The cache bucket name was already limited to 63 characters in practice by Horde Storage. This makes it consistent across every cache store.

#preflight 629e6f0a1c7e8f9a180e192a
#rb Zousar.Shaker

#ROBOMERGE-OWNER: Devin.Doucette
#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-COMMAND: _robomerge[bot4] UE5-MAIN
#ROBOMERGE-SOURCE: CL 20536454 via CL 20536805 via CL 20536993
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20538633 by devin doucette in ue5-main branch]
2022-06-07 11:17:10 -04:00
mark lintott
da46ade47c Added Cache Speed Stats to Analytics
Added Zen Server Stats to Analytics
#rb zousar.shaker, devin.doucette
#jira none
#preflight 6295d84bd57da28cc8ee9eab

[CL 20434901 by mark lintott in ue5-main branch]
2022-05-31 05:11:05 -04:00
Devin Doucette
47e28f2fe0 DDC: Optimized the file system cache for SMB
- Reading files from the Game Thread now launches a task to check and update the modification time, which approximately halves the latency of these reads.
- Writing files now only asks to delete the temporary file upon failure, as it added unnecessary latency before by trying to delete it after it was renamed.

#preflight 6272d5b21f37fd32b0f07652
#rb Zousar.Shaker

[CL 20048278 by Devin Doucette in ue5-main branch]
2022-05-04 16:23:17 -04:00