Commit Graph

1297 Commits

Author SHA1 Message Date
karen jirak
e2ba4c5032 Revert: Updates for Modular Class Display to add a widget registration system and get it working for BaseToolkit and toolbars....
#rb none

[CL 27299600 by karen jirak in ue5-main branch]
2023-08-23 03:14:14 -04:00
karen jirak
acea30606e Feature:
* The details panel must be enhanced to show Components as cards
* This new Card style should be applicable to any details panel
* Subobject editor had to be hidden upon selection of entity

#jira UE-192032
#rb Brooke.Hubert

[CL 27297832 by karen jirak in ue5-main branch]
2023-08-23 00:49:40 -04:00
jeanfrancois dube
a5384ad9e0 Changed a TArray to a TSet for FLevelEditorOutlinerSettings::UnsavedAssets.
Editor is now responsive when generating 32K actors through PCG.

#rb richard.malo

[CL 27269795 by jeanfrancois dube in ue5-main branch]
2023-08-22 10:09:06 -04:00
stu mckenna
3010f7ca39 - Fix for accumulating realtime overrides after each PIE session
#rb logan.buchy

[CL 27127048 by stu mckenna in ue5-main branch]
2023-08-15 19:41:14 -04:00
juan portillo
ec5551d238 Added GetLevelEditor to Level Editor Menu Context to get the (public facing) ILevelEditor, as the existing SLevelEditor is unusable outside
#rb Rex.Hill

[CL 27029302 by juan portillo in ue5-main branch]
2023-08-11 11:17:52 -04:00
han chu
89e5e78e72 Fix Pivot Update Issue When Snapping Object to View
#jira UE-184113
#rb @ronald.koppers

[CL 26975327 by han chu in ue5-main branch]
2023-08-09 17:55:33 -04:00
han chu
0e226bf6a8 Problem:
"Mode Widgets" is by default disabled in game mode. The expected behavior in this case, according to feedback from content producers, should be as follows: "Mode Widgets" should be enabled by default, but the selection outline and transform widgets should be hidden. They should reappear once the user selects an actor.

Cause:
"EngineShowFlags.SetModeWidgets(false);" when entering game mode

Fix:
When entering game mode, temporarily set LevelViewportClient->bShowWidget to false while keeping the showflag "Mode Widgets" set to true. Transform widget is hidden in this manner when entering game mode, and selecting any actor will make it visible again because of the modification in SLevelViewport::OnActorSelectionChanged. The modification to SLevelViewport::ToggleGameView() makes sure that after leaving game mode, LevelViewportClient->bShowWidget is properly reset to true.

#jira UE-191508
#rb @logan.buchy

[CL 26893130 by han chu in ue5-main branch]
2023-08-07 14:23:36 -04:00
logan buchy
afc26a0f51 Prevent LevelEditorViewportClient draw on PIE in LevelEditorViewport
* This change addesses an issue which causes the LevelEditorViewportClient to render while PIE is active on the LevelEditorViewport. This results in a frame which is never displayed and therefore reduced rendering performance.
* The issue's root cuase is due to behaviour where the GameViewportClient and EditorViewportClient swap their stat flags when PIE is started on a selected LevelEditor sceneviewport - see FSceneViewport::SwapStatCommands.  When stat flags are present on the GameViewportClient before PIE is started, the EditorViewportClient will inherit the stat flags.  However, this has the side-effect of pushing a 'true' RealTime override onto ViewportClient.  This causes ViewportClient->IsRealtime() to return true.
* UEditorEngine::UpdateSingleViewportClient() is called by the UEditorEngine::Tick() each frame,  finds the EditorViewportClient->IsRealtime() to be true and triggers LevelEditorViewportClient->Viewport->Draw() even though there is no SceneViewport to display the render.
* The fix pushes a realtime override to disable realtime mode for the LevelEditorViewportClient when a PIE session is started that takes over the LevelEditorViewport and subsequently removes the override when PIE ends.

#jira UE-168061
#rb ronald.koppers

[CL 26621251 by logan buchy in ue5-main branch]
2023-07-26 16:56:32 -04:00
sebastien hillaire
b6879a2b60 Rename from LocalHeightFog to LocalFogVolume in code
#rb none
#jira UE-187077

[CL 26545239 by sebastien hillaire in ue5-main branch]
2023-07-24 12:00:44 -04:00
sebastien hillaire
90e9834931 Rename/move file(s) from LocalHeightFog to LocalFogVolume
#rb none
#jira UE-187077

[CL 26543667 by sebastien hillaire in ue5-main branch]
2023-07-24 11:29:58 -04:00
han chu
a7927fb7d8 Make show flags persistent under "Game View".
Assumptions:
1. Selections are cleared and "Mode Widget" is disabled after switching into "Game View", based on the existing function "void FEditorViewportClient::SetGameView(bool bGameViewEnable)" in "EditorViewportClient.cpp".
2. "bAlwaysShowModeWidgetAfterSelectionChanges" being "true" under "Game View" is not the intended behavior, as "void SLevelViewport::OnActorSelectionChanged(const TArray<UObject*>& NewSelection, bool bForceRefresh)" would bring "Mode Widget" back.

#jira UE-183635
#rb @ronald.koppers

[CL 26530624 by han chu in ue5-main branch]
2023-07-21 19:19:25 -04:00
aditya ravichandran
5a557ad1a8 Disable the bulk edit section in the Outliner if the property matrix can't be invoked
#rb rex.hill

[CL 26146909 by aditya ravichandran in ue5-main branch]
2023-06-21 09:47:05 -04:00
han chu
e2f901b594 The problem:
When the level is locked, CanSelectElement evaluates to true, causing Unreal Engine to crash in the following two scenarios:
1. After locking the level, the user clicks on an ISM
2. After locking the level, the user drags the remaining gizmo on an ISM

The cause:
1. FSMInstanceElementLevelEditorSelectionCustomization::CanSelectElement evaluates to true because GEdSelectionLock seems always be false
2. DeselectAllActors in SetLocked does not recursively deselect the ISM components

The fix:
1. Determine whether the owner level is lockedin FSMInstanceElementLevelEditorSelectionCustomization::CanSelectElement
2. Use the typed element selection APIs to clear the current level's selection

#jira UE-181821
#rb

[CL 26000790 by han chu in ue5-main branch]
2023-06-14 20:05:51 -04:00
logan buchy
87012153c4 Remove TypedElementViewportInteractionGizmoManipulation from TypedElement ViewportInteraction
* The same functionality is provided by the GizmoManipulationStarted and GizmoManipulationStopped.
* This simplifies the interface and removes the bespoke parameter added to branch between when manipulation starts and when it is ongoing to avoid expensive rendering invalidations
* There are some clients of TypedElementViewportInteractionGizmoManipulation::ApplyDeltaToActor, this CL does not address usage of this function.  Doing so will require further adoption of TypedElements among those systems

#jira UE-187188
#rb Brooke.Hubert

[CL 25964466 by logan buchy in ue5-main branch]
2023-06-13 17:28:30 -04:00
marc audy
4b121aea27 Explicitly register FGlobalEditorCommonCommands to avoid implicit initialization order issues
#horde 317282

[CL 25908436 by marc audy in ue5-main branch]
2023-06-09 19:33:43 -04:00
henrik karlsson
f027bfa856 [Core]
* Fixed compile errors when compiling .h files in isolation

#rb none

[CL 25865668 by henrik karlsson in ue5-main branch]
2023-06-08 02:30:27 -04:00
richard malo
6b9e568792 Fixed WorldOutliner force refreshing for nothing during PIE.
- Avoid broadcasting OnActorEditorContextClientChanged for game worlds
- Prevent UActorEditorContextSubsystem from broacasting ActorEditorContextSubsystemChanged when running Game/PIE.
#rb patrick.enfedaque
#preflight 647a2be0f40c6565433ebde8

[CL 25789367 by richard malo in ue5-main branch]
2023-06-05 07:08:49 -04:00
bryan sefcik
ecd9fa8a99 Removed dependencies that aren't needed by the modules that declare them. This is to help fix bad circular dependencies in the engine.
#preflight 647b5f919c5bac5c6f8be490
#jira

[CL 25782459 by bryan sefcik in ue5-main branch]
2023-06-03 15:25:01 -04:00
brooke hubert
475a3855fe Unshelved from pending changelist '25239902':
PR #10401: Level editor place actors menu to respect Class DisplayName overrides
#contrib 10401
#Jira UE-184698

#rb brooke.hubert
#preflight 6478af138417d79259fb76ce

[CL 25727113 by brooke hubert in ue5-main branch]
2023-06-01 11:01:45 -04:00
aditya ravichandran
f0f4b7fda3 Fix a crash in the bulk edit components submenu on Mac
#jira UE-187340
#rb trivial

[CL 25726527 by aditya ravichandran in ue5-main branch]
2023-06-01 10:36:41 -04:00
patrick enfedaque
b6a5a155c8 ActorMenu: Avoid loading non UClass assets
#rb jeanfrancois.dube
#prefight 647749180848b7126dbc1156
#rnx

[CL 25725216 by patrick enfedaque in ue5-main branch]
2023-06-01 09:54:16 -04:00
ben hoffman
90ed12e1e5 This is two changelists, re-submitting of 25473883 (which was backed out with 25495316) and also a cherry pick of 25507685 to fix an ensure the original CL caused.
#preflight 647773ab0d55081f5494ab67
#jira none

--------------------------------------------------
Add ability to add a widget inside the global window overlay

#rb Patrick.Boutot

#ushell-cherrypick of 25473883 by kristof.morva1

----------------------------------------------
Fix ensure when hiding mouse capture label after exiting PIE

#rb Vincent.Gauthier

#ushell-cherrypick of 25507685 by kristof.morva1

[CL 25709904 by ben hoffman in ue5-main branch]
2023-05-31 14:56:43 -04:00
Patrick Enfedaque
baddbd59d0 [Backout] - CL25689444
#fyi han.chu
Original CL Desc
-----------------------------------------------------------------
Fix crash when interacting with a script actor containing an ISM when the level is locked

#jira UE-181821
#rb Zach.Rammell
#preflight 647666294a277ca8f023dcc4

[CL 25699655 by Patrick Enfedaque in ue5-main branch]
2023-05-31 07:47:01 -04:00
han chu
1728c4847c Fix crash when interacting with a script actor containing an ISM when the level is locked
#jira UE-181821
#rb Zach.Rammell
#preflight 647666294a277ca8f023dcc4

[CL 25689444 by han chu in ue5-main branch]
2023-05-30 17:19:03 -04:00
patrick enfedaque
924ce2e2c5 ActorEditorContext:
- Allow switching Current level from context in WP World
- Unify display of Current Level when editing Level Instance (WP and non-WP)
- Level Instance Mode will lock/unlock selection and render postprocess based on current level being the Level Instance level or not.

#rb richard.malo, jeanfrancois.dube
#preflight 647501192e05bcc330bd4059
#rnx

[CL 25674513 by patrick enfedaque in ue5-main branch]
2023-05-30 06:44:15 -04:00