Commit Graph

4394 Commits

Author SHA1 Message Date
nick darnell
f602862479 Core - Reverting the base type of FObjectProperty's FObjectPropertyBase to UObject* instead of TObjectPtr<UObject>, there's some range garbage collection issue this causes where things arent cleaned up in the expected fashion. This may be limited to script, but unsure. Working on it. Reverting for now to fix the EngineTest tests.
#jira UE-164443
[REVIEW] [at]Zousar.Shaker, [at]Joe.Pribele

[CL 22097502 by nick darnell in ue5-main branch]
2022-09-20 13:50:06 -04:00
per larsson
4549f92468 Bulk Data - crash fix for bulk data with wrong flags getting uploaded to DDC
#rb Paul.Chipchase
#preflight none
#rnx

[CL 22088631 by per larsson in ue5-main branch]
2022-09-20 00:48:35 -04:00
robert millar
9d74d688f9 Deprecate FNames containing full object paths.
#jira UE-161932
#rb none
#preflight https://horde.devtools.epicgames.com/job/6328da74331ace46b5c0c0f5?step=a789

[CL 22088586 by robert millar in ue5-main branch]
2022-09-20 00:46:13 -04:00
dave jones2
50533cba09 UE-145634 - Delegate fixup doesn't work when bound functions are not in the current BP
Another consequence of using doubles everywhere in Blueprints is that delegate binding can fail if a native delegate signature uses floats. The initial attempt at fixing this would update modify function pins in the current Blueprint to use PC_Float as a subcategory if it was used in a delegate binding. Unfortunately, this doesn't work if we're binding to a function in a different BP class. Attempting to fix up those functions would dirty several Blueprints, and likely confuse users.

The approach that we take here creates a proxy delegate function that matches the underlying signature. The proxy's function graph will then call the original bound function, which implicitly handles any double/float conversions. Additionally, we'll perform a "capture" of any actors that we need to call the bound function on. The compiler will add a new hidden property for the actor class, which we set in the original graph that had the bound delegate. The proxy function graph will then read this property when it calls the original function.

#jira UE-145634
#preflight 63191b1cb069eea9ab594ea2
#rb phillip.kavan

[CL 22087332 by dave jones2 in ue5-main branch]
2022-09-19 22:27:18 -04:00
carlmagnus nordin
9355c00328 EditorPackageLoader: Fixed issue with exports from already loaded uncooked packages not being registered in the import store
#rb pj.kack
#preflight 63284780ae4e65ae63c4da96

[CL 22084676 by carlmagnus nordin in ue5-main branch]
2022-09-19 19:49:50 -04:00
Matt Peters
97d33caf50 MeshDescription: In addition to applying the package's CustomVersions when deserializing MeshDescription out of BulkData, also apply the UEVersion and LicenseeUEVersion.
#jira UE-160855
#rb Richard.TalbotWatkin
#rnx
#preflight 63289253ea1c94f4c5e2fd67

[CL 22076022 by Matt Peters in ue5-main branch]
2022-09-19 13:01:00 -04:00
Mattias Hornlund
15ec8ac39e Iris
- Fixed issue where custom property overrides was not properly initialzied for iris if set before beginplay/beginreplication
- Cleaned up delegates propagating custom property overrides to iris-replicationsystem
- Marked interface methods in IRepChangedPropertyTracker to be deprecated in the future and added routing of SetCustomActive override via FNetPropertyConditionManager::SetPropertyActiveOverride to allow for future removal of the interface

#jira https://jira.it.epicgames.com/browse/UE-158358
#rb Peter.Engstrom
#preflight 63285ec98131e92d65975851

[CL 22072998 by Mattias Hornlund in ue5-main branch]
2022-09-19 08:51:23 -04:00
nick darnell
2920da6a0b Edits changed where the variable was accessible, adjusting that.
[CL 22064674 by nick darnell in ue5-main branch]
2022-09-16 21:00:59 -04:00
nick darnell
4f276666f9 Making GetPath public for TObjectPtr to satisfy existing uses.
[CL 22064659 by nick darnell in ue5-main branch]
2022-09-16 21:00:29 -04:00
nick darnell
6c7d81f099 Core - Updating low level ObjectPtr tests, the number of resolves from updating a SoftObjectPath from an ObjectPtr should be 0.
[CL 22064071 by nick darnell in ue5-main branch]
2022-09-16 20:29:04 -04:00
bryan sefcik
e5edfdd06d Added support to inline the gen.cpp files into the module cpp files.
This change does a few things:
* Improves compile times because the gen.cpp is inlined so less header parsing is required.
* Allows us to forward declare more types in the headers where we were not able to because the gen.cpp files did not have all the required headers included. The gen.cpp files required the header that generated it to include all the types because of the constructor and desructor in the gen.cpp need to know the full type.

#jira
#preflight 6323b43f8131e92d65aed1d9

[CL 22064061 by bryan sefcik in ue5-main branch]
2022-09-16 20:28:51 -04:00
nick darnell
4dc398d682 Fixing a COREUOBJECT_API being in the wrong spot on a struct for linux.
[CL 22064047 by nick darnell in ue5-main branch]
2022-09-16 20:28:05 -04:00
nick darnell
2a866db4f0 Core - Some more build fixes!
[CL 22064041 by nick darnell in ue5-main branch]
2022-09-16 20:27:52 -04:00
nick darnell
e4d61cb40a Removing some unused stuff from ObjectRefTrackingTestBase for builds with LOW_LEVEL_TESTS in them.
[CL 22064011 by nick darnell in ue5-main branch]
2022-09-16 20:27:03 -04:00
nick darnell
42c12e3776 Core - Adding support for getting the PathName from a ObjectPtr without resolving the Object*.
Core - Refactoring the Object Handle event callbacks so that we can hook and unhook them with delegates/delegatehandles.
Core - Adding support for detecting loads via object handles as a new event distinct from resolution callback.
Core - Expanding the utility functions on FObjectRef so that we can resolve it in a myraid of fashions to get the path, the class path, the full path and the export path.

[REVIEW] [at]Zousar.Shaker, [at]Joe.Pribele

[CL 22063982 by nick darnell in ue5-main branch]
2022-09-16 20:26:12 -04:00
nick darnell
4b6c70b5a6 Core - Changes the base CPPTYPE of FObjectProperty from UObject* to TObjectPtr<UObject>, this ensures that no matter how people access the value be it as a FObjectProperty or not, calling GetPropertyValue won't return a UObject* directly - which effectively would reinterpret cast a TObjectPtr, if it is one, and then if lazy loading is enabled would potentially result in a crash from trying to treat a non-pointer as a TObjectPtr.
Class - When iterating the classes sparse values, don't accidentally load deferred objects, or crash because you're reinterpret casting the value of something that isn't a pointer.

[REVIEW] [at]Zousar.Shaker, [at]Joe.Pribele

[CL 22063963 by nick darnell in ue5-main branch]
2022-09-16 20:25:31 -04:00
carlmagnus nordin
98fd341d01 ZenLoader: Let the async loading thread progress on other packages if there's no more work to do for the current sync load
#preflight 63245c4bae4e65ae63e96d20
#rb pj.kack

[CL 22059800 by carlmagnus nordin in ue5-main branch]
2022-09-16 16:34:29 -04:00
carlmagnus nordin
25d64f3d04 ZenLoader in editor:
* Fixed issue with LOAD_PackageForPIE getting lost when calling LoadPackageAsync from LoadPackageInternal
* Fixed issue with externally created packages not being tracked in the import store and unintentionally being loaded multiple times
* Fixed issue with instancing contexts not being propagated to imported packages

#preflight 63232218e872d7da0397f29e
#rb pj.kack
#jira UE-162812

[CL 22050271 by carlmagnus nordin in ue5-main branch]
2022-09-16 11:32:12 -04:00
danny couture
8d1dbe1877 Small cleanup of dead code in blueprint support
#rb Dan.OConnor
#preflight 6323b50774361465142e3e35

[CL 22043390 by danny couture in ue5-main branch]
2022-09-15 20:36:36 -04:00
phillip kavan
33f35205b9 Defer import class verification to creation time when appropriate so that we don't emit load linker warnings for false positives.
#jira UE-163652
#rb Francis.Hurteau
#preflight 63224e239677b738f4118145

[CL 22041617 by phillip kavan in ue5-main branch]
2022-09-15 19:37:04 -04:00
Thomas Engel
f389bb820a Adding HDR playback capabilities to MediaFrameWork & Electra (PC, GDK, PS4, PS5)
#jira UE-163865
#fyi jens.petersam
#preflight 632357cdc225e8be3809214e

[CL 22034307 by Thomas Engel in ue5-main branch]
2022-09-15 14:30:21 -04:00
henrik karlsson
6739fe3d60 [Engine]
* Added UE_SCOPED_ENGINE_ACTIVITY in a couple places that takes noticable amount of time when starting monolith editor

#preflight skip
#rb self

[CL 22030271 by henrik karlsson in ue5-main branch]
2022-09-15 11:47:18 -04:00
jamie dale
70736a012c Allow existing FName properties to be replaced by FSoftObjectPath/Ptr without losing serialized data
#jira
#preflight 6320b7ea29254beccb77a340
#rb Robert.Millar

[CL 22020500 by jamie dale in ue5-main branch]
2022-09-14 19:59:27 -04:00
jamie dale
5f086b8c04 Allow existing FString/FName properties to be replaced by FTopLevelAssetPath without losing serialized data
#jira
#preflight 6320b7ea29254beccb77a340
#rb Robert.Millar

[CL 22020480 by jamie dale in ue5-main branch]
2022-09-14 19:57:38 -04:00
robert millar
71d214e239 Fix static analysis errors in unit test.
#rb none
#jira none
#preflight 6321fe82b602881e8e2ac864

[CL 22013206 by robert millar in ue5-main branch]
2022-09-14 15:04:46 -04:00