Commit Graph

120 Commits

Author SHA1 Message Date
Dan Oconnor
76e1440d85 Further changes from PVS-Studio, submitted without modification, reviewed with owners where I was unsure of the change
[CL 2500334 by Dan Oconnor in Main branch]
2015-04-02 16:31:18 -04:00
Maciej Mroz
3ed5ae4cf6 UE-12214 Calling a function that returns TWeakObjectPtr in blueprints causes crash
Only a simple pointer to UObjects can be a parameter of BlueprintCallable (or BlueprintImplementableEvent.. etc) function. No WeakObjPtr or AssetSubclassOf is accepted. Strict check in UHT.

#codereview Steve.Robb, Richard.Hinckley

[CL 2499396 by Maciej Mroz in Main branch]
2015-04-01 20:59:46 -04:00
Steve Robb
983796dc35 ValidateMetaDataFormat overloads and AddMetaDataToClassData moved out of FHeaderParser.
#codereview robert.manuszewski

[CL 2497048 by Steve Robb in Main branch]
2015-03-31 07:20:11 -04:00
Steve Robb
0ad5c735f2 Property creation moved to its own function.
DoesAnythingInHierarchyHaveDefaultToInstanced moved out of FHeaderParser.

#codereview robert.manuszewski

[CL 2497043 by Steve Robb in Main branch]
2015-03-31 07:03:34 -04:00
Steve Robb
36a973206c UHT can skip inline function declarations.
#codereview robert.manuszewski

[CL 2495922 by Steve Robb in Main branch]
2015-03-30 14:13:41 -04:00
Michael Noland
6ef30e720a Optimized UnrealHeaderTool
- Optimized Tabify and Macroize
- Replaced various %s Spc(constant) calls with direct string literals
- Replaced injected indentation spaces with tabs (avoiding some of the work in Tabify; they were ultimately being replaced anyways)
- Replaced various %s of LINE_TERMINATOR with compile-time string literal concatenation
- Avoided case-insensitive work in various places
- Replaced direct references to FStringOutputDevice with a typedef to facilitate future optimizations
- Used Reset() instead of Empty() on various string builders and strings to reduce reallocations
[INTEGRATE] Change 2494450 by Michael.Noland@mnoland-T2784-HDepot on 2015/03/27 16:48:25

[CL 2494606 by Michael Noland in Main branch]
2015-03-27 18:10:52 -04:00
Michael Noland
9e64d67053 UnrealHeaderTool: Added time logging for various phases and clarified code/comments surrounding the phases
[INTEGRATE] Change 2493166 by Michael.Noland@mnoland-T2784-HDepot on 2015/03/26 23:49:36

[CL 2494507 by Michael Noland in Main branch]
2015-03-27 17:16:51 -04:00
Dan Oconnor
195086b1a5 Changes from PVS-Studio, these could introduce small behavior change.
Consistent null checks, fixes for copy/pasted conditions, copy pasted LOCTEXT identifiers, comparisons against literals of the wrong type, missing return statements, dead code, and some system calls that were ignoring their return value

[CL 2494390 by Dan Oconnor in Main branch]
2015-03-27 16:11:50 -04:00
Maciej Mroz
1a22ee9081 UHT error when an property/parameter exposed to BP is not supported by blueprint.
#codereview Robert.Manuszewski, Steve.Robb

[CL 2494269 by Maciej Mroz in Main branch]
2015-03-27 15:02:56 -04:00
Steve Robb
90ea7283f0 Nested switch broken up.
#codereview robert.manuszewski

[CL 2486563 by Steve Robb in Main branch]
2015-03-20 15:14:52 -04:00
Steve Robb
0fd156ad2a NoArrays parameter removed from GetVarNameAndDim.
#codereview robert.manuszewski

[CL 2486377 by Steve Robb in Main branch]
2015-03-20 13:26:37 -04:00
Steve Robb
89d426db24 IsFunction parameter removed from GetVarNameAndDim.
#codereview robert.manuszewski

[CL 2486354 by Steve Robb in Main branch]
2015-03-20 13:11:34 -04:00
Steve Robb
2443964b1a GetVarAndDim's HardcodedName parameter removed.
#codereview robert.manuszewski

[CL 2486324 by Steve Robb in Main branch]
2015-03-20 12:52:40 -04:00
Steve Robb
b1f4463491 Redundant GetVarType return value removed.
#codereview robert.manuszewski

[CL 2484783 by Steve Robb in Main branch]
2015-03-19 13:42:08 -04:00
Steve Robb
4f14c1c278 Error contexts determined from EVariableCategory.
HintText/Thing parameters removed from GetVarNameAndDim/GetVarType.

#codereview robert.manuszewski

[CL 2484763 by Steve Robb in Main branch]
2015-03-19 13:27:48 -04:00
Steve Robb
a7f92019fb GetVarType and GetVarNameAndDim no longer take ObjectFlags.
#codereview robert.manuszewski

[CL 2484601 by Steve Robb in Main branch]
2015-03-19 11:33:15 -04:00
Dmitry Rekman
b7afabb59a Fix && and || being in the same scope.
#codereview Jaroslaw.Palczynski

[CL 2481965 by Dmitry Rekman in Main branch]
2015-03-17 14:48:41 -04:00
Jaroslaw Palczynski
b8c4d83b9c Enabling UHT to digest GENERATED_BODY instead of GENERATED_*_BODY.
#codereview Robert.Manuszewski

[CL 2481360 by Jaroslaw Palczynski in Main branch]
2015-03-17 06:02:26 -04:00
Jaroslaw Palczynski
f23f29257b Back out changelist 2481333
Rob asked me to back out GENERATED_*_BODY -> GENERATED_BODY change for now until the "_Validate and _Implementation auto-generation" discussion is over.

#codereview Robert.Manuszewski

[CL 2481343 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:38:32 -04:00
Jaroslaw Palczynski
fa31560e2d Enabled UHT to digest GENERATED_BODY instead of GENERATED_UCLASS_BODY, GENERATED_USTRUCT_BODY, GENERATED_UINTERFACE_BODY or GENERATED_IINTERFACE_BODY, changed every occurence to the new syntax and fixed every warning that have fallen out of this change.
#codereview Robert.Manuszewski

[CL 2481333 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:19:11 -04:00
Steve Robb
7be67f883f Localized some vars which caused a pointless test.
#codereview robert.manuszewski

[CL 2480498 by Steve Robb in Main branch]
2015-03-16 15:05:08 -04:00
Steve Robb
d4079e9cc8 Some unused stuff removed from FHeaderParser: bIsMulticastDelegate, LegalVariableSpecifiers and IsValidVariableSpecifier.
#codereview robert.manuszewski

[CL 2480191 by Steve Robb in Main branch]
2015-03-16 11:26:20 -04:00
Steve Robb
5eaa66f638 https://github.com/EpicGames/UnrealEngine/pull/910
Fixes UHT crashes with malformed UINTERFACE headers.

#codereview robert.manuszewski

[CL 2478423 by Steve Robb in Main branch]
2015-03-13 08:17:47 -04:00
Maciej Mroz
56e1ade4b0 Inner DELEGATEs as children. [By JaroslawP]
UE-11693 Compiler error when using Bind Event to OnTextChanged in UMG
UE-11674 BindEvent node gives "Wrong Event Dispatcher" error for BlueprintAssignable MC delegate

#codereview Jaroslaw.Palczynski

[CL 2477120 by Maciej Mroz in Main branch]
2015-03-12 14:06:13 -04:00
Jaroslaw Palczynski
f12f8a83bc UHT was reporting circular dependency if UClassA inherited UClassB defined in the same header. Fixed.
[CL 2473892 by Jaroslaw Palczynski in Main branch]
2015-03-10 12:06:49 -04:00