#UE-13299 - Comments and comment balloons don't obey colors set in editor preferences
#Branch UE4
#Proj BehaviourTreeEditor, EnvironmentQueryEditor, GraphEditor
#codereview Dan.Oconnor
[CL 2505562 by Ben Cosh in Main branch]
I have reviewed each change carefully, but it is a large change and I could have missed something! Here is a summary of the types of changes in this CL:
* Made nullptr checks consistent (the plurality of the changes are of this type)
* Completed switch statements (IE, switch did not explicitly handle default case, but had unhandled enum entries - this is the second most popular type of fix)
* Removed unused variables
* Removed redundant initializations
* WidgetNavigationCustomization.cpp was fixed by the owner
* integers converted to floats where result was stored in a float
* Removed redundent null checks (e.g. before delete statements)
* Renamed variables to prevent non-obvious shadowing
* Fixed use of bitwise & when checking for equality to an enum entry (which is often 0)
* Fixes for some copy paste errors (e.g. FoliageEdMode.cpp)
[CL 2498053 by Dan Oconnor in Main branch]
Consistent null checks, fixes for copy/pasted conditions, copy pasted LOCTEXT identifiers, comparisons against literals of the wrong type, missing return statements, dead code, and some system calls that were ignoring their return value
[CL 2494390 by Dan Oconnor in Main branch]
Refactored logic for what selection type is allowed in a SGraphActionMenu to the widgets that react to the selection.
#jira UE-11644 - Selected BP Variables do not refresh details properly
[CL 2493909 by Michael Schoell in Main branch]
https://github.com/EpicGames/UnrealEngine/pull/946
I have gone through these changes and verified that whatever behavior change they cause could only be an improvement (generally they just prevent possible access to nullptrs, but there are also some style corrections). A separate changelist is being prepared that includes changes that could unintentionally caues behavior change for the worse.
[CL 2486801 by Dan Oconnor in Main branch]
- Currently gated by a setting in Editor Preferences..Graph Editors
- Alt+LMB Click on the spline to break the connection
- Ctrl+LMB Click on the spline to move the connection to a different pin
- Hover over the spline to highlight it
[CL 2483923 by Michael Noland in Main branch]
Some P4V problem with backing out large changelist missed some files.
#codereview Robert.Manuszewski
[CL 2481366 by Jaroslaw Palczynski in Main branch]
Rob asked me to back out GENERATED_*_BODY -> GENERATED_BODY change for now until the "_Validate and _Implementation auto-generation" discussion is over.
#codereview Robert.Manuszewski
[CL 2481343 by Jaroslaw Palczynski in Main branch]
Note that to do this we need to load all behavior trees in the asset registry to check for blackboard/key usage
UE-8415 - Renaming a Blackboard Key removes it's references in the Behavior Tree
[CL 2475144 by Thomas Sarkanen in Main branch]
CL# 2453024: added navigation filter to EQS pathfinding tests
CL# 2466155: added batch pathfinding test for EQS
CL# 2466237: EQS generators will now cache NavLocation of items if navmesh projection is enabled
CL# 2466356: added support for deprecated nodes in EQS editor
CL# 2466358: pathing grid EQS generator is now deprecated
CL# 2466439: added failsafe in EQS editor for recreating missing nodes
CL# 2467466: fixed recreating test nodes in EQS graph
CL# 2467476: disabled HPA* in pathfinding EQS test
CL# 2467508: removed hierarchical pathfinding option from EQS tests
CL# 2468574: EQS generators will now cache NavLocation of items if navmesh projection is enabled (crash fix)
[CL 2472208 by Lukasz Furman in Main branch]
Editor: Replace ad-hoc _C suffix removal with two new utilities in FBlueprintEditorUtils
- GetClassNameWithoutSuffix just removes _C (but now only for BP generated classes)
- GetFriendlyClassDisplayName looks for DisplayName metadata and potentially pulls a nice localized display name if one is available, falling back to removing _C when necessary
[CL 2435096 by Matthew Griffin in Main branch]
#jira UE-7808 - Editor slows exponentially when selecting an instanced static mesh in viewport that has a large number of instances
[CL 2427864 by Richard TalbotWatkin in Main branch]
