Commit Graph

4382 Commits

Author SHA1 Message Date
nick darnell
0d69ab0b8e Fixing build issues after merge.
#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 8102880 via CL 8109724 via CL 8109829
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v401-8057353)

[CL 8149536 by nick darnell in Dev-Build branch]
2019-08-20 23:17:26 -04:00
michael kirzinger
6f63893602 Back out changelist 8064021. This had some unexpected side effects
#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: michael.kirzinger
#ROBOMERGE-SOURCE: CL 8096402 via CL 8096407 via CL 8100650 via CL 8109200 via CL 8109293
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v401-8057353)

[CL 8148069 by michael kirzinger in Dev-Build branch]
2019-08-20 23:11:26 -04:00
nick darnell
46646f2f78 Core - Adding full support for bool to the console variable system. Before the support was very spotty, they worker on refs, but nothing else, and nobody properly implemented the IsVariable___() functions. So I made a pass at getting it working throughout the system, and shuring up specializations to provide overrides for the IsVariable___() functions so that you can correctly determine what the underlying type of the variable is if you need it (i need it). Also, some things used TTypeFromString<T>, other places atoi(), so trying to normalize around TTypeFromString.
Bob.Tellez, Michael.Noland

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 8095438 via CL 8099422 via CL 8109042 via CL 8109114
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v401-8057353)

[CL 8147694 by nick darnell in Dev-Build branch]
2019-08-20 23:10:02 -04:00
jason bestimt
5c37a504fb Fix for HL2 static lighting in packaged builds
#RB: ryan.vance
[CODEREVIEW] ryan.vance
#JIRA: UE-78604
#lockdown: nick.penwarden

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: jason.bestimt
#ROBOMERGE-SOURCE: CL 8096970 in //UE4/Release-4.23/... via CL 8096974
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v401-8057353)

[CL 8146299 by jason bestimt in Dev-Build branch]
2019-08-20 23:04:25 -04:00
jeanfrancois dube
89f9b0d1b3 Introduce owned packages:
- Owned packages can reference private objects in their owner package.
 - Owned packages can reference private objects in other packages sharing the same owner.
 - Owner package can reference private objects in it�s owned packages.

Note: UE4 object version changed.

#rb robert.manuszewski, jamie.dale, richard.malo
#rnx

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: jeanfrancois.dube
#ROBOMERGE-SOURCE: CL 8089997 via CL 8095845 via CL 8095932
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v401-8057353)

[CL 8143804 by jeanfrancois dube in Dev-Build branch]
2019-08-20 22:53:11 -04:00
michael kirzinger
f5e3682868 Tick FEmbeddedCommunication directly in FEngineLoop::Tick instead of CoreTicker
[at]josh.adams, [at]rob.cannaday

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: michael.kirzinger
#ROBOMERGE-SOURCE: CL 8064021 via CL 8064037 via CL 8064040 via CL 8093035 via CL 8093151
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v401-8057353)

[CL 8136745 by michael kirzinger in Dev-Build branch]
2019-08-20 22:28:05 -04:00
jordan cristiano
74e87accd9 Fixed off by 1 error in FNameEntry::GetSize. FNameEntry strings are not null terminated, so a +1 when calculating size is incorrect.
This function is hit when running console command 'ViewNames'.

#rb johan.torp
#rnx

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: jordan.cristiano
#ROBOMERGE-SOURCE: CL 8062093 via CL 8092504 via CL 8092633
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v401-8057353)

[CL 8135210 by jordan cristiano in Dev-Build branch]
2019-08-20 22:22:50 -04:00
jeff fisher
c5d1f4dbad UE-78915 HoloLens - Packaged apps sometimes crash on launch
-Task jobs were not projected by critical section, and could get into unexpected states by being processed more than once simultaneously.
-Corrected hololens implementation of TryLock so that it keeps the lock when it finds it available rather than immediately releasing it, matching the behavior on other platforms.
#rb Uriel.Doyon (actually he proposed this exact solution)
#jira UE-78915
#lockdown nick.penwarden

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: jeff.fisher
#ROBOMERGE-SOURCE: CL 8080556 in //UE4/Release-4.23/... via CL 8080563
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v401-8057353)

[CL 8110463 by jeff fisher in Dev-Build branch]
2019-08-17 02:26:40 -04:00
nick darnell
65028ef176 Fixing build issues after merge.
#ROBOMERGE-SOURCE: CL 8102880 via CL 8109724
#ROBOMERGE-BOT: (v401-8057353)

[CL 8109829 by nick darnell in Main branch]
2019-08-17 02:00:40 -04:00
michael kirzinger
d7dd366b28 Back out changelist 8064021. This had some unexpected side effects
#ROBOMERGE-SOURCE: CL 8096402 via CL 8096407 via CL 8100650 via CL 8109200
#ROBOMERGE-BOT: (v401-8057353)

[CL 8109293 by michael kirzinger in Main branch]
2019-08-17 01:46:39 -04:00
nick darnell
e1cac32b0a Core - Adding full support for bool to the console variable system. Before the support was very spotty, they worker on refs, but nothing else, and nobody properly implemented the IsVariable___() functions. So I made a pass at getting it working throughout the system, and shuring up specializations to provide overrides for the IsVariable___() functions so that you can correctly determine what the underlying type of the variable is if you need it (i need it). Also, some things used TTypeFromString<T>, other places atoi(), so trying to normalize around TTypeFromString.
Bob.Tellez, Michael.Noland


#ROBOMERGE-OWNER: nick.darnell
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 8095438 via CL 8099422 via CL 8109042
#ROBOMERGE-BOT: (v401-8057353)

[CL 8109114 by nick darnell in Main branch]
2019-08-17 01:42:31 -04:00
jason bestimt
ebd1add0fe Fix for HL2 static lighting in packaged builds
#RB: ryan.vance
[CODEREVIEW] ryan.vance
#JIRA: UE-78604
#lockdown: nick.penwarden

#ROBOMERGE-SOURCE: CL 8096970 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v401-8057353)

[CL 8096974 by jason bestimt in Main branch]
2019-08-16 14:58:52 -04:00
jeanfrancois dube
6c79ec7645 Introduce owned packages:
- Owned packages can reference private objects in their owner package.
 - Owned packages can reference private objects in other packages sharing the same owner.
 - Owner package can reference private objects in it�s owned packages.

Note: UE4 object version changed.

#rb robert.manuszewski, jamie.dale, richard.malo
#rnx


#ROBOMERGE-SOURCE: CL 8089997 via CL 8095845
#ROBOMERGE-BOT: (v401-8057353)

[CL 8095932 by jeanfrancois dube in Main branch]
2019-08-16 13:52:30 -04:00
michael kirzinger
baf4621cd3 Tick FEmbeddedCommunication directly in FEngineLoop::Tick instead of CoreTicker
[at]josh.adams, [at]rob.cannaday


#ROBOMERGE-SOURCE: CL 8064021 via CL 8064037 via CL 8064040 via CL 8093035
#ROBOMERGE-BOT: (v401-8057353)

[CL 8093151 by michael kirzinger in Main branch]
2019-08-16 12:57:35 -04:00
jordan cristiano
e358940b6c Fixed off by 1 error in FNameEntry::GetSize. FNameEntry strings are not null terminated, so a +1 when calculating size is incorrect.
This function is hit when running console command 'ViewNames'.

#rb johan.torp
#rnx


#ROBOMERGE-SOURCE: CL 8062093 via CL 8092504
#ROBOMERGE-BOT: (v401-8057353)

[CL 8092633 by jordan cristiano in Main branch]
2019-08-16 12:49:21 -04:00
jeff fisher
8f72c0e34a UE-78915 HoloLens - Packaged apps sometimes crash on launch
-Task jobs were not projected by critical section, and could get into unexpected states by being processed more than once simultaneously.
-Corrected hololens implementation of TryLock so that it keeps the lock when it finds it available rather than immediately releasing it, matching the behavior on other platforms.
#rb Uriel.Doyon (actually he proposed this exact solution)
#jira UE-78915
#lockdown nick.penwarden

#ROBOMERGE-SOURCE: CL 8080556 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v400-8057353)

[CL 8080563 by jeff fisher in Main branch]
2019-08-16 03:09:30 -04:00
krzysztof narkowicz
9ea65aa96b New SkyAtmosphere component CLs in FN
Merging using //Fortnite/Main/_to_/UE4/Dev-Rendering
#rb none

Also tested on mobile with Dmitriy.
Improvement and optimisation pending with https://docs.google.com/document/d/17fBBGX_cP9YARfiBU3P9BIElOo2m6IpqJhRXOZvzXa0/edit#heading=h.tuqnyahzdlw8

Integrated / edtigrated CLs are
7555515
7559183
7565353
7577376
7593568
7624000
7785404
7785501
7839046
7861664
7949251
7949481
7951875
7973183

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: sebastien.hillaire
#ROBOMERGE-SOURCE: CL 8020041 via CL 8027701 via CL 8062409
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v400-8057353)

[CL 8070395 by krzysztof narkowicz in Dev-Build branch]
2019-08-16 00:28:28 -04:00
krzysztof narkowicz
c3f806ef7b New SkyAtmosphere component CLs in FN
Merging using //Fortnite/Main/_to_/UE4/Dev-Rendering
#rb none

Also tested on mobile with Dmitriy.
Improvement and optimisation pending with https://docs.google.com/document/d/17fBBGX_cP9YARfiBU3P9BIElOo2m6IpqJhRXOZvzXa0/edit#heading=h.tuqnyahzdlw8

Integrated / edtigrated CLs are
7555515
7559183
7565353
7577376
7593568
7624000
7785404
7785501
7839046
7861664
7949251
7949481
7951875
7973183


#ROBOMERGE-OWNER: krzysztof.narkowicz
#ROBOMERGE-AUTHOR: sebastien.hillaire
#ROBOMERGE-SOURCE: CL 8020041 via CL 8027701
#ROBOMERGE-BOT: (v400-8057353)

[CL 8062409 by krzysztof narkowicz in Main branch]
2019-08-15 13:46:05 -04:00
simon tourangeau
aeb5dd072f Path Selection Window
When user selects target path for exporting or saving, we need to refresh content from server. So we add OnPathSelected event to FSharedAssetDialogConfig and SAssetDialog.
Changed files: IContentBrowserSingleton.h, SAssetDialog.h, SAssetDialog.cpp.

GPumpingMessages
When files and folders are deleted or created by user, we want to save these changes to server. So we monitor such changes through IAssetRegistry. But we need to determine whether it�s triggered by user. So we add GPumpingMessages, a global flag indicating that application is processing Windows messages. Which means it�s triggered by user input.
Another possible choice is adding delegates. But this requires more changes and is less general.
Changed files: CoreGlobals.h, CoreGlobals.cpp, WindowsPlatformApplicationMisc.cpp.

Mesh Editor Small Fix
Fix an issue where vertex colors in Toolbar didn't work in 4.22.
Changed file is SStaticMeshEditorViewport.cpp.

#jira UE-78897

PR #6121: Editor changes for NVIDIA USD plugin

#rb chris.gagnon
#lockdown nick.penwarden

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: simon.tourangeau
#ROBOMERGE-SOURCE: CL 8042071 in //UE4/Release-4.23/... via CL 8042138
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v400-8057353)

[CL 8058403 by simon tourangeau in Dev-Build branch]
2019-08-15 08:35:47 -04:00
jules blok
48cd16e039 Re-enable geometry shaders on Lumin
Volumetric textures are still a problem so these are disabled instead

#jira UE-78571
#rb Ryan.Vance

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: jules.blok
#ROBOMERGE-SOURCE: CL 8030670 in //UE4/Release-4.23/... via CL 8030682
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v399-8035122)

[CL 8053618 by jules blok in Dev-Build branch]
2019-08-14 23:22:05 -04:00
dave belanger
7768a462f0 Ignore "SObjectWidget destroyed while collecting garbage" ensure during blueprint compile GC phase.
#rb Nick.Darnell
#jira UE-66995

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 8030117 in //UE4/Release-4.23/... via CL 8030139
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v399-8035122)

[CL 8053592 by dave belanger in Dev-Build branch]
2019-08-14 23:22:00 -04:00
marc audy
0c780ffb48 Restore removed version so assets saved while the version was in place can still load
#rb
#jira
#rnx
[CODEREVIEW] Maxwell.Hayes, Aaron.McLeran

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 8029798 in //UE4/Release-4.23/... via CL 8029985
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v399-8035122)

[CL 8053582 by marc audy in Dev-Build branch]
2019-08-14 23:21:58 -04:00
jordan cristiano
389e1f40dd Added constructors to FAutoConsoleVariable that allow passing in a FConsoleVariableDelegate as a OnChangedCallback.
#rb michael.noland andrew.ladenberger
#rnx

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: jordan.cristiano
#ROBOMERGE-SOURCE: CL 8009641 via CL 8015324 via CL 8015394
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v399-8035122)

[CL 8050414 by jordan cristiano in Dev-Build branch]
2019-08-14 23:09:52 -04:00
maxwell hayes
3ef6baa1ae Removing serialization from SoundClass from deprecated audio project setting
[FYI] dan.reynolds
#jira none
#rb none

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: maxwell.hayes
#ROBOMERGE-SOURCE: CL 8013532 in //UE4/Release-4.23/... via CL 8013534
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v399-8035122)

[CL 8048433 by maxwell hayes in Dev-Build branch]
2019-08-14 23:01:56 -04:00
simon tourangeau
5ecedcab2d Path Selection Window
When user selects target path for exporting or saving, we need to refresh content from server. So we add OnPathSelected event to FSharedAssetDialogConfig and SAssetDialog.
Changed files: IContentBrowserSingleton.h, SAssetDialog.h, SAssetDialog.cpp.

GPumpingMessages
When files and folders are deleted or created by user, we want to save these changes to server. So we monitor such changes through IAssetRegistry. But we need to determine whether it�s triggered by user. So we add GPumpingMessages, a global flag indicating that application is processing Windows messages. Which means it�s triggered by user input.
Another possible choice is adding delegates. But this requires more changes and is less general.
Changed files: CoreGlobals.h, CoreGlobals.cpp, WindowsPlatformApplicationMisc.cpp.

Mesh Editor Small Fix
Fix an issue where vertex colors in Toolbar didn't work in 4.22.
Changed file is SStaticMeshEditorViewport.cpp.

#jira UE-78897

PR #6121: Editor changes for NVIDIA USD plugin

#rb chris.gagnon
#lockdown nick.penwarden

#ROBOMERGE-SOURCE: CL 8042071 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v399-8035122)

[CL 8042138 by simon tourangeau in Main branch]
2019-08-14 16:18:58 -04:00