Commit Graph

37 Commits

Author SHA1 Message Date
zach bethel
53b49dee8a Minor fixes to RenderGraph implementation.
#rb none
#jira none

#ROBOMERGE-SOURCE: CL 7326766 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v371-7306989)

[CL 7326772 by zach bethel in Main branch]
2019-07-16 15:10:54 -04:00
zach bethel
f38aad9da5 Refactored render graph validation logic. Hardened mip generation pass barrier handling. Fixed compute-based mip generation pass helper.
#jira UE-77059
#rb guillaume.abadie

#ROBOMERGE-OWNER: zach.bethel
#ROBOMERGE-AUTHOR: zach.bethel
#ROBOMERGE-SOURCE: CL 7324754 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v371-7306989)

[CL 7324765 by zach bethel in Main branch]
2019-07-16 13:08:56 -04:00
zach bethel
564177bd96 Fixed issue where RDG buffer pool would grow unbounded.
#rb guillaume.abadie
#jira UE-76453

#ROBOMERGE-SOURCE: CL 7252701 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v368-7249887)

[CL 7252715 by zach bethel in Main branch]
2019-07-09 17:22:17 -04:00
Marc Audy
656ad034d6 Remove duplicated function
#rb
#rnx
#codereview zach.bethel

[CL 7090361 by Marc Audy in Main branch]
2019-06-19 09:14:52 -04:00
zach bethel
42846be25b Hand-Integrated fixes from Main:
7064877 - RDG Resource Barrier Fixes and Improvements.

 - Resource barriers are now batched and submitted as a group at the beginning of a pass.
 - UAVs referencing the same underlying resource now only submit a single write barrier instead of a write + N UAV barriers.
 - During a mip generation pass, barriers are not issued for textures (they are implicitly converted to the SubRWBarrier state).
 - Depth / stencil read now transitions to the read state; this allows DSV + SRV to work correctly.

#jira UE-76196
#rb Guillaume.Abadie

7064884 - Fixed RHI resource transitions causing validation failures.

#rb Rolando.Caloca
#jira none

7064898 - Fixed issue where implementation of RHICopyTexture would only copy mip 0, breaking environment probe copies.

#jira UE-76203
#rb Jeremy.Moore


#ROBOMERGE-OWNER: zach.bethel
#ROBOMERGE-AUTHOR: zach.bethel
#ROBOMERGE-SOURCE: CL 7082976 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v367-6836689)

[CL 7082994 by zach bethel in Main branch]
2019-06-18 22:23:27 -04:00
zach bethel
879a31dc40 RDG Resource Barrier Fixes and Improvements.
- Resource barriers are now batched and submitted as a group at the beginning of a pass.
 - UAVs referencing the same underlying resource now only submit a single write barrier instead of a write + N UAV barriers.
 - During a mip generation pass, barriers are not issued for textures (they are implicitly converted to the SubRWBarrier state).
 - Depth / stencil read now transitions to the read state; this allows DSV + SRV to work correctly.

#jira UE-76196
#rb Guillaume.Abadie

[CL 7064877 by zach bethel in Main branch]
2019-06-18 13:23:41 -04:00
rolando caloca
83c57c2a0f UE4.23 - Deprecate FUniformBufferRHIParamRef, FIndexBufferRHIParamRef, FVertexBufferRHIParamRef, FStructuredBufferRHIParamRef, FTextureRHIParamRef, FTexture2DRHIParamRef, FTexture2DArrayRHIParamRef, FTexture3DRHIParamRef, FTextureCubeRHIParamRef
#rb none
#jira UE-76364

#ROBOMERGE-SOURCE: CL 7046967 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v367-6836689)

[CL 7047009 by rolando caloca in Main branch]
2019-06-17 13:39:07 -04:00
Rolando Caloca
aa0d2303d6 Copying //UE4/Dev-Rendering to Dev-Main (//UE4/Dev-Main) @ 6944469
#rb none
#rnx

[CL 6944849 by Rolando Caloca in Main branch]
2019-06-11 18:27:07 -04:00
guillaume abadie
e1c486cec4 Cherry-pick 5814346: Fixes 2 resource transitions bugs on FRDGBuffers
1: Two passes writing to same UAV was not getting the RWBarrier transition.
2: Incorrectly transitioned to readable when accessing for indirect draw call or SRV.

#rb none
#jira none
[FYI] zach.bethel
#lockdown nick.penwarden

#ROBOMERGE-SOURCE: CL 6147601 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 6147606 by guillaume abadie in Main branch]
2019-04-29 18:23:20 -04:00
jeff newquist
1269af6044 Add RenderThread CSV exclusive stats
#rb ben.woodhouse


#ROBOMERGE-SOURCE: CL 5830660 via CL 5830670 via CL 5835167

[CL 5835925 by jeff newquist in Main branch]
2019-04-12 10:05:47 -04:00
juan canada
ac58ad5e6b Copying //UE4/Private-Woodchuck-Staging[at]4997051 to Release-4.22 (//UE4/Release-4.22)
#rb none
#jira
[FYI] marcus.wassmer
[FYI] zachary.wilson

#ROBOMERGE-SOURCE: CL 4997195 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4997198 by juan canada in Main branch]
2019-02-14 14:23:27 -05:00
Guillaume Abadie
1328dbdab6 Cherry-pick 4883297: Disabled render graph building warnings inside test build, and made it off by default, as it takes considerable amount of render thread time.
#rb none
#fyi Guillaume.Abadie
#jira UE-69545
#rnx

[CL 4900083 by Guillaume Abadie in Dev-Rendering branch]
2019-02-05 14:06:00 -05:00
Krzysztof Narkowicz
534dd5bde9 Disabled render graph building warnings inside test build, and made it off by default, as it takes considerable amount of render thread time.
#rb none
#fyi Guillaume.Abadie

[CL 4883297 by Krzysztof Narkowicz in Main branch]
2019-02-04 10:14:58 -05:00
Guillaume Abadie
7132135b24 Fixes some MSVC static analysis warnings.
#rb none
#jira UE-67755
#lockdown marcus.wassmer

[CL 4802211 by Guillaume Abadie in Dev-Rendering branch]
2019-01-24 14:01:53 -05:00
Rolando Caloca
732810a13b DR - Copying //UE4/Dev-Main@4785067 to //UE4-DevRendering
#rb none
#rnx
#lockdown Marcus.Wassmer

[CL 4790611 by Rolando Caloca in Dev-Rendering branch]
2019-01-23 17:01:56 -05:00
Guillaume Abadie
3d14d2577d Makes the errors checking render graph executions more precise.
#rb none

[CL 4768429 by Guillaume Abadie in Dev-Rendering branch]
2019-01-22 02:15:37 -05:00
Guillaume Abadie
a11fbac7b5 Fixes compilation failures in render graph.
#rb none

[CL 4767308 by Guillaume Abadie in Dev-Rendering branch]
2019-01-21 20:08:38 -05:00
Guillaume Abadie
4572c93021 Adds an option in the render graph to emit warning regardless if it has been already emited.
#rb none

[CL 4736385 by Guillaume Abadie in Dev-Rendering branch]
2019-01-16 16:12:36 -05:00
Guillaume Abadie
f24cd00ca8 Ensures render graph emitted warnings are only emitted once.
#rb none

[CL 4736239 by Guillaume Abadie in Dev-Rendering branch]
2019-01-16 15:48:28 -05:00
Guillaume Abadie
e729e855dc Adds a warning in render graph when a resource is produced by a pass, but never used after.
#rb none

[CL 4730698 by Guillaume Abadie in Dev-Rendering branch]
2019-01-15 19:57:23 -05:00
Guillaume Abadie
b6b06afb3c Impoves implementation of FRDGBuilder::WarnForUselessPassDependencies()
#rb none

[CL 4705754 by Guillaume Abadie in Dev-Rendering branch]
2019-01-10 17:53:26 -05:00
Guillaume Abadie
408f2d59a1 Implements early validation of resource production in render graph to catch common user mistakes more conveniently.
#rb none

[CL 4685955 by Guillaume Abadie in Dev-Rendering branch]
2019-01-07 14:44:04 -05:00
Guillaume Abadie
ca8389b9ec s/UBMT_GRAPH_TRACKED_/UBMT_RDG_ for better naming consistency.
#rb none

[CL 4682491 by Guillaume Abadie in Dev-Rendering branch]
2019-01-04 14:52:46 -05:00
Marcus Wassmer
cbfcbbb93b Merging //UE4/Dev-Main@4662404 to Dev-Rendering (//UE4/Dev-Rendering)
#rb none
Should be just copyright updates

[CL 4680440 by Marcus Wassmer in Dev-Rendering branch]
2019-01-03 19:16:26 -05:00
Marcus Wassmer
4cc088f35c Copying //UE4/Dev-Rendering-HLR@4669539 to Dev-Rendering (//UE4/Dev-Rendering)
#rb none
#lockdown rolando.caloca

[CL 4669551 by Marcus Wassmer in Dev-Rendering branch]
2018-12-18 21:41:17 -05:00