robert manuszewski
a1ee8ce674
Fixed crashes related to multithreaded destruction of widget components
...
#rb none
#jira UE-77600
#ROBOMERGE-SOURCE: CL 7473681 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v371-7306989)
[CL 7473682 by robert manuszewski in Main branch]
2019-07-22 04:46:41 -04:00
danny couture
d8e1ea3466
Provide caching for FindViewComponentForActor to improve editor responsiveness when a selected actor contains many others.
...
- Add GetAttachedActor overload which takes a functor so we can iterate more effectively and abort iteration if needed.
- 5 sec to 90ms per frame (55x improvement) when selected actor contains 60 000 others.
- 43 sec to 2s (21x improvement) for CaptureSceneThumbnail at the end of datasmith import for a 60 000 actors scene.
From dev-enterprise[at]7062261,7063185
#rb Steve.Robb, Marc.Audy, JeanMichel.Dignard
#jira UE-77027
#ROBOMERGE-SOURCE: CL 7259947 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v369-7254125)
[CL 7259948 by danny couture in Main branch]
2019-07-10 05:33:41 -04:00
sebastian nordgren
e964494035
FScriptMapHelper and FScriptSetHelper now have a GetInternalIndex that maps a logical index (ie. Nth element) to the internal index.
...
#rb steve.robb
#jira UE-75123
Source: 6932549 (Dev-Editor)
#ROBOMERGE-SOURCE: CL 7247481 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v367-6836689)
[CL 7247483 by sebastian nordgren in Main branch]
2019-07-09 03:39:46 -04:00
robert manuszewski
b0f0c484a2
Adding a range check to the cluster array index operator that logs the bad index unlike the TArray range check
...
#rb none
#ROBOMERGE-SOURCE: CL 7086448 via CL 7104030
#ROBOMERGE-BOT: (v367-6836689)
[CL 7104131 by robert manuszewski in Main branch]
2019-06-20 10:46:43 -04:00
Marc Audy
8ba11eb5c1
Fix up inconsistencies between UE4/Main and Dev-EngineMerge
...
#rb
#rnx
[CL 7021692 by Marc Audy in Main branch]
2019-06-14 22:32:59 -04:00
Rolando Caloca
aa0d2303d6
Copying //UE4/Dev-Rendering to Dev-Main (//UE4/Dev-Main) @ 6944469
...
#rb none
#rnx
[CL 6944849 by Rolando Caloca in Main branch]
2019-06-11 18:27:07 -04:00
daniel lamb
724dd8a0b0
Clean up missing packages list when we mount pak files.
...
#ROBOMERGE-SOURCE: CL 6912467 via CL 6912474 via CL 6912475 via CL 6913209
#ROBOMERGE-BOT: (v366-6836689)
[CL 6914251 by daniel lamb in Main branch]
2019-06-10 14:27:11 -04:00
JeanMichel Dignard
0f9ad96858
Copying //UE4/Dev-Enterprise @ cl 6890376 to Dev-Main (//UE4/Dev-Main)
...
#lockdown nick.penwarden
#rb none
[CL 6890764 by JeanMichel Dignard in Main branch]
2019-06-07 11:22:52 -04:00
Lina Halper
b0bdc590d5
Merging //UE4/Dev-Main to Dev-Anim (//UE4/Dev-Anim)
...
#lockdown: thomas.sarkanen
#fyi: Laurent.Delayen
#rb: none
[CL 6861656 by Lina Halper in Dev-Anim branch]
2019-06-06 12:33:54 -04:00
stefan boberg
7f1f94b842
Copying //UE4/Dev-Core to Dev-Main (//UE4/Dev-Main)
...
#rb none
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: stefan.boberg
#ROBOMERGE-SOURCE: CL 6815521 in //UE4/Main/...
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)
[CL 6821478 by stefan boberg in Dev-Anim branch]
2019-06-03 19:17:40 -04:00
dan oconnor
fd918f6084
Avoid unnecessary alloca call when not calling remote functions, remove unused parameter from UObject::GetFunctionCallspace
...
Upgrade notes: second parameter of GetFunctionCallspace overrides should be removed - it served no purpose
#rb Michael.Noland
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: dan.oconnor
#ROBOMERGE-SOURCE: CL 6635880 via CL 6639399 via CL 6639673
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)
[CL 6754029 by dan oconnor in Dev-Anim branch]
2019-05-31 18:30:57 -04:00
ben zeigler
783d29a698
Fix obj refs code by merging parts of CL 5365249 and 5536455 as 6542056 conflicted with a change in framework. This fixes an infinite recursion crash in obj refs and changes it so you don't need to pass the GC collector to AddReferencedObjects but doesn't include the deprecation changes or setting the debug name on streamablemanager
...
[CODEREVIEW] bob.tellez
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.zeigler
#ROBOMERGE-SOURCE: CL 6578103 via CL 6581750 via CL 6581772
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v363-6677109)
[CL 6699980 by ben zeigler in Dev-Anim branch]
2019-05-31 12:50:48 -04:00
bob tellez
b06ca21b0b
#UE4 Better FGCObject reporting in obj refs. FGCObject names are now reported in the "obj refs" console command, provided that they pass in FGCObject::GGCObjectReferencer as the referencer when calling AddReferencedObjects. FGCObjects may now also implement GetReferencerPropertyName to describe more details about how it references an object.
...
#ROBOMERGE-VERSION: 348-6547088
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 6542056 via CL 6542588 via CL 6542593
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 6568946 by bob tellez in Dev-Anim branch]
2019-05-18 11:12:37 -04:00
nick darnell
1b43fbbb03
Adding const variants of some of the more common AddReferencedObject(s) functions to allow for FGCObjects to store const pointers to UObjects or collections and report those references easily, otherwise people make the mistake of creating local ptrs that can't be nulled out correctly.
...
#rb Robert.Manuszewski
[FYI] Dan.Hertzka
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 5830834 via CL 5830835 via CL 5835213 via CL 5835996
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5875741 by nick darnell in Dev-Anim branch]
2019-04-12 21:09:15 -04:00
bob tellez
bd38d54667
#UE4 Improve logging when assets fail to load. Failing to get the package linker will now produce fewer redundant log messages and all failure messages will include the asset that failed to load as well as the asset that was requesting the linker where possible.
...
#rb Robert.Manuszewski
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 5713888 via CL 5714486 via CL 5714487
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5721617 by bob tellez in Dev-Anim branch]
2019-04-03 21:43:47 -04:00
marc audy
0ba5ad88f1
Rework sparse delegate storage to not use uobject annotation and manage its own map and lock state. This eliminates unnnecessary annotation cache overhead and ensures entire operation on map is completed while the lock is in place rather than copying per-object map out of the annotation and then moving modified inner per-object map back in to the annotation as two separately locked actions.
...
#rnx
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5483896 via CL 5483909 via CL 5483913 via CL 5487278 via CL 5487454
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5507513 by marc audy in Dev-Anim branch]
2019-03-22 17:12:17 -04:00
steve robb
6e246488a8
Fix for warnings about engine classes being hot reloaded when they haven't even changed.
...
#jira UE-71581
#rb none
[FYI] jamie.dale
#lockdown cristina.riveron
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 5459196 in //UE4/Release-4.22/... via CL 5459199
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5475456 by steve robb in Dev-Anim branch]
2019-03-20 13:21:48 -04:00
robert manuszewski
34fae63f6d
Fixing issues with objects not being serialized before they are being ConditionallyPostLoaded by other objects and LoadContext related crashes
...
#rb none
#jira UE-69177
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5401696 in //UE4/Release-4.22/... via CL 5401697
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5410704 by robert manuszewski in Dev-Anim branch]
2019-03-15 05:40:49 -04:00
marc audy
c413a56e21
Fix sparse multicast delegates operating on the wrong object when binding, removing, or clearing on an object from another object's blueprint.
...
#jira
#rnx
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5370086 via CL 5370286 via CL 5373422 via CL 5377685
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5382170 by marc audy in Dev-Anim branch]
2019-03-13 10:13:09 -04:00
Thomas Sarkanen
bb193db1aa
Merging //UE4/Dev-Main to Dev-Anim (//UE4/Dev-Anim) @ CL 5356908
...
#rb none
[CL 5360337 by Thomas Sarkanen in Dev-Anim branch]
2019-03-11 12:18:32 -04:00
marc audy
12818f40be
Override GetCPPType in the multicast delegate TProperty specialization as the new hierarchy was using the TProperty version instead of the UMulticastDelegateProperty version.
...
This fixes nativization crash generating code for a multicast delegate.
#rb Phillip.Kavan
#rnx
#jira
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5313198 via CL 5313199 via CL 5315969 via CL 5316036
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5330321 by marc audy in Dev-Anim branch]
2019-03-06 18:38:29 -05:00
marc audy
adbce8a066
Provide a comment at the check that will occur if a sparse delegate is used on the stack so user has better understanding of why it is checking.
...
#rnx
#jira
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5313147 via CL 5313158 via CL 5315966 via CL 5316033
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5330316 by marc audy in Dev-Anim branch]
2019-03-06 18:38:27 -05:00
marc audy
d5232114b6
Dynamic Multicast delegates can now specify that their storage be stored in a sparse allocation for delegates that are expected to be bound rarely. The memory usage of an unbound sparse delegate is 1 byte instead of 16 bytes (for the empty array), however, a bound sparse delegate will have access overhead to retrieve the invocation list from the sparse object annotation.
...
The definition of the delegate type must specify the class and property name of the delegate that will use it and the type cannot be used outside of that context or just on the stack.
UMulticastDelegateProperty is now abstract and has 2 subclasses (UMulticastDelegateInlineProperty and UMulticastDelegateSparseProperty). The SparseProperty SignatureFunction will be a USparseDelegateFunction.
The sparse delegates do not work correctly with the python bindings at this point, but this will be visited soon.
#rb Michael.Noland
#jira
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5295832 via CL 5306530 via CL 5306657
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5322213 by marc audy in Dev-Anim branch]
2019-03-06 18:02:30 -05:00
Helge Mathee
157f5167e4
Documentating "DocumentationPolicy" meta tag for inside ObjectMacros.h
...
#rb lina.halper
[CL 5312098 by Helge Mathee in Dev-Anim branch]
2019-03-06 08:29:36 -05:00
Thomas Sarkanen
474bc576ee
Merging //UE4/Dev-Main to Dev-Anim (//UE4/Dev-Anim) @ CL 5236305
...
#rb none
#jira none
[CL 5236785 by Thomas Sarkanen in Dev-Anim branch]
2019-02-28 04:41:36 -05:00