Commit Graph

11448 Commits

Author SHA1 Message Date
UnrealBot
73409369c0 Branch snapshot for CL 21319338
[CL 21319338 in ue5-main branch]
2022-08-10 16:03:37 +00:00
mark lintott
e2d74ce99d Fixed unacceptable words in Stats and Profiling system
#jira UE-158612, UE-158573, UE-158613
#rb pj.kack
#preflight 62f3b39cf75a2a539c84166f

[CL 21317572 by mark lintott in ue5-main branch]
2022-08-10 09:49:10 -04:00
paul chipchase
085b274017 Renamed the config value [Core.VirtualizationModule].EnablePushToBackend to [Core.VirtualizationModule].EnablePayloadVirtualization so that it makes more sense
#rb trivial
#jira UE-156189
#rnx
#preflight 62f3ab2023003b62a324f67a

- The older versions of this value ([Core.ContentVirtualization].EnablePushToBackend and [Core.VirtualizationModule].EnablePushToBackend) will continue to work but will log a warning to the user telling them to update it.
- It is very unlikely that anyone is actually using these old values and so we can remove this backwards compatibility when 5.1 ships. It is only present to allow us to fix up internal projects and to avoid interrupting people testing the system.

[CL 21317383 by paul chipchase in ue5-main branch]
2022-08-10 09:43:35 -04:00
paul chipchase
da282e1873 Add FSourceControlBackend support for storing virtualized payloads in a stream type depot.
#rb Per.Larsson
#rnx
#jira UE-160619
#preflight 62f37c86b66d5d93133d67e3

- Based on work from Jess.Kube

### Virtualization
- The source control backend now takes an optional config option "ClientStream" which takes the name of the client stream to use.
- If a client stream is set then workspaces created for payload submission will use that and not provide a client-view mapping.

#ushell-cherrypick of 21195584 by Jess.Kube
### PerforceSourceControl
- Allow FCreateWorkspace to create workspaces with streams as well as classic workspaces cia FCreateWorkspace::SetStream.
- Add a method FCreateWorkspace::ClearClientViewMappings which will clear any client view mappings already added to the operation.
- If we detect that a FCreateWorkspace operation has both a stream set and client view mappings set then FPerforceCreateWorkspaceWorker will return an error. Perforce will allow us to creat a client spec with both entries, but will default to using the stream. Technically we could allow this too but it might cause unexpected behaviour to the caller. It is better to give a clear error and fail the workspace creation.

[CL 21316756 by paul chipchase in ue5-main branch]
2022-08-10 08:51:05 -04:00
paul chipchase
a34eae2d63 [Backout] - CL21316332
#fyi paul.chipchase
Original CL Desc
-----------------------------------------------------------------
The virtualization manager will now read the newer config file location (Core.ContentVirtualization) first and only fall back to the older location (Core.ContentVirtualization) if it was not found.

#rb trivial
#jira UE-156189
#rnx
#preflight 62f38fed086f90bbc4d915f0

[CL 21316410 by paul chipchase in ue5-main branch]
2022-08-10 07:43:22 -04:00
paul chipchase
ab8981c0bc The virtualization manager will now read the newer config file location (Core.ContentVirtualization) first and only fall back to the older location (Core.ContentVirtualization) if it was not found.
#rb trivial
#jira UE-156189
#rnx
#preflight 62f38fed086f90bbc4d915f0

- This will help if someone has updated their set up to the new location but not removed the old entries.
- We still warn that the old enteries exist, even if not used.

[CL 21316332 by paul chipchase in ue5-main branch]
2022-08-10 07:36:06 -04:00
mark lintott
3d47f895e5 Fixed unacceptable words in PakFileUtilities
#jira UE-158611
#rb pj.kack
#preflight 62f383dbbc175ec68c338e38

[CL 21316108 by mark lintott in ue5-main branch]
2022-08-10 06:24:40 -04:00
marc audy
d9e396186c Fix non-unity errors
#jira
#rnx

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 21314172 via CL 21314182 via CL 21314192
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21315260 by marc audy in ue5-main branch]
2022-08-10 03:02:24 -04:00
Devin Doucette
db73e60520 DDC: Fixed a compile error in the mock cache store
#preflight skip
#rb trivial
#rnx
#robomerge FNMain

[CL 21301375 by Devin Doucette in ue5-main branch]
2022-08-09 18:09:15 -04:00
Devin Doucette
07e5f7441b DDC: Added a mock cache store for testing the cache
#preflight 62f2c634bc175ec68c149158
#rb Zousar.Shaker
#rnx
#robomerge FNMain

[CL 21300835 by Devin Doucette in ue5-main branch]
2022-08-09 17:55:24 -04:00
jay nakai
2aa0133963 Adjustments to allow easier advanced copy customization
* SetPackageThatInitiatedCopy() is now called before any customization steps to fix issue with inconsistent values in PackageThatInitiatedCopy. Notably that PackageThatInitiatedCopy could be the name of the previous package initiator during some method calls if the same advanced copy customization was re-used during the editor lifetime
* Made UAdvancedCopyCustomization::GetARFilter() virtual so customization have an opportunity to define additional filtering

#rb Lauren.Barnes

#ROBOMERGE-AUTHOR: jay.nakai
#ROBOMERGE-SOURCE: CL 21293857 via CL 21293920 via CL 21293937
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21297704 by jay nakai in ue5-main branch]
2022-08-09 16:34:05 -04:00
Devin Doucette
76e5a1365f DDC: Separated the async completion counter from the cache singleton
#preflight 62f2ae3e3f500fb6dcf79ad1
#rb Zousar.Shaker
#rnx
#robomerge FNMain

[CL 21296269 by Devin Doucette in ue5-main branch]
2022-08-09 15:39:06 -04:00
ennorehling
664320eb6b PR #9375: Common typo: doens't -> doesn't (Contributed by ennorehling)
#preflight 62f27e1a0264595302eefa12
#jira UE-158763
#rb trivial

[CL 21292281 by ennorehling in ue5-main branch]
2022-08-09 13:21:24 -04:00
Chris Varnsverry
0fcb315349 - Fix ConsoleListener attempting to send TCHAR* to cout, printing pointer values instead of strings.
#jira OI-4874
#review-21257422 @Michael.Kirzinger @Stephen.Ma @Alex.Kasianchuk @Sam.Zamani
#preflight 62f28751d76ea4b5030ad047

[CL 21290568 by Chris Varnsverry in ue5-main branch]
2022-08-09 12:19:20 -04:00
jamie dale
9f2519d7f3 Fixed non-unity build
#preflight skip
#rb none
#rnx

#ROBOMERGE-OWNER: jamie.dale
#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 21277722 via CL 21285961 via CL 21285981 via CL 21286112
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21290435 by jamie dale in ue5-main branch]
2022-08-09 12:16:16 -04:00
jamie dale
a84ca6fb32 Moved some object-centric transaction APIs out of Core and into CoreUObject
The following types have moved to ITransactionObjectAnnotation.h:
- ITransactionObjectAnnotation

The following types have moved to TransactionObjectEvent.h:
- FTransactionObjectDeltaChange
- ETransactionObjectEventType
- FTransactionObjectEvent
- FTransactionDiff

#preflight 62f141b7086f90bbc473f631, 62f1351a904c243122f5eacd
#rb Francis.Hurteau, Rex.Hill

#ROBOMERGE-OWNER: jamie.dale
#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 21272390 via CL 21285937 via CL 21285973 via CL 21286088
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21290425 by jamie dale in ue5-main branch]
2022-08-09 12:16:06 -04:00
Catalin Dragoiu
d69fb31520 [Insights] Table Import Tool initial implementation
#rb Ionut.Matasaru
#preflight 62f274a40264595302ee9cd9

[CL 21289407 by Catalin Dragoiu in ue5-main branch]
2022-08-09 11:43:04 -04:00
paul chipchase
38ad29096c The DumpPackagePayloadInfo console command now accepts fullobject paths as args as well as filepaths.
#rb trivial
#jira UE-160497
#rnx
#preflight 62f263c43b773d041627830f

[CL 21287990 by paul chipchase in ue5-main branch]
2022-08-09 10:47:23 -04:00
paul chipchase
07ddbfa4f5 Add a config file option to allow payloads stored in .umap and associated "_builddata.uasset" files to be filtered from the virtualization process. This option defaults to true.
#rb Per.Larsson
#jira UE-156750
#rnx
#preflight 62f212e13b773d04161ee7dd

### Problem
- The payloads stored in map files tend to change more than other assets and would cause a lot more churn in the VA system.
- Some other systems like the landscape component are not able to sensibly continue if their payloads cannot be accessed (heightmaps for exmaple) and would prefer not to allow virtualization.
- As a short term fix we need an option to disable the virtualization on all payloads in map files. Future improvements to the filtering system will allow systems to more easily opt their payloads out of virtualization. When this is functional we might want to change the default from true to false.

### Feature
- The config optionf for this filtering is "[Core.VirtualizationModule]FilterMapContent=True"
- Testing if the owning UObject for a payload is in a umap can get tricky, because we not only need to check the umap but we also need to check if it is in a "_builddata.uasset" file, which is an additional file we store next to a umap containing things like lightmaps etc.
- At the moment we check for this by finding the outermost object for the given owner and check to see if it is a ULevel, UWorld or UMapBuildDataRegistry. This is a bit of a kludge but the types we need to check against are not accessible by this module and making them accessible will pull in a lot of dependencies that we'd prefer not to add.
-- One improvement might be to tag the FLinkerSave with the info we need and passing that into the serialization process rather than trying to work it out ourselves but I am wary of making that change until we are 100% sure that we want to keep this feature.

### Refactor
- Removed IVirtualizationSystem::IsDisabledForObject and replaced it with ::FilterPayload which can return multiple reasons for preventing a payload from virtualizing. (the method was added during 5.1 development so it should be fine to just replace it without deprecation)
-- The original behaviour for FVirtualizationManager::IsDisabledForObject has been moved to FVirtualizationManager::ShouldVirtualizeAsset
- Added a new header to declare enums/types used by the various parts of the virtualization system and started by moving EPayloadFilterReason there from the package trailer header. This allows both the core API and PackageTrailer to use EPayloadFilterReason without creating overburdened header dependencies.
-- EPayloadFilterReason has moved from the UE namespace to UE::Virtualization so the package trailer code needed updating accordingly.
- EditorBulkData will ask the virtualization system for the base filter reason, then add it's own reasons if UE_ENABLE_VIRTUALIZATION_TOGGLE is enabled. This bit of code will be removed for 5.1

[CL 21283179 by paul chipchase in ue5-main branch]
2022-08-09 07:51:55 -04:00
nick brett
be3323e0db [UE][FEATURE] PhAT Constraint Transform Editing
- Enable users to view and edit the parent and child frame transforms of constraints in the PhAT details panel
- Constraint transforms are represented as a position and a rotator in the details panel (internally they are represented as a position and a pair of orthonormal vectors)
- Constraint transforms can optionally be displayed in the frame of the assocaited bone OR relative to the default (snapped) transforms
- Allow parent / child transform position / orientation componenets to be 'snapped' to defaults individually
- Support using modifier keys to manipulate only the child frame transform via a viewport widget

#jira UE-119744
#jira UE-119741
#rb [at]Thomas.Sarkanen, [at]sebastian.nordgren
#preflight 62f13b9a23003b62a3d4c277

#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 21282618 via CL 21282632 via CL 21282638
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21283069 by nick brett in ue5-main branch]
2022-08-09 07:30:26 -04:00
sara schvartzman
897cf294b1 Control Rig: Fix crash when undoing collapse function references
#jira UE-159919
#rb helge.mathee
#preflight 62f139b7d834fe6ee78ff81d

[CL 21282179 by sara schvartzman in ue5-main branch]
2022-08-09 05:01:30 -04:00
sara schvartzman
5d52a11107 Control Rig: Fix crash when copy pasting template node
#jira UE-159896
#rb helge.mathee
#preflight 62f127ec185da2495f7b3e81

[CL 21282129 by sara schvartzman in ue5-main branch]
2022-08-09 04:58:19 -04:00
danny couture
88831798ee Fix potential fatal error when saving a package with skeletal mesh still being loaded asynchronously
#jira UE-160451
#rb PJ.Kack, Francis.Hurteau
#preflight 62f12822086f90bbc46e1542

[CL 21270851 by danny couture in ue5-main branch]
2022-08-08 12:57:01 -04:00
Yujiang Wang
f6dc5c0058 Make sure every uniform buffer name in shader optional data is a valid name, i.e. no more "None"-s. Usually it's $Global being removed
#rb laura.hermanns
#preflight 62f1216bd76ea4b503e25128

[CL 21269863 by Yujiang Wang in ue5-main branch]
2022-08-08 12:01:59 -04:00
luc eygasier
4d284a4bc9 Fixes adding newfiles to Uncontrolled Changelist offline mode when Source Control is disabled.
Fixes Deleted new assets staying in Uncontrolled Changelist.

#rb Patrick.Enfedaque
#preflight 62d9608f3122bf80aefecd30

#changelist validated

#ROBOMERGE-AUTHOR: luc.eygasier
#ROBOMERGE-SOURCE: CL 21267809 via CL 21267821 via CL 21267830
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21269698 by luc eygasier in ue5-main branch]
2022-08-08 11:50:31 -04:00