Commit Graph

200 Commits

Author SHA1 Message Date
charles bloom
ab5bc4c973 TextureCompressorModule : fix bug with MaxTextureSize on images with more than 1 slice (cubes, arrays)
bump DDC key for affected textures
bug introduced in CL 31470247
#rb Dan.Thompson

[CL 32105201 by charles bloom in ue5-main branch]
2024-03-07 18:16:29 -05:00
dan thompson
2ed61a6050 Updating FCompressedImage2D to NumSlices from SizeZ, for clarity.
Tested cooked build diff for sanity as this should only ever affect in-memory editor values.

#jira UE-149124
#rb fabian.giesen

[CL 31997496 by dan thompson in ue5-main branch]
2024-03-04 14:39:15 -05:00
charles bloom
8d76e1c458 ImageCore: more resize filter options (Lanczos)
make DownscaleOptions Default pass through without changing to SimpleAverage for new filters
map DownscaleOptions to better resize filters
#rb Dan.Thompson, fabian.giesen

[CL 31916433 by charles bloom in ue5-main branch]
2024-02-29 13:40:21 -05:00
charles bloom
abeccccd75 TextureCompressorModule : if CanAcceptNonF32Source allow all formats to pass through, not just BGRA8
#rb martins.mozeiko

[CL 31869377 by charles bloom in ue5-main branch]
2024-02-28 08:36:35 -05:00
charles bloom
4b4e8649bd TextureCompressorModule::GetOutputAlphaFromKnownAlphaOrFallback to clean up common patterns of trying to query alpha
TextureFormatOodle : yes you can free the float mip immediately because hashing is no longer on an async task
FImage::FreeData with async detach option
validate VT sizes better to prevent crashes

#jira UE-183888

#rb dan.thompson, fabian.giesen

[CL 31815947 by charles bloom in ue5-main branch]
2024-02-26 16:02:58 -05:00
charles bloom
49896082b2 TextureCompressorModule use ResizeImage for MaxTextureResolution so we can resize directly from source to dest size
bump DDC key for change in output of MaxTextureResolution affected textures
Also free source images and temporaries as they are consumed and no longer needed to reduce peak mem use
In the nop case, move the image instead of copying
#rb Dan.Thompson
#jira UE-204167

[CL 31470270 by charles bloom in ue5-main branch]
2024-02-14 09:06:31 -05:00
charles bloom
bc627b53db Texture fix GetBuildRequiredMemoryEstimate was not accounting for pow2 pad options
causing it to under-estimate memory use in some cases
move GetPowerOfTwoTargetTextureSize to TextureBuildUtilities so it can be shared
fix some comments

#rb Dan.Thompson, fabian.giesen

[CL 30943675 by charles bloom in ue5-main branch]
2024-01-26 17:19:20 -05:00
dan thompson
4b50d4927e Undoing backout - this was depending on the original issue, not an issue in and of itself. This does also correct a separate issue with the texture editor using the removed metadata information.
Removing texture build metadata due to ddc complexities. It will be added to the metadata system in the new build flow SoonTM. Additionally, the alpha information for the source mips is no longer necessary as that is computed elsewhere now.
#rb fabian.giesen
#jira UE-183750

[CL 30894760 by dan thompson in ue5-main branch]
2024-01-25 14:17:55 -05:00
dan thompson
47c94de653 Testing the alpha detection based on the channel source info. This CL incorporates the original 30692988 as well as the fixes under review 30729887. The base problem is a race condition touching the lock mip data - read only mip locking shoulid if at all possible favor the MipData interface rather than LockMip*. RB list is from the two input CLs.
#rb fabian.giesen
#jira UE-204348

[CL 30785833 by dan thompson in ue5-main branch]
2024-01-22 16:36:00 -05:00
evgenii babinets
40709a976b [Backout] - CL30692988
[FYI] Dan.Thompson
Original CL Desc
-----------------------------------------------------------------
Testing the alpha detection based on the channel source info.
#rb fabian.giesen
#jira UE-175146

[CL 30772929 by evgenii babinets in ue5-main branch]
2024-01-22 10:15:58 -05:00
evgenii babinets
8f67c5bef7 [Backout] - CL30697260
[FYI] Dan.Thompson
Original CL Desc
-----------------------------------------------------------------
Removing texture build metadata due to ddc complexities. It will be added to the metadata system in the new build flow SoonTM. Additionally, the alpha information for the source mips is no longer necessary as that is computed elsewhere now.
#rb fabian.giesen
#jira UE-183750

[CL 30772772 by evgenii babinets in ue5-main branch]
2024-01-22 10:12:42 -05:00
dan thompson
99e50792ea Removing texture build metadata due to ddc complexities. It will be added to the metadata system in the new build flow SoonTM. Additionally, the alpha information for the source mips is no longer necessary as that is computed elsewhere now.
#rb fabian.giesen
#jira UE-183750

[CL 30697278 by dan thompson in ue5-main branch]
2024-01-18 16:38:20 -05:00
dan thompson
48136a6f1f Testing the alpha detection based on the channel source info.
#rb fabian.giesen
#jira UE-175146

[CL 30693168 by dan thompson in ue5-main branch]
2024-01-18 14:54:53 -05:00
charles bloom
e259c1cc1f Texture fix some logic treating long-lat cubemaps as nonpow2 when they are in fact always pow2 after building even if source was nonpow2
Also make the default import settings of using no mip maps for nonpow2 textures only apply to 2d textures

#rnx
#rb fabian.giesen

[CL 30574965 by charles bloom in ue5-main branch]
2024-01-11 14:53:06 -05:00
charles bloom
3a4e13401f ImageCore ScaleChannelsSoMinMaxIsInZeroToOne replicates the behavior of the RenderTarget UNorm ReadPixels modifier
scales image outside [0,1] so that it is inside
uses ImageParallelFor

#rnx

[CL 30130491 by charles bloom in ue5-main branch]
2023-12-05 15:01:49 -05:00
charles bloom
0ccd098e9c TextureCompressorModule : fast path for common SourceEncoding conversions
sRGB conversion is 2X faster just because it is one pass over the image instead of two

#rnx

[CL 29480364 by charles bloom in ue5-main branch]
2023-11-05 10:37:37 -05:00
charles bloom
f7f6576b6d Texture Downscale use new ResizeImage, if NewFilter
#rb jon.olick
#rnx

[CL 29426689 by charles bloom in ue5-main branch]
2023-11-03 18:32:37 -04:00
charles bloom
cf6ad9f1c2 Texture: make stretch-to-pow2 use new ResizeImage
bump ddc key for affected textures

#rnx
#rb fabian.giesen

[CL 29369767 by charles bloom in ue5-main branch]
2023-11-02 12:42:56 -04:00
charles bloom
92e4e91612 nop comments only; mark some of the bad image resizers in UE and redirect users to the new ResizeImage
not actually deprecated yet, need to keep legacy behavior to avoid patches
todo actually remove use of the old resize functions and deprecate them

#jira UE-163527
#rnx

[CL 29248582 by charles bloom in ue5-main branch]
2023-10-30 16:35:55 -04:00
alexander suvorov
795fd1edf1 Implement Resize to Specific Resolution texture padding and resizing option.
#jira UE-158070
#rb Dan.Thompson

[CL 28425273 by alexander suvorov in ue5-main branch]
2023-10-03 14:56:03 -04:00
alexander suvorov
7d23806b95 Implement PadWithBorderColor texture setting.
#jira UE-158070
#rb Dan.Thompson

[CL 28253332 by alexander suvorov in ue5-main branch]
2023-09-26 18:49:57 -04:00
Szmyk
1b7d725edc Fix for typo in non pow2 volume texture mip count computation.
#jira UE-196278
#10907
#rb fabian.giesen

[CL 28201841 by Szmyk in ue5-main branch]
2023-09-25 15:54:57 -04:00
alexander suvorov
56126d98a9 Add Stretch to Power Of Two mode in Texture Settings.
#jira UE-160620
#rb Dan.Thompson

[CL 27575466 by alexander suvorov in ue5-main branch]
2023-09-01 21:44:43 -04:00
dan thompson
bb9bc58b72 CPU accessible textures
#rb fabian.giesen
#rb charles.bloom

[CL 26655002 by dan thompson in ue5-main branch]
2023-07-27 16:46:23 -04:00
eric renaudhoude
c0e4318bcb ColorManagement: Fixed DDC2 texture build for advanced source color/encoding settings, added dependency on OpenColorIO library version for key invalidation.
#jira UE-188952
#rb dan.thompson

[CL 26442009 by eric renaudhoude in ue5-main branch]
2023-07-18 14:44:35 -04:00