Commit Graph

4695 Commits

Author SHA1 Message Date
leigh swift
aa8aefd04d Add support for BPT ChunkDeltaOptimise 'DiffAbortThreshold' commandline param to automation code.
[CODEREVIEW] William.Ewen

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: leigh.swift
#ROBOMERGE-SOURCE: CL 5502459 via CL 5503111 via CL 5535519
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5538898 by leigh swift in Dev-VR branch]
2019-03-25 16:59:55 -04:00
sorin gradinaru
a1869bee9e UE-66204 iOS and tvOS errors in Application Loader to Apple: 'Invalid Code Signing Entitlements' with iCloud
#jira UE-66204
#4.22
#iOS
#rb Jack.Porter
#lockdown cristina.riveron


Fixed a problem with the order of values in the  com.apple.developer.icloud-container-environment array

Also modified parsing com.apple.developer.ubiquity-container-identifiers and com.apple.developer.ubiquity-kvstore-identifier in order to preserve the team id from the mobileprovisioning

Note:iPhonePacvkager needs to be recompiled + binaries uploaded on //UE4/Release-4.22/Engine/Binaries/DotNET/IOS

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: sorin.gradinaru
#ROBOMERGE-SOURCE: CL 5533538 in //UE4/Release-4.22/... via CL 5533539
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5535136 by sorin gradinaru in Dev-VR branch]
2019-03-25 13:08:20 -04:00
ben marsh
0f5aa45c32 Fix problems with HotReload on Mac.
* Linker arguments for each hot-reloaded module where only being patched with that module's new name (and not *all* the new module names). Windows was unaffected by this, since it uses response files (which were being handled correctly).
* Loop to rename modules in the manifest was terminating after the first modified module was found. This prevented other modules from being renamed.

#rb none
[FYI] Steve.Robb, Michael.Trepka
#jira UE-62612

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5503573 in //UE4/Release-4.22/... via CL 5503574
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5518591 by ben marsh in Dev-VR branch]
2019-03-22 18:55:51 -04:00
andrew grant
e038bcf2c4 Moved param validation to common code
Added -flavor check to BuildCookFort


#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 5501854 via CL 5501865 via CL 5502958 via CL 5503140
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5518140 by andrew grant in Dev-VR branch]
2019-03-22 18:52:14 -04:00
ben marsh
9efba077b3 Simplify error messages for UE4Build, so we don't get unnecessary lines tagged by EC.
#jira

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5501618 via CL 5501622 via CL 5501811 via CL 5501820
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5518028 by ben marsh in Dev-VR branch]
2019-03-22 18:51:26 -04:00
ben marsh
8397b2c846 Remove superfluous errors when a recursive UAT command fails, or a child process fails. They should already output their own error messages, and adding additional errors is just noise.
#jira

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5496878 via CL 5496883 via CL 5499236 via CL 5499309
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5516690 by ben marsh in Dev-VR branch]
2019-03-22 18:26:00 -04:00
bob tellez
d84630af91 #UE4 Disable warning while we wait for a key cycle
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 5493785 via CL 5495889 via CL 5496062
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5515897 by bob tellez in Dev-VR branch]
2019-03-22 18:08:05 -04:00
andrew grant
c67400398b Moved dsymutil with fix for large sizes into Binaries for the time being so people with Xcode installed don't need to also set up autosdks
michael.trepka

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 5492294 via CL 5492301 via CL 5493068 via CL 5493122
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5515524 by andrew grant in Dev-VR branch]
2019-03-22 18:03:00 -04:00
ben marsh
8246d5a1df Fix log output showing CL being synced for iterative cooks.
#jira
[FYI] Jeff.Williams

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5491806 via CL 5492141 via CL 5492157
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5514730 by ben marsh in Dev-VR branch]
2019-03-22 17:57:13 -04:00
sorin gradinaru
7f0aa97acc UE-71596 iOS packaging error with CloudKit enabled - Provisioning profile <...> doesn't match the entitlements file's values
#jira UE-71596
#4.22
#iOS
#tvOS
#rb Jack.Porter
#lockdown cristina.riveron

Write the entitlements in PostBuldSync.
Target.bCreateStubIPA is false when building on mac, true on windows (using the -CreateStub argument)

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: sorin.gradinaru
#ROBOMERGE-SOURCE: CL 5491331 in //UE4/Release-4.22/... via CL 5491335
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5514614 by sorin gradinaru in Dev-VR branch]
2019-03-22 17:55:50 -04:00
graeme thornton
411ff454fd Use accessor function on crypto settings in UAT to determine if signing is enabled, rather than reading the flag directly. Makes sure that signing is correctly disabled if the setting is enabled but no key was set
#rb ben.marsh
#jira UE-71803
#lockdown cristina.riveron

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: graeme.thornton
#ROBOMERGE-SOURCE: CL 5487901 in //UE4/Release-4.22/... via CL 5487905
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5510164 by graeme thornton in Dev-VR branch]
2019-03-22 17:26:08 -04:00
graeme thornton
ab42f2f4ec Add new config values to go alongside "PlatformRequiresDataCrypto" which can specifically disable signing or encryption. Allows selective disabling of signing OR encryption on some platforms, rather than the old config value which would disable both.
Disable signing on platforms that we wanted encryption enabled for by default (mobile mainly)
Add a warning if pak signing or encryption is enabled but there is no key, then disable the offending functionality for that build

#rb none
#jira UE-71811, UE-71806
#lockdown cristina.riveron

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: graeme.thornton
#ROBOMERGE-SOURCE: CL 5487098 in //UE4/Release-4.22/... via CL 5487102
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5509409 by graeme thornton in Dev-VR branch]
2019-03-22 17:21:46 -04:00
chris babcock
f87e5007e7 Fix logging of store version
#rb none
[FYI] Andrew.Grant

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: chris.babcock
#ROBOMERGE-SOURCE: CL 5481418 via CL 5481426 via CL 5484531 via CL 5484535
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5507481 by chris babcock in Dev-VR branch]
2019-03-22 17:12:11 -04:00
andrew grant
e1c8c2b7c8 Added some logging around Android symbol generaton
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 5469194 via CL 5469197 via CL 5470751 via CL 5470757
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5505416 by andrew grant in Dev-VR branch]
2019-03-22 17:00:12 -04:00
graeme thornton
a56af60239 Edigrated rollup of all engine RSA changes that were done for 4.22. Pak signature checking is now much more competent.
#rb none
[FYI] joe.barrett
#rnx

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: graeme.thornton
#ROBOMERGE-SOURCE: CL 5469067 via CL 5469119 via CL 5470585 via CL 5470597
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5505344 by graeme thornton in Dev-VR branch]
2019-03-22 16:59:55 -04:00
andrew grant
eae72658e7 Fixed issue with UBTArgs including quotes.
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 5460234 via CL 5462256 via CL 5462315
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5480498 by andrew grant in Dev-VR branch]
2019-03-20 13:56:15 -04:00
ben marsh
f51b07e8f9 Fix missing plugin error at startup.
#jira

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5459335 via CL 5461952 via CL 5462074
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5480322 by ben marsh in Dev-VR branch]
2019-03-20 13:52:14 -04:00
ben marsh
c27594562e UBT: Make mismatched supported target platforms an error.
#jira

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5459241 via CL 5460114 via CL 5460172
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5480307 by ben marsh in Dev-VR branch]
2019-03-20 13:51:42 -04:00
ben marsh
a947a59b4f Add a warning when a plugin reference overrides the plugin's list of supported target platforms. Silently failing at build time will cause errors at runtime.
[FYI] Justin.Marcus
#jira

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5459133 via CL 5459920 via CL 5460056
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5479786 by ben marsh in Dev-VR branch]
2019-03-20 13:48:20 -04:00
andrew grant
fc290eea43 Added some verbose logging when copying Kairos files
Fixed some case checks
Made -config param optional

[FYI] daniel.lamb

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 5459100 via CL 5459911 via CL 5460034
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5479740 by andrew grant in Dev-VR branch]
2019-03-20 13:48:06 -04:00
ben marsh
8281e6e108 Fix exception when hot-reloading a module that contains an additional bundle resource. List of hot-reload build products for each module now only includes import library and DLL.
#rb none
#jira UE-71692

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5458343 in //UE4/Release-4.22/... via CL 5458360
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5476657 by ben marsh in Dev-VR branch]
2019-03-20 13:27:20 -04:00
sorin gradinaru
250b26739b UE-52346 TM-Gameplay: Load Level Volume Fails to Read TestSlot.sav file
#jira UE-52346
#iOS
#tvOS
#rb Jack.Porter

Created a pList key named ICloudContainerIdentifier to be used at run-time when intializing the CloudKit services

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: sorin.gradinaru
#ROBOMERGE-SOURCE: CL 5448858 in //UE4/Release-4.22/... via CL 5448862
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5471394 by sorin gradinaru in Dev-VR branch]
2019-03-20 13:01:03 -04:00
ben marsh
cfe608feb7 UBT: Disable the "bAdaptiveUnityDisablesPCH" build flag by default. This significantly improves iteration times on individual files, at the risk of introducing missing headers. Will validate this in CIS instead.
#rb none
#jira

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5447578 in //UE4/Release-4.22/... via CL 5447579
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5471223 by ben marsh in Dev-VR branch]
2019-03-20 13:00:26 -04:00
graeme thornton
f9123f5f24 Created a new interface to RSA functionality that is independent of key size (unlike the old TBigInt version). Internally, RSA functions are implemented by OpenSSL on Windows/Mac/Linux an falling back to the TBigInt implementation for other platforms
- Future plan would be not to use OpenSSL directly, but to go via PlatformCrypto or something like it which could provide platform specific RSA functionality if it exists
- Also contains some compensation code for platforms that are still stuck on an older version of OpenSSL (everything except windows)
- On platforms that use OpenSSL < 1.1.1, register a locking callback so we can provide mutexes and stop it crashing horribly when the same RSA key is used concurrently on different threads

Changed default key size in the CryptoKeys plugin to 4096 bits.

#jira UE-71377
#rb ian.fox, robert.manuszewski, ryan.gerleve

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: graeme.thornton
#ROBOMERGE-SOURCE: CL 5447433 in //UE4/Release-4.22/... via CL 5447485
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5447722 by graeme thornton in Dev-VR branch]
2019-03-19 09:01:04 -04:00
jules blok
f052c97b89 Escape all paths when generating VS project filter files
#jira UE-71727
#rb Jack.Porter

#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: jules.blok
#ROBOMERGE-SOURCE: CL 5439949 in //UE4/Release-4.22/... via CL 5439986
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)

[CL 5443382 by jules blok in Dev-VR branch]
2019-03-19 01:06:29 -04:00