Commit Graph

96 Commits

Author SHA1 Message Date
Jurre deBaare
2448a4f237 Static analysis fixes
#jira none
#rb trivial
#preflight 637df3e2f514e1ded95e3b4c

[CL 23247071 by Jurre deBaare in ue5-main branch]
2022-11-23 05:38:28 -05:00
henrik karlsson
b5164ac775 Fixes to make modules compile with IWYU. We've added to IWYU toolchain so it compiles "orphaned" headers which does not have a owning cpp file. This identified lots of headers that couldn't be compiled by themselves (or if they were to included first)
Change consist of only forward declaration and additional includes

#preflight 63789c1de30d438849c48188
#rb none

[CL 23218412 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:23 -05:00
Jurre deBaare
3252094e90 Fixup unacceptable string wording
#jira none
#preflight 63776906815e4b9b75413668

[CL 23192158 by Jurre deBaare in ue5-main branch]
2022-11-18 06:21:54 -05:00
Jurre deBaare
a5305f76a3 Contributed by Yupeng.Zhang from The Coalition:
Animation Modifier : Fix Modifier on Skeleton
Transfered the ownership of 'PreviouslyAppliedModifier' from an animation modifier instance to the animation sequence being applied.
This solved the following issue:
- Modifier on Skeleton cause USkeleton dirtied everytime the modifier is applied to an animation sequence.
- Modifier on Skeleton cannot be re-apply or reverted correctly.
- CanRevert & OutOfDate status for Modifier on Skeleton was not reflect the true status of all animation sequences referencing that skeleton.

- CurrentAnimSequence/CurrentSkeleton was not set on OnRevert()
- IAnimationDataController::FScopedBracket was not open on OnRevert() before re-apply modifier
- Stateful animation modifier can now be reverted correctly (Applied modifier instance is nolonger reverted after OnApply call)

#preflight 63775e0ff514e1ded99ef095

[CL 23191977 by Jurre deBaare in ue5-main branch]
2022-11-18 05:35:47 -05:00
Jurre deBaare
782976dbe4 Crash in UAnimSequence::GetBonePose after adding curve with UAnimationBlueprintLibrary::AddCurve with Anim Modifier
#jira UE-166435
#fix remove scope bracket around application of ANimationModifier, moving responsibility to the user

Curve keys added with Anim Modifiers have incorrect time
#jira UE-166436
#fix ensure that when adding a scalar curve, its tick rate is matched to the AnimModel's, and convert between tick-rate and model frame rate when setting keys

#rb Aaron.Cox
#preflight 6346de84663dafe4162d9485

[CL 22500269 by Jurre deBaare in ue5-main branch]
2022-10-13 05:54:31 -04:00
jose villarroel
982346095f Non-unity build fix
#rb trivial
#preflight 6332d1bdc7791417aab0a100
#rnx

[CL 22217630 by jose villarroel in ue5-main branch]
2022-09-27 23:52:04 -04:00
marc audy
cea63473a7 [Backout] - CL22206223
#fyi jurre.debaare
#horde 218123,218081,218073,218063,218057,217995,217831,217939
Original CL Desc
-----------------------------------------------------------------
REDO: UEFN - Users are able to apply Animation Modifiers via the right-click context menu
#fix moved animation modifier menu section into module itself - gated by whether or not AnimationModifier class is allowed
#rb Thomas.Sarkanen
#preflight 6332c289a4769ad714e78a8c

[CL 22217414 by marc audy in ue5-main branch]
2022-09-27 23:06:31 -04:00
jurre debaare
4f8c9cc5fc REDO: UEFN - Users are able to apply Animation Modifiers via the right-click context menu
#fix moved animation modifier menu section into module itself - gated by whether or not AnimationModifier class is allowed
#rb Thomas.Sarkanen
#preflight 6332c289a4769ad714e78a8c

[CL 22206223 by jurre debaare in ue5-main branch]
2022-09-27 10:55:17 -04:00
cbrandtieng
98d904fd1f PR #9136: Adding a setting for animation modifiers to reapply post owner change (Contributed by cbrandtieng)
#rb Thomas.Sarkanen
#preflight 6315e8c8ec45fbf3d7b0dd92

[CL 21791261 by cbrandtieng in ue5-main branch]
2022-09-05 08:28:49 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
jurre debaare
28d866e5be Undo changelist 21456941
Original description:
UEFN - Users are able to apply Animation Modifiers via the right-click context menu
#fix moved animation modifier menu section into module itself - gated by whether or not AnimationModifier class is allowed
#preflight 62ff59569835a27d8d9a4a2c
#rb Thomas.Sarkanen

[CL 21499937 by jurre debaare in ue5-main branch]
2022-08-22 21:22:25 -04:00
jurre debaare
1f623574f2 UEFN - Users are able to apply Animation Modifiers via the right-click context menu
#fix moved animation modifier menu section into module itself - gated by whether or not AnimationModifier class is allowed
#preflight 62ff59569835a27d8d9a4a2c
#rb Thomas.Sarkanen

[CL 21499924 by jurre debaare in ue5-main branch]
2022-08-22 21:21:42 -04:00
bryan sefcik
98b51354ed Ran IWYU on Public headers under Engine/Source/Editor/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065253 by bryan.sefcik
#jira
#preflight 62d5b3e91062f2e63014598e

#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21152630 via CL 21156388 via CL 21157044
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21181817 by bryan sefcik in ue5-main branch]
2022-07-20 11:56:29 -04:00
Robb Surridge
0a5a02c5b2 Coding standard fixes: gender-inclusive language
#jira UE-156429
#preflight 62b32e826a25ba6ae52f94bd
#rb jason.walter

[CL 20795375 by Robb Surridge in ue5-main branch]
2022-06-23 11:14:07 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
Matt Peters
c1b46b1fed FAssetData: Callsites need to handle AssetData.GetClass() returning null. Added IsInstanceOf(UClass*) for the common operation GetClass() && GetClass->IsChildOf(BaseClass).
#jira UE-146521
#rb Zousar.Shaker
#rnx
#preflight 623874b789625f06129e466b

[CL 19450936 by Matt Peters in ue5-main branch]
2022-03-21 09:00:36 -04:00
jurre debaare
fa330baae5 Warning in FortniteEditor Static Analysis Win64 (PVS-Studio): animationmodifier.cpp(103): warning V595: The 'CurrentAnimSequence' pointer was utilized before it was verified
#fix integrating 17963104 and 17948236 to address AnimModifier.cpp static-analysis warnings
#rb none
#preflight 61d6dda0c65e66487b273948

#ROBOMERGE-OWNER: jurre.debaare
#ROBOMERGE-AUTHOR: jurre.debaare
#ROBOMERGE-SOURCE: CL 18532919 via CL 18532974 via CL 18533065 via CL 18533541 via CL 18534001
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18534191 by jurre debaare in ue5-release-engine-test branch]
2022-01-06 14:19:52 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
aurel cordonnier
7f517562d5 Merge from Release-Engine-Staging @ 17438845 to Release-Engine-Test
This represents UE4/Main @17430120 and Dev-PerfTest @17437669

[CL 17439044 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-06 12:23:53 -04:00
julien stjean
e3fb173774 Fixed Static analysis issues in interchange (fbxmesh.h) by changing the function GetMeshUniqueID from FbxHelper to return a empty string when the mesh is empty.
[FYI] Richard.TalbotWatkings

Fixed Static analysis in AnimationModifier.cpp the CurrentAnimSequence ptr can't be null since it was deferenced at the line 75.

Fixed Static analysis in PackageStoreOptimizer for some reason the static analysis did like the way the check was presented.

Fixed Static analysis in SComponentClassCombo.cpp and SDisplayClusterConfiguratorComponentCombo.cpp changed the code so that the static analyser should understand it better.

#jira UE-120410
#rb Jean.MichelDignard

#ROBOMERGE-SOURCE: CL 17071360 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v853-17066230)

[CL 17071396 by julien stjean in ue5-release-engine-test branch]
2021-08-05 13:15:23 -04:00
jurre debaare
69a7c18269 Option to apply Animation Modifiers to only new or changed animations
#feature add ability to only apply out-of-date animation modifiers from asset context menu, and through details view on AnimationModifier classes
#fix ensure that we do not apply pending kill modifiers or instances that are used for reverting
#jira UE-84819
#rb Thomas.Sarkanen
#preflight 60cb38fd6092ba000140842e

#ROBOMERGE-SOURCE: CL 16704034 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16704042 by jurre debaare in ue5-release-engine-test branch]
2021-06-17 09:50:18 -04:00