Commit Graph

554 Commits

Author SHA1 Message Date
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
jurre debaare
efbc802629 Preview Additional Meshes doesn't copy curves from source skelmesh
#fix ensure that the native copy-pose node inside of AnimPreviewAttacheInstance has the 'Copy Curves' flag set
#jira UE-148236
#rb Thomas.Sarkanen
#preflight 6266bd250634d0904ce276de

#ROBOMERGE-AUTHOR: jurre.debaare
#ROBOMERGE-SOURCE: CL 19917005 in //UE5/Release-5.0/... via CL 19917380
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 19917945 by jurre debaare in ue5-main branch]
2022-04-26 07:14:33 -04:00
thomas sarkanen
3aa0ff6d93 Fixed crash opening an anim BP with an aim offset graph connected
#jira UE-148644
#jira UE-148642
#rb Jurre.deBaare
#preflight 62611e92375115ece306a43b

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 19845943 in //UE5/Release-5.0/... via CL 19846273
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19846641 by thomas sarkanen in ue5-main branch]
2022-04-21 07:06:44 -04:00
frederick lupien
86374f2cb0 Added a distinction in color and title between linked anim layer & self anim layer anim nodes.
Self anim layer are now titled Anim Layer (self) instaed of Linked anim layer

#rb Thomas.Sarkanen
#tests editor

#ROBOMERGE-AUTHOR: frederick.lupien
#ROBOMERGE-SOURCE: CL 19630124 via CL 19636027 via CL 19640541 via CL 19641080 via CL 19641168
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19642090 by frederick lupien in ue5-main branch]
2022-04-06 00:23:18 -04:00
thomas sarkanen
8d1de28971 Fix crash in cooked builds where references to editor-only properties were left in anim BP bytecode
This was inadvertenly caused by CL 19250839 that renamed some generated properties to that of the same name as an anim node property (BlendSpace - they used to be called ObjectProperty). Then the code that expanded anim nodes to link up BP logic left a 'set struct member to null' behind because the generated member name matched the pin on the anim graph node.
This fix switches generated members to have a "__" prefix to avoid collisions with user properties, as well as fixing the code on expansion to check the correct property name, which will cause the 'set struct member to null' node to not be left in the exec path.


#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 19568495 via CL 19568548 via CL 19568614 via CL 19568625 via CL 19568631
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v937-19513599)

[CL 19568916 by thomas sarkanen in ue5-main branch]
2022-03-30 23:02:36 -04:00
Phillip Kavan
f64e3e18d7 Some minor refactoring to assist with auto-importing external type object dependency namespaces into the Blueprint editor context in response to user actions.
Change summary:
- Moved base definition of UK2Node::HasExternalDependencies() up one level to UEdGraphNode (to avoid blind casts in a context where we may not necessarily have a UK2Node subtype).
- Updated subtype headers that override HasExternalDependencies() to relocate the declaration into the class declaration's 'UEdGraphNode overrides' section (for clarity).
- Reverted previous UBlueprintNodeSpawner::ImportTarget solution in favor of using node dependencies; this allows auto-import actions to scale more easily to all existing node subtypes and avoids data duplication.
- Modified SBlueprintActionMenu::OnActionSelected() to utilize the new method for determining which namespace(s) to auto-import after executing a node spawner action in response to a context menu item selection (UE-146803).
- Reverted FBlueprintNamespaceUtilities::GetPropertyValueNamespaces() back to its original 5.0 signature so that it uses a TSet<FString> for the output rather than a TArray<FString>; this fits in better with input to other APIs.
- Renamed FBlueprintEditor::FImportNamespaceParameters to FImportNamespaceExParameters (for clarity).
- Changed the 'FBlueprintEditor::FImportNamespaceParameters::AdditionalNamespaces' member to a TSet<FString> containing *all* namespaces to import rather than limiting to only additional ones.
- Reverted FBlueprintEditor::ImportNamespace() back to its original 5.0 signature and added/implemented FBlueprintEditor::ImportNamespaceEx() as the "extended" version that allows for batched imports and future customizations.
- Revised existing FBlueprintEditor::ImportNamespace() call sites to utilize and/or conform to the extended ImportNamespaceEx() API where appropriate.

#jira UE-146803
#rb Benjamin.Fox
#preflight 623cf3a433709ff50128e8d4

[CL 19505118 by Phillip Kavan in ue5-main branch]
2022-03-24 19:50:46 -04:00
daren cheng
9f0b63a667 Move BP extensions to private, expose getters / setters instead.
#rb Phillip.Kavan, Patrick.Boutot
#preflight 623b95b99304d833f4105401
#jira UE-145133

[CL 19487374 by daren cheng in ue5-main branch]
2022-03-23 18:12:22 -04:00
jurre debaare
524ceab54b Non-looping Montage animations pop and don't finish their playback duration in previewer
#fix ensure that blending (in/out) multiplier for montage instance is zero-ed (matching old behaviour)
#rb Thomas.Sarkanen
#preflight 62333348ef5d0f0e8f03a13e

#ROBOMERGE-AUTHOR: jurre.debaare
#ROBOMERGE-SOURCE: CL 19421374 via CL 19421402 via CL 19422905 via CL 19429327 via CL 19429393
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v930-19419903)

[CL 19432575 by jurre debaare in ue5-main branch]
2022-03-18 02:34:06 -04:00
halfdan ingvarsson
2797a0a1c5 Remove the Pose Driver's 'experimental' label. It's been around long enough.
#jira UE-144549
#rb david.corral
#preflight 6233a026e14776a6ebc27cee

[CL 19427186 by halfdan ingvarsson in ue5-main branch]
2022-03-17 17:12:24 -04:00
nick brett
053fcb090f [UE][FIX] cyclic module dependency introduced with CL-19283727
- Revert change to AnimGraph.Build.cs
- Introduce new abstract interface for Physics Assert Render functions called from the AnimGraph module

[REVIEW] [at]Thomas.Sarkanen

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 19336821 via CL 19337203 via CL 19337471 via CL 19337507
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19348771 by nick brett in ue5-main branch]
2022-03-10 22:29:02 -05:00
frederick lupien
2be85d3154 Made LinkedAnimLayers node purple to distinguish them from LinkedAnimGraph
[REVIEW] [at]Thomas.Sarkanen
#tests anim blueprint editor

#ROBOMERGE-AUTHOR: frederick.lupien
#ROBOMERGE-SOURCE: CL 19284487 via CL 19295534 via CL 19304957 via CL 19305399
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19347138 by frederick lupien in ue5-main branch]
2022-03-10 21:02:48 -05:00
nick brett
7e1eab27e2 [UE][Feature] RBAN Better Debug Draw - 2nd attempt
- Added Debug Visualization of physics bodies and constraints for RBAN nodes in AnimBP editor
- Added checkboxes to filter debug Visualization to Phat skeleton tree
- Created a new PhysicsAssetRenderSettings class that incorporates the debug rendering and filtering settings from Phat
- Created a new PhysicsAssetRenderUtilities namespace that incorporates the debug rendering and filtering code from Phat
- Synchronize debug visualization of physics bodies and constraints between Phat and AnimBP editors

oringinaly submitted as cl-19242421 but failed on non-unity build so backed out

#rb [at]Chris.Caulfield, [at]Thomas.Sarkanen, [at]Cedric.Caillaud
#preflight 6221e57d335298c3145112d1

#ROBOMERGE-OWNER: nick.brett
#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 19283727 via CL 19295417 via CL 19304854 via CL 19304870
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19347122 by nick brett in ue5-main branch]
2022-03-10 21:02:14 -05:00
thomas sarkanen
e1151831f9 Fixed tagged-property-serialization causing warnings with generated sparse class data structs in animation blueprints
This changes the generated property names for object properties to ensure that object properties of differing class types dont collide. This avoids the warning in FObjectPropertyBase::CheckValidObject (Serialized Class X for a property of Class Y. Reference will be nullptred.).

#jira UE-144970
#jira FORT-455566
#preflight 62262d20b97fb949cf4bea13
#rb Jurre.deBaare
#lockdown simon.tourangeau

#p4v-cherrypick 19251391

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 19285792 in //UE5/Release-5.0/... via CL 19286676
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19291659 by thomas sarkanen in ue5-main branch]
2022-03-07 15:54:51 -05:00
leon huang
0193ffe8d3 Fix for CIS warnings for localization duplicate keys. Fixes simply involve changing one of the colliding localization keys.
#rnx
	#rb: Vincent.Gauthier
	#jira: UE-143620
	#preflight: 6222489d2f7d78332e121416
	#lockdown Mitchell.Wilson

#ROBOMERGE-AUTHOR: leon.huang
#ROBOMERGE-SOURCE: CL 19272838 in //UE5/Release-5.0/... via CL 19273134
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19275063 by leon huang in ue5-main branch]
2022-03-04 16:10:23 -05:00
frederick lupien
a6fdf1d576 Allow linked animation graphs to be set to a null anim blueprint class both in the animation blueprint editor and at runtime when using UAnimInstance::LinkAnimGraphByTag
[REVIEW] Thomas.Sarkanen
#tests BP Compiler + various linked anim layers cases

#ROBOMERGE-AUTHOR: frederick.lupien
#ROBOMERGE-SOURCE: CL 19173813 via CL 19173848 via CL 19173864 via CL 19174435
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19174691 by frederick lupien in ue5-main branch]
2022-02-28 11:25:34 -05:00
benoit gadreau
5bac2b1cb2 fixed crash when validating nodes: template anim BPs don't have any skeleton assigned
#rb thomas.sarkanen
[FYI] kiaran.ritchie
#jira UE-142972
#preflight 6214d1cc9e2201e21406a740
#lockdown tbd

#ROBOMERGE-AUTHOR: benoit.gadreau
#ROBOMERGE-SOURCE: CL 19071009 in //UE5/Release-5.0/... via CL 19090369
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19134147 by benoit gadreau in ue5-main branch]
2022-02-24 19:44:00 -05:00
jamie dale
cfdad64946 Added context to PostCDOCompiled and also call it for skeleton-only compiles
#jira
#preflight 6210112553204823ae8bcf4f
#rb Michael.Noland

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 19058032 via CL 19058041 via CL 19058078 via CL 19058094 via CL 19059619
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19066317 by jamie dale in ue5-main branch]
2022-02-21 02:04:58 -05:00
nick brett
977a29d03a [UE][FIX] AnimDynamics UI - Ensure bone name updates correctly in details panel array element headers.
#rb [at]Thomas.Sarkanen
[FYI] [at]Charles.Anderson
#preflight 620a74e817632e948459d2a7
#rmx

#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 18994598 via CL 18994608 via CL 18994616 via CL 18994855 via CL 18994946
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18997965 by nick brett in ue5-main branch]
2022-02-15 12:07:16 -05:00
thomas sarkanen
a5948bb075 Fixed nested structs that are bound to anim node pins not showing their child values
#rb Jurre.deBaare

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18918369 via CL 18918381 via CL 18918386 via CL 18922642 via CL 18923567
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18923672 by thomas sarkanen in ue5-main branch]
2022-02-09 15:28:13 -05:00
nick brett
6d3811e933 [UE][FIX] Bug fixes for Anim Dynamics UI
- Removed cached USkeletalMeshComponent* from AnimGraphNode as we can now get it from AnimGraphNode_Base
- Add a templatized version of AnimGraphNode_Base::GetDebuggedAnimNode() that allows retrival of derived node types
- Can now calculate chain bones without waiting for the node to be compiled - removed associated warning from UI
- Prevent Copy+Paste of bone names in chain bone array, improving workflow
- Ensure that changing bound bone name does not reset physics body parameters, improving workflow
- Improve chain body UI

[REVIEW] [at]Thomas.Sarkanen
[FYI] [at]Charles.Anderson

#ROBOMERGE-OWNER: nick.brett
#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 18903371 via CL 18903392 via CL 18903410 via CL 18915322 via CL 18915359
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v915-18905420)

[CL 18915362 by nick brett in ue5-main branch]
2022-02-09 05:02:00 -05:00
helge mathee
645e1c7469 Control Rig: Support modifybone to work without a preview mesh
#rb sara.schvartzman
#jira UE-141661
#preflight https://horde.devtools.epicgames.com/job/62027c51bf1c496911476ca7
#lockdown juan.canada

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18902011 in //UE5/Release-5.0/... via CL 18902196 via CL 18902397
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v912-18901109)

[CL 18902410 by helge mathee in ue5-main branch]
2022-02-08 10:30:46 -05:00
jose villarroel
3f650197bf Fix "additional meshes" in persona preview not animating
#rb Aaron.Cox, Jurre.DeBaare
#preflight 61fd7b9fe65336d14550704c

#ROBOMERGE-AUTHOR: jose.villarroel
#ROBOMERGE-SOURCE: CL 18872694 via CL 18872736 via CL 18872771 via CL 18875005 via CL 18875491
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18875508 by jose villarroel in ue5-main branch]
2022-02-04 17:43:49 -05:00
dave jones2
ed1b4ed6a5 UE-140327 - Remove ENABLE_BLUEPRINT_REAL_NUMBERS usage
The original ENABLE_BLUEPRINT_REAL_NUMBERS macro was strictly meant for AB testing in the Dev-LWC. Currently, disabling it won't work, and would likely lead to broken behavior. Its presence might incorrectly indicate to licensees that this is an option that can be toggled safely.

#rb marc.audy
#jira UE-140327
#preflight 61fc6449dc0b3ecbecb6f381
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18864654 in //UE5/Release-5.0/... via CL 18864683 via CL 18864993
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18865002 by dave jones2 in ue5-main branch]
2022-02-04 11:54:52 -05:00
thomas sarkanen
ff1e91c927 Fix issues with child anim BP compilation ordering & sparse class data fixup
This partially ports a fix from CL 18740288, but improves on when and how sparse class data gets fixed up.
This allows this fix to cover more parent->child load/compile orderings (the previous fix only worked if they were all compiled in the same batch, which isnt always guaranteed.

Original CL desc:

Ensures that cleaned-up sparse class data structs are moved out of the package they are in, thus not requiring a GC step to ensure that batch compilation works correctly.
Without this, it is possible for the NewObject call in FAnimBlueprintCompilerContext::RecreateSparseClassData to attempt to re-use (as it has a fixed name) the currently-existing (but not referenced) object rather than creating a new one.
This also reverts some other changes that were made to try to address related issues.

#jira FORT-444463
#jira UE-140565
#jira UE-140530
#lockdown laurent.delayen
#rb jurre.debaare
#preflight 61fbddc53b22793ca35ebfc0

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18843087 in //UE5/Release-5.0/... via CL 18843109 via CL 18843285
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18843294 by thomas sarkanen in ue5-main branch]
2022-02-03 10:36:00 -05:00