Commit Graph

829 Commits

Author SHA1 Message Date
dave jones2
1b50b70aee UE-160862 - Fix FW-Gameplay miscellaneous module truncation warnings
#jira UE-160862
#preflight 63191b1cb069eea9ab594ea2
#rb andrew.davidson

[CL 21974045 by dave jones2 in ue5-main branch]
2022-09-12 18:16:22 -04:00
bryan sefcik
b93a6cf7ed Pass 1 on editor include fixes:
Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631e283bec5b0c765fc0ffdb

[CL 21960084 by bryan sefcik in ue5-main branch]
2022-09-11 18:33:06 -04:00
jordan hoffmann
b17b74c49d small comment change
#jira trivial
#preflight trivial

[CL 21924417 by jordan hoffmann in ue5-main branch]
2022-09-09 13:58:00 -04:00
jordan hoffmann
b504d83505 [BugFix] //UE5/Main - Build Engine Localization - GraphDiffControl.cpp Warning: Text conflict from LOCTEXT macro for namespace and key
#jira UE-163377
#rb trivial
#preflight trivial

[CL 21924061 by jordan hoffmann in ue5-main branch]
2022-09-09 13:28:49 -04:00
Robert Millar
1313cc865d FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for class features in the editor.

#jira UE-161932
#rb ben.zeigler
#preflight 631a55942b7fe03eb6c27d74

[CL 21903450 by Robert Millar in ue5-main branch]
2022-09-08 17:06:00 -04:00
jordan hoffmann
43ac7c9adc [BugFix] Blueprints incorrectly diff cleanly when you link a pin to a different pin on the same node
#jira UE-162933
#preflight 631a24c4980179553ed7f7cb

[CL 21897560 by jordan hoffmann in ue5-main branch]
2022-09-08 13:35:34 -04:00
Robert Millar
d2a8b279ca FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for blueprints in editor.

#jira UE-161932
#rb ben.zeigler
#preflight 631820e4d135b61bc59b9981

[CL 21841686 by Robert Millar in ue5-main branch]
2022-09-07 01:06:47 -04:00
bryan sefcik
925161d3e2 Another IWYU pass on Engine/Source/Editor/...
#jira

[CL 21716486 by bryan sefcik in ue5-main branch]
2022-08-30 23:04:40 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
massimo tristano
a2934e54d2 Fix SGraphPinNum bug causing value not to change in the Niagara editor when the user enters a new value.
#rb kevin.ortegren
#preflight 63034cf8c00af5e294de9df3

[CL 21481129 by massimo tristano in ue5-main branch]
2022-08-22 05:37:51 -04:00
massimo tristano
c333401cd5 Re-introduced 21440571 after fixing a crash opening some Blueprints. From 21440571:
Fixed Scalar Parameter and Vector node to avoid triggering a component value change transaction if the user only clicks on the textbox (without effectively changing the value).

Currently when the user clicks on a Scalar or Vector parameter text box and then simply deselects the node, a data change is erroneously detected and a transaction is pushed onto the Undo stack. This change fixes the logic that determines whether the value is actually changed, removing these spurious and redundant transactions.

#rb sebastian.nordgren
#jira UE-159512
#preflight 62ff9986f7404b55a326ce08

[CL 21457315 by massimo tristano in ue5-main branch]
2022-08-19 10:40:49 -04:00
ben hoffman
3cd99fcd75 Revert 21442104 because it crashes a blueprint when you open it.
#fyi massimo.tristano
#preflight skip
#rnx
#jira UE-161349

[CL 21448370 by ben hoffman in ue5-main branch]
2022-08-18 15:31:18 -04:00
massimo tristano
1f8d25197d Fixed Scalar Parameter and Vector node to avoid triggering a component value change transaction if the user only clicks on the textbox (without effectively changing the value).
Currently when the user clicks on a Scalar or Vector parameter text box and then simply deselects the node, a data change is erroneously detected and a transaction is pushed onto the Undo stack. This change fixes the logic that determines whether the value is actually changed, removing these spurious and redundant transactions.

#rb sebastian.nordgren
#jira UE-159512
#preflight 62fe4890200ff87e07bddf46

[CL 21442104 by massimo tristano in ue5-main branch]
2022-08-18 10:39:09 -04:00
massimo tristano
80eb789b44 Fixed assertion crash occurring when mouse-overing collapsed material attributes.
Crash occured while generating preview graph displayed in tooltip.

#jira UE-159508
#rb jason.nadro
#preflight 62f3c0e823003b62a328216c

[CL 21318060 by massimo tristano in ue5-main branch]
2022-08-10 10:34:41 -04:00
Rob Gay
2ae22b2f87 Make Graph Knot API public so it can be extended
#preflight 62f186fe086f90bbc47f1c70

[CL 21276599 by Rob Gay in ue5-main branch]
2022-08-08 18:06:03 -04:00
jordan hoffmann
6d24db7929 [Bug Fix] Crash when diffing a graph that was deleted
#ROBOMERGE-OWNER: jordan.hoffmann
#ROBOMERGE-AUTHOR: jordan.hoffmann
#ROBOMERGE-SOURCE: CL 21211920 via CL 21211921 via CL 21212105
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21213016 by jordan hoffmann in ue5-main branch]
2022-07-21 20:42:14 -04:00
fabian giesen
7d8781778c Deprecate TVector2 operator <, >, <=, >=
2D vectors are not canonically ordered and having these operators results in very unfortunate interactions with generic code. In particular FMath::{Min,Max,Abs} on TVector2s compile but do not behave as one would expect.

Add explicit comparison methods as a replacement and deprecate uses of TVector2 overloaded relational operators since it's confusing and error-prone. Fix existing uses to avoid deprecation warnings. Several of these fixes are behavioral changes to fix what I am reasonably certain are bugs in the existing code - in particular, uses of FMath::{Min,Max,Abs} on TVector2s that almost certainly actually want TVector2::{Min,Max,GetAbs} instead.

#rb charles.bloom,jeff.roberts
#preflight 62d70a6547779a730aaac04b

#ROBOMERGE-AUTHOR: fabian.giesen
#ROBOMERGE-SOURCE: CL 21168341 via CL 21173069 via CL 21173193
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21192034 by fabian giesen in ue5-main branch]
2022-07-20 18:23:11 -04:00
dave jones2
52ee51c6a8 Build fix - missing headers.
#jira UE-158700
#rb none
#preflight none

[CL 20971216 by dave jones2 in ue5-main branch]
2022-07-06 15:11:16 -04:00
dave jones2
3799e9c331 UE-157166 - Vector literal pins lack precision with high values
Similar to other numerical Slate widgets, we need to templatize SGraphPinVector so that it can choose between a float and double representation. Currently, only the BP editor will use the double variant, while other tools continue to use a float.

This also update SGraphPinVector2D and SGraphPinVector4 to use a template. While we do use SGraphPinVector2D in BPs, we currently don't use SGraphPinVector4. However, that may change in the future.

#jira UE-157166
#preflight 62bf6898c438da7f09e95af0
#rb andrew.davidson

[CL 20947777 by dave jones2 in ue5-main branch]
2022-07-05 15:33:08 -04:00
jordan hoffmann
0c729fbf28 Unshelved from pending changelist '20809968':
Additional right-click Blueprint graph context menu profiling.

#preflight 62be03913f0d6beee29e55e0

#ROBOMERGE-OWNER: jordan.hoffmann
#ROBOMERGE-AUTHOR: jordan.hoffmann
#ROBOMERGE-SOURCE: CL 20905335 via CL 20915206 via CL 20915216
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20917862 by jordan hoffmann in ue5-main branch]
2022-07-01 14:16:41 -04:00
jordan hoffmann
f2957e798a [Bug Fix] Navigating the Event Graph in Blueprint Diff window causes visual snapping issues
#jira UE-156552
#rb Phillip.Kavan
#preflight 62b245a4e9509b62d927a108
#preflight 62b24d09604d9ccfc7422282

[CL 20767743 by jordan hoffmann in ue5-main branch]
2022-06-21 19:07:19 -04:00
jordan hoffmann
913c930427 [BugFix] Crash when attempting to open AnimGraph in ABP_BlendSpaceGraph blueprint
#jira UE-156643
#rb ryan.benedetto
#preflight 62ab8414633acd4c125d9466

[CL 20692910 by jordan hoffmann in ue5-main branch]
2022-06-16 15:47:10 -04:00
jordan hoffmann
927a75a885 [BugFix] Crash using blueprint Diff view without a selected diff item
- This was the result of a merge error. I removed the duplicate/incorrect code

#jira UE-156396
#jira UE-156396

[BugFix] Selected diff Pins aren't highlighted in blueprints with more than one graph
- FocusedDiffResult attribute returned the index of the diff result in a list of all diff results when it needed to return the index of a subset array that only includes results diffs between the currently rendered graph
#preflight 62a7d093045c9fe61ee09c19

[CL 20638583 by jordan hoffmann in ue5-main branch]
2022-06-13 20:11:07 -04:00
thomas tedemalm
9a88eea99f Fixed an issue where an uninitialized flag would cause some graph connections to be faded out.
#rb none
#preflight 62a71cac5a44fbc40278a187
#fyi jordan.hoffmann

[CL 20625012 by thomas tedemalm in ue5-main branch]
2022-06-13 07:24:43 -04:00