Commit Graph

638 Commits

Author SHA1 Message Date
bryan sefcik
892629fe83 Fixed some paths that got updated to include the full "ThirdParty" path.
#jira
#preflight 6320877bbc40358fa2995069

[CL 21997782 by bryan sefcik in ue5-main branch]
2022-09-13 21:48:33 -04:00
devin doucette
abd22903b7 Fixed forwarding of -DDC=<Graph> to avoid initializing DDC and only forward non-default graph names
#preflight 631f926c1e6887c4a6d4c30d
#rb Zousar.Shaker

[CL 21984731 by devin doucette in ue5-main branch]
2022-09-13 12:12:58 -04:00
bryan sefcik
a3dddc6630 Pass 1 on Developer include fixes:
Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631e281694758d0bf2ea1399

[CL 21960082 by bryan sefcik in ue5-main branch]
2022-09-11 18:32:18 -04:00
Devin Doucette
870bc44362 DDC: Reduced Zen cache chunk miss log verbosity from Display to Verbose
#preflight 631b942bd135b61bc57331c1
#rb none
#rnx
#fyi Tim.Smith

[CL 21926517 by Devin Doucette in ue5-main branch]
2022-09-09 15:49:08 -04:00
Marc Audy
e42d1fa0a3 Fix implicit conversion
#preflight
#rnx

[CL 21897568 by Marc Audy in ue5-main branch]
2022-09-08 13:36:12 -04:00
Devin Doucette
2d6866d2ec DDC: Set UnsafeTypeCastWarningLevel to Error
#preflight 631907e2a20b67673b513de6
#rb Zousar.Shaker
#rnx

[CL 21871353 by Devin Doucette in ue5-main branch]
2022-09-07 22:45:29 -04:00
Devin Doucette
9aee9a4bd8 DDC: Fixed unsafe type cast warnings
#preflight 6317fc04a20b67673b1de7c3
#rb Zousar.Shaker
#rnx

[CL 21850770 by Devin Doucette in ue5-main branch]
2022-09-07 10:37:16 -04:00
Zousar Shaker
860fdb7053 Fix bugs in the System.DerivedDataCache.HttpDerivedDataBackend.CacheStore automated test caused by:
1. Using the wrong structured namespace when instantiating Zen.
2. Assuming that the order that PUT requests will complete is equal to the order that they were in the original request array.

#rb none
#fyi dan.engelbrecht
#preflight 6317a9e72b7fe03eb64e3d7c

[CL 21829182 by Zousar Shaker in ue5-main branch]
2022-09-06 17:05:48 -04:00
Zousar Shaker
6dfdd060fd Disabling the -DDC=None codepath for non-programs to reduce confusion when people attempt to use it in editor.
#rb devin.doucette
#preflight 63176267032bd43d8649bade

[CL 21818771 by Zousar Shaker in ue5-main branch]
2022-09-06 11:47:52 -04:00
devin doucette
9b905880aa DDC: Fixed UserData value returned by the cache hierarchy
#rb trivial
#rnx

[CL 21449943 by devin doucette in ue5-main branch]
2022-08-18 17:04:23 -04:00
Devin Doucette
055ba32b38 DDC: Added partial cache record propagation to the hierarchy, with tests
#jira UE-156058
#preflight 62fd59d5e64b1a51093918f8
#rb Zousar.Shaker

[CL 21441390 by Devin Doucette in ue5-main branch]
2022-08-18 09:51:07 -04:00
Devin Doucette
30886eda76 More workarounds for issues with /Zc:lambda in MSVC 14.33
#preflight 62fd28c30f2aefc97abbe0ee
#preflight 62fd2940aa546d5e9dc15245
#rb trivial
#rnx
#fyi Joe.Kirchoff

[CL 21427854 by Devin Doucette in ue5-main branch]
2022-08-17 14:04:36 -04:00
Joe Kirchoff
6e545d7633 Fix vs2022 compile errors when /Zc:lambda- is removed
#rnx
#rb trivial
#preflight 62fc24382d5e2ed99cdbbc84

[CL 21417071 by Joe Kirchoff in ue5-main branch]
2022-08-16 19:23:33 -04:00
Joakim Lindqvist
99738a925d Allow users to interactivly login if they are missing a token. Will present a dialog for users if not unattended so they are aware they need to login.
#preflight https://horde.devtools.epicgames.com/job/62f26d7723003b62a3f3b58f

[CL 21334992 by Joakim Lindqvist in ue5-main branch]
2022-08-11 09:17:03 -04:00
Devin Doucette
76e5a1365f DDC: Separated the async completion counter from the cache singleton
#preflight 62f2ae3e3f500fb6dcf79ad1
#rb Zousar.Shaker
#rnx
#robomerge FNMain

[CL 21296269 by Devin Doucette in ue5-main branch]
2022-08-09 15:39:06 -04:00
Devin Doucette
1da9f58aa5 DDC: Optimized Horde Storage cache bucket transforms
#preflight 62dab595d54af4b9a23cea07
#rb Zousar.Shaker
#rnx

[CL 21221014 by Devin Doucette in ue5-main branch]
2022-07-22 10:54:37 -04:00
Devin Doucette
32b644e560 DDC: Use TSharedRef for shared Horde Storage completion functions
#preflight 62da25ec185da2495f7bbf5d
#rb Zousar.Shaker
#rnx

[CL 21220414 by Devin Doucette in ue5-main branch]
2022-07-22 10:21:26 -04:00
Devin Doucette
62f66e3e49 DDC: Fixed verbose logging in the file system cache
#preflight 62da257cbc175ec68cb7b9db
#rb Zousar.Shaker
#rnx
#robomerge FNMain

[CL 21220401 by Devin Doucette in ue5-main branch]
2022-07-22 10:20:41 -04:00
Devin Doucette
e8e097228d DDC: Changed cache replay to enable compression by default
The -DDC-ReplayCompress param has been replaced by -DDC-ReplayNoCompress.

#preflight 62da1f46086f90bbc477b270
#rb none
#rnx
#robomerge FNMain

[CL 21220189 by Devin Doucette in ue5-main branch]
2022-07-22 09:56:23 -04:00
Devin Doucette
0c93504b3c DDC: Added more detail to warnings from the Zen cache client
#preflight 62d9ced6d76ea4b503d3f487
#rb Zousar.Shaker
#rnx

[CL 21214276 by Devin Doucette in ue5-main branch]
2022-07-21 23:01:51 -04:00
zousar shaker
75d0e7277b Add status icon to indicate DDC cache store status with tooltip text for details. Currently used to show when a cache store has been deactivated for performance.
#rb devin.doucette

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 21152573 via CL 21155094 via CL 21156160
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21181761 by zousar shaker in ue5-main branch]
2022-07-20 11:55:16 -04:00
Devin Doucette
075bd0dc0b DDC: Fixed warnings from PVS-Studio in CurlHttpClient
#preflight 62d71b4d3c3df32390382aef
#rb Zousar.Shaker
#rnx
#preflight 62d71d1dd54af4b9a29c1918

[CL 21167452 by Devin Doucette in ue5-main branch]
2022-07-19 17:18:52 -04:00
Devin Doucette
463ecf80f5 DDC: Added public key pinning support to the Horde Storage client
It would be better to use Certificate Transparency, but the UE SSL module currently expects pinned public keys, and verification using known key hashes is far better than no verification.

#preflight 62d5c582d54af4b9a23b92e7
#rb Zousar.Shaker
#rnx

[CL 21157474 by Devin Doucette in ue5-main branch]
2022-07-18 23:15:54 -04:00
Devin Doucette
bbbaf00e02 DDC: Fixed an error in IHttpClient::GetHeader[s]
#preflight skip
#rb none
#rnx

[CL 21150205 by Devin Doucette in ue5-main branch]
2022-07-18 13:24:08 -04:00
Devin Doucette
c6bcab8076 DDC: Refactored the HTTP API to add configurability and remove reliance on types from DDC
- FHttpSharedData is now IHttpConnectionPool. It is a connection pool of configurable size.
- FHttpRequestPool is now IHttpClient. It is a request pool of configurable size and the point at which most behaviors are configured.
- FHttpRequest is now split into IHttpRequest and IHttpResponse. This separation allows requests to be released back to the client for reuse while the response is still being processed.
- FScopedHttpPoolRequestPtr is now THttpUniquePtr. It is used uniformly with the pool, client, request, and response.
- The response body is now handled by IHttpReceiver, with a basic FHttpByteArrayReceiver provided to capture the whole body into an array.
- The response now includes stats about how much time was spent on various parts of the request, as well as how much data was sent and received and at what rate.
- The response supports cancellation at any point before it is complete, and IHttpResponseMonitor is provided to support thread-safe cancellation and waiting without requiring locks around the unique owner of the response.
- The response will be canceled automatically when destroyed through its THttpUniquePtr.
- The client does not directly support blocking on request creation. Blocking creation of requests is now provided by FHttpRequestQueue.
- The HTTP thread now relies on curl_multi_poll, available in newer libcurl versions, to allow immediate waking when a handle needs to be added or removed.

#preflight 62d580dd2e3e5993c3b678dd
#rb Zousar.Shaker

[CL 21149626 by Devin Doucette in ue5-main branch]
2022-07-18 12:23:16 -04:00