Remove code that was stripping Base and Engine as it could have other similar side effects in out of date config code
This code might need further updates for UE5, the only reason it worked before was because it was depending on the fact that Find would create a nonsaveable config file when passed a bad key
[CODEREVIEW] michael.noland
#rb none
#ROBOMERGE-SOURCE: CL 16962667 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)
[CL 16962687 by ben zeigler in ue5-release-engine-test branch]
Fix spelling error and comments while I'm already modifying this code
Change calling sites that were doing this manually to use new function, and fix a bad merge in the plugin code
Add logic to strip Base and Default prefixes from plugin config overrides, as the old behavior with Find instead of FindConfigFile lead to that sometimes working by accident
I may update the handling of Base/DefaultPluginName.ini in a separate checkin to make that more consistent
#rb josh.adams
#ROBOMERGE-SOURCE: CL 16959529 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)
[CL 16959549 by ben zeigler in ue5-release-engine-test branch]
Do not log an error if LoadModulesForEnabledPlugins is called multiple times in a row on the same phase, since this occurs for PreEarlyLoadingScreen.
#rb Graeme.Thornton
#robomerge Release-5.0-EarlyAccess
#rnx
[CL 15900315 by Matt Peters in ue5-main branch]
Remove CreateIfNotFound parameter to FConfigCacheIni::Find.
This was creating thousands of fstat calls peeking for the existence of Saved/Config/WindowsEditor/GameplayTagsEditorState.ini when opening the Project Settings dialog. This we make frequent calls (in a recursive manner) into the config system, but no file or config is created (where false is passed), and we keep statting it thousands of times
Callers that pass false for this fail to land on any config properties because they don't exist to begin with.
Callers that pass true for this still basically get what they want. Since we did not stub the file out upon Find(), there is no disk state difference between Find() and config system shutdown (where dirty config files are saved to disk). So saving is still manual, and there is no implication from
CreateIfNotFound communicated to the FConfigFile about whether it is meant to be saved or not. So by and large this semantic is meaningless except with the existence of the new config file of the config file map (which creates the optimization of skipping the subsequent stats).
SSettingsEditor::ReloadCategories before: 2290ms
SSettingsEditor::ReloadCategories after: 1669ms
Tested with a BuildCookRun of ShooterGame, and running with it in Editor for a few days.
#jira UE-95853
[CL 14258235 by geoff evans in ue5-main branch]
- Does not have the changes for new .ini file locations
#rb ben.marsh
#ROBOMERGE-SOURCE: CL 12676628 via CL 12676630 via CL 12676633
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)
[CL 12676637 by josh adams in Main branch]
