Commit Graph

112 Commits

Author SHA1 Message Date
tim smith
e3e9a63090 Remove the bEnableReinstancing global setting to reduce confusion now that a project setting is available.
#rb none
#rnx
#jira UE-118772

#ROBOMERGE-SOURCE: CL 17015824 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v839-17012307)

[CL 17015829 by tim smith in ue5-release-engine-test branch]
2021-08-02 10:26:32 -04:00
tim smith
9b29a45945 Updating the xxhash license for version included in Live++
#rb none
#rnx

#ROBOMERGE-SOURCE: CL 16967550 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 16967553 by tim smith in ue5-release-engine-test branch]
2021-07-27 07:29:33 -04:00
tim smith
5aafdc5888 Fixed issue where starting PIE after starting a LiveCoding compile would lockup the editor.
#rb trivial
#jira UE-85026
#preflight 60ff11837f21c90001dbbf0b

#ROBOMERGE-SOURCE: CL 16961146 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 16961156 by tim smith in ue5-release-engine-test branch]
2021-07-26 17:08:28 -04:00
joe kirchoff
43386ca4e5 LC_StringUtil.cpp workaround is also required for MSVC Clang 12.0.0
#ROBOMERGE-SOURCE: CL 16763061 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16763918 by joe kirchoff in ue5-release-engine-test branch]
2021-06-23 18:08:19 -04:00
tim smith
b294a27c29 Add the ability to enable re-instancing via project settings. Old setting still supported.
Add the ability to enable auto compile when adding new C++ classes.
Fixed user feedback issues when adding new C++ classes.

#rb joe.kirchoff
#rnx
#jira UE-116958
#preflight 60cb2e884ce02c0001d278c1

#ROBOMERGE-SOURCE: CL 16703582 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16703591 by tim smith in ue5-release-engine-test branch]
2021-06-17 08:47:50 -04:00
aurel cordonnier
c139661dc1 Fixes for no unity errors
#rb trivial
#rnx

#ROBOMERGE-SOURCE: CL 16655282 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v833-16641396)

[CL 16655283 by aurel cordonnier in ue5-release-engine-test branch]
2021-06-13 23:49:22 -04:00
tim smith
899eaa25cd Improved notifications in the editor/game for live coding.
Added message that packaging can fail if assets reference new changes.

#rb
#rnx
#jira UE-115558
#preflight 60c39c8e8d00b80001b1e85f

#ROBOMERGE-SOURCE: CL 16645001 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v833-16641396)

[CL 16645007 by tim smith in ue5-release-engine-test branch]
2021-06-11 14:48:40 -04:00
tim smith
af243577b4 Fixed global delegate functions to support changes when doing live coding.
Fixed issue where changing a function signature in an interface wouldn't update nodes in a blueprint.
Changed the API of the deferred registry to be more inline with UE coding standards.

#rb ben.marsh phillip.kavan
#rnx
#jira UE-113662
#preflight 60c0c0fdc61264000190e16a

#ROBOMERGE-SOURCE: CL 16606206 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16606221 by tim smith in ue5-release-engine-test branch]
2021-06-09 11:43:12 -04:00
tim smith
49f59fcedd Fixing LiveCoding issue where multiple changes to properties could still result in crashes during editing and at exit time.
#jira UE-112720
#rb jonathan.adamczewski
#rnx
#preflight 609e59dc22cce00001cf19d9

#ROBOMERGE-SOURCE: CL 16328393 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v804-16311228)

[CL 16328401 by tim smith in ue5-release-engine-test branch]
2021-05-14 07:45:59 -04:00
Tim Smith
de9adfe9b0 Fix NonUnity build
#rb trivial
#rnx

[CL 16122938 by Tim Smith in ue5-main branch]
2021-04-27 06:40:20 -04:00
Tim Smith
5fb833c5c1 Added support for more arbitrary property changes to live coding.
1) Changed the pre/post compile notifications from module notifications to process commands.
2) Added server command to notify that we want re-instance patching (two phase)
3) Added support for two phase patching to enable re-instancing without all the limitations.
4) Added a null CDO check for old blueprint classes (approved by Phillip)

#rb ben.marsh
#rnx
#preflight 6086e3481046fb000183c2d4

[CL 16115620 by Tim Smith in ue5-main branch]
2021-04-26 12:49:25 -04:00
Marc Audy
01b7c9f4f5 Merge UE5/RES @ 15958325 to UE5/Main
This represents UE4/Main @ 15913390 and Dev-PerfTest @ 15913304

[CL 15958515 by Marc Audy in ue5-main branch]
2021-04-08 14:32:07 -04:00
Tim Smith
737ad605ed Fixing Clang warnings in LiveCoding
#rb devin.doucette
#jira UE-112494

[CL 15877566 by Tim Smith in ue5-main branch]
2021-03-31 13:00:20 -04:00
halfdan ingvarsson
e5c856c8c9 Instead of relying on non-conflict with library-provided wmemchr, just re-implement std::wstring::find on top of wcsstr for clang 11.0 on Windows only.
#jira none
#rb tim.smith
#rnx

[CL 15860653 by halfdan ingvarsson in ue5-main branch]
2021-03-30 09:03:46 -04:00
tim smith
238c0372a1 Removing UE4 from code
#rb none
#jira UE-111710

#ROBOMERGE-SOURCE: CL 15852066 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15852981 by tim smith in ue5-main branch]
2021-03-29 13:42:53 -04:00
Tim Smith
5dc30d2303 Adding the ability to disable re-instancing when doing live coding.
Will be disabled until blueprint issues are resolved.

#rb trivial

[CL 15851149 by Tim Smith in ue5-main branch]
2021-03-29 10:54:06 -04:00
halfdan ingvarsson
c8d619d990 Workaround for a bug in clang-cl 11.0 when building in C++17 mode, where __builtin_wmemchr is not implemented.
#jira none
#rb tim.smith
#rnx

[CL 15850274 by halfdan ingvarsson in ue5-main branch]
2021-03-29 09:23:17 -04:00
Tim Smith
196d6c5b42 Fix improper extern declaration that caused issues with Clang but not MSVC (Clang was right IMHO)
#rb trivial
#jira UE-111492

[CL 15747765 by Tim Smith in ue5-main branch]
2021-03-19 11:36:00 -04:00
Tim Smith
a2237e050d LiveCoding Re-instancing
LIMITATIONS:

1) Re-instancing will only update UClass instance data.
2) Adding and removing properties should only be done towards the end of a class or structure and can not be followed by complex data types.
3) Adding and removing properties from a base class should not be done if a derived class contains complex data types.

KNOWN ISSUES:

1) Changes to enumerations and structures will not be reflected in existing blueprints.  However, adding new nodes to the blueprint will show the updated enumeration or structure.
2) If a class contains an enumeration or structure as a member, the class will not be re-instanced if enumeration or structure is changed.

CHANGES:

1) LiveCodingServer
1a) Modified to always execute certain static instances during load.
1b) Modified to exclude the _Statics static structures to avoid patching to old copies.

2) Added support for LiveCoding reinstancing
2a) Refactored deferred registration system for UClass, UEnum, and UScriptStruct to use a common system that works for normal game, hot reload and live coding.
2b) Type specific version check data is possible (i.e. enum doesn't have a size)
2c) Single registration static for UClass
2d) Single registration class for all types that is just a blind forward to API.
2e) Static and dynamic registrations use different API entry points to avoid having overloaded argument lists that just apply to one or the other.
2f) Shims for older API

3) New common "Reload" system to avoid using HotReload code.
3a) Support common delegates regardless of who is reloading/reinstancing.
3b) Re-instancing code moved from HotReload to Kismet2 (where the bulk of the re-instance code already existed).
3c) Modified PyWrapper to use new helper class instead of depending on HotRelaod
3d) Added WITH_RELOAD which is defined if HotReload or LiveCoding is enabled.
3e) Modifed existing code to use new #define and delegates.

Robert did the review on the changes covered by Part 2.  Remaining changes are all straightforward.

#rb robert.manuszewski
#jira UE-74493

[CL 15736777 by Tim Smith in ue5-main branch]
2021-03-18 08:13:59 -04:00
Tim Smith
bbe145fc4d Refixing a PVS warning stomped by the integration
#rb trivial
#jira none
#rnx

[CL 15136209 by Tim Smith in ue5-main branch]
2021-01-19 11:40:24 -04:00
Tim Smith
e599eed6a4 Integration of Live++ 1.6.4 (2021/18/01)
This fixes and re-enables a feature of 1.6 that didn't work in an Unreal environment.

#jira none
#rb trivial
#rnx

[CL 15131026 by Tim Smith in ue5-main branch]
2021-01-18 13:02:32 -04:00
Tim Smith
d193b70a3b Fixing PVS 7.7 Issues:
warning V781: The value of the 'XYZ' index is checked after it was used. Perhaps there is a mistake in program logic.

#rb trivial
#jira UE-91644

[CL 15066377 by Tim Smith in ue5-main branch]
2021-01-13 09:08:55 -04:00
Martin Ridgers
51437d6cf8 Fixed static analysis warning. The warning is correct; _setjmp is declared with and without the _Out_ annotation in setjmp.h and intrin.h respectively. It is however, harmless in this instance.
#rb none
#rnx

[CL 14968921 by Martin Ridgers in ue5-main branch]
2020-12-30 11:10:50 -04:00
Tim Smith
76cec15371 Fixing a PVS warning. Changing the code to avoid the + operator since PVS is having issues interpreting the code in this instance.
#rb trivial
#jira UE-104645

[CL 14946615 by Tim Smith in ue5-main branch]
2020-12-17 10:05:33 -04:00
Tim Smith
ca0e8a4101 Fixing a few PVS warning. The memcpy issue is intentional by the 3rd party library.
#rb trivial
#jira UE-104645

[CL 14940455 by Tim Smith in ue5-main branch]
2020-12-16 13:43:24 -04:00