Commit Graph

942 Commits

Author SHA1 Message Date
dan oconnor
1990f8aa53 Allow keyboard navigation in the action menu to disable scoring of added entries - this allows the user to keyboard navigate effectively while the menu is still building
#rb Phillip.Kavan
#jira UE-211629

[CL 32780151 by dan oconnor in ue5-main branch]
2024-04-05 20:46:03 -04:00
dan oconnor
55f1af2746 Made the focussed menu entry stable in the blueprint context menu, even while populating with a filter string
#rb Phillip.Kavan
#jira UE-211629

[CL 32766131 by dan oconnor in ue5-main branch]
2024-04-05 13:55:11 -04:00
dan oconnor
40e74fa28f Rework SGraphActionMenu such that there is no need to walk all existing nodes during menu building, GetLeafNodes is instead called only during keyboard navigation. This speeds up asynchronous (and synchronous) action menu construction. FGraphActionNode now tracks the number of 'leaf' nodes that have been added to it, SGraphActionMenu now tracks the selected node, rather than its leaf index (which is unstable and would require expensive recalculation)
#rb Phillip.Kavan
#jira UE-211244

[CL 32716387 by dan oconnor in ue5-main branch]
2024-04-03 20:04:53 -04:00
robert millar
6bb7c2cc89 Remove heading from "Find References" submenu
[CL 32642738 by robert millar in ue5-main branch]
2024-04-01 12:36:47 -04:00
jordan hoffmann
39807d6b5e [CrashFix] A udn user found a crash in LinkedToDifferent in GraphDiffControl.cpp. This change adds an ensure to catch and recover from it
[CL 32481668 by jordan hoffmann in ue5-main branch]
2024-03-25 16:03:26 -04:00
jared therriault
5f63191f99 Blueprint Editor:
-Fix Panning on Linux is slow
-Add bUseHighPrecisionMouseMovement (true by default) and bUseInterpolationWithManualPanning (false by default) as Graph Editor Settings, set to the current behaviour, but can be switched to allow for a better panning experience on Linux versions of the editor.

#jira UE-209711
#rb ben.hoffman, ronald.koppers
[FYI] jason.walter

[CL 32463490 by jared therriault in ue5-main branch]
2024-03-24 15:16:46 -04:00
ben hoffman
3af1382c28 Blueprints: Fix dropdown for UPARAM's GetOptions was not hidden when a pin was connected
#rb dave.jones2, jodon.karlik

#ushell-cherrypick of 31385532 by kristof.morva1

#ushell-cherrypick of 31619147 by ben.hoffman

[CL 31733962 by ben hoffman in ue5-main branch]
2024-02-22 16:05:37 -05:00
luke thatcher
01203093c6 Deprecate:
- FRHITexture2D
 - FRHITexture2DArray
 - FRHITexture3D
 - FRHITextureCube
 - FTexture2DRHIRef
 - FTexture2DArrayRHIRef
 - FTexture3DRHIRef
 - FTextureCubeRHIRef

Replaced with FRHITexture and FTextureRHIRef

These types were unified in UE 5.1 and have been defined via "using" statements to the same underlying texture type for several engine releases.

#rb christopher.waters

[CL 31724002 by luke thatcher in ue5-main branch]
2024-02-22 11:38:35 -05:00
sameer mirza
e024f77e88 Material nodes connection tooltip gets stuck
#rb massimo.tristano
#jira UE-207136

[CL 31560557 by sameer mirza in ue5-main branch]
2024-02-16 07:02:10 -05:00
phillip kavan
c2c89bd6e2 Fix a regression that could prevent widgets from being destroyed after closing an editor window containing a graph panel.
This could lead to an inability to delete certain assets through the content browser, as panel widgets would continue to reference the underlying graph object through the slate application context with no way to clean them up. In turn, this would result in the asset persisting and being (incorrectly) noted as now existing in a "corrupt" state.

After this change, the asset deletion dialog will no longer report the asset as being referenced in this manner.

This change also minimizes the number of active timers registered to the panel widget for incoming node add/remove graph change events (which matches what was already being done for node select events).

#jira UE-201589, UE-194980
#rb ben.hoffman

[CL 30894681 by phillip kavan in ue5-main branch]
2024-01-25 14:16:01 -05:00
zhikang shao
239e804676 Reverting blueprint editor shortcut Alt+Shift+F to search locally by mapping it to the singular Find References action. The singular Find References action, while not exposed to UI for nodes that have Find References By Name/Class Member support, can still be triggered with shortcut and will trigger a local By Name or By Class Member search based on what the previous behavior was for that node type. For function nodes it will search by function name, while for variable nodes it will do an exact search since Find References already did that for a while.
However: function searches will do a quoted search by native function name. The previous behavior was unquoted search by node title (usually function display name). As a result, the previous behavior for Find References would fail in functions with special characters in their name. Now that the name is surrounded in quotes, all function names are supported. The new Find References behavior now searches for correct function name for parent call nodes, interface implementations, event overrides, where the previous behavior failed due to searching for node title.
#rb Phillip.Kavan

[CL 30854644 by zhikang shao in ue5-main branch]
2024-01-24 13:55:51 -05:00
steve robb
6d5b974842 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30735396 by steve robb in ue5-main branch]
2024-01-19 19:41:56 -05:00
dave jones2
73d6c12907 Deprecated bIsBeadFunction.
This was a really old feature that never took off. It's not needed anymore.

#rb dan.oconnor

[CL 30718919 by dave jones2 in ue5-main branch]
2024-01-19 12:19:18 -05:00
zulqarnain abbasi
15d196a910 Fix for Texture Graph Undo Redo Issues
Also added the tests for undo redo

#jira UE-203475
#jira UE-203476
#jira UE-201944
#jira UE-202697


#rb Zohaib.Javed

[CL 30637460 by zulqarnain abbasi in ue5-main branch]
2024-01-16 12:59:55 -05:00
evgenii babinets
690bc2cbc4 Fixed unreachable code warnings/errors.
#rb simon.orr

[CL 30620936 by evgenii babinets in ue5-main branch]
2024-01-15 12:29:05 -05:00
mateo egey
42d515886c Added slate argument to automatically select an action in the graph action menu when only one action exists.
Defaults to off to save perf. Useful for some Niagara cases

#jira UE-144291
#rb aditya.ravichandran

[CL 30617677 by mateo egey in ue5-main branch]
2024-01-15 08:46:24 -05:00
geordiemhall
c2dd3c9d30 PR: Fix graph nodes flashing for a frame when using undo/redo
#10486
#rb zahra.nikbakht
#jira UE-187947

[CL 30514745 by geordiemhall in ue5-main branch]
2024-01-09 15:39:38 -05:00
zahra nikbakht
114a0d681f GraphEditor: ensure the correct LOD is applied to graph node and pins before the first tick.
We rely on the LOD setting of the graph panel to determine the LOD of nodes and pins, but they only get a reference to the panel after their construction, so we need to refresh the LOD once we get a reference to the owning panel from the node. This is only needed before the first tick.
This is a prerequisite to fix the issue of graph nodes disappearing for a frame on undo/redo
#jira UE-187947
#rb Patrick.Boutot

[CL 30514055 by zahra nikbakht in ue5-main branch]
2024-01-09 15:02:34 -05:00
zhikang shao
5a4f3dadcf #jira UE-196209
Improves "Find References" in blueprints: now supports function search by [class, function] call-sites and definitions rather than a generic search for function name. Replaces the "Find References" context menu action with a sub-menu for variables and functions in BlueprintEditor, WidgetBlueprintEditor, SubobjectEditor and SubobjectEditor. That context sub-menu has 'By Name' and 'By Class Member' search options and local+global versions of both.

Made changes to Find-in-Blueprints metadata that is generated per blueprint asset to be able to do "specific function of a specific class" type queries; some search types were unsupported with previous metadata. Incremented the EFiBVersion so that the Find-in-Blueprints search window will ask to re-index all blueprints and resave. Added an opt-out editor setting "Allow Index All Blueprints" (default: true) to disable the button, which can be decided per project. Added an action in the Find-in-Blueprints modal when outdated metadata is detected to export the list of affected assets.
#rb Phillip.Kavan

[CL 30316851 by zhikang shao in ue5-main branch]
2023-12-14 06:34:39 -05:00
zhikang shao
15c016080d [Backout] - CL30289707
[FYI] zhikang.shao
Original CL Desc
-----------------------------------------------------------------
#jira UE-196209
Improves "Find References" in blueprints: now supports function search by [class, function] call-sites and definitions rather than a generic search for function name. Replaces the "Find References" context menu action with a sub-menu for variables and functions in BlueprintEditor, WidgetBlueprintEditor, SubobjectEditor and SubobjectEditor. That context sub-menu has 'By Name' and 'By Class Member' search options and local+global versions of both.

Made changes to Find-in-Blueprints metadata that is generated per blueprint asset to be able to do "specific function of a specific class" type queries; some search types were unsupported with previous metadata. Incremented the EFiBVersion so that the Find-in-Blueprints search window will ask to re-index all blueprints and resave. Added an opt-out editor setting "Allow Index All Blueprints" (default: true) to disable the button, which can be decided per project. Added an action in the Find-in-Blueprints modal when outdated metadata is detected to export the list of affected assets.
#rb Phillip.Kavan

[CL 30289794 by zhikang shao in ue5-main branch]
2023-12-13 07:33:50 -05:00
zhikang shao
68c300ecfa #jira UE-196209
Improves "Find References" in blueprints: now supports function search by [class, function] call-sites and definitions rather than a generic search for function name. Replaces the "Find References" context menu action with a sub-menu for variables and functions in BlueprintEditor, WidgetBlueprintEditor, SubobjectEditor and SubobjectEditor. That context sub-menu has 'By Name' and 'By Class Member' search options and local+global versions of both.

Made changes to Find-in-Blueprints metadata that is generated per blueprint asset to be able to do "specific function of a specific class" type queries; some search types were unsupported with previous metadata. Incremented the EFiBVersion so that the Find-in-Blueprints search window will ask to re-index all blueprints and resave. Added an opt-out editor setting "Allow Index All Blueprints" (default: true) to disable the button, which can be decided per project. Added an action in the Find-in-Blueprints modal when outdated metadata is detected to export the list of affected assets.
#rb Phillip.Kavan

[CL 30289718 by zhikang shao in ue5-main branch]
2023-12-13 07:25:05 -05:00
ben humphreys
e9c9ac7a74 Added binding to create a new Custom Event Node. No binding by default. Similar to pressing C to create a new Comment Node.
#jira UE-200930
#rb Phillip.Kavan

[CL 30218170 by ben humphreys in ue5-main branch]
2023-12-08 15:12:30 -05:00
christopher waters
86af3ce99d Fixing various header only compile errors.
[CL 30138626 by christopher waters in ue5-main branch]
2023-12-05 17:55:30 -05:00
ben zeigler
64c32b73fb Deprecate GetCurrentTag/InvalidateTag and remove all calls as the feature was unreliable and is no longer used by TSoftObjectPtr as of 5.3
#rb jodon.karlik, robert.millar
#jira UE-187216

[CL 29996164 by ben zeigler in ue5-main branch]
2023-11-29 14:47:34 -05:00
phillip kavan
239da03f7b Minor revision to SGraphPanel to decouple its refresh on updates to the underlying graph object from a dependency on a parent SGraphEditor.
This allows SGraphPanel widgets that live outside of an editor context (e.g. previews) to avoid node/pin references going stale if the underlying graph object is reconstructed.

#jira UE-194980
#rb daren.cheng

[CL 29963162 by phillip kavan in ue5-main branch]
2023-11-28 12:35:28 -05:00