- Array-based bindless (Vulkan) only needed one more piece of data to use "GenerateBindlessAccess"
- Now all bindless shader platforms will generate a getter function for each bindless resource/sampler.
#rb dan.elksnitis, jeannoe.morissette
[CL 32375983 by christopher waters in ue5-main branch]
This re-introduced the backed-out CL for the DXC update including fixes to detect derivitive opcodes in DXIL containers and a null-pointer fix in the DXIL code generator (GitHub draf #6411).
Only the Windows binary is updated since no other platform uses the DXIL code generator. Linux and Mac binary updates will follow in a separate CL.
Also replaced DXIL binary with v1.8 obtained from https://github.com/microsoft/DirectXShaderCompiler/releases/tag/v1.8.2403
#jira UE-203636
#rb Graham.Wihlidal, Jeremy.Moore
[FYI] Bob.Tellez, Dan.Elksnitis
[CL 32257727 by matanshukry in ue5-main branch]
- Only WorkGraph shaders use this currently.
- SM6.8 needs to set the __SHADER_TARGET_MAJOR and __SHADER_TARGET_MINOR defines
- Changing some logic that was SM6.6 specific to now allow the higher shader model.
#rb Jeremy.Moore
[CL 32220197 by christopher waters in ue5-main branch]
Add basic DX12 Work Graph support.
For this first pass there is no exposed RHI functionality for directly dispatching a work graph. Instead shader bundles have been extended to support a work graph based implementation.
Nanite compute materials now can use work graph shader bundles on D3D12 when r.Nanite.AllowWorkGraphMaterials and r.Nanite.Bundle.Shading are both set. Both of these default to off at the moment.
Also DataDrivenPlatformInfo now expose bSupportsWorkGraphs. This is false everywhere, but will be enabled for D3D12_SM6 as soon as we have the latest DXC shader compiler with lib_6_8 support submitted.
#rb Kenzo.Terelst, Yuriy.ODonnell
[CL 32196717 by jeremy moore in ue5-main branch]
[FYI] Laura.Hermanns
Original CL Desc
-----------------------------------------------------------------
[DXC] DXC release-1.8.2403 update
This is the last CL of the DXC update including the binary files and API headers. The other CLs including all source changes are:
- 32164743 SPIRV-Headers
- 32166600 SPIRV-Tools
- 32165724 SPIRV-Cross
- 32165890 DirectXShaderCompiler
- 32165937 ShaderConductor
- 32165762 googletest
- 32165815 cxxopts
#jira UE-203636
#rb Graham.Wihlidal, Carl.Lloyd, JeanNoe.Morissette, Florin.Pascu, Serge.Bernier
[FYI] Dan.Elksnitis, Jason.Nadro, Yuriy.Odonnell, Jeremy.Moore
[CL 32172513 by bob tellez in ue5-main branch]
This is the last CL of the DXC update including the binary files and API headers. The other CLs including all source changes are:
- 32164743 SPIRV-Headers
- 32166600 SPIRV-Tools
- 32165724 SPIRV-Cross
- 32165890 DirectXShaderCompiler
- 32165937 ShaderConductor
- 32165762 googletest
- 32165815 cxxopts
#jira UE-203636
#rb Graham.Wihlidal, Carl.Lloyd, JeanNoe.Morissette, Florin.Pascu, Serge.Bernier
[FYI] Dan.Elksnitis, Jason.Nadro, Yuriy.Odonnell, Jeremy.Moore
[CL 32167352 by laura hermanns in ue5-main branch]
We can't get usage information from reflection with this enabled, mainly for bindless, so we'll need to revisit this later.
#rb Laura.Hermanns
[CL 31741310 by christopher waters in ue5-main branch]
- Adding utility function for easier additions to FShaderCompilerOutput::ShaderStatistics
- Simplified existing uses of FShaderCompilerOutput::ShaderStatistics
- Reworked D3D compilation to allow DXC vs FXC to specify their different shader limits.
- Adding Shader Statistics for D3D SamplerState and Resource usages.
- Adding Shader Statistics for D3D SM6.6 bindless resource usages.
#rb Jason.Nadro, Laura.Hermanns
[CL 31740056 by christopher waters in ue5-main branch]
- add FShaderSource class which wraps source as populated by preprocessing and subsequently accessed by compilation and other debug features; this class automatically inserts zeroed padding such that 16-byte-wide SIMD string comparison operations do not require a non-SIMD tail to process any overhang.
- add typedefs for the string/view/character types and update preprocessing code to use these typedefs instead of the explicit types
- add explicit if constexprs in minifier code around char width to disable simd optimizations for char width != 2 (and subsequently skip the non-simd tail if char width == 2 since FShaderSource automatically adds the required padding)
#rb Jason.Nadro, Yuriy.ODonnell
[CL 30358137 by dan elksnitis in ue5-main branch]
- move sequence of preprocessing steps out of ShaderPreprocessor module and into UE::ShaderCompilerCommon::ExecuteShaderPreprocessingSteps; the former is now explicitly just the low-level preprocessor lib
- add an implementation of PreprocessShader in FBaseShaderFormat so backends which have no custom code to execute as part of preprocessing can just automatically inherit this implementation, and fix up such backends to eliminate now-unnecessary overrides
#rb christopher.waters, Laura.Hermanns
[CL 30178136 by dan elksnitis in ue5-main branch]
- move uniform buffer cleanup and dead stripping into ShaderPreprocessor module's PreprocessShader function
- add "required symbols" to compiler input struct to specify additional symbols to keep during minification aside from those specified by the entrypoint; modify API such that both an entry point string and additional symbols can be specified (to avoid each backend needing to manually parse the compound RT entry point string)
- make use of ModifyShaderCompilerInput in all backends to set additional defines and required symbols on input struct up front; only use the AdditionalDefines map in cases where it's actually necessary
- remove the various per-platform defines for enabling minifier, no longer required now that this has been rolled out for all backends
- fix SCW directcompile mode; this had rotted due to pieces of the FShaderCompilerEnvironment having been added that weren't explicitly serialized to either cmdline or in the shader source. this now serializes as a base64 string written inside the USF containing all portions of the environment required for compilation (using the same serialization function as is used to write/read the SCW input file)
- use a debug flag for indicating we're in "direct compile" mode and should load the debug USF off disk, rather than the poorly named "bSkipPreprocessedCache" (this name is both inaccurate and also confusing due to the addition of the preprocessed job cache)
- modify platform "force wave32" mechanism to use a pragma directive to set a compiler define, instead of doing string replacement in the preprocessed source
- add a view version of the RT entrypoint parsing to use in preprocessing, note that other paths still need to construct fstrings due to further manipulation so keeping the FString path around too
- clean up backends manually checking the "directcompile" cmdline arg
#rb christopher.waters, Yuriy.ODonnell
#rb Chris.Waters
#rb Laura.Hermanns
[CL 30023082 by dan elksnitis in ue5-main branch]
- Forcing EShaderResourceUsageFlags bindless flags when bindless is enabled to avoid ping ponging issues at runtime.
#jira UE-162014
#rb dan.elksnitis
[CL 30001874 by christopher waters in ue5-main branch]
- Only log a system error message if we didn't get any error messages back from the DXC error blob.
#rb Laura.Hermanns
#rnx
[CL 29810728 by jason nadro in ue5-main branch]
- Adding EShaderCodeFeatures::Barycentrics
- Adding GRHIGlobals.SupportsBarycentricsSemantic
- Adding FDataDrivenShaderPlatformInfo::GetSupportsBarycentricsIntrinsics to control COMPILER_SUPPORTS_BARYCENTRIC_INTRINSICS
- Adding FDataDrivenShaderPlatformInfo::GetSupportsBarycentricsSemantic to control PLATFORM_SUPPORTS_BARYCENTRICS_SEMANTIC
#jira UE-193429
#rb graham.wihlidal, mihnea.balta
[CL 29771745 by christopher waters in ue5-main branch]
The PDB name is either retrieved from the PDB blob part of DXC's output, or is generated using the shader hash that DXC reports even when no PDB is requested. We don't export PDBs because it would result in duplicate data as we use embedded PDBs.
#rb christopher.waters, Laura.Hermanns
[CL 29723169 by daniele vettorel in ue5-main branch]
- ELanguage and Input flags were being used inconsistently to determine defines and shader profiles to use.
- ED3DShaderModel now communicates the exact shader model to use to the FXC and DXC backends.
- Moved all D3D custom definitions to ModifyShaderCompilerInput
- D3D definitions have been fixed to be based on specific needs of input flags. ie- "PLATFORM_MAX_SAMPLERS" doesn't imply that wave operations are wanted/supported.
#jira UE-199838
#rb laura.hermanns, michael.wanderson
[CL 29632531 by christopher waters in ue5-main branch]
- Removing the need for COMPILER_DEFINE on GetResourceFromHeap and GetSamplerFromHeap
- FShaderParameterParser constructor now requires a FPlatformConfiguration object that each shader format can configure.
- FPlatformConfiguration::GenerateBindlessAccess allows each platform to generate the code for accessing a bindless resource or sampler.
- Added EShaderParameterParserConfigurationFlags to specify support for stable constant buffers and bindless.
- Moved EBindlessParameterMode into EShaderParameterParserConfigurationFlags::BindlessUsesArrays
- While moving things around, I was able to convert some TCHAR* uses to FStringView
#jira UE-166341
#rb mihnea.balta
[CL 29533376 by christopher waters in ue5-main branch]
