izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity
167,095 Commits 23 Branches 254 Tags
a38ca94c2d62b15a550e2cd009abca2d40e5780c
Commit Graph

31 Commits

Author SHA1 Message Date
ben hoffman
a38ca94c2d Add a flag to force deletion on subobjects so that when making a new scene root the CanDelete check will be bypassed. 
This is needed because when the user drags a new scene component over the existing one, the old one should be deleted but is still marked as the SceneRoot (and cannot be deleted because we have to update the instances of the archetypes)

#jira UE-119151
#rb trivial
#rnx
#preflight 60edf5d0ef22fa000176acdf

[CL 16843507 by ben hoffman in ue5-main branch]
 2021-07-13 17:56:24 -04:00
ben hoffman
60c7ca432f Replace an incorrect check for a child actor with a check for a child actor subtree object. 
#jira none
#rb trivial
#rnx

[CL 16840124 by ben hoffman in ue5-main branch]
 2021-07-13 14:22:17 -04:00
ben hoffman
188d3e325d If the attachment point is a BP inherited subobject then find the correct archetype attachment point when adding subobjects to an instance 
#rb marc.audy
#jira UE-117457
#jira UE-119112
#rnx
#preflight 60ec6955ef22fa000150f693

[CL 16837795 by ben hoffman in ue5-main branch]
 2021-07-13 11:21:36 -04:00
ben hoffman
2d93fed50e Instead of checking if something is a child actor component when attempting to maniuplate it, check if its owner is a CAC instead. If it's owner is a CAC, then it cannot be removed because it is determined by the owning CAC. Before, the code was incorrectly checking if something was just a plain old child actor component, resulting in being unable to delete, reparent, or attach to a child actor component. 
#jira UE-117132
#jira UE-117332
#jira UE-117327
#jira UE-117329

#rb marc.audy
#rnx

#preflight 60d48296925f1400010bb909

[CL 16773601 by ben hoffman in ue5-main branch]
 2021-06-24 10:55:53 -04:00
ben hoffman
ff3b233df8 Use CopyPropertiesForUnrelatedObjects instead of a basic ObjectWriter/Reader combo when duplicating components to properly handle subobjects. 
#jira UE-68780
#rb marc.audy
#rnx

[CL 16751102 by ben hoffman in ue5-main branch]
 2021-06-22 19:04:02 -04:00
ben hoffman
435dcc7d82 Correctly set the module path when creating a C++ class from the subobject data subsystem. This will correctly set the module path so that the error messages are correct from GameProjectUtils::AddCodeToProject. This will make the module selection the same as how the SNewClassDialog handles it for a more consistent and correct experience. 
#jira UE-116994
#rnx
#rb phillip.kavan

[CL 16748591 by ben hoffman in ue5-main branch]
 2021-06-22 16:23:15 -04:00
Jamie Dale
ac95fa3168 Fixed subobject editor not honoring the requested post-delete selection 
#rb Ben.Hoffman

[CL 16747272 by Jamie Dale in ue5-main branch]
 2021-06-22 15:19:31 -04:00
ben hoffman
fb9dde0359 Notify the level editor that a subobject has been changed when adding or deleting a subobject. This ensures that if there is a selected actor instance in the level that it will have it's subobjects properly updated 
#jira UE-116645
#rb justin.hare
#rnx
#preflight 60cba56378c3b0000138e856

[CL 16711849 by ben hoffman in ue5-main branch]
 2021-06-17 17:11:39 -04:00
ben hoffman
b6365aba67 Attach a dupliucated component to the source's parent instead of the source directly 
#jira UE-118043
#rb trivial
#rnx

[CL 16709163 by ben hoffman in ue5-main branch]
 2021-06-17 15:06:40 -04:00
ben hoffman
1ee7ce31ff Check if a subobject is allowed to be deleted before allowing the subsystem to delete it. This solves the problem where a BP script may not be doing the same validation when calling DeleteSubobjects that the Subobject Editor does. 
Add logging when a subobject can't be deleted

#jira UE-117853
#rb michael.noland
#rnx

#preflight 60c8def586ce760001d8de51

[CL 16678061 by ben hoffman in ue5-main branch]
 2021-06-15 15:39:14 -04:00
ben hoffman
2c4b1df587 Added logging when a blueprint component cannot be deleted when called from blueprints 
#jira UE-117855
#rb trivial
#rnx

[CL 16665192 by ben hoffman in ue5-main branch]
 2021-06-14 17:50:08 -04:00
ben hoffman
e8e72270fb Remove an unnecessary check from the deletion of subobjects. This check was originally there to confirm that the SCS node being deleted is from the current subobject tree, but is not a valid check anymore when you can call this function from Blueprints as well. 
#jira UE-117836
#rb trivial
#rnx

[CL 16661733 by ben hoffman in ue5-main branch]
 2021-06-14 14:35:04 -04:00
ben hoffman
1dba26f55d Automatically select a new component for rename upon duplication. 
#jira UE-117759
#rb phillip.kavan
#rnx
#preflight 60c2bc6c1264df0001bc76ee

[CL 16635347 by ben hoffman in ue5-main branch]
 2021-06-10 22:27:25 -04:00
ben hoffman
388f3db4a7 Fix duplication of an inherited blueprint variables in the subobject instance editor by using the correct ComponentInstanceInActor instead of the SCS node 
#jira UE-117371
#rb marc.audy
#rnx

[CL 16625879 by ben hoffman in ue5-main branch]
 2021-06-10 13:52:23 -04:00
ben hoffman
74ba7a83b6 Fix SA warning with NewSCSNode in PasteSubobjects 
#jira none
#rb trivial
#rnx

[CL 16623623 by ben hoffman in ue5-main branch]
 2021-06-10 11:05:53 -04:00
ben hoffman
dbe9a24a9a Add clearer logging when creating a new BP component 
#jira UE-117725
#rb trivial
#rnx
#preflight 60c161b8b68c700001b51b83

[CL 16617905 by ben hoffman in ue5-main branch]
 2021-06-09 22:01:11 -04:00
ben hoffman
3fb10ffe8f Fix a crash when deleteing instances of subobjects if the component template is null 
#jira UE-117672
#rn trivial
#rnx

[CL 16615637 by ben hoffman in ue5-main branch]
 2021-06-09 19:25:32 -04:00
ben hoffman
fb8a5f3e2a Fix a crash when pasting subobjects into the blueprint editor. This will ensure that a valid attachment target is selected for the subobject, and correctly create a subobject data handle based off of the SCSnode instead of the SCSNode's component template, which was causing the crash. 
#jira UE-116864
#rb phillip.kavan
#rnx
#preflight 60c115d6c6126400019f921b

[CL 16613714 by ben hoffman in ue5-main branch]
 2021-06-09 17:47:07 -04:00
ben hoffman
cbd9782fdc Remove unused parent class filter from Subobject Data Subsystem 
#rb trivial
#rnx
#jira none
#preflight 60bfe2a31ab03100015ac15d

[CL 16597093 by ben hoffman in ue5-main branch]
 2021-06-08 19:58:14 -04:00
ben hoffman
4b3aa3e563 Make DeleteSubobject functions for an instance and blueprint seperate for better context menu searches 
#jira none
#rb trivial
#rnx

#preflight 60be2392884c63000171ad30

[CL 16572253 by ben hoffman in ue5-main branch]
 2021-06-07 12:17:06 -04:00
ben hoffman
5c81d43585 Change how the old root component gets deleted to correctly handle the promotion of its children 
#jira UE-117184
#rb trivial
#rnx
#preflight 60b942e615b2f10001aade6e

[CL 16555185 by ben hoffman in ue5-main branch]
 2021-06-03 19:21:20 -04:00
ben hoffman
fd1fe7595b Subobject Data Subsystem: 
- Do not create a new blueprint component via the Subobject Data subsystem if the given class is not a blueprint type.
- Check for existing classes with that have the same name when creating a BP class to prevent the user from creating invalid packages.
- Add logging to show the user a reason for failure when the given class name is invalid.

#rb phillip.kavan

#jira UE-116746
#jira UE-116749
#jira UE-117000

#preflight 60b8e5f78e7ee10001f44220

[CL 16549867 by ben hoffman in ue5-main branch]
 2021-06-03 13:44:44 -04:00
ben hoffman
0267dce005 When adding to instance inhertied subobjects, if the actor instance cannot be initalliy found walk up the heirarchy until we find one. 
#jira UE-115687
#rb marc.audy
#preflight 60a6ad227370d300018b3ad5

[CL 16408716 by ben hoffman in ue5-main branch]
 2021-05-20 15:59:06 -04:00
ben hoffman
f521548a94 Sort blueprint subobjects by their type to ensure that non-scene components show up on the bottom. When adding a new subobject parent non-scene components to the actor instead of the default scene root. 
#jira UE-116086
#rb marc.audy
#preflight 60a5604aa5fa6d0001321600

[CL 16391076 by ben hoffman in ue5-main branch]
 2021-05-19 15:51:34 -04:00
ben hoffman
cace383786 Fix a case where an ensure could be triggered when adding a new component to a blueprint with BP inherited components 
#jira none
#rb
#rnx
#preflight 60a42f4a7d6b060001e8d724

[CL 16377852 by ben hoffman in ue5-main branch]
 2021-05-18 18:36:56 -04:00