Commit Graph

3421 Commits

Author SHA1 Message Date
devin doucette
efa61fcca3 Added structured serialization of FPropertyTypeName
#rb Francis.Hurteau
#rnx

[CL 31050185 by devin doucette in ue5-main branch]
2024-01-31 11:21:12 -05:00
tim smith
7fc11a2c8d Added support for Verse serialization to the verse properties
#rnx
#rb russell.johnston

[CL 31048692 by tim smith in ue5-main branch]
2024-01-31 10:40:45 -05:00
dan oconnor
6e8ec97e00 Report missing script (native) packages on import when using zenloader
#jira UE-205146
#rb Francis.Hurteau

[CL 31023851 by dan oconnor in ue5-main branch]
2024-01-30 17:29:33 -05:00
tim smith
307e11af46 Change the verse properties to either be use TWriteBarrier<VValue> or VRestValue. The former is intended for UClass definitions and the latter is used internally by verse generated classes.
#rb russell.johnston

[CL 31011719 by tim smith in ue5-main branch]
2024-01-30 12:45:18 -05:00
jordan hoffmann
09a8b4b77c [Feature] PropertyTypeLayout deatails customization of types will be used in the details for their InstanceDataObject counterparts
#rb Francis.Hurteau, logan.buchy
#jira UE-202457

[CL 30979900 by jordan hoffmann in ue5-main branch]
2024-01-29 18:05:37 -05:00
maxime mercier
cc5da7438a Return the added override state on an object.
#rb kurtis.schmidt

[CL 30971072 by maxime mercier in ue5-main branch]
2024-01-29 11:27:46 -05:00
maxime mercier
ef84924fbf Fix undo/redo of overrides
#rb kurtis.schmidt

[CL 30970465 by maxime mercier in ue5-main branch]
2024-01-29 11:08:05 -05:00
devin doucette
0b42dd41a1 Fixed a crash in FPropertyBag caused by an invalid type in a property tag
#jira UE-205061
#rb Francis.Hurteau, Jordan.Hoffmann
#rnx

[CL 30940473 by devin doucette in ue5-main branch]
2024-01-26 16:13:18 -05:00
kevin macaulayvacher
4897f8726b - Separates FFrame::ReadObject and FFrame::ReadProperty to rely on a new method, FFrame::ReadPointer(), which returns a bare ScriptPointerType.
- Changed codepaths reading FProperty objects using ReadObject() to now use ReadPropertyUnchecked(), since FProperty is not a child of UObject (ReadObject was also an unchecked implementation so validation has been lost).

These changes allow ReadObject to return a UObject fetched from a constructed TObjectPtr<UObject> which enables UObject access tracking. This corrects the previous implementation of ReadProperty which would return an FProperty from a temporarily constructed TObjectPtr<UObject>. This had the effect of running TObjectPtr tracking handlers (if any are registered) on the FProperty object which is not actually a UObject type. Using the intermediate TObjectPtr<UObject> in a handler could corrupt the underlying FProperty data as many codepaths in TObjectPtr lazily initialize UObject member variables upon calling UObject methods.

#jira UE-204533
#rb Francis.Hurteau, Robert.Manuszewski

[CL 30924162 by kevin macaulayvacher in ue5-main branch]
2024-01-26 10:27:20 -05:00
ben zeigler
239dde3eee Fix some incorrect calls to IsDefaultSubobject
#rb Tim.Smith

[CL 30906710 by ben zeigler in ue5-main branch]
2024-01-25 18:33:07 -05:00
maxime mercier
3ed09569c4 Added clear overides API to the Overridable Manager.
#rb kurtis.schmidt

[CL 30888982 by maxime mercier in ue5-main branch]
2024-01-25 11:31:40 -05:00
kevin macaulayvacher
951a754390 [Backout] - CL30884576
[FYI] kevin.macaulayvacher
Original CL Desc
-----------------------------------------------------------------
Re-enable check for invalid PackageHandles when resolving Packaged Objects. This check helps with identifying cases where garbage memory is used to construct objects

#rb Francis.Hurteau

[CL 30885059 by kevin macaulayvacher in ue5-main branch]
2024-01-25 09:34:26 -05:00
kevin macaulayvacher
b01908e31c Re-enable check for invalid PackageHandles when resolving Packaged Objects. This check helps with identifying cases where garbage memory is used to construct objects
#rb Francis.Hurteau

[CL 30884614 by kevin macaulayvacher in ue5-main branch]
2024-01-25 09:25:55 -05:00
devin doucette
308d762eb7 Updated FPropertyTypeName to make it more convenient to use
#rb Francis.Hurteau
#rnx

[CL 30862617 by devin doucette in ue5-main branch]
2024-01-24 16:37:36 -05:00
ben zeigler
a847428a94 Add new IsTemplateForSubobjects function that correctly handles querying for all types of subobject templates
Add comments warning against use of IsDefaultSubobject due to the historically inconsistent behavior, and deprecate CollectDefaultSubobjects for being redundant and incorrect
Improve general comments related to subobject functions to better match the current behavior
#jira UE-201046
#rb dan.oconnor

[CL 30858830 by ben zeigler in ue5-main branch]
2024-01-24 15:22:15 -05:00
robert manuszewski
4d2ba73f8a Fixing CIS
#rb trivial

[CL 30849814 by robert manuszewski in ue5-main branch]
2024-01-24 12:18:47 -05:00
robert manuszewski
b53c4d6840 GC stats for analytics.
Added GarbageCollectComplete event that gets fired after GC is truly done (existing events were inconsitent in that manner)

#rb Johan.Torp

[CL 30845256 by robert manuszewski in ue5-main branch]
2024-01-24 10:55:23 -05:00
jordan hoffmann
ee0c2e0c87 [BugFix] CDOs weren't being copied when InstanceDataObjects were generated
[BugFix] mark properties as overridden when changed by fixup tool
[Temp] gave IDO properties without categories a category as a workaround to a details customization bug
#rb Francis.Hurteau

[CL 30826433 by jordan hoffmann in ue5-main branch]
2024-01-23 19:44:48 -05:00
spencer melnick
b367cc2712 Adding support for multi-line entries on config set properties.
Duplicate values are filtered out during load.
Existing config values for set properties should continue to be loaded the same way as before.

Example syntax:
SetProperty=("Value1", "Value2")
+SetProperty="Value3"
+SetProperty=("Value4", "Value5")

[REVIEW]

[CL 30815266 by spencer melnick in ue5-main branch]
2024-01-23 15:18:19 -05:00
steve robb
104c0f2416 Fixed up more bool-taking calls to take EAllowShrinking instead.
[CL 30806200 by steve robb in ue5-main branch]
2024-01-23 11:07:28 -05:00
maxime mercier
5d628a7021 Fix default CDO value not being serialized in cooked server content when using Overridable Serialization.
#rb kurtis.schmidt, Tom.Noonan

[CL 30802134 by maxime mercier in ue5-main branch]
2024-01-23 09:05:28 -05:00
logan buchy
400d6a7e34 Serialize Override Property data if using Unversioned serialization
* Allows resulting object from StaticDuplicateObject to get override information

#rb Maxime.Mercier
#jira UE-204007

[CL 30790681 by logan buchy in ue5-main branch]
2024-01-22 19:03:51 -05:00
aris theophanidis
7192b9d0a2 Remove text.h from script.h (script.h is included by object.h)
#rb Yoan.StAmant

[CL 30776575 by aris theophanidis in ue5-main branch]
2024-01-22 11:52:48 -05:00
danny couture
2a8f3849b6 [ZenLoader/UObject]
- Avoid automatically adding AsyncLoading flag during duplication as this can prevent GC. This flag should only be managed by the async loading code itself.

#jira UE-204346
#rb Francis.Hurteau

[CL 30771059 by danny couture in ue5-main branch]
2024-01-22 09:34:15 -05:00
thomas sarkanen
266d9b077d Added the ability to add comments to curves on animations
Comments are added from the curve's outliner menu. Editing can just be done by clicking the comment after it has been created
Also exposed the setting to view curves in a tree view in the timeline itself

NOTE: this removes a 4.5 core redirect from CurveName to LastObservedName as CurveName was reinstated as the canonical name for the curve, and having the redirect in place causes issues with tagged property serialization when new properties are added.

#jira UE-203593
#rb Nicholas.Frechette

[CL 30769970 by thomas sarkanen in ue5-main branch]
2024-01-22 09:01:15 -05:00