Commit Graph

781 Commits

Author SHA1 Message Date
shirley man 34519468d3 #preflight 63db295b39234ef628432297
#rb trivial
Fixed spelling typo in log message.

[CL 23964736 by shirley man in ue5-main branch]
2023-02-02 01:25:57 -05:00
jordan hoffmann 31b04b24ba [Feature/Bugfix] Support for diffing against nullptr (treated as an empty or nonexistent file)
#rb dan.oconnor
#preflight 63d83f963656ea96dc2a0a4c

#jira UE-173747
"Crash occurs when scrolling down through files in Review Changelist window upon loading of asset"
  - certain widget blueprints were crashing the review tool because we were working around the inability to diff against nullptr by constructing temprorary empty objects. This approach circumvents that problem entirely

#jira UE-173231
"Changelist Review tool allows diffing against previous revision for Deletion changes"
  - while this jira suggests that the ability to diff deletion changes is a bug, it was actually an intended feature. The real bug was that it would crash or fail to work in many cases. This has been fixed by either asset diffing against nullptr or text diffing against an empty file (depending on circumstance)

#jira UE-174610
"Reviewing Changelist with Deletion Changes results in LogLinker warnings & LoadErrors"
 - deletion changes were trying to load the new revision of files but obviously it doesn't exist because it's a deletion. Fixed by only loading the previous revision


note: since the review tool is going to be "Production Ready"  in 5.2, these changes are neccesary for stability

[CL 23924072 by jordan hoffmann in ue5-main branch]
2023-01-31 01:28:46 -05:00
alexis matte b93fee971d Create a system to control which extension importer should support.
#rb jeanluc.corenthin
#rnx
#preflight 63d7eb4cba4fadeef006c7d7

[CL 23923306 by alexis matte in ue5-main branch]
2023-01-31 01:12:25 -05:00
stuart hill df6df596f7 Ensure the camera does not reset when we are syncing or reverting a file or all files via source control
A scoped class is added to retain and restore all camera views which is used when we reload or sync packages.

#preflight 63d2766de55deff624ed1b5a

[CL 23867883 by stuart hill in ue5-main branch]
2023-01-26 10:15:04 -05:00
johan duparc 83548e6f86 Fix typo in asset tools category
[CL 23845882 by johan duparc in ue5-main branch]
2023-01-25 06:01:10 -05:00
Alexis Matte c780cd0119 Interchange: Integrate interchange with the AssetImportTask workflow, by allowing user to specify an override pipeline stack in the AssetImportTask::Options parameter.
Also implement a pipeline asset name option so user can specify a name when they import only one asset.

#jira UE-173881
#rb jeanluc.corenthin
#rnx
#preflight 63cfe55f6730a500ffb0815e

[CL 23829783 by Alexis Matte in ue5-main branch]
2023-01-24 09:17:49 -05:00
nick darnell 1d16e1bb1c AssetDefinition - Fixing AssetDefintions for native classes not existing.
#jira UE-165574

[CL 23824481 by nick darnell in ue5-main branch]
2023-01-23 18:48:51 -05:00
marco anastasi 96fdec112c Fixed: SkeinUE does not sync latest if only non-package files have changed
[REVIEW] [at]manuel.lang, [at]wouter.burgers

[CL 23821510 by marco anastasi in ue5-main branch]
2023-01-23 16:16:19 -05:00
nick darnell e6dc94a38f AssetDefinition - Fixing filter categories to include everything that hasn't yet been converted to a Asset Definition.
AssetDefintiion - Converted more blueprint / Animation blueprint stuff over to be an asset definition.

#jira UE-165574

[CL 23804692 by nick darnell in ue5-main branch]
2023-01-21 21:00:48 -05:00
marco anastasi b29f599449 * Refactored Sync Latest operation to improve performance
* Sync Latest no longer listing and reloading all packages when the source control provider provides a sync preview functionality. When a Sync Preview is available, Sync Latest unloads only the files that are going to be overwritten by the sync operation, and then reloads them and the world

* Refactored Revert All operation to improve performance
* Revert All no longer lists and reloads all packages when the source control provider provides a sync preview functionality. Instead it unloads only the files that may be overwritten by the revert operation (i.e. submittable files), and then reloads them and the world
* Replaced RevertAndReloadAllPackages with RevertAndReloadWorld, no longer listing and reloading all packages (see https://p4-swarm.epicgames.net/reviews/23244245/)

This review is a combination of the two archived reviews https://p4-swarm.epicgames.net/reviews/23736137 and https://p4-swarm.epicgames.net/reviews/23736282

#rb wouter.burgers, stuart.hill, brooke.hubert, francis.hurteau
#preflight 63c9c7786a00f3cc8ead6779

[CL 23796067 by marco anastasi in ue5-main branch]
2023-01-20 15:31:16 -05:00
nick darnell 496d9a03a6 AssetDefinitions - Removing files I missed.
[CL 23791514 by nick darnell in ue5-main branch]
2023-01-20 11:50:17 -05:00
nick darnell 58645cbc15 Editor Performance - Fixing a long standing issue with asset thumbnails, they've been loading the assets for a pretty long time now, because of the thumbnail editing mode. Note that thumbnail editing mode was not needed to be enabled and yet the asset would still load. This was a cause for a lot of hitches in the Content Browser.
AssetDefinition - Working on the asset definitions for blueprints/class types, iterating on the Merge API.  Bringing over more of the blueprint features into its asset definition, unregistered the Blueprint AssetType Actions.

Asset Filters - We now support categories per filter, this enables a single asset definition to correctly specify multiple filters.  For example, blueprints actually supply 4 filters, one for blueprints, but also blueprint interfaces, macros and function libraries.

[CL 23791489 by nick darnell in ue5-main branch]
2023-01-20 11:49:23 -05:00
dj schilens 6548d72e8c Advanced Copy - Optional callback when copy is complete, and expose to blueprints
* Adds a new delegate for when AdvancedCopy is complete (since Advanced Copy is async and can't return the results directly)
* Adds a new blueprint callable overload for AdvancedCopy in the AssetTools interface that optionally takes this callback

[REVIEW] [at]matt.peters [at]brooke.hubert

[CL 23781823 by dj schilens in ue5-main branch]
2023-01-19 17:12:52 -05:00
nick darnell 7c56e6c4d1 AssetDefinition - Upgrading several skeletal and animation assets to be asset definitions. Had to upgrade a few utilities that were causing the assets to still load.
#jira UE-165574

[CL 23781708 by nick darnell in ue5-main branch]
2023-01-19 17:09:58 -05:00
julien stjean 4661e3773e Fixed an issue where the metadata of the package wouldn't be migrated for some assets.
#jira UE-172915
#preflight 63c585e9a06ab115eacb2961
#lockdown aurel.cordonnier

[CL 23747902 by julien stjean in ue5-main branch]
2023-01-17 18:37:25 -05:00
nick darnell 3486296e42 AssetDefinition - When proxying to the old category system, if the advanced top level category doesn't exist, make sure to create it. Fixes FX/Niagara stuff not appearing in the top level menu.
[CL 23732858 by nick darnell in ue5-main branch]
2023-01-16 17:04:58 -05:00
nick darnell ae774ca1eb AssetDefinition - Upgrading the Data/Curve tables to use the new AssetDefinition.
AssetDefinition - Changing how getting the SourceFiles works a bit, wanted it to be easier to just get the real data and not have to wrap it myself, and also to not need to needlessly put it into a container if it's not needed.

#jira UE-165574

[CL 23686064 by nick darnell in ue5-main branch]
2023-01-13 16:11:10 -05:00
Alexis Matte 3ae90e5430 If we import only one main asset (static mesh, skeletal mesh or anim sequence), we should select it in the content browser when the import is done.
#jira UE-165275
#rb jeanluc.corenthin
#preflight 63c1a40970575f89004e2b2e

[CL 23682334 by Alexis Matte in ue5-main branch]
2023-01-13 13:49:45 -05:00
Patrick Boutot 6e02de5817 Fix memstomp with color picker. Prepare SColorPicker for API change. Update AssetViewUtilis::PathColors to use FLinearColor instead of shared pointer. The shared pointer was only needed for the SColorPicker.
#jira UE-173303, UE-173454
#review-23672715 23617361,23611673
#rb daren.cheng
#preflight 63c0b12b1a06fc61059f2fa3

[CL 23672712 by Patrick Boutot in ue5-main branch]
2023-01-12 20:33:08 -05:00
nick darnell 3e81121a50 AssetDefinition - "UV Editor" plugin's option no longer hides if it won't work (determining it requires loading the assets), so it's just going to determine that when you fire it and fire a notification if it wont work.
AssetDefinition - Skeleton
AssetDefinition - SkeletonMesh
AssetDefinition - StringTable

#jira UE-165574

[CL 23658411 by nick darnell in ue5-main branch]
2023-01-11 20:52:36 -05:00
julien stjean 547e401ec2 Added the auto save flag to the package migration to avoid some asset from generating stuff on save.
#rb none

[CL 23635342 by julien stjean in ue5-main branch]
2023-01-10 18:11:49 -05:00
dj schilens f346caac06 Compile AR filter only once when getting Advanced Copy sources/dependencies
- Using Advanced Copy on assets with lots of dependencies spent most of the time just compiling the AR filter
- I kept the original IAssetRegistry::UseFilterToExcludeAssets() (using an FARFilter) as it is blueprint callable

[REVIEW] [at]*matt.peters [at]jay.nakai [at]brooke.hubert

[CL 23631854 by dj schilens in ue5-main branch]
2023-01-10 15:25:00 -05:00
julien stjean 8b4de387d0 The migration can now change the writing permissions temporally to save the migrated assets.
The migration also now report in its callback the dependencies that where not exported because of the new filtering of the assets that can be migrated.
Fixed some other issues like a crash and a bad event broadcast.

#preflight 63bc235c763c6c10641898bb
#rb JeanLuc.Corenthin

[CL 23617167 by julien stjean in ue5-main branch]
2023-01-09 13:51:05 -05:00
nick darnell 32457bcb13 AssetDefinition - Converted Fonts/FontFaces, SlateBrush, SlateWidgetStyle, and Lightweight instance.
#jira UE-165574

[CL 23592534 by nick darnell in ue5-main branch]
2023-01-05 16:11:54 -05:00
nick darnell f8bd93f6b1 AssetDefinition - Converting the Haptic AssetTypeActions to AssetDefinitions.
The copying localization ID is now an option stated as such instead of a right click showing the ID you click.  In order to show the ID the asset has to be loaded, so instead it's now a copy operation that then loads the asset before copying the ID.

Fixing a regression that stopped showing export options for unloaded assets.  The code was using FastGetAsset, which won't load the asset if unloaded.  The new code just looks at the package flags from the FAssetData, no need to attempt to load the asset.

#jira UE-165574
#jira UE-173203

[CL 23588044 by nick darnell in ue5-main branch]
2023-01-05 10:47:04 -05:00