Commit Graph

7384 Commits

Author SHA1 Message Date
Stefan Boberg
d63e527730 Workaround for [[nodiscard]] error
#jira UE-66732
#rb steve.robb

[CL 12384448 by Stefan Boberg in 4.25 branch]
2020-03-23 19:11:12 -04:00
devin doucette
84b56d6f4f Allow FStringView to be used with the ByHash TMap functions for FString TMap key queries (by Jamie.Dale)
#jira none
#rb none
#fyi Jamie.Dale
#ushell-cherrypick of 12158634 by Jamie.Dale

[CL 12370569 by devin doucette in 4.25 branch]
2020-03-23 10:56:17 -04:00
Michael Lentine
32d2db5ecc Missed file.
#rb none
#jira nojira

[CL 12366721 by Michael Lentine in 4.25 branch]
2020-03-21 14:36:43 -04:00
Jamie Dale
93aa457b2c Added missing includes
#jira
#rb none
#rnx

[CL 12366708 by Jamie Dale in 4.25 branch]
2020-03-21 14:01:37 -04:00
devin doucette
ea2434250b Allow FStringView to be used with TMap and TSet
#jira none
#rb none
#rnx
#fyi Jamie.Dale
#ushell-cherrypick of 12158634 by Jamie.Dale

[CL 12356623 by devin doucette in 4.25 branch]
2020-03-20 20:37:43 -04:00
Jamie Dale
d9d751852c Added support for performing text substitution for fragments within a culture display name
#jira UELOC-4322
#rb Francis.Hurteau
#rnx

[CL 12342427 by Jamie Dale in 4.25 branch]
2020-03-20 14:13:15 -04:00
devin doucette
beb3bb93e3 Changed FName(F[Ansi]StringView) constructors to be explicit
Avoid unintentional construction of names as this can be expensive and bloats the name table.

#jira none
#rb Johan.Torp, Steve.Robb
#rnx

[CL 12341371 by devin doucette in 4.25 branch]
2020-03-20 13:40:10 -04:00
Johan Berg
c045a8e639 Fix for crashreportclient.ini not included in cooked builds
#jira UE-90154
#rb none

[CL 12333227 by Johan Berg in 4.25 branch]
2020-03-20 07:42:41 -04:00
Brandon Schaefer
60a37c5e1d Support VirtualTextureStreaming for Linux
#jira UE-90920
#rb Ben.Ingram

[CL 12324168 by Brandon Schaefer in 4.25 branch]
2020-03-19 19:39:08 -04:00
devin doucette
18059ac76a Fix static analysis warning from StringFwd.h
#jira none
#rb trivial
#rnx

[CL 12244748 by devin doucette in 4.25 branch]
2020-03-18 09:29:21 -04:00
devin doucette
a20108bd87 Fix StringFwd.h compile errors in strict builds
#jira none
#rb trivial
#rnx

[CL 12237974 by devin doucette in 4.25 branch]
2020-03-17 22:13:14 -04:00
devin doucette
1b7f9548e3 Added and used StringFwd.h for string builder and string view declarations
Including StringFwd.h in place of forward declarations offers more flexibility to change how these types are declared.

#jira none
#rb Steve.Robb
#rn minor Core
#robomerge[FORTNITE] Release-12.30

[CL 12235779 by devin doucette in 4.25 branch]
2020-03-17 16:38:03 -04:00
Patrick Laflamme
dce4f6143d #jira UE-90769 - //UE4/Main - UE4 Static Analysis Win64 (MSVC) - WindowsPlatformCrashContext.cpp Warning: 'ThreadHandle' could be '0': this does not adhere to the specification for the function 'SuspendThread'
- Added a null check to fix the analysis.

#rb Trivial
#rnx

[CL 12232702 by Patrick Laflamme in 4.25 branch]
2020-03-17 11:36:02 -04:00
Patrick Laflamme
f69a0144b3 Tried to get more reliable Editor analytic data out of crash rerporter app:
- Ensured the data is fully written and read to/form the pipe between the Editor and CrashReporter.
  - Refactored the code sending MTFB to send it as soon as possible
  - Added some special exit code to detect when the Editor is still running or the exit code is unknown when the summary event is sent.

#rb Sebastian.Nordgren, Johan.Berg
#jira UE-90733 - Editor summary event may not be sent as expected because CrashReportClient may not consume the pipe data

[CL 12216180 by Patrick Laflamme in 4.25 branch]
2020-03-16 14:44:16 -04:00
Johan Berg
1fed703659 Fix for ensure messages disappearing in editor log
Calls to PanicFlushLog should only happen on crashes, and not ensures. On ensures on any thread other than the main thread the editor log, which is not thread safe, will loose these messages. On crashes we don't care about the non thread-safe output devices since we will not recover, we are only interested in the log file.

#jira UE-82581
#rb rob.manuszewski
#ushell-cherrypick of 12147436 by Johan.Berg

[CL 12192433 by Johan Berg in 4.25 branch]
2020-03-16 03:31:27 -04:00
Johan Torp
526f046922 Fix FParse::QuotedString() for wide characters
#jira UE-90600
#rb none

[CL 12161670 by Johan Torp in 4.25 branch]
2020-03-13 07:18:45 -04:00
Mi Wang
27bd30e9d9 Fix bUseNEONForArmV7=true compile error for android where vqtbx1q_u8 is an A64 instruction.
Fallback to use FPU version for VectorContainsNanOrInfinite.
#jira none
#rb Chris.Babcock

[CL 12154916 by Mi Wang in 4.25 branch]
2020-03-12 17:24:13 -04:00
devin doucette
0cf98e569b Fix a typo in TStringView::LeftInline
Reported by JeanMichel.Dignard

#jira none
#rb trivial
#rnx

[CL 12154767 by devin doucette in 4.25 branch]
2020-03-12 17:06:18 -04:00
Johan Torp
36f7fa0521 Various engine init optimizations and new string conversion paths
* Added some core string conversion paths
* Added FString::Append() and += overloads to avoid pointless temporaries when appending c strings and various other string types
* Added UTF32 <-> TCHAR string conversion macros
* Optimized QuotedString parsing
* Optimized property parsing
* PackageName optimizations
* SoftObjectPath optimizations

#jira none
#rb see original changelists
#ushell-cherrypick of 11932317 by Johan.Torp
#ushell-cherrypick of 11932319 by Johan.Torp
#ushell-cherrypick of 11932321 by Johan.Torp
#ushell-cherrypick of 11932322 by Johan.Torp
#ushell-cherrypick of 11932324 by Johan.Torp
#ushell-cherrypick of 11932462 by Johan.Torp
#ushell-cherrypick of 11934123 by Johan.Torp
#ushell-cherrypick of 12000177 by Johan.Torp
#ushell-cherrypick of 12000183 by Johan.Torp
#ushell-cherrypick of 12114232 by Johan.Torp

[CL 12147981 by Johan Torp in 4.25 branch]
2020-03-12 08:11:14 -04:00
Johan Torp
b0bab3422b Fixed memory stomping occuring when a long command line is used.
Modified FGenericCrashContext to perform safe string copies

Caused TLazySingleton crash due to static memory being stomp

#rb jeanfrancois.dube, johan.berg, johan.torp
#jira UE-90162
#ushell-cherrypick of 12124406 by Sebastien.Lussier

[CL 12124880 by Johan Torp in 4.25 branch]
2020-03-11 09:32:44 -04:00
Arne Schober
4a6ceaa752 REL - This shallow copy of Create Snapshot causes the RobinHoodHashTable to leak it's support data structure as empty is not cleaning it up as it needs to be available to not polute the insertion loops with init guards.
#JIRA
#RB

[CL 12117125 by Arne Schober in 4.25 branch]
2020-03-10 16:28:04 -04:00
Patrick Laflamme
740634e53c #jira UE-90394 - The total amount of physical ram is incorrectly reported by FPlatformMemory::GetStats()
- Fixed value FGenericPlatformMemoryConstants::TotalPhysical not set on Windows (was initialized to zero, but never set)

#rb Stefan.Boberg

[CL 12112859 by Patrick Laflamme in 4.25 branch]
2020-03-10 13:02:12 -04:00
Jamie Dale
e8cede8348 Re-enabled a test case for file appending, and added one for file truncation
#jira UE-89826
#rb Stefan.Boberg
#rnx

[CL 12094847 by Jamie Dale in 4.25 branch]
2020-03-09 17:05:27 -04:00
Jamie Dale
a0bb84763f Allow Truncate to retry if interrupted
Ensure we're using the 64-bit version of Truncate so it can deal with large files correctly.

#jira UE-89826
#rb Stefan.Boberg

[CL 12094830 by Jamie Dale in 4.25 branch]
2020-03-09 17:04:51 -04:00
Jamie Dale
2a9c402d69 Fixed FCachedFileHandle issues with append and truncate
FCachedFileHandle wasn't taking the current Tell value of the underlying handle on construction, so for a file opened in append mode it would be out-of-sync. It also wasn't updating its cached values on Truncate.

This also fixes some platform file impls not updating their cached file size on Truncate.

#jira UE-89826
#rb Stefan.Boberg, Patrick.Laflamme

[CL 12094817 by Jamie Dale in 4.25 branch]
2020-03-09 17:04:17 -04:00